When NativeKey crashes by itself, it means that we detect an impossible situation in usual environment. In such case, active 3rd party's keyboard layout or something other utility may hook API and returns odd result to us.
For investigating the cause and deciding what we should do in such cases, we should collect active keyboard layout name via crash reports.
MozReview-Commit-ID: HYRj24GwDHZ
--HG--
extra : rebase_source : 5f01c2a3b36179a61dc00eebd4de6f05596d217b
We're curious how long we spend waiting on sync IPCs to complete.
So this patch adds telemetry which reports that, on a per message
basis, so we can identify problem messages.
MozReview-Commit-ID: CB4UaitPBeq
--HG--
extra : rebase_source : 1a5042bcbce3930771e3861156ba9dcf77312ff9
Check for nullptr arguments passed to CompareTextTracks. Based
on Ben Kelly's analysis this can happen if the cycle collector
has cleared a TextTrack pointer while comparision is still
happening, perhaps in a queued event task.
This change makes nullptr sort to the end, and adds a
MOZ_DIAGNOSTIC_ASSERT for trying to get the position
of a nullptr track should someone add another call at
a later date.
--HG--
extra : rebase_source : 596dbe2fb718535946a65e02619ae1a7c4c6ce10
We're already installing the plugin binaries to the objdir, so by packaging
the addon during the build we can allow these builds to run tests using
the addon.
MozReview-Commit-ID: CnzrHXiWQjM
--HG--
extra : rebase_source : 73df9c714d0b1c7628cb3bc9667fb27e757cf89f
We were including toolchain info in the testaddon on OSX so we could separate
xpis for universal builds. With universal builds going away, we can stop doing
this.
MozReview-Commit-ID: 4vqMfKJPGp3
--HG--
extra : rebase_source : 7bd0eee6550adf9af136a21ac22f5b59036e2e34
There are two parts to this patch:
1) The maintenance service installer now writes its uninstall registry keys to
the same registry view (either 32-bit or 64-bit) that it uses for all its other
registry keys. Previously it would always use the 32-bit view. Additionally,
if the 64-bit view is used, any existing entries in the 32-bit view are removed.
2) The Firefox uninstaller now looks in both views to find the path to the
maintenance service uninstaller. Previously it looked only in the native view.
This change was made in addition to #1 so that we have a fix for the bug that
will get delivered in an update, as opposed to requiring a reinstall.
MozReview-Commit-ID: Hu5AhopzO2x
--HG--
extra : rebase_source : 7bf784cc50f7a0235930f44a78335f73e295db48
The bug only mentions the shortcuts checkbox, but the ping checkbox label looks
precariously close to also being too long, so I handled it as well.
This patch only supports up to two lines of text, and only the shortcuts and
ping checkboxes can have multiple lines. Both of those limitations could be
lifted without too much trouble, but it doesn't seem necessary for now.
MozReview-Commit-ID: 9cm1scfrOY5
--HG--
extra : rebase_source : b16cc6bd86cf15b74c7b71f3ab31043165deebd7
Back when the class was written, for the packaging code, it made sense
that the default was True. But now that it's used all over the place,
and that the vast majority of uses are with find_executables=False, it
makes more sense for that to be the default.
--HG--
extra : rebase_source : ff813735fc0d53093f348f20eb77ee03e9b09d4e
And make it an error not to give it. While the default is True, we do
pass a value of False wherever it makes sense, which happens to be, in
most places.
This is an intermediate step to flip the default from True to False,
ensuring that we don't unwantedly switch some calls to False.
--HG--
extra : rebase_source : 432e03f032fef378af482581685583262e5d2661
We add the following command line options to Taskcluster try syntax:
--spsProfile - enable profile mode.
--rebuild-talos <N> - retrigger talos tests N times.
--setenv <VAR>=<val> - add extra environments variables.
--tag <TAG> - run tests only the tag TAG.
--no-retry - doesn't retry failed jobs.
We have a chicken-egg problem, as we first generate the full task graph
and then parse the try message. But the graph generation step needs to
know the try message to process the aforementioned options. The
solution is to parse the message before graph generation and then
pass the command line options to the transforms. Then, each transform
can look at the option that interests it and process it accordingly.
The message parse function is configured in kind.yml, which gives some
flexibility for future implementations of alternative syntaxes.
MozReview-Commit-ID: DMwRjuV2vpf
--HG--
extra : rebase_source : 211ecf52694078986caf290c5b0cca35c775da61
We add the following command line options to Taskcluster try syntax:
--spsProfile: enable profile mode.
--rebuild-talos <N>: retrigger talos tests N times.
--setenv <VAR>=<val>: add extra environments variables.
--tag <TAG>: run tests only the tag TAG.
--no-retry: doesn't retry failed jobs.
We have a chicken-egg problem, as we first generate the full task graph
and then parse the try message. But the graph generation step needs to
know the try message to process the aforementioned options. The
solution is to parse the message before graph generation and then
pass the command line options to the transforms. Then, each transform
can look at the option that interests it and process it accordingly.
The message parse function is configured in kind.yml, which gives some
flexibility for future implementations of alternative syntaxes.
MozReview-Commit-ID: EQlE6q5E8z7
--HG--
extra : rebase_source : 4b7323cd915e8ef9820816015b4b45524811eaf1
Michael Froman
Jay Harris
Masayuki Nakano
Chris Pearce
Ralph Giles
Phil Ringnalda
Mike Conley
Masatoshi Kimura
Chris Manchester
Daosheng Mu
Jared Wein
Matt Howell
Mike Hommey
Wes Kocher
Sebastian Hengst
Wander Lairson Costa
Nathan Froyd
ffxbld
Carsten "Tomcat" Book
Olli Pettay
Alessio Placitelli
Ryan VanderMeulen
Andrea Marchesini
Yura Zenevich
Cameron McCormack
Lee Salzman
Geoff Brown