With this patch, we now have an automated test to verify if a transition
is run properly on a visited link. Note that the test aims to verify
the behavior in Stylo should match that in Gecko. Due to Bug 868975, we
haven't supported transitioning on visited styles yet, so the test should
be put in our own repo for now. This test can be tweaked and put into
web-platform repo once we resolve Bug 868975.
MozReview-Commit-ID: Ci1cERXkIUK
--HG--
extra : rebase_source : 7feb1229bc2dc430bc2a1e40be40047049469fbd
This doesn't actually implement style context reparenting in the style set yet; that part is next.
There is one behavior difference being introduced here compared to Gecko: we
don't reparent the first block piece of an {ib} (block-inside-inline) split
whose first inline piece is being reparented. This is actually a correctness
fix. In this testcase:
<style>
#target { color: green; }
#target::first-line { color: red; }
</style>
<div id="target">
<span>
<div>This should be green</div>
</span>
</div>
Gecko makes the text red, while every other browser makes it green.
We're preserving Gecko's behavior for out-of-flows in first-line so far, but
arguably it's wrong per spec and doesn't match other browsers either. We can
look into changing it later.
MozReview-Commit-ID: 5eC6G449Mlh
--HG--
extra : rebase_source : 8c333a0afe96c68a4e3b6aeca1b742ef8d5edd3b
This parameter isn't used by any implementation of onDispatchedEvent,
and keeping the parameter makes later refactorings in this bug more difficult.
MozReview-Commit-ID: 90VY2vYtwCW
Otherwise we risk losing track of the frame if we hit the cache.
MozReview-Commit-ID: ByHGhcBwIfX
--HG--
extra : rebase_source : 4534efa9ef02f4d7f59a33b55c50d9d372ad08a8
Add ServoFontFeatureValuesRule for CSSOM representation of
@font-feature-values rule and wire up with bindings.
MozReview-Commit-ID: B4Lpj43bvKX
--HG--
extra : rebase_source : 6508027f88ff76784ed7d0e5420d6e174f116b38
Extract CSSFontFeatureValuesRule from nsCSSFontFeatureValuesRule
class. This is necessary because we will create a FontFeatureValues
rule for Servo side.
MozReview-Commit-ID: GKy5wa6JLv9
--HG--
extra : rebase_source : 015f13da9a776c4ece8aa13655395afbb347b870
This bug report became semi-obsolete after the assertion it triggered was
removed (as part of CSSUnprefixingService being replaced with native code).
I'm adding its testcase as a crashtest for good measure & for
regression-testing.
MozReview-Commit-ID: GhsoI8UHqI8
This patch replaces four functions of the name AssignWithConversion which
are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII
with direct calls to the latter two functions. The replaced functions are:
void nsCString::AssignWithConversion( const nsAString& aData )
void nsString::AssignWithConversion( const nsACString& aData )
void nsTString_CharT::AssignWithConversion(
const incompatible_char_type* aData,
int32_t aLength = -1);
The last of the three exists inside the double-included nsTString* world and
so describes two functions, giving four in total.
This has two advantages:
* it removes code
* at the call points, it makes clear (from the replacement name) which
conversion is being carried out. The generic name "AssignWithConversion"
doesn't make that obvious -- one had to infer it from the types.
The patch also removes two commented out lines from
editor/composer/nsComposerCommands.cpp, that appear to be related. They are
at top level, where they would never have compiled. They look like
leftovers from some previous change.
--HG--
extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5
We need this new API in the following patch.
MozReview-Commit-ID: JSoCgzKWrfs
--HG--
extra : rebase_source : e7da0a990b991b1c417015a9cb4f9e2b1e98faae
extra : source : 8f02c1ea8448315f9284939823d66e67cdc5ad87
The details element, which is a sibling of an animating element, is checked
whether the element needs to be processed in a post traversal for throttled
animation flush because the parent element has animation-only dirty bit (i.e.
the parent element is a common ancestor of the animating element and the
details element). Also at the moment of the check the details element has
reconstruct frame damage because 'open' attribute is changed. Thus in the check
the details element was not restyled but had reconstruct frame damage.
MozReview-Commit-ID: FvsyZlUjhFi
--HG--
extra : rebase_source : 80ee22e7a3092ee208ce74304c242da782f6a0f4
Jeremy Chen
Xidorn Quan
Sebastian Hengst
Boris Zbarsky
Nazım Can Altınova
Wes Kocher
Bill McCloskey
Botond Ballo
Carsten "Tomcat" Book
Cameron McCormack
Bobby Holley
Emilio Cobos Álvarez
Daniel Holbert
Julian Seward
J. Ryan Stinnett
Ehsan Akhgari
cku
Josh Matthews
Fernando Jimenez Moreno
Ryan VanderMeulen
Hiroyuki Ikezoe
Kevin Hsieh