I was there, looking at a Firefox directory in my file manager while
working on bug 1079662, when I noticed the `Throbber-small.gif`
appearing first in the list, and wondering where it came from. And I
found it's there for the crashreporter UI. Fair enough.
But back when it was added in bug 404855, the file was also used for
Firefox, which is why it's taken from the Firefox theme. Interestingly,
back then, the file was duplicated in multiple themes, but was taken
from the windows theme rather than the gnome theme. Figures.
Anyways, later down the road, in bug 421595, Firefox replaced the gif
throbber with an APNG version. Then even later, bug 418003 removed the
unused gif throbber files, leaving the Windows one alone because it's
used by the crashreporter client moz.build (Makefile, back then), but
still removed the reference from the jar.mn.
9 years later, here we are, still using a file from the Windows theme,
that is not actually part of the Windows theme, for the Linux
crashreporter.
--HG--
rename : toolkit/themes/windows/global/throbber/Throbber-small.gif => toolkit/crashreporter/client/Throbber-small.gif
It was accidentally copied from the previous ruleset for the -moz-ui-invalid rules but I meant to invesigate whether -moz-ui-invalid applied to <xul:textbox> before landing.
Differential Revision: https://phabricator.services.mozilla.com/D4359
--HG--
extra : moz-landing-system : lando
When any scrollbar color is specified, or scrollbar-width is thin, we
switch to use the fallback rendering.
The change to xulscrollbars.css is for ensuring that the scrollbar is
displayed for scrollbar-width: thin when there is no scrollbar color
specified. It wouldn't affect cases where -moz-appearance takes effect.
This also changes the fallback width of the scrollbars. Since the two
widths was picked rather randomly, I think it should be fine to change
it if a value looks better than the old one, especially on Linux which
is the main usecase for this fallback rendering.
Differential Revision: https://phabricator.services.mozilla.com/D3952
--HG--
extra : moz-landing-system : lando
Almost all widgets provide a non-overridable size for scrollbar buttons,
so it makes no sense to specify min size for them.
It is probably a layout bug that min size properties can override the
value returned by GetMinimumWidgetSize even if aIsOverridable is set to
false, but removing this rule is simpler than locating and fixing the
issue in layout code :)
MozReview-Commit-ID: 58pmxQaHlGe
--HG--
extra : rebase_source : 11db9446c273d31c574bdb63fc696e7951741ecd
videocontrols.js handles the controls attribute with a callback named
"onattributechange" called by UAWidgets, replaces the CSS selectors.
MozReview-Commit-ID: 8rrw0Pbu8Dj
--HG--
rename : toolkit/content/widgets/videocontrols.xml => toolkit/content/widgets/videocontrols.js
extra : rebase_source : 8d8a38afac0273621f711b988c1be82d04865e33
Instead of `<xul:hbox class="textbox-input-box">`, consumers now should use
`<xul:moz-input-box />`. This covers the normal case and also handles
[spellcheck=true] while sharing much of the code within one class.
MozReview-Commit-ID: DjvT8sFq3SQ
--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/textbox.js
Update the Save to Pocket svg icons in the urlbar, page action panel, and reader view. There's another Save to Pocket icon in activity stream that the bug doesn't mention but that should probably be updated too. I'll make a different revision for it.
Differential Revision: https://phabricator.services.mozilla.com/D2676
--HG--
extra : moz-landing-system : lando
The new "tooltip.css" file allows styling the default tooltip, which is created as native anonymous content.
MozReview-Commit-ID: ADWsFTNPfhw
--HG--
rename : toolkit/themes/linux/global/popup.css => toolkit/themes/linux/global/tooltip.css
rename : toolkit/themes/osx/global/popup.css => toolkit/themes/osx/global/tooltip.css
rename : toolkit/themes/windows/global/popup.css => toolkit/themes/windows/global/tooltip.css
extra : rebase_source : bd79b86fb44ac0dc77d0d21fdc003105da6f43eb
extra : intermediate-source : a06a200098013d5dbc42c2431f845ca1dd8b0b76
extra : source : 4d511f7fc5b5c16fdfea91242dea6086cd57c8c3
Support for "listbox" in preferences is also removed, in preparation for the removal of the "listbox" element and binding.
MozReview-Commit-ID: Bi2VKKi5rdk
--HG--
extra : source : 762819bac1b9efe0e939be07394bd7d293638c40
The specificity of some Windows rules is reduced to match other platforms.
MozReview-Commit-ID: 28oUf7b6vCW
--HG--
extra : source : 3c131dac495ed46d524f4de2f92cfe79049aff8f
extra : intermediate-source : 7c1de225e4ab5dff9443c763ad59f5aecd72a593
The content of this element is always overridden and the "xul:button" display mode is unnecessary, so the binding can be removed. The styles that control color are moved to "richlistbox.css" in preparation for the removal of the "listbox" element.
MozReview-Commit-ID: 5pGVE6n34EL
--HG--
extra : rebase_source : 8c5e37736c92382486ac605cc2d30085c16b7de7
extra : source : 8be7c63ea5c620641816664d9be81e58a912f9f3
These simple lists are converted to normal layout by setting a fixed height that isn't a multiple of the row height, which is already the case for most other lists in the user interface.
MozReview-Commit-ID: 1tV4MIoRp0d
--HG--
rename : toolkit/themes/windows/global/richlistbox.css => toolkit/themes/linux/global/richlistbox.css
extra : rebase_source : d6c53aa341bc5711f6ecf16485b5bd03d4f9caf2
extra : intermediate-source : 1355778929be17234ca3ced4f9930f05fb2cf20a
extra : source : 2e4527da76bba52492353aa5a40c128b09f389f1
The specificity of some Windows rules is reduced to match other platforms.
MozReview-Commit-ID: 28oUf7b6vCW
--HG--
extra : source : 3c131dac495ed46d524f4de2f92cfe79049aff8f
The .menu-iconic-right class is not used anymore so it can be removed.
MozReview-Commit-ID: 9hBGemRLB1l
--HG--
extra : rebase_source : 8a86d6cf5f244321a1eee61739878d3215ec077e
Portions of the patch contributed by Tim Nguyen (ntim.bugs@gmail.com)
MozReview-Commit-ID: DEBBjcgHIyH
--HG--
extra : rebase_source : 04283a360411699c23a6acee9027fb7750c8d6eb
This aligns the markup of the base "arrowscrollbox" binding with the "clicktoscroll" derived binding, while still keeping different event handlers.
MozReview-Commit-ID: 9eYt1kyjgP9
--HG--
extra : rebase_source : 16600f0916ac4188ceaf8dff61fb61021cc8da5a
I messed up while rebasing on top of bug 1450816.
MozReview-Commit-ID: Hn2dQhJpsL1
--HG--
extra : rebase_source : 3d08fc963e2f734bed40b6a5090b435a5b88b7a1
Gtk checkboxes and radio buttons used to render a solid background on hover and so we also set a text color for that state. Apparently we're not getting that background anymore.
MozReview-Commit-ID: 7c5dbWroRbP
--HG--
extra : rebase_source : 4159ac0ff197f700e86692c7d1d939601c1453bd
Right now it uses extends="xul:button" so that the element it wraps doesn't get
mouse events. There's a way to do that with CSS, using pointer-events: none on
the child.
MozReview-Commit-ID: GKLG62HDD7l
Having the native theme widget to flip its own direction turned out to be
something not needed anymore, and it interfere with the CSS rule we set to
flip non-native SVG background.
This patch turned that off and always flips the resizer with CSS transform.
MozReview-Commit-ID: EbjTfFpJpZ0
--HG--
rename : layout/reftests/forms/textarea/resize-ref.html => layout/reftests/forms/textarea/resize-rtl-ref.html
rename : layout/reftests/forms/textarea/resize.html => layout/reftests/forms/textarea/resize-rtl.html
extra : rebase_source : a319698cea6c8460aaed23948e20b0757cec686e
For some reason, removing the scrollbar binding triggers
content process performance regression on Linux.
We'll add an empty binding for now until we find the real cause.
MozReview-Commit-ID: 5sonOULH1x8
--HG--
extra : rebase_source : 10d9a1577f2f36937baf65b10baf29c6e2e3a114
- There is no longer any resizer[type="window] in the tree (was added in
bug 556645)
- min-width/height was added to ensure the minimum dimensions, but
intrinsic size of native and non-native resizer widget are already
bigger than the size set (and there is no way to overwrite it).
See bug 636564 comment 71.
MozReview-Commit-ID: A8uYkwoJiVy
--HG--
extra : rebase_source : c112df69b509837ea657decda16b80ed206463f7
extra : source : bab30989a50d6a8e505dee720ead93433e83ffdf
This patch changes the direction context the dir=bottomend/bottomstart value
from the CSS direction property value to locale dir, with the help
from :-moz-locale-dir(rtl) selector.
The change is justified because:
- In the web content, we have since rely on the nsScrollFrame to set the
direction explicity.
- XUL window should always render in the application locale; it should be
fine to disregard direction property set in the local document DOM teee,
as it is unlikely to be differ than the locale dir.
This remove the one last bit of JavaScript from the resizer binding.
MozReview-Commit-ID: AweJ5GARNUE
--HG--
extra : rebase_source : 17772435a1f9cfdbc7289eb41d69e5922ffdb302
extra : source : edfba1676e4bb74e32cc987d851f7a6b12abef3b
It was never included in the manifest from file creation in bug 554810.
The error went undetected for 8 years, because the Linux manifest overwrites
the Windows one, and the Windows file goes to the same name (with a similar
look) gets packaged.
MozReview-Commit-ID: HXFxD0KmSYA
--HG--
extra : rebase_source : c7f7f71eacc4a251e938cc49413c0caaceedf9ee
extra : source : 36fbf38cbfec6ab7d9dab9a635046596f26560c6
nsScrollbarFrame::CreateAnonymousContent() would create the children
markup originally created by XBL. The attributes updated by XBL attribute
inheritance is updated by nsScrollbarFrame::UpdateChildrenAttributeValue().
This removes the XBL part of the scrollbar implementation.
MozReview-Commit-ID: FWi3HR2qkwF
--HG--
extra : rebase_source : c0b1b2ddbccb1d8e9d523db91a5b81fbcfa328e9
This UI is the only consumer of `checkState`, and it's using it in a
confusing way represent a ascending and descending sorts on the checkbox.
And also since the default sort for Recent Updates (most recent first)
is reasonable, go ahead and remove the binding altogether.
MozReview-Commit-ID: 4OnAN1t2fGq
--HG--
extra : rebase_source : 765bc7f830886ed2a5a52ca433a6e1d86511cc46
This also aligns the help button to the bottom of the window even when the meta tree is hidden.
MozReview-Commit-ID: GCmgThN569z
--HG--
extra : rebase_source : 0dba1f8b8f84d5d97706a283560a3a3c6d7278d8
The Animation and KeyframeEffect constructors and the finshed promise are not
enabled on release channel currently. The polyfill is added to make sure
we don't break on release.
When the feature ships, removing the polyfill should be as easy as
reverting this changeset.
MozReview-Commit-ID: 2EWN7hBN5tj
--HG--
extra : rebase_source : 19290268e281fc631458eb64745bea000994c3e7
Web Animation API should give us deterministic timing when the transition ends or aborts.
Additional clean-ups:
- Make sure hidden status is always set/get from the hidden property,
instead of the hidden attribute.
- Remove the unused isControlBarHidden property.
- controlsSpacer no longer has a background color (removed in bug 1374007),
therefore it no longer needs a transition and there is no need to test
its state with the test added in bug 1319301.
- Fix a logic error at hideByAdjustment property, revealed by the changed
transition timing, in which adjustControlSize() would show the controlBar
set hidden by the transition.
MozReview-Commit-ID: DB2cgQcUEXi
--HG--
extra : rebase_source : 2a715038197aa29d3eaf837fad85797ec1e98b15
Fades out all the UIs by applying CSS transition on opacity and visibility.
Stop relying on transitionend event to set the hidden state.
This removes a source of intermittent failure and while making sure UIs are
hidden.
MozReview-Commit-ID: FR7JQn4eO3X
--HG--
extra : rebase_source : d62faf9eb8c1cab72e9a0e445974be67e7ff5c85
Enlarge controls by around 1.3x, which is the size of the original touch controls.
MozReview-Commit-ID: kpgFFIW2hh
--HG--
extra : rebase_source : 66636a0cb15a17ef15c2a2307a2f9100c1852480
extra : source : ae615321dc9b3e6276d8e79285d0e9d65b6d6bc2
Also migrates TouchUtils to videoControls in order to keep some interactions.
Removed the casting button from TouchUtils (to be add back to Utils in the next
commit; not removing the SVG images for hg annotation)
MozReview-Commit-ID: DzhmjykCLzu
--HG--
extra : rebase_source : d77dfe3e2d9de2087d21dc2fb9b1773e710177d7
The noControls binding is bound to <video> without controls on mobile
(see geckoview/content.css), and is only visible when the video is
blocked because of background autoplay.
MozReview-Commit-ID: KZqlQedCjd5
--HG--
extra : rebase_source : c5f619b0849ee56f957e9017ab2627d592a3285e
Improves the UI for pages blocked by the enterprise policy manager. These improvements include a new image instead of the generic "info" image and updated, approved strings for the page.
MozReview-Commit-ID: 9d6V9onHGGg
--HG--
extra : rebase_source : d702947924f24d9440455a56b7e2f876ab634464
Along with removing the view source standalone windows and prefs this patch:
1) Re-structures several of the view source tests that were only testing the old
standalone windows to now test view source in tab.
2) Adds support viewSourceUtils.viewSource() to open a browser window when there
aren't any open (for browser toolbox view source).
3) Cleans up some of the API for viewSourceUtils and removes the old deprecated
ways of calling it.
MozReview-Commit-ID: DI6sgZwbCf
--HG--
extra : rebase_source : 64677186122f74ab95912d5f3f173cf37472458a
The default styles of richlistbox autocomplete were originally created to support the location bar popup, but now every autocomplete field uses the richlistbox version. This reworks the styles so that the number of overrides is minimized.
MozReview-Commit-ID: BwagKpMR5Dt
--HG--
extra : rebase_source : 52eda7f9d561dd23f279a3d15659e84f6c46eec6
The events that get silenced here are already covered for native anonymous content
by IsEventStoppedFromAnonymousScrollbar.
In trees, where <xul:scrollbar> and <xul:scrollcorner> are part of the DOM, copy the
handlers over into attributes on each instance.
MozReview-Commit-ID: Huk5nFC7Qua
--HG--
extra : rebase_source : f5e596f04c6a2022b9d6019d49e61bf64422f912
* The number is no longer selected on number input focus
MozReview-Commit-ID: AmR5c6YKTCP
--HG--
extra : rebase_source : fdaab23fca57f361c9185191d9c30e047375cbe8
* The number is no longer selected on number input focus
MozReview-Commit-ID: EoXNqhXwK95
--HG--
extra : rebase_source : b5a522e11796ec42c87019f6c3955e6c40eb21d0
* The number is no longer selected on number input focus
MozReview-Commit-ID: 6XQdnJP65m0
--HG--
extra : rebase_source : 96d16469e99fc52c15a0b5024bdf9c3b4211a171
Dão Gottwald
Noemi Erli
Jason Chapin
arika.arnzen@wsu.edu
Bogdan Tara
Mike Hommey
Prathiksha
Paolo Amadini
ahillier
Narcis Beleuzu
Arshad Kazmi
Matthew Noorenberghe
Sriharsha sriharsh007jc@gmail.com
Xidorn Quan
Devika Sugathan
Timothy Guan-tin Chien
vinoth
Dorel Luca
Bharat Raghunathan
Richard Marti
sahil bhosale
arthur.iakab
Tim Nguyen
Andreea Pavel
Brian Grinstead
Drew Willcoxon
Jonathan Watt
shindli
Mark Striemer
Trisha Gupta
Cosmin Sabou
Harry Twyford
trisha
Ciure Andrei
Coroiu Cristina
Israel Madueme
Gijs Kruitbosch
Gurzau Raul
Jared Wein
Mike Conley
Brindusan Cristian
Emilio Cobos Álvarez
Bogdan Pozderca
Andrew Swan
Manish Kumar
Jonathan Kingston
UK992
sreeise
raymond
Tiberius Oros
shorlander@mozilla.com
Kirk Steuber
Brendan Dahl
Martin Stransky
Csoregi Natalia