There was an issue for test with less than 10 entries
as we were assuming we already had everything we needed
in the grip preview. This wasn't the case and was making
loading entries object failing.
Since there's not reason we should find actors in the
preview object, and we should have a unified way of
loading objects, whatever their sizes is, this patch remove
this specific behaviour to always load entries.
Jest tests had to be modified or removed, and the mochitest
that is already testing expanding Maps and Sets is enhanced
to make sure this issue is fixed.
Differential Revision: https://phabricator.services.mozilla.com/D65941
--HG--
extra : moz-landing-system : lando
Gecko don't commit composition when software keyboard calls
InputConnection.finishComposingText. It is incompatible with Blink's behaviour.
BaseInputConnection.finishComposingText() implementation is the following.
1. Begin batch edit.
2. Remove all composition span flag.
3. End batch edit.
So if no composition after batch edit is finished, we should commit it on Gecko
to synchronize composition state.
Differential Revision: https://phabricator.services.mozilla.com/D66370
--HG--
extra : moz-landing-system : lando
CompositorVsyncDispatcher holds a reference to the VsyncSource, so it must be informed on change.
Differential Revision: https://phabricator.services.mozilla.com/D65878
--HG--
extra : moz-landing-system : lando
Expect forced-colors-mode-backplate tests to fail because they were passing for the wrong reason,
and the backplate is now properly applied, causing them to fail.
Remove tests for field and fieldtext from color-valid.html because they are tested again
in system-color-valid.html.
Differential Revision: https://phabricator.services.mozilla.com/D66879
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Using WPT metadata to mark fetch.https.any.js test as slow.
This CL annotates cross-origin-resource-policy/fetch.https.any.js with:
// META: timeout=long
and removes [ Timeout ] expectations that this test has accumulated in
blink/web_tests/TestExpectations over multiple sheriffing duties.
Bug: 626703
Fixed: 1012599
Change-Id: Ia26c9200bc4182fb7fe51c98fd256079175c0801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103074
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750320}
--
wpt-commits: af71682c3fb9880458752eebc3f98aa2a708e8a9
wpt-pr: 22247
Automatic update from web-platform-tests
WebXR - add WPTs for transient hit test API
Change-Id: I845e082ca413bcfa19a5ca4e06f587ebcb2cb254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101713
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750277}
--
wpt-commits: 9610643196e6b5eb25b14c33016121290886dac2
wpt-pr: 22229
Automatic update from web-platform-tests
WebOTP: Cleanup navigator.sms.receive()
This change removes the previous iteration of WebOTP,
SMS Receiver API, which we ran for Origin Trial.
This is now being removed in favor of the credential
management version, WebOTP API [1].
WebOTP API Explainer: https://github.com/WICG/WebOTP
I2E ending in M80: https://groups.google.com/a/chromium.org/d/topic/blink-dev/-bdqHhCyBwM/discussion
Bug: 1045526
Change-Id: I1e73bed5018c814770fa34edcf64daafd234a543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097041
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750226}
--
wpt-commits: b6cf8f290e3d4053dbad33913473bc77532f0d89
wpt-pr: 22199
Automatic update from web-platform-tests
Make LogicalHeightComputesAsNone check the override cb height
If the override height is indefinite, this function should return true.
This fixes the case of max-height: xx% on a replaced item in a flexbox,
which otherwise would get resolved to 0 because resolving the percentage
for replaced items would convert negative numbers to 0.
Fixed: 1048051
Change-Id: I192e65b37a3670226fa764662448bdb4216c9fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100771
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750285}
--
wpt-commits: 4c698c2c113d37c4a71f0bd0d1f32d631fa51a76
wpt-pr: 22242
Automatic update from web-platform-tests
[ScrollTimeline] Support composited scroll-linked Web Animation
This patch integrates ScrollTimeline with cc::Animation. Major changes
include:
1. blink::ScrollTimeline is able to create its compositor counterpart
2. cc::ScrollTimeline is attached to cc::AnimationHost upon creation
3. cc::AnimationHost ticks animations based on their timeline type
4. Remove scroll_timeline_ from cc::WorkletAnimation and use the unified
animation_timeline_.
5. Added virtual/threaded/external/wpt/scroll-animations/.
See [1] for more details.
[1] https://docs.google.com/document/d/1RpJrYIDYHvtu0ia1vPv_EhBfan428QZ2sgsFhtnXb20/edit?usp=sharing
To sheriffs: if any virtual tests become flaky, please add them to
TestExpectation instead of reverting the change.
Bug: 1023508
Change-Id: Ib4aa853bda34ce9b2c0abc943be9f99ac81e799a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084088
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749389}
--
wpt-commits: 65dfaeccfa8044f290f22a13fd91fb0209cf50e1
wpt-pr: 22180
Automatic update from web-platform-tests
Fix position:sticky when inside fixed subtree
In https://crrev.com/4d25b125dae5 I changed the scroll tree parenting
logic so that elements in position:fixed subtrees have the LayoutView's
ScrollNode as the scroll parent. This made sense since scrolling over a
fixed element should cause the document to scroll. However, this is
slightly different from how the transform tree looks. Because scrolling
the document doesn't cause position:fixed eement so translate, these
nodes don't have the LayoutView's ScrollTranslation transform node as an
ancestor.
As a simple example, a scrolling document with a position:fixed <div>
scroller will generate the following scroll and transform trees
(approximately):
*ScrollTree* *TransformTree*
Root Root
| |
VisualViewport Translation VisualViewport
| / \
LayoutView Translation / \
| Fixed LayoutView
Fixed Scroller Translation
The situation above makes sense for what parent-child relationships mean
in each tree: the scroll tree encodes how scrolls chain; scrolling on a
child should bubble up to its parent in this tree. The transform tree
encodes the physical effect of scrolling a node. In the above example,
scrolling from the fixed scroller should bubble up to the LayoutView
(when the scroller is fully scrolled) but scrolling the LayoutView will
not cause movement of the fixed scroller.
The above makes sense but caused sticky code to get confused. A sticky
constraint is attached to the scroll translation node. With the above
situation, this meant that inside a fixed subtree, we'd attach it to the
VisualViewport's scroll translation node. This was unexpected; the
constraints are in "document coordinates", meaning that to translate
them into the viewport space we must apply the scroll offset [1]. The
compositor would use the visual viewport's (typically 0) scroll offset
to adjust these values, leading to incorrect calculations.
This previously worked because the scroll node used in a fixed subtree
would be the visual viewport (before the CL mentioned at the top). In
[2] we check whether the current overflow clip is also our scroller,
prior to the CL this check have failed because "our scroller" was the
visual viewport but our clip was the LayoutView. Now they are both the
LayoutView.
The fix in this CL is to make the check in [2] more stringent; we also
want to make sure that our scroller is the nearest scroller in the
transform tree. That is, if we scroll it, will we cause the current node
to move? If not, we don't need a sticky constraint on the compositor
because user scrolling can't change the sticky's offset relative to its
clip.
[1] https://cs.chromium.org/chromium/src/cc/trees/property_tree.cc?l=321&rcl=628f869d1fda631a85f051ad13b5d278319298fc
[2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc?l=553&rcl=99a5a1266f303ba6ae46174a2b4cbd165ea7e934
Bug: 1019142
Change-Id: I781943ff43514905d399803c780c6081d7d47e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097542
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750264}
--
wpt-commits: 1e6645ce41bc902a4c60d6f90a934f9d6d8a258a
wpt-pr: 22195
Automatic update from web-platform-tests
Migrate UnsizedMedia from feature policy to document policy
This CL migrates UnsizedMedia from feature policy to document policy.
Following web tests are being migrated:
- unsized-media.tentative.https.sub.html
- unsized-media-reporting.html
Following web tests are removed, because document policy currently
does not have a js API to list all features available.
- feature-policy-unsized-media-disabled.html
- feature-policy-unsized-media-enabled.html
Bug: 993790
Change-Id: Id5e0189c0277c940177460380970eab0015109d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097028
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750246}
--
wpt-commits: 550ab235e713dc584eb0e60ecc3861a11b644f02
wpt-pr: 22221
--HG--
rename : testing/web-platform/tests/feature-policy/experimental-features/resources/image.jpg => testing/web-platform/tests/document-policy/experimental-features/resources/image.jpg
rename : testing/web-platform/tests/feature-policy/experimental-features/resources/image.png => testing/web-platform/tests/document-policy/experimental-features/resources/image.png
rename : testing/web-platform/tests/feature-policy/experimental-features/resources/image.svg => testing/web-platform/tests/document-policy/experimental-features/resources/image.svg
rename : testing/web-platform/tests/feature-policy/experimental-features/resources/video.ogv => testing/web-platform/tests/document-policy/experimental-features/resources/video.ogv
rename : testing/web-platform/tests/feature-policy/reporting/image.jpg => testing/web-platform/tests/document-policy/reporting/image.jpg
Automatic update from web-platform-tests
Clamp sub-pixel borders accounting for zoom
A previous patch added clamping for sub-pixel borders to ensure they
did not round to zero size. The change was done in paint code, leaving
the borders as sub-pixel sized in layout. The code prior to that patch
clamped the borders during style conversion but did not account for zoom,
meaning borders disappeared under zoom.
This change removes the clamping in paint and reverts to clamping in the
style conversion code, only this time accounting for zoom when considering
whether to clamp or not. This will prevent borders growing too large as
content is made larger, while preventing sub-pixel borders from disappearing
as content is made smaller.
Design Doc: https://docs.google.com/document/d/1fAYkOFxp2Luh6OOoXxtwOehmvNRGNss58ibQtVXL0Tw/edit?usp=sharing
Bug: 763402, 834489
Change-Id: Iba2ae80b0a981736b93453c1058fd586ba10212c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097514
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750231}
--
wpt-commits: 4b8af2e84553f4f1391a58251037ea1a4b152682
wpt-pr: 22225
Automatic update from web-platform-tests
Add tests for color-scheme and iframes.
Iframes where the color-scheme of the iframe element and the iframe
document's root does not match, will get a backdrop matching the color-
scheme of the iframe's root element.
Also adjust existing test according to spec change. See:
https://github.com/w3c/csswg-drafts/issues/4772
Bug: 1058822
Change-Id: I82fd3cc3c2bbf5b4835b157a7522cb22c459ff20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095112
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750186}
--
wpt-commits: 348adc5c7b2e3abb76763af063fbd921afb99ac5
wpt-pr: 22213
Automatic update from web-platform-tests
Fix manifest writing in python3 (#22139)
Store more properties as text and convert to str for output.
--
wpt-commits: d4cdf4021ab48c66b052fb62d91da1a06c8cbcf7
wpt-pr: 22139
Automatic update from web-platform-tests
correct default expectation for existing mrow test (#22226)
* Update tabindex-001.html
Attempting to match defaults defined in https://github.com/whatwg/html/pull/5248
definitely needs scrutiny..
* Update tabindex-001.html
The default `.tabIndex` of an mrow should be 0 regardless of when it has an href or not, as a linkable element and matching historical (oddity) of other linkable things in HTML/SVG
--
wpt-commits: 6b2fee71a825487369f34f82e7daa732920d186e
wpt-pr: 22226
Automatic update from web-platform-tests
Correctly test document.all quirks
For legacy compatibility, this property is specified with some willful
violations of JS: <https://html.spec.whatwg.org/#dom-document-all>.
Prior to this commit, idlharness wasn't accounting for these, so
html/dom/interfaces.html was wrong for document.all/HTMLAllCollection
tests.
It's a bit ugly to include this directly in idlharness.js and
testharness.js, but it's the cleanest solution I can think of.
Fixes#4207.
--
wpt-commits: 687b92d025e32df7f5217bc06b0e510a39953ef9
wpt-pr: 22236
Automatic update from web-platform-tests
Make computedStyleMap return the computed value for lineHeight
It previously returned the resolved value as produced by
ValueForLineHeight (this property is unique in that the computed and
resolved values differ even without a layout object).
Introduce another serializer ComputedValueForLineHeight which produces
the actual computed value.
Change-Id: Ic27d9a4fe7c67cbbb577ec4e4efed14a88a846c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101858
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750170}
--
wpt-commits: 550ffc84d3c79e80ea4b8b90a2489a0b8426aa1b
wpt-pr: 22230
Automatic update from web-platform-tests
Origin policy: rearrange a couple tests
Although these tests use content security policy to test that the policy is not applied, they're really about testing what happens when the server does something wrong. Since we'll be adding more tests of that sort for https://crbug.com/1051170 and https://crbug.com/1042036, it makes sense to have a top-level directory for them.
This also extends the test to use the new expectedIds test runner feature as an extra check that no policy was applied.
Bug: 751996
Change-Id: I5a91eb7f97ed81b65b94fd67b44586e7c8f70e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101351
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750163}
--
wpt-commits: c7e667518c4c835a79124be8a8511a6b6121b01f
wpt-pr: 22231
Automatic update from web-platform-tests
Test Access-Control-Allow-Credentials header and xhr (#22219)
Test based on fetch/api/cors/cors-expose-star.sub.any.js.
--
wpt-commits: be8ae0e79486c890fe060055c4b7240184b06182
wpt-pr: 22219
Christoph Kerschbaumer
Kartikaya Gupta
luma
Nicolas Chevobbe
Makoto Kato
Logan Smyth
Glenn Watson
Coroiu Cristina
Nicholas Nethercote
Matt Woodrow
Kenny Levinsen
Lee Salzman
Michał Sobkiewicz
Daniel Varga
Sam Mauldin
Cosmin Sabou
MahakBansal
moz-wptsync-bot
Lukasz Anforowicz
Piotr Bialecki
Ayu Ishii
Christian Biesinger
Alan Cutter
Tobie Langel
Yi Gu
David Bokan
Charlie Hu
Stephen Chenney
Rune Lillesveen
Sergio
Brian Kardell
Aryeh Gregor
George Steel
Domenic Denicola
Rob Buis