geckodriver currently writes a legacy capabilities structure to the
WebDriver:NewSession command it uses on creating a new WebDriver
session which duplicates the top-level object:
{capabilities: {<caps>, desiredCapabilities: <caps>}}
Where caps can look something like:
{acceptInsecureCerts: true, pageLoadStrategy: "normal", ...}
Marionette has picked up the top-level "capabilities" key for a
very long time now, and there is no longer any need to duplicate
the body.
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
--HG--
extra : rebase_source : fbfbcf7608efbfb35c9be4018ff0f4e70b2768d2
To check that changes in P1 still work when layout is required.
MozReview-Commit-ID: ArqwDQXQwnR
--HG--
extra : rebase_source : 28cec6a6805bbd3c993c91115c663b791e35a20d
Automatic update from web-platform-testsUpdate the cors-rfc1918 IDL test (#11959)
--
wpt-commits: 4826368b55fb570a2f4177099103860a160589be
wpt-pr: 11959
--HG--
extra : source : 8fdb94dcb58de58b83c432e84f7aae872e4e3a1c
Automatic update from web-platform-testsUpdate the picture-in-picture IDL test (#11916)
--
wpt-commits: ab9fce0c39c50afa4e6bb51b1cabfe4ffccc2bf8
wpt-pr: 11916
Automatic update from web-platform-testsUpdate the IndexedDB tests to cover all workers (#11958)
--
wpt-commits: ceba83a56edd838cca0aacd35549f979292a5995
wpt-pr: 11958
--HG--
extra : source : 281f85b1c1062f933f13f477f21fd455e341eb1e
Automatic update from web-platform-testsUpdate the remote-playback IDL + test (#11944)
--
wpt-commits: 2ef7f40f10060dbc7bd677f649d3111e3b0c4314
wpt-pr: 11944
Automatic update from web-platform-testswebrtc wpt: remove generateMediaStreamTrack usage
removes most usage of generateMediaStreamTrack in favor of
await-ing tracks from getUserMedia and stopping them)
BUG=836871
Change-Id: Id84f6cb6b3537faf2bb83332c5d7993550246581
Reviewed-on: https://chromium-review.googlesource.com/1117069
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574855}
--
wpt-commits: 948babd1549e445e83260bcc715202a7cbda98ec
wpt-pr: 11694
Automatic update from web-platform-testsTest fetch abort with keepalive (#11822)
Aborting a fetch with keepalive: true should normally work. However, if
the context has been detached then it should not work. Test these cases.
--
wpt-commits: e9385e019228141b8df04360ad80d39af2fa781f
wpt-pr: 11822
Automatic update from web-platform-testsRevert "Correctly initialize and test SnapContainerData in cc."
This reverts commit 37061f875b167ab82f1a0ddca84b510b7c6802dc.
Reason for revert:
The layout tests added by this CL is failing on the CL:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
Original change's description:
> Correctly initialize and test SnapContainerData in cc.
>
> This patch initializes the rect_ field in SnapContainerData in copy
> constructor and move constructor. Fixing a snapping issue in the
> composited pages.
>
> We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> test suite so that they are tested with the composited cases.
>
> snap-at-user-scroll-end-manual-automation.js calls
> mouseClickInTarget() of pointerevent_common_input.js. That method
> invokes programmatic scrolls. The test was written before programmatic
> scroll snapping was implemented so it worked at that time. However,
> with programmatic scroll snapping implemented, it will always snap
> in mouseClickIntarget() and cannot test whether the user scroll snaps.
> This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> to avoid invoking programmatic scrolls in the test.
>
> This patch also checks nullptr for layout_box in
> ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
>
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> Reviewed-on: https://chromium-review.googlesource.com/1132386
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574781}
TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
No-Presubmit: true
No-Tree-Checks: true
No-Try : true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136171
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574825}
--
wpt-commits: 211d3165a3b66b6a8eb85a765b0aedb60410ab88
wpt-pr: 11961
Automatic update from web-platform-testsUpdate the remote-playback IDL + test (#11944)
--
wpt-commits: 2ef7f40f10060dbc7bd677f649d3111e3b0c4314
wpt-pr: 11944
Automatic update from web-platform-testsCorrectly initialize and test SnapContainerData in cc.
This patch initializes the rect_ field in SnapContainerData in copy
constructor and move constructor. Fixing a snapping issue in the
composited pages.
We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
test suite so that they are tested with the composited cases.
snap-at-user-scroll-end-manual-automation.js calls
mouseClickInTarget() of pointerevent_common_input.js. That method
invokes programmatic scrolls. The test was written before programmatic
scroll snapping was implemented so it worked at that time. However,
with programmatic scroll snapping implemented, it will always snap
in mouseClickIntarget() and cannot test whether the user scroll snaps.
This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
to avoid invoking programmatic scrolls in the test.
This patch also checks nullptr for layout_box in
ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
Reviewed-on: https://chromium-review.googlesource.com/1132386
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574781}
--
wpt-commits: ffcd0bede8fa1e7da8c8216655193584795dcca7
wpt-pr: 11907
Automatic update from web-platform-testsAdd WindowPostMessageOptions and a new postMessage overload.
Add bindings code to process the options, add WPT tests to cover
the cases that are special. A pull request against the HTTP Spec
will be done shortly.
Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/xACYBou4f9A/Ft0-QlFMAQAJhttps://github.com/dtapuska/useractivation
BUG=846858
Change-Id: I24f570850280e6935d43793041252312c2bfc484
Reviewed-on: https://chromium-review.googlesource.com/1118850
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574753}
--
wpt-commits: 1bbb7050e6f33d2b3a64a763fd6405542a74dd45
wpt-pr: 11716
Automatic update from web-platform-testsAdd a fail-fast for longtask layouttests
This CL adds checks to fail tests for browsers that do not support longtasks
instead of forcing them to timeout.
Change-Id: I5be54a1ab0a5d003decb58fc1e79380cbce15976
Reviewed-on: https://chromium-review.googlesource.com/1128174
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573900}
--
wpt-commits: cd75119c6b1fe0fd7721e1abece1acab38397d7e
wpt-pr: 11837
Automatic update from web-platform-testsUpdate the IndexedDB tests to cover all workers (#11958)
--
wpt-commits: ceba83a56edd838cca0aacd35549f979292a5995
wpt-pr: 11958
Automatic update from web-platform-testsUpdate the cors-rfc1918 IDL test (#11959)
--
wpt-commits: 4826368b55fb570a2f4177099103860a160589be
wpt-pr: 11959
Automatic update from web-platform-testsupdate hoverable pointerevent wpt
Update test wpt/pointerevent_attributes_hoverable_pointers
This test was failing occationally on manual test, when we have
clientX == box.right or clientY == box.bottom.
update the test assertion so coordinates on border can be consider
inside box.
Note that on right border can also be outside box for the mouseevents.
because we truncate the coordinates into interger.
Bug: 863029
Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
Reviewed-on: https://chromium-review.googlesource.com/1135432
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574624}
--
wpt-commits: df05bcb7c5c82e300805d7c11121453ec4036e32
wpt-pr: 11956
Automatic update from web-platform-testsDisable tox for all of tools/third_party (#11955)
--
wpt-commits: ed4811186ae6a02e9804012c2fc05fa94477d273
wpt-pr: 11955
Automatic update from web-platform-testsDOMParser changed to accept StringOrTrustedHTML arguments
Previously existing constructor made private and its name is now parseFromStringInternal
parseFromString wraps parseFromStringInternal
Bug: 739170
Change-Id: I3c4dd3aae13bb478ed054d328c77aa2d4ea5d3ef
Reviewed-on: https://chromium-review.googlesource.com/1128970
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Cr-Commit-Position: refs/heads/master@{#574559}
--
wpt-commits: 5834cfc29ec99cc30b3cb82a95ff52effd56a19d
wpt-pr: 11881
Automatic update from web-platform-testsRemove webkit-appearance.tentative.html WPT test
This test is not a good indicator of -webkit-appearance support; it only
checks whether computed-value == applied-value for -webkit-appearance
values specified on a vanilla <div>. In reality most values of
-webkit-appearance are not of interest to other UAs (see
https://github.com/whatwg/compat/issues/6), and the behavior is
different on different elements (e.g. <input>).
Since this has caused issues across different platforms on Chrome (see
bug), remove it.
Bug: 810162
Change-Id: I9d469cb624569f453978f3c56cc180eb07435b5b
Reviewed-on: https://chromium-review.googlesource.com/1134387
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574546}
--
wpt-commits: 4981a13ac22db892707dcaac3a6678e623224268
wpt-pr: 11933
Automatic update from web-platform-testsStreams Object.prototype.then interception (#11767)
Add tests to verify that modifying Object.prototype.then does not make the
internals of pipeTo() and tee() visible.
Equivalent standard change is whatwg/streams#936.
--
wpt-commits: 6bbdc36d277bf24bef261034660e8e6a8aaee58f
wpt-pr: 11767
Automatic update from web-platform-testsAdd tests for element setCustomValidity (#11913)
* Add tests for element setCustomValidity
* Fixed nit issues
--
wpt-commits: d2adee4d8c293f0d48475a96e76a00e0c4917167
wpt-pr: 11913
Automatic update from web-platform-tests[LayoutNG] Force legacy for SVG foreignObject
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng;luci.chromium.try :linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I12c7d4dd4af0392c2dd2d75c884dc36bff3624ab
Reviewed-on: https://chromium-review.googlesource.com/1133164
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574435}
--
wpt-commits: 48cb42da1cc4db54cd682169a355264fc117538a
wpt-pr: 11920
Automatic update from web-platform-testsMoving some encoding files from .html to .any.js
--
Generalized test
--
converted some encoding tests to use any.js
--
wpt-commits: e44b8b3dae4f0f0c874ef0b2a89290d0dd32dcdd, 12b30f56e3dddb896d343a6b6331cd25d3740e1d, dfa045c04225bbd6c1d7b6c1512f446948c12deb
wpt-pr: 11930
Automatic update from web-platform-testsStreams: pipeTo error flushing pending writes test
Add a test for what happens when an error occurs flushing pending writes in
pipeTo after the readable closes.
This clarifies behaviour that is not obvious from the standard.
Related to whatwg/streams#939
--
wpt-commits: 828cbf6461e1b36ff5ff02310cb7d6749125b57c
wpt-pr: 11914
Automatic update from web-platform-tests[html] Reduce test duration (#11876)
The `audio_loop_base.html` and `video_loop_base.html` tests were written
to verify playback looping, making it necessary to play a given media
file in its entirety.
Prior to the application of this patch, the modified tests were among
the longest-running tests in WPT [1]. Because media files of any
duration may be used to validate playback looping, the selected files'
4-second duration was unnecessary.
Introduce new procedurally-generated media files with minimal duration.
Update the tests to reference these new files, drastically reducing the
time required to execute them.
The files were created via the following commands (using ffmpeg version
2.8.14):
$ ffmpeg -f lavfi -i anullsrc=r=44100:cl=mono -t 0.05 -q:a 9 -acodec libmp3lame media/sound_0.mp3
$ ffmpeg -f lavfi -i anullsrc=r=44100:cl=mono -t 0.05 -q:a 9 -acodec libvorbis media/sound_0.oga
$ ffmpeg \
-f lavfi \
-i anullsrc=r=44100:cl=mono -ac 1 \
-i media/1x1-green.png -loop 1 -vframes 1 -pix_fmt yuv420p -vf scale=2:2 \
-shortest -acodec libmp3lame -vcodec libx264 -map 0:a -map 1:v \
media/2x2-green.mp4
$ ffmpeg \
-f lavfi \
-i anullsrc=r=44100:cl=mono -ac 1 \
-i media/1x1-green.png -vframes 1 -pix_fmt yuv420p -vf scale=2:2 \
-shortest -acodec libvorbis -vcodec libtheora -q:a 9 -map 0:a -map 1:v \
media/2x2-green.ogv
[1] https://github.com/web-platform-tests/wpt/issues/11571
--
wpt-commits: 23057064c87f42aba0615705b11570ace9cb4324
wpt-pr: 11876
Automatic update from web-platform-tests[LayoutNG] Encompass border and padding for contain:size.
When discarding intrinsic block size for contain:size, we need to reset
intrinsic size to the border+padding sum (not zero), since
intrinsic_block_size_ is the size of the border box, not the content
box.
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: I29195a09a6d47b9e3c2a82da3be6f528aac25c68
Reviewed-on: https://chromium-review.googlesource.com/1133163
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574148}
--
wpt-commits: 492e03a9902d1f94bb679832030201df4e831ab9
wpt-pr: 11921
Automatic update from web-platform-testsUpdate the picture-in-picture IDL test (#11916)
--
wpt-commits: ab9fce0c39c50afa4e6bb51b1cabfe4ffccc2bf8
wpt-pr: 11916
Automatic update from web-platform-testsRemove reviewers who have not joined the web-platform-tests org (#11888)
Part of https://github.com/web-platform-tests/wpt/issues/11293.
Reminder also in https://github.com/web-platform-tests/wpt/issues/11568.
This does not fully resolve#11293, as a few non-responders where
there would be no remaining reviewers are left, and one known to be
out-of-office. These will be handled separately to finish this.
--
wpt-commits: 8fea122cf1ed5b392c86aae5e445e7553ad83deb
wpt-pr: 11888
Automatic update from web-platform-testsMake ShadowRoot.elementsFromPoint always return document element
Currently in some cases, ShadowRoot.elementsFromPoint may not return
the document element even when Document.elementsFromPoint returns the
document element such as when the document element height is shorter than
the hit-tested element's position. This CL fixes it by removing a check
in TreeScope::ElementsFromHitTestResult.
See example live case detailed in this comment:
https://bugs.chromium.org/p/chromium/issues/detail?id=843215#c16
Bug: 843215
Change-Id: I5b774d1a091f3c3f72345c55bca188fad309ba58
Reviewed-on: https://chromium-review.googlesource.com/1131023
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574104}
--
wpt-commits: 7464bf643da4e4a689436aa8d7b4d325e583824e
wpt-pr: 11882
Automatic update from web-platform-testsWeb Locks API: Upstream tests to web-platform-tests (as .tentative)
* Move tests from http/tests/locks to external/wpt/web-locks
* Name with '.tentative' infix since this is still just a proposal
* Name most tests with '.https' infix since feature is [SecureContext]
(and remove redirect-to-secure-host logic in tests)
* Consolidate window/worker interfaces test with '.any.js' variant
* Update paths to service worker helpers
Bug: 857265
Change-Id: Iaf254c5d53ff5b6bb65de4516df85307ad3a6519
Reviewed-on: https://chromium-review.googlesource.com/1118764
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573991}
--
wpt-commits: 89ccb892ad85159b093dab6956ca9caea7bb4edc
wpt-pr: 11713
Automatic update from web-platform-testsIf AudioWorklet AudioParam is constant, make the array have length 1
If the AudioParam is constant over a rendering quantum, we're allowed
to set the parameter value array to have a length one to indicate that
the audio param is constant.
Make this so if the audio param is truly constant.
Bug: 814796
Test: audioworklet-audioparam-size.https.html
Change-Id: Ib6e5805dbeb418ad3c202c9c79adc87bc93dad4a
Reviewed-on: https://chromium-review.googlesource.com/1097977
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573985}
--
wpt-commits: e4f27865678f2e78cb64ebedf25f22b18f7f82d0
wpt-pr: 11482
Automatic update from web-platform-tests[css-properties-values-api] Add support for <transform-function> syntax.
See https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-strings.
Note: The ConsumeTransformValue function in css_parsing_utils.cc has been
moved without changes to the function.
R=chrishtr@chromium.org
Bug: 860309
Change-Id: Icdf7240f45960ed94fdfa62dd5e199ec865747cd
Reviewed-on: https://chromium-review.googlesource.com/1127042
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573914}
--
wpt-commits: eccb1d4c0bbc96697c57d007651bebc392f44d12
wpt-pr: 11808
Before this change, we accessed the browser URL in the following ways:
- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js
MozReview-Commit-ID: I5vtRke1x9t
--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
As discussed here:
https://github.com/w3c/csswg-drafts/issues/2691
We have a similar check in SetCurrentTime (with the exception that, according to
the spec, this behavior applies to either play OR pause pending, instead of just
pause-pending) so this patch tries to match the comment and format of that
check.
Differential Revision: https://phabricator.services.mozilla.com/D2410
--HG--
extra : rebase_source : 519a976424b021203a369926344c2174662e6156
Any info-level log entries emitted before session creation will
not be subject to the requested log level from moz:firefoxOptions.
This can confuse users, so instead of logging the geckodriver
version number on starting the program, we can return it later
during session creation as an extension capability.
Additionally this patch reduces the log level of the port geckodriver
listens to from info to debug for similar reasons.
Marionette currently truncates a selection of log messages that
exceed 250 characters. It is however sometimes, usually when
debugging locally, to not truncate logs so one can see exactly what
is sent to and fro the server.
These files are duplicates of each other, so for simplicity we may as well use the
upstream copies to avoid falling out of sync.
MozReview-Commit-ID: JpG3joT8NNJ
--HG--
extra : rebase_source : d06c8969a9f8871b078c22e72947f7cd7584fb00
We agreed some time ago that it would not be possible to keep the
copy-pasted specification algorithm steps up-to-date in the WPT
wdspec tests. This patch removes all such steps.
Marionette used to return a session UUID starting with "{" and
ending with "}" from the uuid-generator in Gecko. It has not done
this for a very long time rendering this geckodriver check needless.
In particular the animation-003 test needs it but we may as well turn it on for
all tests since we'll possibly add more tests like this in the future.
--HG--
extra : histedit_source : 3e16067a59780c195b54fae7ad420138e1f18209
Automatic update from web-platform-tests[css-layout-api] Don't use LayoutNG for custom layout children.
Custom layout children may not establish new formatting contexts, and
since the custom container itself is laid out by the legacy engine, we
need to force its children to be laid out by legacy as well.
Added a margin collapsing test that used to fail in NG because of this.
Change-Id: Id320f60fb76b0ed6563fb2b88f6936ac37efc1fd
Reviewed-on: https://chromium-review.googlesource.com/1131179
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573864}
--
wpt-commits: b47e2cd91cfe1b2246655b6612c407898939588c
wpt-pr: 11887
Automatic update from web-platform-testsAdd tests for (module dedicated|classic shared) worker's URLs
This CL adds WPT tests for
- WorkerLocation (wpt/workers/interfaces/WorkerGlobalScope/location/),
- referrer (wpt/xhr/), and
- API base URL (wpt/workers/baseurl/)
that should reflect worker global scope's URL, for
- classic shared workers and
- module classic workers.
Some tests are half-migrated to fetch_tests_from_worker()-style
to test shared workers easily, while the tests for
module workers uses the existing non-fetch_tests_from_worker()-style
tests, because testharness.js can't be used from module scripts.
Bug: 861564
Change-Id: I62fa415647da47e00bf7cbf4d7648f5d64377c04
Reviewed-on: https://chromium-review.googlesource.com/1128517
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573840}
--
wpt-commits: 1eefa00af8eb0137b4812d0947a38fb5b76cd04e
wpt-pr: 11846
--HG--
rename : testing/web-platform/tests/workers/baseurl/alpha/sharedworker.html => testing/web-platform/tests/workers/baseurl/alpha/sharedworker-in-worker.html
rename : testing/web-platform/tests/workers/baseurl/alpha/worker.html => testing/web-platform/tests/workers/baseurl/alpha/worker-in-worker.html
Automatic update from web-platform-testsMove [SecureContext] to NavigatorBluetooth
This change moves the [SecureContext] extended attribute from the
individual attributes on the Bluetooth interface to the entire partial
Navigator interface for Web Bluetooth.
This has the practical effect of making the entire navigator.bluetooth
attribute undefined in in-secure contexts rather than only
navigator.bluetooth.requestDevice.
Web Platform Tests are also updated to test access to this attribute
from both secure and in-secure contexts.
Bug: 860798
Change-Id: Ife32dcfe9d035613c41399d7189e087cdb9f54d6
Reviewed-on: https://chromium-review.googlesource.com/1128248
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573780}
--
wpt-commits: 0dcad092b51b7e71890565a7df114a1955a84b78
wpt-pr: 11839
--HG--
rename : testing/web-platform/tests/bluetooth/idl/idl-NavigatorBluetooth.html => testing/web-platform/tests/bluetooth/idl/idl-NavigatorBluetooth.https.html
rename : testing/web-platform/tests/bluetooth/idl/idlharness.tentative.window.js => testing/web-platform/tests/bluetooth/idl/idlharness.tentative.https.window.js
Automatic update from web-platform-tests[testharness.js] Report error for worker errors (#11400)
Ensure that uncaught exceptions in typical worker tests cause the
harness to report an ERROR status, and update the corresponding test
accordingly. Add a test to verify that the harness reports an OK status
in response to uncaught exceptions which originate from "single-page
test" workers.
--
wpt-commits: 98848dff9fe765e3719484392fa27458f5a21c54
wpt-pr: 11400
Automatic update from web-platform-testsVerify that invalid selectors throw for empty elements
--
wpt-commits: 553778eb487e687efc08ef81b77206c7b91dd930
wpt-pr: 11848
Automatic update from web-platform-testsDisallow font-relative units when resolving var() for font-size.
For a registered custom property --foo, the following is no longer
allowed:
--foo: 10em;
font-size: var(--foo);
The same applies to ex and ch, as well as rem on the root element.
This is because --foo depends on font-size via the 'em' unit, and
font-size depends on --foo via the var() reference. This creates a
circular dependency that must be resolved somehow. The agreed-upon way
to resolve that, has been by treating the whole var() reference as
invalid.
This patch implements that cycle detection by adding flags to disallow
resolution of any var() references that contain font-relative units.
These flags are set in ResolveVariableReferences based on the
CSSPropertyID/StyleResolverState.
When a custom property itself contains var() references, it needs to
"inherit" the font-unit-ness from the resolved variables (similar to
is_animation_tainted). This is why flags have also been added to Result.
Bug: 848698
Change-Id: Ife0570949d996c5fc26dc10b1d7ca15bd27343b1
Reviewed-on: https://chromium-review.googlesource.com/1120334
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573712}
--
wpt-commits: a8bd7948236886b2dbce7456beb0406e7d2207a1
wpt-pr: 11748
Automatic update from web-platform-testsReplace/remove ayg in suggested_reviewers in META.yml (#11852)
Responsibilities distributed as discussed in
https://github.com/web-platform-tests/wpt/issues/11521.
In html/, because there aren't obvious candidates for some of the
subdirectories, instead expand html/META.yml to include all present
editors of the HTML standard.
In the past year, most of the action has been in html/semantics/, and
the busiest of the directories within do all have more granular
reviewers, so hopefully this is an improvement.
Fixes https://github.com/web-platform-tests/wpt/issues/11521.
--
wpt-commits: d332f12c8af648643c54082194c120ba654100a2
wpt-pr: 11852
Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851)
These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19
and reflect the structure of the HTML spec as it was in 2012.
The structure largely remains the same, but some directories like
webappapis/user-prompts/dialogs-implemented-using-separate-documents/
are gone from the spec (https://github.com/whatwg/html/pull/374) and
others like introduction/ are non-normative and should never be
populated.
But mainly, a lot of empty directories is a nuisance when exploring
the directory in a file manager or on GitHub.
The number of directories in 2dcontext/ and html/ combined decreases
by almost 200, from 653 to 456.
--
wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c
wpt-pr: 11851
Automatic update from web-platform-testsMerge pull request #11880 from graouts/overlapping-keyframes
Don't assume opacity computed values are exactly the same as specified on keyframe input
--
wpt-commits: afc3a452f2020dc10c51f467a435ba5b32dc0589
wpt-pr: 11880
Automatic update from web-platform-testsUpdate the generic-sensor IDL test (#11824)
--
wpt-commits: 66218ca7d67e968f2e1384d6bba97e4c47a08061
wpt-pr: 11824
Automatic update from web-platform-tests[web-animation] Make contain/will-change/writing modes props not animatable
Match the recent CSSWG resolutions:
https://github.com/w3c/csswg-drafts/issues/2737#issuecomment-402574750https://github.com/w3c/csswg-drafts/issues/2751#issuecomment-402604609
Make following properties none animatable:
* contain
* direction
* display
* text-orientation
* unicode-bidi
* will-change
* writing-mode
Note that wpt tests have already been updated for direction and writing-mode
here [1]
[1] 41f4ab65b2
Bug: 860359
Change-Id: I3e7296e3c28ff494eddbc6f011621dd29ba7d2aa
Reviewed-on: https://chromium-review.googlesource.com/1127062
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573509}
--
wpt-commits: 7f017e863fec0f00ab1eb531b1bc12864d850d06
wpt-pr: 11813
Automatic update from web-platform-testsUse AtomicString for PerformanceEntry::entryType()
This CL makes PerformanceEntry::entryType() a pure virtual method
instead of storing |entry_type_|. It also changes the usage from String
to AtomicString. Only PerformanceEventTiming keeps |entry_type_| since
it can be 'event' or 'firstInput'.
Since the entry type is no longer available from the PerformanceEntry
constructor, we change EntryTypeEnum() to pure virtual too.
Bug: 852050
Change-Id: Ie02040b52cf17c7563667ef440bbb78ae97e64c7
Reviewed-on: https://chromium-review.googlesource.com/1113671
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573442}
--
wpt-commits: d59ad168b7820ace3bfc7c80707f9d1b08a6f313
wpt-pr: 11773
Automatic update from web-platform-tests[testing] Remove per platform expectations for wpt animation-types tests
The only difference that required per platform expectation files was
the fact that 'hyphens: auto' is only supported in Chromium on Mac.
These tests don't care about the actual css property value but how one
value is animated to another in web animation interpolation model. So instead of
using 'auto' for hyphens, we use 'none' which is supported on all platforms.
This help remove three 500+ lines per platform expectation files and reduce
unnecessary maintenance burden.
Change-Id: I5f3b716ce11a72a5235e7899d2e90f4bbea77ebc
Bug: 860359
Reviewed-on: https://chromium-review.googlesource.com/1129201
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573328}
--
wpt-commits: 028ff8d15432d595df85c2becf66cce686659de7
wpt-pr: 11860
Automatic update from web-platform-tests[css-properties-values-api] Support comma-separated lists.
This adds support for syntax strings like "<length>#".
R=chrishtr@chromium.org
Bug: 859509
Change-Id: Ifd1ec986e5e11e8d00dfa5956f174616be857512
Reviewed-on: https://chromium-review.googlesource.com/1122625
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573293}
--
wpt-commits: 4497a88542cd6e6e0dfd14742ebc0225bbae6fb3
wpt-pr: 11756
Automatic update from web-platform-testsReplace/remove kristijanburnik in some META.yml files (#11853)
No longer active on GitHub.
--
wpt-commits: 97690698b35d56e57449c407b6b5f45a6c3487f3
wpt-pr: 11853
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: https://github.com/w3c/webappsec-csp/pull/313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
Automatic update from web-platform-testsAdd referrer policy support to script fetching
This adds referrer policy attribute to top-level script
elements and ensures that the referrer policy for a script
specified by its attribute gets inherited by imported script
subresources.
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jfd4knvCiioR=hiroshige@chromium.org, kouhei@chromium.org, mkwst@chromium.org, yhirano@chromium.org
Bug: 841673
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I49650d593ba433a53793c846afc18be83dc9fc87
--
wpt-commits: 172489943de49dde6b3aa9d5d5ce5e6cc3cbd6e9
wpt-pr: 11085
Automatic update from web-platform-testssensors: Stop passing undefined as an invalid SensorOptions value (#11823)
While the undefined -> double conversion in WebIDL should indeed throw a
TypeError, we cannot forget we have a WebIDL dictionary (SensorOptions) in
the middle:
{frequency: undefined}
is essentially equivalent to
{}
so we do not actually throw a TypeError in this case at all.
--
wpt-commits: 4713ec6523e637619ec607e7882fd1e7ba54cde9
wpt-pr: 11823
Automatic update from web-platform-testsMerge pull request #10746 from bocoup/webrtc-media
[webrtc] Use procedurally-generated media streams
--
wpt-commits: eee513ca541588299fafa71a9337eceae6b680cf
wpt-pr: 10746
Bump the version number to 3.8, incorporating the LSAN changes. This
minor version bump assumes that mozlog consumers are supposed to
handle unknown actions gracefully (i.e. by ignoring them) and
therefore adding actions doesn't count as a compat-breaking change.
MozReview-Commit-ID: ECsDTuUgkfQ
Summary:
This fixes a couple fuzz bugs and prevents special-casing <svg:use> even more in
bug 1431255.
Unfortunately not as many hacks went away as I'd have hoped, since we still need
to match document rules, see the linked SVGWG issues.
But blocks_ancestor_combinators goes away, which is nice since it's on a very
hot path.
Test Plan: WPT for style invalidation, covered by existing tests otherwise.
Reviewers: heycam
Tags: #secure-revision
Bug #: 1450250
Differential Revision: https://phabricator.services.mozilla.com/D2154
MozReview-Commit-ID: C4mthjoSNFh
We're going to enable block autoplay of HTMLMediaElements by default in Nightly,
but lots of our tests assume they are allowed to playback media without requiring
user interaction. After we've enabled block autoplay that assumption won't be valid.
So configure the prefs that control block autoplay so that we allow media to
autoplay.
This means the existing tests we have don't need to be rewritten to work when
we enable block autoplay by default.
MozReview-Commit-ID: 50yydubQjkS
--HG--
extra : rebase_source : a19e6c5b60d3b89e754be786281ca3242baa3830
Refactor the tests to make them work with pytest directly rather than
also depending on unittest. Fix the helper functions to work with the
current state of metadata.py. Add some tests for update of assertion
count and lsan data.
MozReview-Commit-ID: 1XcMqSbqr43
Previously we were holding a map of test id -> test and test ->
expectation data. But this is an unnecessary layer of indirection, and
it works perfectly well to map test id to the expectation data
directly. This makes the code simpler and may also help make the
update a little faster.
MozReview-Commit-ID: 5PymX6Lxkgu
In this case we want to take the existing value into account, and update
to 1 more than the new value (in the max-asserts case).
MozReview-Commit-ID: 1RtJ2gU1ZbH
The `stop` method is always called to shutdown firefox, but the
cleanup method is only called at the end of a test run. Therefore we
need all the leak processing stuff ot happen in stop().
MozReview-Commit-ID: 5OE54cEygNy
LSAN data differs from existing expectation data because the data is
only generated when the browser exits, so the problems reported can
happen at any point in the current session. We use the `scope`
property in the log message to determine the path to a __dir__.ini
file that covers all the tests run in the session, and add the LSAN
exclusion rules to there.
The rules themselves are generated by taking the topmost frame of any
stack that's reported as unexpectedly leaking, and adding that to the
list of permitted frames in the lsan-allowed property. We never remove
entries from this list since intermittents may be present which won't
appear on a specific run. Instead we rely on humans fixing the issues
to also clean up the expectation files.
MozReview-Commit-ID: Kxm0hFXlGE3
This initially contains a scope entry which is set to the base directory of
the tests being run. Typically this is /, but with run_by_dir, it's the
path to the current run_by_dir group e.g. /html/semantics/form_elements/
MozReview-Commit-ID: JEFJByKTUsH
This adds a property lsan-allowed to the expectation manifest files
that takes a list of strings. Any entry in the list that matches a
frame in an LSAN stack will cause that stack to be regarded as an
expected failure.
MozReview-Commit-ID: 2oUw0joThha
This is a copy for now rather than a move because followup patches are
going to convert the LSAN support to use mozlog and I don't want to
risk breaking mochitest by accident.
MozReview-Commit-ID: I6NVgjDjsX2
Bug 1447977 introduced a new implementation of evaluate.isCyclic
that was not based on JSON.stringify to overcome cyclic references
stored on Element prototypes.
This patch reverts the new behaviour and hides it behind an environment
variable MOZ_MARIONETTE_NEW_CYCLIC. This is useful so we can more
easily test the difference in automation.
MozReview-Commit-ID: 2xtNL596Imc
This is probably the last thing we will ship since it needs the most spec work.
MozReview-Commit-ID: LLmDBLCsCBJ
--HG--
extra : rebase_source : c06752c9201a9ede87e1ac200ab12577bf784ce6
This feature should not be shipped until the various definitions of addition for
each additive property are properly specified.
Unlike other patches in this series, compositing is not frequently used
internally (e.g. by DevTools etc.) so there is no need to enable this by default
for system code.
Also, it turns out we have inadvertently been shipping part of this feature for
some time now. The next patch in this series will add tests for that case and
disable that part of the feature (a suitable intent to unship will follow). This
patch merely adapts and extends the existing tests without affecting the surface
area covered by the combination of the newly-added pref and the existing
dom.animations-api.core.enabled pref.
MozReview-Commit-ID: Htr6mlyCBav
--HG--
rename : dom/animation/test/mozilla/file_disable_animations_api_core.html => dom/animation/test/mozilla/file_disable_animations_api_compositing.html
rename : dom/animation/test/mozilla/test_disable_animations_api_core.html => dom/animation/test/mozilla/test_disable_animations_api_compositing.html
extra : rebase_source : 7715a25e59568eb122ba3f7dbd2c2b2ffdd19954
This preference controls whether authors are allowed to specify animations
without a 0% or 100% keyframe.
We intend to ship this soon but this preference acts as a safeguard in case we
discover we need to disable it.
This feature is very convenient and commonly used so this patch ensures it is
always enabled for system content.
MozReview-Commit-ID: BHTsuS2xO61
--HG--
rename : dom/animation/test/mozilla/file_disable_animations_api_core.html => dom/animation/test/mozilla/file_disable_animations_api_implicit_keyframes.html
rename : dom/animation/test/mozilla/test_disable_animations_api_core.html => dom/animation/test/mozilla/test_disable_animations_api_implicit_keyframes.html
extra : rebase_source : 04fd93dd26a4765c14b0b22febdb0311b650ea59
We don't intend to ship this in the near future until the integration with
AnimationWorklet is clear (although we might ship a read-only version).
That said, we use this feature extensively internally (e.g. in DevTools etc.) so
we enable this feature for system callers.
MozReview-Commit-ID: AhB7ZmU1Xzw
--HG--
extra : rebase_source : 630d7dc56b44a9261bb34aa5417cb9b7050efba4
The test aims to check playback events and CSS events
MozReview-Commit-ID: Bo5OhC6AdGC
--HG--
extra : rebase_source : 7635890b84099bce14a7e2beac1fec56439d42c6
Both for mochitest (simply an expectation adjustment), and in mochitest (align
with the code).
MozReview-Commit-ID: 2UIq4zrcd02
--HG--
extra : rebase_source : 1858e73b3ad89aade3219ee8556c653c55c85bed
This is the result of an execution of:
> find testing/web-platform/tests/webaudio/the-audio-api -exec sed -i "s/'TypeError'/TypeError/" {} \;
MozReview-Commit-ID: 8T0RoOobxJW
--HG--
extra : rebase_source : df093a9c433c0bab78bae0dad8570ec696aa183e
extra : intermediate-source : 1f89fc574e6ccffbdf96ae74e1151c2a8442c7c3
extra : source : 30c0660089d57c5c63a1dff88a340e1e4d5779a3
We don't support setting the rate of an AudioParam yet, so we fail this.
MozReview-Commit-ID: 4bbnHannHvG
--HG--
extra : rebase_source : 771436213d96b352634e5af02fe62eb73cb44547
This patch adds new functions taking the arena parameter rather than overloading
existing functions, because there are already overloads of calloc that take
two size_t parameters (which arena_id_t is an alias for), so it couldn't have
been done that way, and malloc and realloc needed to be consistent with calloc.
MozReview-Commit-ID: 1MUXoCUgJWO
--HG--
extra : rebase_source : 16261ba4e802efa0bc65878d490ae9b62aa35797
Automatic update from web-platform-testsSplit up WebCryptoAPI/derive_bits_keys/ with `variant`
Also use .any.js.
Fixes#11203.
--
wpt-commits: 864cba25d0ac3d2f49e851623370f565ca293cbe
wpt-pr: 11204
Automatic update from web-platform-testsCorrectly pick the block-end margin when calculating overflow.
We need to use the writing mode of the containing block to do this, not that of
the child, which is completely irrelevant.
Change-Id: Ia5907d9ce60d00ad453f48fb72193e2eab1aaa3e
Reviewed-on: https://chromium-review.googlesource.com/1127047
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572931}
--
wpt-commits: efea7337078c4b4e18ed9c1703870ec4e0da57eb
wpt-pr: 11817
Automatic update from web-platform-tests[sensors] Check that sensor frame and focused frame of same origin (#11803)
#11426 introduced new tests for mitigation stragegy defined in [1]
for partial concrete sensors. This PR add the same tests for remain
concrete sensors: Ambient Light Sensor, Geolocation Sensor, and Proximity.
[1] https://www.w3.org/TR/generic-sensor/#focused-area
--
wpt-commits: c9c1a7d1b2306fada9bc3b469bf39ca31b4508cc
wpt-pr: 11803
Automatic update from web-platform-testsMake preload play nice with CSP strict-dynamic
Dynamically loaded preloaded scripts were not loaded when a strict-dynamic
CSP directive was used. This was because the state regarding whether the
element was parser created or not was not properly propoagated to the CSP
checks. This CL fixes that and adds tests that make sure that such scripts
can be preloaded (and that markup based preloaded scripts with no nonce cannot).
Bug: 752922
Change-Id: Ib4f3bce8583ccc9770c261d76167243033e5a112
Reviewed-on: https://chromium-review.googlesource.com/1125064
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#572908}
--
wpt-commits: e6ac489577c1ac1e0dadd9bef80e63af2a2eb42a
wpt-pr: 11777
Automatic update from web-platform-testsMerge pull request #11583 from ewilligers/z-index-test
SVG: Test that z-index controls rendering order
--
wpt-commits: 2b9ac244538d91c069ae6aa9273c4298b749bf99
wpt-pr: 11583
Automatic update from web-platform-testsChange parsing order for scroll-snap-align to block/inline.
As in the newest spec[1], the parsing order for scroll-snap-align is
changed to block/inline.
[1] https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align
Bug: 854379
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I70d2e9d526ffa0564e260faacdb5f79857a69324
Reviewed-on: https://chromium-review.googlesource.com/1115701
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572869}
--
wpt-commits: 0ffa5aaa7809a1957bdf260aaf55c16403fbf3fe
wpt-pr: 11691
MozReview-Commit-ID: 4HG0lm1atpj
Automatic update from web-platform-testsAdd an API to query whether the window has seen a user gesture.
Add a variable on the navigator object to query whether the frame has
seen a user activation ever.
The postMessage part of the proposal will be done in a separate patch,
this change is limited to just adding the object definition and
exposing it on navigator.
https://github.com/dtapuska/useractivationhttps://github.com/whatwg/html/issues/1983
BUG=846858
Change-Id: I6ca4c80f4096bfae9ca13b175b46df6b4486a6dd
Reviewed-on: https://chromium-review.googlesource.com/1076979
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572847}
--
wpt-commits: dfca5197519caef6c189636b5d80b33e3424e91e
wpt-pr: 11361
Automatic update from web-platform-testswebdriver: correct expected exception type for delete session test (#11809)
The SessionNotCreatedException should be thrown if an attempt to create a
session fails. If a user tries to access a session that existed, but has
already been deleted, the correct exception is InvalidSessionIdException.
--
wpt-commits: dfe2b1ce939ce7b80a64d079655cfa14451e9960
wpt-pr: 11809
Automatic update from web-platform-tests[LayoutNG] Support anonymous table cells natively.
Use LayoutObjectFactory when creating anonymous table cells, just
like we already do for non-anonymous cells.
We used to create legacy LayoutTableCell objects for anonymous cells,
but allowed children to be NG. This was bad, since we should only
switch engines at formatting context boundaries.
One NG change was necessary here: Only anonymous *blocks* should
inherit % resolution size. Anonymous table cells should NOT. This
prevents fast/table/percent-height-inside-anonymous-cell.html from
regressing.
This made one existing test pass. Also added a new one.
Two tests not related to tables regressed. Separate bugs reported.
Some rebaselining was also necessary, since NG handles text runs and
whitespace slightly differently.
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: Ibbb77073f1fbe1841ebf102c8bce440046f73319
Reviewed-on: https://chromium-review.googlesource.com/1122218
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572753}
--
wpt-commits: 6562ed003eebcd25d093ae52d68de28a0ae0d786
wpt-pr: 11755
MozReview-Commit-ID: 6XbTBEjeesL
Automatic update from web-platform-tests[css-properties-values-api] Require PropertyDescriptor.inherits.
As of a recent spec change, the 'inherits' field must now be set.
See https://drafts.css-houdini.org/css-properties-values-api-1/#registering-custom-properties.
This patch changes all calls to CSS.registerProperty (that are missing
'inherits') such that 'inherits' is explicitly set to 'false', which was
the old default.
In wpt/css/css-properties-values-api/register-property.html, I have added
a new test to very that we throw an exception if it's omitted.
Note that CSS.registerProperty API is an unshipped feature behind the
CSSVariables2 flag.
R=mstensho@chromium.org
Bug: 860289
Change-Id: I14aa02d40c69e0ff6d1160160a8f772cb5159092
Reviewed-on: https://chromium-review.googlesource.com/1126303
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572731}
--
wpt-commits: ac8b4953a09fa7e7d7490cea8af26ab88d061dcb
wpt-pr: 11792
Automatic update from web-platform-testsMerge pull request #10296 from dstorey/types-svg-to-dom-changes
Test removed interfaces and SVG* -> DOM* in Types chapter
--
wpt-commits: fc77ed0960d401343b4327a3dbb105276024bfb9
wpt-pr: 10296
Automatic update from web-platform-testsWPT tests for http-equiv Accept-CH-Lifetime
WPT tests are added for:
(i) When ACL http-equiv header is sent by a same-origin iframe.
(ii) When ACL http-equiv header is sent by a cross-origin iframe.
(iii) When ACL http-equiv header is sent by a subresource.
(iv) When ACL http-equiv header is sent on the main frame.
Change-Id: Ie4adce0c1b5983a66ce3dce7bb6b77e30f63c03a
Bug: 852484
Reviewed-on: https://chromium-review.googlesource.com/1125212
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572706}
--
wpt-commits: f2fdea2d681d3618c7215e9333535c9585ec7171
wpt-pr: 11778
Automatic update from web-platform-testsUnflake wpt/fetch/security/redirect-to-url-with-credentials.https.html
The test is flaky because of step_timeout. This CL removes that, and
marks the test as consistent TIMEOUT.
Bug: 846497, 626703
Change-Id: Iaa8b0e275d1d4fc9db6cb77db5399d06744fd60a
Reviewed-on: https://chromium-review.googlesource.com/1125548
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572688}
--
wpt-commits: 250d8640a9c8e43a13cc02595b72097bed69695d
wpt-pr: 11782
Automatic update from web-platform-testsTest that will-change:will-change has no effect. (#11798)
* Test that will-change:will-change has no effect.
* Add test owners.
--
wpt-commits: adaa7b65ac4a455b26720a7691278f9f992b4f03
wpt-pr: 11798
Automatic update from web-platform-testsMove wptrunner marionette usage onto a single thread
Running marionette on a background thread is problematic in the case
that a test times out. In this case the background thread is not
terminated. If we then call into marionette again on the main thread
we may race with something that happens on the runner thread. The
marionette client isn't threadsafe, so this leads to buggy behaviour.
The simplest fx for the problem is just to move all the marionette
calls onto the main thread and instead of waiting on the main thread,
spin up a thread with a timer.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: 9b8539a9a2a6c20220cdcb07e19b7bf3a91c7436
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato
--
Make base_executor_kwargs arguments match executor_kwargs
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b99661f1fcc56bca0176bd813c166525a4ebf2e4
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato
--
Add support for recording asserts in wptrunner
Gecko has an API for producing a non-fatal "assert". For quality
control, it should be possible to annotate the range of possible
numbers of these asserts produced during a test execution, and fail if
the actual number of asserts falls outside this range.
This patch adds assert checking by default in debug builds. It adds
two metadata properties; max-asserts and min-asserts for specifying
the range of possible asserts produced in a test.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: bc43ae3ccc9f203268a2b495b99515c617306c88
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato, maja_zf
--
Reverse the order of metadata iteration
wptrunner previously iterated over properties from least significant
to most significant. However this was broken since it caused
per-directory properties to override per-test properties, which wasn't
expected. Therefore we reverse the order of iteration from most
significant to least.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: cc1d47bf0aa7efe3e770316c9ea5d895beafcaba
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Support updating asserts with wpt-update
With support for asserts, it's also necessary to be able to update the
expected number of asserts automatically using
wpt-update. Unfortunately asserts don't work quite like test statuses,
so this involves a reasonable amount of refactoring.
For asserts the desired behaviour is that the max asserts is either
one plus the highest recorded number of asserts, or the current
value, whichever is higher, and for the minimm asserts, it's the
minumum of the current value and one lower than the lowest recorded
value (clamped at zero). Instead of creating per-platform
expectations, the code only updates the defaults (or any existing
conditional that happens to match). It's not clear that we have enough
information to meaningfully make per-platform expectations, and we
want to reduce the risk of intermittents.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: cc9b28394533a30a6ae33def5ce1117882653134
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Use ujson where possible for faster metadata update
Profiling shows that switching to this library means we no longer
spend most of the update time parsing json (vs 80% or so before),
making other optimisations worthwhile. This is never used in
automation (except wptsync) so availability of the library in the
internal pypi isn't a problem.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: 605324b9d70e822a9d25e1c6ff7ca2bcbff6085c
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Output asserts to wptreport.json
In the future we want to update metadata using the wptreport.json data, since
that's much much smaller and easier to parse. In addition, this is
required to determine if a test fully passed, so it makes sense to
store it here.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b7716dedbf5a24e0e9a940a907225f7b3dd7d35c
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Add a test for wpttest metadata
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b021a8615326a99919fe62b493874ac9d49441da
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Fix flake8 failures
--
wpt-commits: 7204b317f506490e35f7ae380cab1a68d5f8fdbc, d675750a83e50878810091f7d96bbd5b57b2571a, e462113b6009d39305889e5b9966c2b7b671638e, 29fc7128d5d8f1760799a9840b3d930dd60b1016, 67010d9392b66ffa97a86e7ba2a9c18baa6bdf48, af25577da115208dc870a3c76c04bad8df532e59, 642bfb6e32ad2d20a22f1597d05e7243ac042be2, ac0f20081c03047ceed14dbe4b656c590304e175, cf4bcf12ed566497addb109183c23082a3a33371
wpt-pr: 11167
Automatic update from web-platform-tests[css-logical] Implement flow-relative margin, padding and border shorthand properties
They are implemented behind the CSSLogical runtime flag.
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ
Spec: https://drafts.csswg.org/css-logical/#box
BUG=850004
TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html
TEST=external/wpt/css/css-logical/logical-box-border-color.html
TEST=external/wpt/css/css-logical/logical-box-border-style.html
TEST=external/wpt/css/css-logical/logical-box-border-width.html
TEST=external/wpt/css/css-logical/logical-box-margin.html
TEST=external/wpt/css/css-logical/logical-box-padding.html
The tests still have some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).
Change-Id: Ibe3d7f39e1ce17de465aa635388b3f8510ed82a3
Reviewed-on: https://chromium-review.googlesource.com/1122872
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572576}
--
wpt-commits: 8dba144063a41d57c8272329bbe5c8810f34adca
wpt-pr: 11759
Automatic update from web-platform-testsAdd a test for the bounds-checking in createImageBitmap.
--
wpt-commits: 3634f42a67eeb156aceb8d4e337b62f01908cdf8
wpt-pr: 11786
Automatic update from web-platform-testsDon't crash when aborting a fetch in a destroyed context
Once the context in which a fetch is executing has been destroyed the fetch
cannot be aborted. blink::BodyStreamBuffer was attempting to abort the fetch
anyway, leading to a crash. Check that the context hasn't been destroyed before
attempting the abort.
BUG=860063
Change-Id: I593dcbfe2f2dacd7be9df456399cd0328da7af39
Reviewed-on: https://chromium-review.googlesource.com/1125543
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572493}
--
wpt-commits: bfba9da11d4c53a7d33785dfe5b2a5e96171bc7f
wpt-pr: 11780
Automatic update from web-platform-tests[LayoutNG] Fix hit test clipping by fragmented border with round corner
Current NG hit test code decides whether a hit test location is clipped
by rounded border by adding border radius to all four corners and then
compare with the hit test location. This is wrong if the box is
fragmented, where it may have only two or zero rounded corners.
This patch changes HitTestClippedOutByBorder() to take the above into
consideration. By utilizing |border_edges_|, it can generate the
corrected rounded border to be hit tested.
Test: This patch slightly modifies WPT
hit-test-inline-fragmentation-with-border-radius.html as a workaround
of some rounding issue, which is out of the scope of this patch.
Bug: 855279, 859233
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng;luci.chromium.try :linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43
Reviewed-on: https://chromium-review.googlesource.com/1123265
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572079}
--
wpt-commits: cffbd07683d6a0aa3fc032181dee1f4ac21d3bff
wpt-pr: 11760
MozReview-Commit-ID: nouPFy4brV
Automatic update from web-platform-testsAsync Cookies: Expose oncookiechange on ServiceWorkerGlobalScope.
cookiechange events have been dispatched to ServiceWorkerGlobalScope
since https://crrev.com/c/979334 landed, and can be observed using
addEventListener, as shown by the WPT test at
cookie-store/serviceworker_cookieStore_subscriptions_basic.tentative.https.html
This CL adds the oncookiechange attribute to ServiceWorkerGlobalScope,
allowing the event to be handled by a DOM0-style event handler.
Bug: 729800
Change-Id: Ic27979d94934abf833c116787cdad5243422324b
Reviewed-on: https://chromium-review.googlesource.com/1123766
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572400}
--
wpt-commits: bf35451761ed3c9063f928bc8c4c340ee66634f3
wpt-pr: 11761
Automatic update from web-platform-testsRewrite BlobBytesConsumer to not rely on blob URLs.
The existing implementation depended on the non-mojo blob URL code path,
and so would break soon after mojo blob URLs ship when the old code gets
deleted. So rewrite the implementation to read blobs more directly rather
than going through a blob URL.
Bug: 859109
Change-Id: Ia6f2432e48ac5304ea8f5598d293e31c2c1e1905
Reviewed-on: https://chromium-review.googlesource.com/1120679
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572363}
--
wpt-commits: 8f6ed28158100d414ddac343e6a6f44a74a37e3a
wpt-pr: 11738
Automatic update from web-platform-testsAdd more WPT tests for client hints
The WPT tests check the Accept-CH-Lifetime (ACL) header functionality.
Add tests for:
(i) When ACL header is sent by a same-origin iframe.
(ii) When ACL header is sent by a cross-origin iframe.
(iii) When ACL header is sent by a subresource.
(iv) When ACL header is sent on the main frame.
Also, change the ACL persistence time-duration from 20
seconds to 5 seconds to make it easier to run multiple tests
quickly and without waiting too long.
Change-Id: I31047598bbb1e7c64cadf3e6845bf850c29aca8b
Bug: 856700
Reviewed-on: https://chromium-review.googlesource.com/1119848
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#572273}
--
wpt-commits: 59d4a411a8ead528f17b124b03c07387a3d43d07
wpt-pr: 11735
Automatic update from web-platform-testsDeflake cache-storage/script-tests/cache-storage-match.js WPT
The test assumed no cache named 'foo' existed, but another test
cache-keys-attributes-for-service-worker creates a cache by that name,
so the test would flakily fail in some runs depending on the ordering
of the tests.
Make the test defensive by deleting such a cache before proceeding.
Bug: 840850
Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d
Reviewed-on: https://chromium-review.googlesource.com/1119104
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572232}
--
wpt-commits: 5c8e16d4499991fd344359e44cf6ee85b25bb413
wpt-pr: 11721
Automatic update from web-platform-testsClean up the css-font-loading IDL test (#9771)
--
wpt-commits: 5c05fc07d58b1352de26f62434103c8ec3941749
wpt-pr: 9771
Automatic update from web-platform-testsAdd a new test case for Element#innerText in Web Platform Test
This patch introduces a new test case for Element#innerText to verify that
result has a collapsed whitespace due by soft line break.
In the test case, the layout object associated to space character between
<span> elements, doesn't have neither InlineTextBox and NGPhysicalTextFragment.
Thus, Element#innerText implementation should detect this and handle it.
Bug: 651764
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: Ia25d06a2a3fe993f2e966188b81f9e9c1d0fe982
Reviewed-on: https://chromium-review.googlesource.com/1124264
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572164}
--
wpt-commits: 5d0c4eb770570e966e9b878b787c7de217462567
wpt-pr: 11763
MozReview-Commit-ID: KMSrvRpCH7R
Automatic update from web-platform-testsBackground-size should not accept negative values.
Follow the spec[1], negative values are not allowed.
We should reject the negative values of background-size during parsing.
[1]: https://drafts.csswg.org/css-backgrounds/#background-size
Bug: 825549
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ib260bafa421249aed471ff801c8b49a4b97aba1e
Reviewed-on: https://chromium-review.googlesource.com/989529
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572149}
--
wpt-commits: a04dd9954d333e4f11d093eec4620a2aac95298b
wpt-pr: 10366
Automatic update from web-platform-testsWPT tests for http-equiv accept-ch header
This CL adds WPT tests for http-equiv accept-ch header:
(1) The header is not honored on HTTP pages
(2) Malformed header is not honored
(3) When the header is present, client hints are attached only
on the same-origin subresources, and not on cross-origin
subresources in the same navigation.
(4) When the header is present, client hints are attached only
on the same origin subresources, and not on subresources in
a new navigation.
Bug: 856700
Change-Id: I3f82df8cd02816b06542256062eb291577ebe8b7
Reviewed-on: https://chromium-review.googlesource.com/1120953
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#571986}
--
wpt-commits: 2937bc40761173d438d67b6ebf2b0abcfbb911a4
wpt-pr: 11736
--HG--
rename : testing/web-platform/tests/client-hints/accept_ch.sub.https.html.headers => testing/web-platform/tests/client-hints/accept_ch.tentative.sub.https.html.headers
Automatic update from web-platform-testsDon't use six.string_types in wptserve.
In python 2, it's defined as basestring, so it matches both str and unicode,
but in python 3, it matches only str (and not bytes). This does not seem like
a useful approach as we add python 3 support, and the now-passing tests
support that view.
--
wpt-commits: f1587a318576ff766b8237e3428ff5377eedfb8e
wpt-pr: 11754
Automatic update from web-platform-testsMerge pull request #11636 from ewilligers/css-color-parsing
[css-color] Parsing color and opacity
--
wpt-commits: 8bb14e8b2bd36d97b216ef72ec46eaae44695707
wpt-pr: 11636
Automatic update from web-platform-testsUpdate requests from 2.18.4 to 2.19.1
--
Update requests from 2.18.4 to 2.19.1
--
wpt-commits: 1b5a507e1d141b6c8cdf14897ff206e85fff0753, c88d124cd2bcd2760735fac91a3e2eef4693ad05
wpt-pr: 11508
Automatic update from web-platform-tests[fullscreen] Do not return value from cleanup fns
Today, the return value of functions provided to the global
`add_cleanup` function has no effect on the behavior of the test runner.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1].
Despite this, some existing tests have already been authored to return a
value: the result of `document.exitFullScreen`. Although this is
expected to be a Promise in conforming implementations, some browsers do
not yet implement this functionality.
To allow the new test harness feature to land without introducing
harness errors, refactor existing tests to omit a return value.
Additionally, use `Promise.prototype.catch` to avoid race conditions
resulting from unhandled Promise rejections (which trigger a harness
error in testharness.js today).
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 31a51c70f74e23dc52f2033e552990a03f3166a9
wpt-pr: 11733
Automatic update from web-platform-tests[html] Do not return value from cleanup fns
Today, the return value of functions provided to the `Test#add_cleanup`
function has no effect on the behavior of the test runner. Despite this,
some existing tests have already been authored to return a value: the
result of `Element#removeChild`.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1]. To allow the new test harness
feature to land without introducing harness errors, refactor existing
tests to omit a return value.
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 21369c1a88085d4804d520887978392d19c8c656
wpt-pr: 11740
Automatic update from web-platform-tests[fetch] Do not return value from cleanup fns
Today, the return value of functions provided to the `Test#add_cleanup`
function has no effect on the behavior of the test runner. Despite this,
some existing tests have already been authored to return the `null`
value.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1]. To allow the new test harness
feature to land without introducing harness errors, refactor existing
tests to omit a return value.
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 86455a624bb05eb7503ccbe340dca973f5dea4c8
wpt-pr: 11741
Automatic update from web-platform-testsAsync Cookies: Update Cookie Store API to match spec.
This CL changes the signatures of cookieStore.{get,getAll,set,delete}
and introduces the CookieStoreDeleteOptions and
CookieStoreSetExtraOptions dictionary. The CL also updates the
CookieListItem dictionary.
TBR=haraken
Bug: 729800
Change-Id: Iaa62b5a51cc79b19cb567be30a2f0dda54e326d8
Reviewed-on: https://chromium-review.googlesource.com/1117868
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571736}
--
wpt-commits: 0e96b1f8627cf798ebea0c2a0cdf6b5d8cb8825e
wpt-pr: 11724
Automatic update from web-platform-tests[Squad] Generate ::before/::after/::backdrop in style recalc.
We used to create these pseudo elements and their computed styles in
Element::AttachLayoutTree when building the layout tree. Now we create
or dispose these elements from style recalc, that is,
UpdatePseudoElement. To make pseudo elements live through a style recalc
with a layout tree re-attach we no longer clear the pseudo elements
during DetachLayoutTree for performing_reattach=true. We do however need
to clear the pseudo elements which do not get a layout object for the
re-attach. That is done in AttachLayoutTree for the originating element
when the originating element does not generate a layout box.
We stop using the pseudo style cache on ComputedStyle for PseudoElements
and instead return the ComputedStyle when creating the pseudo element
and store it as non-attached style which can later be retrieved when
attaching the layout object.
An effect of this change is that we can detect transitions on pseudo
elements when ancestors display types changes and causes re-attachment.
That is issue 836140.
::first-letter may still be generated during layout tree building, and
the ::first-letter layout structure may still be updated during style
recalc.
Bug: 836126, 836140
Change-Id: Iafad705b7a7b988d4c1598e8a126ce0d79c5873d
Reviewed-on: https://chromium-review.googlesource.com/1112244
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571665}
--
wpt-commits: ec35b03ca5e8eec6eb1767a77f0aea13855515a3
wpt-pr: 11634
Automatic update from web-platform-tests[LayoutNG] Allow epsilon when fitting into a line
When NGLineBreaker tries to fit items into a line, rounding
errors are hard to avoid. One case is to fit `monospace` font
into a container whose `width` is set by `ch` unit.
Blink computes `ch` units in float, then round to LayoutUnit.
This rounding often prevents the specified number of
characters to fit into the line. All 4 impls pass this test
for `3ch` to `100ch`.
Bug: 636993
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee
Reviewed-on: https://chromium-review.googlesource.com/1116409
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571642}
--
wpt-commits: c360ca023dc5c341065de0f2814914b3c6004e4f
wpt-pr: 11688
MozReview-Commit-ID: IgzIRG31IMn
Automatic update from web-platform-tests[testdriver.js] Implement `bless` method (#11511)
A common use case for the testdriver.js library is to create a task that
was triggered by user interaction [1]. Doing so using the current API
requires a fair amount of logic which is unrelated to the behavior under
test. This has a number of drawbacks:
- it makes tests less descriptive
- it makes tests less uniform both in terms of implementation and in
terms of user experience (in non-automated scenarios, human operators
may be prompted to provide the necessary input)
- it makes tests more susceptible to bugs
Define a utility method as a consistent and concise way to facilitate
the common use case. Require descriptive text via the `intent` parameter
in order to encourage test authors to explicitly describe the rationale
for requesting additional privileges.
[1] https://html.spec.whatwg.org/#triggered-by-user-activation
--
wpt-commits: 8b8082f30267410e4b3729439be23df8b803dde8
wpt-pr: 11511
Automatic update from web-platform-testsMake sure stacking context is always updated for ::first-letter.
::first-letter sadly has at least three code paths for computing its
computed style. Two of them were lacking stacking context update. There
is work in progress for Squad to mend this, but let's fix the current
code paths for now.
Bug: 856806
Change-Id: Ifeea799643bfa266e58c948f476bc23481fcdd5e
Reviewed-on: https://chromium-review.googlesource.com/1120249
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571512}
--
wpt-commits: 02cfdfe53b794884bcd731e18f845bec59dfd707
wpt-pr: 11731
Automatic update from web-platform-testsMake sync-tests.sh work with git.
--
Allow specifying the mozilla tree via argument.
--
wpt-commits: 8b61c282650bf72bce0147df320425343ea27f2f, e639f5b4158852b16ffa28613730c2b0b63f5e83
wpt-pr: 11715
Andreas Tolfsen
James Graham
Sebastian Hengst
Rob Wood
Paul Adenot
Andreea Pavel
Ionut Goldan
Dipen Patel
Brad Werth
Hiroyuki Ikezoe
Dan Glastonbury
moz-wptsync-bot
Eric Willigers
Luke Bjerring
Henrik Skupin
Bogdan Tara
Narcis Beleuzu
Boris Zbarsky
Philipp Hancke
Adam Rice
Taiju Tsuiki
Sandra Sun
Dave Tapuska
Nicolas Pena
Nate Chapin
Ella Ge
Timothy Gu
Orsi Batiz
Stephen McGruer
fantasai
kaixinjxq
Morten Stenshorne
Leo Balter
jugglinmike
Katherine Mancuso
Philip Jägenstedt
Rakina Zata Amni
Joshua Bell
Raymond Toy
Anders Hartvoll Ruud
Brian Grinstead
shindli
Brian Birtles
Brindusan Cristian
Brian Hackett
Jan Varga
Jonathan Kingston
Gurzau Raul
Coroiu Cristina
Nicolas Chevobbe
Marco Castelluccio
Anny Gakhokidze
Cosmin Sabou
Ben Hearsum
Emilio Cobos Álvarez
Christoph Kerschbaumer
Christian Holler
Hiroshige Hayashizaki
Reilly Grant
Simon Pieters
Zirro
Marcos Cáceres
Josh Matthews
Luke Bjerring
Antoine Quint
Mark Nottingham
Majid Valipour
Andy Paicu
Dominic Farolino
Raphael Kubo da Costa
L. David Baron
Soares Chen
Tiberius Oros
Bob Clary
Chris Pearce
Xidorn Quan
Gijs Kruitbosch
Paolo Amadini
Ryan Hunt
Andrea Marchesini
Rob Wu
Geoff Brown
Brian Birtles
Kartikaya Gupta
Michael Kaply
Margareta Eliza Balazs
Raphael Pierzina
Matt Woodrow
Erica Wright
Ting-Yu Lin
Alexandre Poirot
Emma Malysz
Joel Maher
Kirk Steuber
Matt Howell
Mihai Tabara
Ms2ger
Wanming Lin
Yoav Weiss
Jonathon Kereliuk
jimevans
Alice Boxhall
Tarun Bansal
Yutaka Hirano
Cameron McCormack
Oriol Brufau
Ms2ger
Xiaocheng Hu
Victor Costan
Marijn Kruisselbrink
Yoshifumi Inoue
Zhuoyu Qian
pyup-bot
Kagami Sascha Rosylight
Florian Rivoal
Mrunal Kapade
Rune Lillesveen
Koji Ishii
Geoffrey Sneddon