We got rid of drawing lwthemes inside the titlebar on OSX in bug 1392219 but
there was still some code that adjusted the titlebar, which we forgot
remove. Incidentally, that code was also causing a bug (even before we
removed the in-titlebar drawing) which we now don't need to worry about
anymore now.
MozReview-Commit-ID: 44HR25Uyp8B
--HG--
extra : rebase_source : 12a9d427a021d00553be8949dd5f9fa7e37eef47
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
the binding is already gone.
* Generalize things into `hideAllViewsExcept(thisOne)`:
- Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
in there too,
- For Photon panels, do all the 'current' attribute setting in there. To show
a panel during transition, I introduced the 'in-transition' attribute.
* I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
that confuses some,
* Move the temporary panel handling, which contains an ephemeral panelmultiview
instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
* Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
* Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
specific transition, _if_ that's passed in as an argument. This resolves any
potential raciness that might occur when `showSubView()` is called again mid-transition.
* Skip the UITour element visibility check when it's inside a panelview, because
too many things need to happen and that check is too simple to be useful in
that case.
MozReview-Commit-ID: 5HpJKs1Ny5j
--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
This fixes the build in non-unified mode, as nsCOMArray::Sort() method uses
NS_QuickSort().
MozReview-Commit-ID: CDBLIX8D3mL
--HG--
extra : rebase_source : 67902cf10b9311adbd97fecf7906762bb86c52e4
The Windows and OSX code paths were essentially doing the same thing,
and the Unix fallback was using an old convention that is pretty much
outdated.
Under normal conditions (XPCOM initialized by Firefox),
NS_XPCOM_INIT_CURRENT_PROCESS_DIR is set from BinaryPath anyways, so
this only really affects adhoc XPCOM initialization from e.g. C++ unit
tests.
--HG--
extra : rebase_source : f7faa6f22ffc56fb4da7ae96eb571a35fa6f615d
The difference between GetXULRunnerStubPath and XRE_GetBinaryPath was
removed in bug 552864.
--HG--
extra : rebase_source : c70116fb663ad97fc24bc86046505b0fb3d5a200
Back in the day, there was no global with an already initialized
DirectoryService. But now there is, and, in fact,
GetCurrentProcessDirectory already errors out if that global is not set
by the time it's called. All calling nsDirectoryService::Create achieves
is doing the check again and calling QueryInterface, which we don't need
to do anyways.
--HG--
extra : rebase_source : 519980829be4ff4a0941c0e8d18be5761ece6552
AudioStream::DataCallback uses cubeb_get_backend_id to work around a bug in
libcubeb's winmm backend, but calling libcubeb APIs from within libcubeb
callbacks is not safe. Move the query to AudioStream::Init and check a simple
bool from within the callback instead.
nsFrame::SchedulePaint() invokes InvalidateRenderingObservers, and
InvalidateRenderingObservers ends up posting change hints during we are
processing sequential tasks for animations, but we don't allow posting any
change hints while we are in the middle of restyling process.
Though the change hints posted by InvalidateRenderingObservers are not harmful
in this case since the change hints will be processed in a second post
traversal without problems. That's said, InvalidateRenderingObservers stuff
should be processed in display list based invalidation anyway (bug 1284053).
MozReview-Commit-ID: GKVRZ98lvEN
We exclude these testcases from being tested under Gecko, because they fail some
mochitest checks for parse+serialize idempotence. The failures happen because of
a combination of these factors:
(a) Gecko's style system is inconsistent about whether an explicitly-specified
(but default) gradient direction should get serialized.
(b) Gecko's style system is inconsistent about whether the vendor prefix is
preserved, when parsing a prefixed gradient.
Since these prefixed gradients aren't super-important and since Gecko's style-system
is being replaced via stylo, we're not bothering to fix the gecko style-system for
this -- we'll just make these tests stylo-specific.
MozReview-Commit-ID: 8lL1aRnDO2H
--HG--
extra : rebase_source : 86d5eab7097ebf39238859debc5ff5539cb2429a
So different test timeouts from the same test case will fall under the same bug.
MozReview-Commit-ID: LDstAhOpkYK
--HG--
extra : rebase_source : 9f2b52f237f18f3fecdd076295da4d43e5b30219
Mark Goodwin
Johann Hofmann
Mike de Boer
Philippe Normand
Andrew Halberstadt
Gijs Kruitbosch
Mike Hommey
Sebastian Hengst
Jan Varga
Jeff Muizelaar
Matthew Gregan
Ethan Lin
Mark Banner
Hiroyuki Ikezoe
Andreas Pehrson
Dan Epstein
Nazım Can Altınova
JW Wang
Kaku Kuo
Munro Mengjue Chiang
Marco Bonardo
Sean Lee
steveck-chung