The most common issue I'm hearing with eslint is people who have an outdated
node installed. This does a quick check to verify the version is high enough
before linting.
MozReview-Commit-ID: Em0jn18OUYo
--HG--
extra : rebase_source : 5325eb5f556f93e09d48fb123e0abb625aa77b84
StringBeginsWith (resp. StringEndsWith) takes a defaulted
nsStringComparator object for doing comparisons. The flexibility this
affords is great, but the cost is not: nsStringComparator has virtual
methods, so initializing that defaulted object (at every callsite)
requires a temporary object whose vtable must be initialized.
Since the overwhemingly common case is to use the default comparator
anyway, we should not use defaulted arguments and instead provide the
default comparator/user-provided comparator cases as separate overloads.
This change eliminates the virtual call for the majority of callsites
and reduces codesize as well.
Atomic's constructor is marked as constexpr, but it calls a
non-constexpr function, ToStorageTypeArgument::convert. For compilers
which require constexpr-ness on constructors to inline away the actual
constructor call, the call to ToStorageTypeArgument::convert completely
disables the constexpr-ness of the constructor. Let's fix this by
marking all relevant instances of ToStorageTypeArgument::convert as
MOZ_CONSTEXPR, thus satisfying the compiler once again.
testing/marionette/EventUtils.js has been converted to a JS module in
testing/marionette/event.js and its API has changed. It was originally
a copy of testing/mochitest/tests/SimpleTest/EventUtils.js, and it should
be fine to use the original instead.
MozReview-Commit-ID: Exi9d5rEeOz
--HG--
extra : commitid : 5SGljZj56xm
extra : rebase_source : fef01fe432241303c73f22425ddec18dc2a9a3a4
extra : amend_source : 968c4d6c4959f5ba502b846294aabe40296d6541
extra : histedit_source : 597b6ac1196966911fa5925cfb95cfdb2cdc6bf7
EventUtils.js previously allowed you to override the Window object
reference through passing it as an optional argument to its functions.
This change fixes certain uses of implicit globals that reside on Window.
MozReview-Commit-ID: EJT8iIs85ej
--HG--
extra : rebase_source : f18f8352a2556efd741986485d3a0fb84fec836c
extra : histedit_source : cb02f0cab1943b85a9ff5a6325591c3ab2044990
There should be no functional changes here.
MozReview-Commit-ID: 360y6vHYuC3
--HG--
extra : histedit_source : 3a058d33224c85f8896ea91978ef9443a64f6342
extra : rebase_source : 816d53905fb736beacf36c72154c70972a98d779
extra : commitid : B1JkBddKDeG
extra : source : 30c8ec933737ed7fde559d50815d3f7222067e3d
extra : amend_source : c92cd096caf9914e9cecf1ed3fe58e404f5b7477
This does not appear to be in use.
MozReview-Commit-ID: B4M335Lb1UM
--HG--
extra : commitid : I8NVDyxCC0e
extra : rebase_source : be6fddfe28cbe626114c38416c97075ee5cdf3a4
extra : source : 22321e6b65e987a76e42f880c8aa5a0427052259
extra : histedit_source : 241a896d0701c529cf56636eff567211198839cb
This change removes almost all the remaining uses of loadSubScript and
global scope pollution. The only remaining use is for common.js, which
is resolved by a later bug for evaluating scripts.
MozReview-Commit-ID: 96h0yLElauq
--HG--
extra : commitid : 8XlX4zVZQUN
extra : rebase_source : a5c8057c7ce0f52dc319f2e9d0937d6a4aab84d4
extra : source : 6bb93562a57656e6cc744c3c901a5ec80f9ec4d8
extra : histedit_source : 70f70a8aeffef3fca18addfa3fca575a9128e11a
To simplify the dependency chain and reduce the number of duplicate
functions in Marionette, a number of functions have been removed from
interactions.js and added to elements.js. This makes them more easily
re-usable and works around a circular dependency issue.
MozReview-Commit-ID: TZc3VZzHqM
--HG--
extra : commitid : BTgnO71SGbB
extra : rebase_source : f206dccccb4794034302bd4b4c16f5111ce3a044
extra : source : 5da7628c376765842c013f90566d4264f9e9312a
extra : histedit_source : 06b82234371ca8cd6bb0ede9cbf03f848fc66d82
Through some very clever hacking of the arguments to each of the atoms,
we are able to contain this in a JS module: Atoms normally extract their
arguments directly from the function scoped `arguments' variable, but
by explicitly naming `window' as the last argument in the functions'
prototype we are able to set the `window' variable used inside.
This is obviously a big hack, but it encapsulates the atoms and we are
moving away from atoms in the long term.
MozReview-Commit-ID: KGO77fjRN2d
--HG--
extra : commitid : 6AkmEPFP2Y4
extra : rebase_source : d9eccbd72030ca4a2e7214612159f0010c3147f2
extra : source : ee7ee24cc65e1b0b316963cc7963425f254e67cc
extra : histedit_source : aaa2005b8872127d8314fd6ad5c15b91d09555b9
testing/marionette/sendkeys.js has been merged into the
new testing/marionette/event.js module, together with
testing/marionette/EventUtils.js.
There is a lot of functionality still left in this module that we can
probably remove, as it is not in use by Marionette.
MozReview-Commit-ID: GrjNuK9VPjp
--HG--
rename : testing/marionette/EventUtils.js => testing/marionette/event.js
extra : commitid : GvNeDeClc50
extra : rebase_source : be6b8a4d8bf332c70ed3aab430ef579a806a4a27
extra : source : 4b2a5ee7199efd86e2b8db1f80c492378649f8dc
extra : histedit_source : f2fea53f3c7a5f49d1f0ef6f2bef4b98aa3566f2
error.wrap acts as a no-op if it is passed a prototype which is already
of the WebDriverError prototypal chain.
MozReview-Commit-ID: Gd9kUEvsgNv
--HG--
extra : commitid : HObqpKV7a9s
extra : rebase_source : c96b3c1a00a68a56d69d253945de5607039e3b49
extra : source : d75ad1397656e43d22d0d69211df9fce3a667f0d
extra : histedit_source : a6e620e3e4b6bfa4e1d77df48eaab59ffbc3cdce
Generally, Error prototypes that are not based on WebDriverError must
be wrapped so that they can be serialised across the AsyncMessageChannel.
MozReview-Commit-ID: EtkpEOBhrST
--HG--
extra : commitid : 825ScXhXQSy
extra : rebase_source : 1d2b7022e311ced9a07830f1017449fbb6220454
extra : source : 1f5e37f8e44641e5434d8393f307f2ea4e80cdc6
extra : histedit_source : c35a686b6b9cea4ae50d0d63223f4cdde6f6e4a2
Due to a previous programming error, error.isError only recognised
the base Error prototype. It must also test for the other built-in
prototypes, such as TypeError et al.
MozReview-Commit-ID: HLkiOAg0Jl1
--HG--
extra : commitid : F50Xhg2Q86e
extra : rebase_source : e7a81b7c07a59209c689b9a53895c17377e39692
extra : source : aec0a01666851a1e03dcb139e1766bae0c1b0fd7
extra : histedit_source : 77fd0e6b6471b18528c27954e6348f93fc520d64
Andrea Marchesini
Nicolas B. Pierron
Dave Townsend
Benjamin Smedberg
Carsten "Tomcat" Book
Olivier Yiptong
Armen Zambrano Gasparnian
Nathan Froyd
Andrew Halberstadt
Ben Kelly
Andreas Tolfsen
Alexander Surkov