CLOSED TREE
Backed out changeset 03c4c517ee37 (bug 1640091)
Backed out changeset a1d86c177d79 (bug 1640091)
Backed out changeset f481d4ec255a (bug 1640091)
Move call_indirect's signature check after pushing the frame. We are going to start to implement trampolines as inline code in call_indirect and so, we will push frame and only then tail call to one of the function entries.
Differential Revision: https://phabricator.services.mozilla.com/D75924
Previously we called DisplayLoadError with NS_ERROR_DOM_BASE_URI for errors detected during AsyncOpen, but not for asynchronous errors, and this patch queue changed when some security errors happen to be asynchronous.
GeckoView has tests that require DisplayLoadError to be called (which allows for a custom error page to be loaded). Unfortunately, doing so breaks existing gecko tests, since the method of detecting a blocked load fails when GeckoView loads a custom error page.
Differential Revision: https://phabricator.services.mozilla.com/D77171
The current state is that we fire error events for content blocking if the error happens synchronously and src was set when the iframe was in-document, or if the error happens asynchronously (from the parent process).
This test is currently setting src before appending the iframe to the document, and thus was expecting no error event to be fired. We have other content security tests that do rely on the error event being fired.
Since we're doing security checks in the parent, the error event now fires, and this changes the test to report success in that case.
Differential Revision: https://phabricator.services.mozilla.com/D75722
For general background see the bug's description. This patch
implements the iNxM.bitmask instructions for x86+x64 in baseline+ion,
and adds some simple test cases.
Differential Revision: https://phabricator.services.mozilla.com/D77784
This is mostly code removal: we remove the platform-specific lowering
and code generation for scalarized i64x2.mul. In its place we use
Andrew Brown's code for a platform-agnostic SIMD implementation, this
fits in very neatly in the existing code generation pipeline.
Differential Revision: https://phabricator.services.mozilla.com/D78015
I also considered setting a flag if a PAC query originates from a
TRR service channel but that doesn't work because of this:
1. We try to load test.com -> PAC script
2. We try to load TRR channel -> PAC script with DISABLE_TRR flag
3. PAC thread is still blocked on resolving test.com - we exit early
regardless of flag
Differential Revision: https://phabricator.services.mozilla.com/D78526
Move call_indirect's signature check after pushing the frame. We are going to start to implement trampolines as inline code in call_indirect and so, we will push frame and only then tail call to one of the function entries.
Differential Revision: https://phabricator.services.mozilla.com/D75924
One note about this solution: it includes the apz callback transform for the root scroll frame of the root content document, but no other apz callback transform that might be on an ancestor of the select element.
Differential Revision: https://phabricator.services.mozilla.com/D78026
Fix of bug 1320229 allowed to paste longer text than `maxlength` attribute of
`<input>` and `<textarea>` because it was thought that the longer text causes
"too long" invalidate state, makes users notified and prevent to submit
form data.
However, according to Bug 1636855 comment 7 (*1), it breaks a major enterprise
web app, SAP, at least because it sends form data without checking validity of
each form data and discards invalid data on server side silently.
According to bug 1636855 comment 24 (*2), one of new behavior's fault is
on Gecko side too. The style of `<input>` element or `<textarea>` element
which has too long text after pasting is changed when it loses focus.
Therefore, users can post the data before they know pasted data is too
long if sending the form data with `Enter` key or something immediately
after pasting (i.e., without moving focus) web apps handle it by themselves.
On the other hand, the original bug report, bug 1320229, should be solved in
the future especially in password field because users may register password
which is cut by `maxlength` silently and they don't use builtin password
manager, only the pasted password is saved, and then, they won't be able to
login as the account. This is really long standing issue of the web forms.
An article (*3) warned this to web developers in 2011. Therefore, we should
keep going advance for solving this issue at least in Nightly channel to get
more feedback from testers and web developers.
1 https://bugzilla.mozilla.org/show_bug.cgi?id=1636855#c7
2 https://bugzilla.mozilla.org/show_bug.cgi?id=1636855#c24
3 https://www.christophermanning.org/writing/dont-use-maxlength-on-password-inputs
Differential Revision: https://phabricator.services.mozilla.com/D78613
Mihai Alexandru Michis
Bogdan Tara
Simon Giesecke
Emilio Cobos Álvarez
Dmitry Bezhetskov
Matt Woodrow
Lars T Hansen
Mark Banner
chocos
Julian Descottes
Cameron McCormack
Christoph Kerschbaumer
Valentin Gosu
Andreea Pavel
Nicolas Chevobbe
Timothy Nikkel
James Teh
Narcis Beleuzu
Mike Hommey
Masayuki Nakano
Andrei Oprea