In this test, we assume the caret does not appear at the end of the input.
However in this case, self.actions.flick() will select all text within the
input, and then send_keys() will replace it with '!'. As a result, the final
content might varies on different platforms. Test the final content match
tho target_content might not be reliable.
To fix this, we instead assert that final content does *not* match the
non_target_content as the bug occurs.
MozReview-Commit-ID: 2YRN8W3PUXG
--HG--
extra : rebase_source : c63b631c609992fccf350d3088bba8e0621d9a55
Move MaskLayerUserData member data setup code into assign operator to reduce
codes in CreateMaskLayer.
MozReview-Commit-ID: FKsM3OfWhvS
--HG--
extra : rebase_source : 1fc2f40615de048805e30133b0eecd4ef3d5ae92
Simply move some code from ContainerState::CreateMaskLayer into MaskImageData,
so that we can reuse it later.
MozReview-Commit-ID: H2zktYL9PIh
--HG--
extra : rebase_source : 091c877af171adcef26fc6f8b1a03e56197be6ef
This makes background-image, mask-image and border-image settable
from Servo.
Since imgRequestProxy resolution in nsStyleImages can now happen later than
at computed value setting time, and that resolution can fail,
nsStyleImage::GetImageData() might now return null. So all of the users of
nsStyleImage now null check its result.
MozReview-Commit-ID: FMRUrC3SfOs
The difference between the PRCList and LinkedList is that the end of a
LinkedList is represented by nullptr, so we don't need to worry about
getting the first element when we iterate pass the last element. The
majority of the changes is due to this difference.
Also, simplify do-while loops by using for-loops in nsCounterManager and
nsQuoteList.
MozReview-Commit-ID: CZQxqNm2Ksm
--HG--
extra : rebase_source : 1a27aa5effa43a46a5d24172085c6d3502cb8c47
This patch also:
* Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore.
* Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly).
MozReview-Commit-ID: 8canWfXk6Kf
This patch also:
* Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore.
* Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly).
MozReview-Commit-ID: 8canWfXk6Kf
1. Rename these functions to agree with Mozilla coding style.
2. Use singular naming instead of plural naming since each of these functions
returns an iterator pointing to a singular line.
3. Rename line() and rline() to BeginLineFrom() and RBeginLineFrom(), which
shall improve the readability.
MozReview-Commit-ID: txZjVnv9Yb
--HG--
extra : rebase_source : b4dae99ab7bf751bd9974616f8f8e6dfe6248fc2
The major change to the Iterator is due to the fact that the end of a
LinkedList is represented by nullptr.
Also delete the type conversion functions which are no longer needed.
MozReview-Commit-ID: 2lYtFW9pSon
--HG--
extra : rebase_source : c822e937679e57a9f2d3ab034e5147fc3aea9e8e
Expose requestIdleCallback on Window and implement running callbacks
in idle periods by posting rICs to the main threads idle queue.
MozReview-Commit-ID: KSYQsyaZ6is
--HG--
extra : rebase_source : 6abd41c2de96b39004f1b2c3c740e81de570970c
Expose requestIdleCallback on Window and implement running callbacks
in idle periods by posting rICs to the main threads idle queue.
MozReview-Commit-ID: KSYQsyaZ6is
--HG--
extra : rebase_source : 4bdd578b654d05cab600489d30d859452d1bc888
This makes background-image, mask-image and border-image settable
from Servo.
Since imgRequestProxy resolution in nsStyleImages can now happen later than
at computed value setting time, and that resolution can fail,
nsStyleImage::GetImageData() might now return null. So all of the users of
nsStyleImage now null check its result.
MozReview-Commit-ID: FMRUrC3SfOs
To send animations to compositor in the delay phase we need to
modify Animation::IsPlaying returning true in the delay phase.
Note about background-position-in-delay.html:
After this patch, background-position animation also creates an active layer
from its delay phase.
Also note about test cases in test_animations_omta.html:
After landing bug 1279071, getOMTAStyle() returns the style value only
specified by animations, also in this patch we don't apply any opacity or
transform values in the delay phase, as a result we can't tell animating
value during delay phase on the compositor.
MozReview-Commit-ID: ILYKig3c08d
--HG--
extra : rebase_source : 5715c1f9ec43da3c8374f08cdca82e2ca29fe474
We need to consider fill mode in compositor thread as well as other properties
because pulling the animation back from the compositor thread is sometimes
delayed due to the main thread busyness. In such situations, if there is
another animation running on the main thread on the same element, users can
easily notice a gap between both of animations.
MozReview-Commit-ID: 1i7YTWboira
--HG--
extra : rebase_source : 036ca7707d07200af7435e027607503cd03f547e
The check of negative elapsedDuration is basically no longer valid since
animation delay is not factored into start time any more. But still we have
somtimes met negative elapsedDuration sice we use a previous vsync time stamp
for async animations to make the animations more sync. This is not a problem
in most cases but makes two reftests intermitent failure because both of them
used steps(1, start), the steps(1, start) composed different results in the
before phase and in the active phase. To avoid this difference this patch
replace the steps(1, start) with steps(1, end).
Once we incorpolate playbackRate into GetCurrentOrPendingStartTime, we don't
need to call AnimationTimeToTimeStamp for deviding delay by playbackRate since
the time passed to AnimationTimeToTimeStamp does not contain delay any more.
MozReview-Commit-ID: IVE2IFfNgm0
--HG--
extra : rebase_source : 7cb42e57067c21451706bd89284016d996dc8b12
If, within a single refresh driver tick, the scroll position is updated by JS
explicitly, and then subsequently also updated by a frame reconstruction, the
scroll origin from the former (nsGkAtoms::other) can get clobbered by the latter
(to nsGkAtoms::restore). The restore scroll origin is "weaker" in that it can
be ignored by the APZ code in some circumstances. This is undesirable because
it means the JS scroll update also gets ignored. This patch ensures that when
setting the scroll origin we don't do this clobbering of stronger origins with
weaker origins.
MozReview-Commit-ID: DA4EHp1Debu
--HG--
extra : rebase_source : 99fd1f91698a605792b2a622450f1ff31bc89101
In nsDisplayItem::RecomputeVisibility, we compute and assign the value of
mVisibleRect base on the return value of nsDisplayMask::GetBounds.
Before this patch, the region of out-of-flow descendants is discarded.
MozReview-Commit-ID: JEeegiO1a6J
--HG--
extra : rebase_source : 0e66c0765d7eb7700592ab947c92a705a7281ea5
In nsDisplayItem::RecomputeVisibility, we compute and assign the value of
mVisibleRect base on the return value of nsDisplayMask::GetBounds.
Before this patch, the region of out-of-flow descendants is discarded.
MozReview-Commit-ID: JEeegiO1a6J
--HG--
extra : rebase_source : 2adcf657f53983375ae67e5d99e1a55d563ec301
This patch introduces a new functions named HasEffectiveAnimationOfProperty.
This function checks that a given CSS property is overridden by !important
rules.
On the other hand, now KeyframeEffetReadOnly::HasAnimationOfProperty() does
just check that the effect has a given CSS property. This is used to create
a stacking context because we should create a stacking context for opacity or
transform animations even if the property is overridden by !important rules.
MozReview-Commit-ID: AG1Y0IgoB3U
This patch introduces a new functions named HasEffectiveAnimationOfProperty.
This function checks that a given CSS property is overridden by !important
rules.
On the other hand, now KeyframeEffetReadOnly::HasAnimationOfProperty() does
just check that the effect has a given CSS property. This is used to create
a stacking context because we should create a stacking context for opacity or
transform animations even if the property is overridden by !important rules.
Note about no-stacking-context-(opacity|transform)-removing-animation-in-delay.html
Before this patch we don't create any stacking context for animations overridden
by !important rules, but after this patch we do create a stacking context for
such animations. As a result, in the test case we did paint a stacking context
in the first rAF callback and then in the second rAF callback we did clear the
painted stacking context. Unfortunately sometimes the second rAF callback was
called prior to clear the stacking context on the compositor because of
compositor delay. To avoid this situation, we have to wait for MozAfterPaint
instead of rAF callback.
MozReview-Commit-ID: AG1Y0IgoB3U
This is refcounted as we'll need to hold strong references to the ImageTracker
from style structs that load images.
MozReview-Commit-ID: 994gE9tOjAn
--HG--
extra : rebase_source : 2d50059e51b42251c89a92a954cef7b49720ceba
Currently this function is used when an nsIFrame is generated by reframing. In
reframing, we call EffectCompositor::UpdateEffectProperties, as a result, we
have to clear the base style that we resolved once. So, for such cases, we need
to re-resolve the base style with the style context that is associated with the
nsIFrame.
MozReview-Commit-ID: F90OuF44SPI
--HG--
extra : rebase_source : ef163681f49b11887d4ea546d28a9fd217251d97
This adds a probe called TIME_TO_NON_BLANK_PAINT_MS which reports time to
non-blank paint for root content documents whose docshell was active for the
entire time between navigation start and first non-blank paint.
MozReview-Commit-ID: 7JQdk5vHr1O
--HG--
extra : rebase_source : 66be2aab4c4a32d20fb44c88c5270c5b5cfc0b81
extra : histedit_source : 5d6bef86d4a2a2250405d24ce28c6bfd9d654f8d
Bring back ShouldInvalidateToSyncDecodeImages check in
nsDisplayFilter::ComputeInvalidationRegion.
nsSVGIntegrationUtils::PaintFilter might be failure if the filter is not ready.
That is, effectProperties.HasValidFilter() returns false. So we still need that
check.
MozReview-Commit-ID: B4Lv5qZlHRr
--HG--
extra : rebase_source : 99a02e8d9401ce144a004795a4b3f4e5f505afb1
Use nsDisplayMaskGeometry, created by nsDisplayMask, in nsDisplaySVGEffects,
which is the parent class of nsDisplayMask) is odd.
So create a base class for both nsDisplayMaskGeometry and
nsDisplayFilterGeometry. Use this base class in nsDisplaySVGEffects's code.
MozReview-Commit-ID: G3FLybT1pQp
--HG--
extra : rebase_source : c8d2f5f122a9888adaba7d309f95cea6b957ee3e
Andi-Bogdan Postelnicu
Jet Villegas
Wes Kocher
Carsten "Tomcat" Book
Cameron McCormack
Keshav Prasad
Jonathan Watt
Ethan Lin
Ting-Yu Lin
cku
Phil Ringnalda
Brad Werth
Sebastian Hengst
Andreas Farre
Mats Palmgren
Kartikaya Gupta
Xidorn Quan
Jared Wein
Daniel Holbert
Tobias Schneider
Ryan VanderMeulen
David Anderson
Adam Velebil
Hiroyuki Ikezoe
Mantaroh Yoshinaga
Jessica Jong
Jeremy Chen
Markus Stange
Bobby Holley
Kris Maglione
Neil Deakin
Andrea Marchesini
Jorg K
Dhanesh B. Sabane
stefanh@inbox.com
Stone Shih
Olli Pettay
Kan-Ru Chen
Botond Ballo
Timothy Nikkel
Matt Woodrow
Emilio Cobos Álvarez