a16f7b0f6a
Bug 1296316 - Convert nsNSSShutDownObject::CalledFromType to an enum class. r=mgoodwin
...
enum classes are in general safer than plain enums, and as such should be
preferred.
MozReview-Commit-ID: 1FK89SNhdk4
--HG--
extra : rebase_source : 764c4855026c02d8c9e33ca33637fec54ea5ca31
2016-08-20 23:00:19 +08:00
e6276ea7f5
Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
...
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
fd84c776c7
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
169d66a3ed
Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
...
MozReview-Commit-ID: 2XVoU05YvES
--HG--
extra : rebase_source : e7ed2d094c21b59dd59476b8930b75da2e6d6980
2016-08-04 03:20:25 -04:00
871ed4e3ba
Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
...
MozReview-Commit-ID: DYOmE6xwMJh
--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
b3e4980239
Bug 1266569 - Avoid including the `ChromeUtils` binding in `Base64.h`. r=froydnj
...
MozReview-Commit-ID: 8ZLdMhJMaUe
--HG--
extra : rebase_source : d5cb2b5bcc587bad95e6223d18ef38c6937f9270
extra : histedit_source : 208b28d87e223333c2995fd615e0602b11d5bb68
2016-04-22 07:41:58 -07:00
d21d6da5e8
Bug 1256488 - Add a Base64 URL-decoder for C++ and chrome JS callers. r=mt,baku
...
MozReview-Commit-ID: IrDwImYfHRu
--HG--
extra : rebase_source : ed7da7447e5d70c596234961625fcd4b8139814f
2016-03-22 12:09:04 -07:00
6e44ebad84
Bug 1257246: Update toolkit for eslint 2. r=Gijs
...
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: KHYdAkRvhVr
--HG--
extra : rebase_source : 720cc9d864175248508146a7f4704b4bf3f02439
extra : histedit_source : 6cc0ecbf21a571e1a41d517b67512a3452fac19a
2016-04-05 11:33:48 -07:00
e496a11771
Bug 1245649: Turn on no-extra-semi. r=markh
...
--HG--
extra : commitid : HReQFPDOA6x
extra : rebase_source : 303a92f511c3c9dd2d26135975d4dc7c85e823b3
2016-02-03 17:27:36 -08:00
0a6414b898
Bug 1245649: Turn on no-trailing-spaces. r=Gijs
...
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
86f03db916
Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8
...
--HG--
extra : commitid : CKT2WDkxE4k
extra : rebase_source : 0be50c483317355b1e9af5985d53e85604748432
extra : histedit_source : 65d203f57ebd38b8c130e5db9aaa8ae3f507e7ac
2015-11-30 13:05:00 -08:00
65e2703499
Bug 1217082 - Remove for-each from toolkit/. r=Gijs
...
--HG--
extra : commitid : Ewr7Bixammr
extra : rebase_source : 91e560a7b8b8d4b78debb1db2512867262b18375
2015-10-19 04:57:14 +09:00
08997000eb
Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
...
Backed out changeset 647025383676 (bug 12029021202902
2015-10-07 14:03:21 +02:00
e7ef778c9d
Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
...
Backed out changeset cfc1820361f5 (bug 1202902
2015-10-07 12:13:45 +02:00
d06b6030f6
Bug 1202902 - Scripted fix the world.
2015-10-06 14:00:31 -07:00
64db2267cf
Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
52d4e225a0
Bug 1026290 - Update mochitest-chrome manifests for android; r=jgriffin
2015-07-10 14:41:59 -06:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
d1c61bc9b6
Bug 1116187 - Disable failing mochitest-chrome tests for B2G, r=gbrown
2015-02-06 16:30:37 -08:00
3d1dca594c
Bug 1129650 - Touching navigator.mozId causes an error NS_ERROR_FACTORY_NOT_REGISTERED. r=baku
2015-03-10 17:25:39 +01:00
375ec5d8d1
Backed out changeset 80987d26adfb (bug 1129650) for intermittent OSX packaging failures.
...
CLOSED TREE
2015-02-25 11:15:44 -05:00
343748a2bf
Bug 1129650 - Touching navigator.mozId causes an error NS_ERROR_FACTORY_NOT_REGISTERED. r=baku
2015-02-25 11:48:50 +01:00
4354953b4f
Bug 1118486 - Part 1: Use `= delete` instead of MOZ_DELETE directly; r=Waldo
...
Most of this patch (with the exception of dom/bindings/Codegen.py) was
generated by the following bash script:
#!/bin/bash
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "*/.git*" \
! -wholename "obj-*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_DELETE '= delete'
2015-01-08 23:19:05 -05:00
d292ee73f1
Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester
2014-10-07 18:18:28 -04:00
02533aaee7
Bug 1045289 - Change uses of "XPCom" to "XPCOM". r=froydnj
2014-09-26 07:20:23 +03:00
542214c4df
Bug 1044162 - part 1 - make EXTRA_{PP_,}JS_MODULES communicate their installation path; r=mshal
...
This patch makes EXTRA_{PP_,}JS_MODULES similar in functionality to
TESTING_JS_MODULES: we indicate the path relative to
$(FINAL_TARGET)/modules with an appropriate hierarchy of paths.
2014-07-25 13:40:07 -04:00
7ea4dd517f
Bug 1027242 - Blacklist mulet's failing tests + expose 'mulet' to ini files; fix previous bustage on a CLOSED TREE, r=ahal
2014-07-02 15:40:56 -07:00
1c5d8636ac
Backed out changeset 64586374a208 on a CLOSED TREE
2014-07-22 18:29:57 -07:00
98afd25e0d
Bug 1027242 - Blacklist mulet's failing tests + expose 'mulet' to ini files; fix previous bustage on a CLOSED TREE, r=ahal
2014-07-02 15:40:56 -07:00
38f79ff899
Backout 4f6d9db92389 for bustage on a CLOSED TREE
2014-07-22 17:55:50 -07:00
37506aa45c
Bug 1027242 - Blacklist mulet's failing tests + expose 'mulet' to ini files. r=ahal
2014-07-02 15:40:56 -07:00
dfb8d4ea04
bug 1036694 - merge nsIMarkupDocumentViewer into nsIContentViewer r=smaug
2014-07-09 17:27:49 -04:00
f40d884f09
Bug 1028398 - FxA will silently provide user's email to privileged apps in 2.0. Part 2: Trigger forceAuth when new privileged app tries to get a FxA assertion. r=jedp"
2014-07-11 16:13:32 +02:00
ad61403660
Bug 1037170 - Fire oncancel() when user cancels Sign Up/Sign In. r=jedp
2014-07-10 18:24:46 -07:00
adba9004ea
Bug 1034229 - Fire oncancel() when passed to request() with refreshAuthentication. r=jedp
2014-07-03 13:23:12 -07:00
a8446b38e4
Bug 1030227 - FxA must fire onlogin() for RPs that have called watch(). r=jedp
2014-06-26 10:04:03 -07:00
7e20285e70
Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
...
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
210693da34
Bug 1028588 - Fix dangerous public destructors in toolkit/ - r=ehsan
2014-06-23 18:40:02 -04:00
e2da20da48
Bug 1025309 - Fire FxA onlogout for RPs such as FMD. r=jedp
2014-06-17 11:28:25 -07:00
d91bae5b76
Bug 1008901 - Fire 'onlogin' when the account is verified. r=jedp
2014-06-06 10:42:22 -07:00
4434286b6b
bug 1006710 - add class of PSM errors to SEC and SSL errors r=briansmith
2014-05-28 15:28:03 -07:00
eabd7b1e52
Bug 982969 - DIALOG_CLOSED_BY_USER fires oncancel. r=jedp
2014-05-13 13:56:30 -07:00
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
2108235bb3
Bug 995353 - fix Firefox Accounts error propagation from toolkit/ through dom/ to web content. r=jedp
2014-04-23 15:45:06 -07:00
9afb24a0a4
Bug 688580 - Run deferred scripts before DOMContentLoaded; r=hsivonen
2014-04-12 11:02:21 +02:00
72ba05589a
Backed out changeset 02876730f55f (bug 688580) for Android 4.0 debug mochitest-7 perma-fail.
...
CLOSED TREE
2014-04-10 14:38:04 -04:00
Cykesiopka
Jared Wein
Tom Tromey
Nicholas Nethercote
Kyle Huey
Kit Cambridge
Dave Townsend
Tooru Fujisawa
Carsten "Tomcat" Book
Shu-yu Guo
Geoff Brown
Ehsan Akhgari
Jonathan Griffin
Fernando Jimenez
Ryan VanderMeulen
Andrew Halberstadt
Birunthan Mohanathas
Nathan Froyd
Alexandre Poirot
Trevor Saunders
Sam Penrose
Jim Blandy
Benoit Jacob
David Keeler
Olli Pettay