Profile-per-install uses a hash of the install directory to identify different
installs of Firefox. This exposes the existing cityhash generated hash from
nsXREDirProvider and makes it available on all platforms.
Differential Revision: https://phabricator.services.mozilla.com/D3852
--HG--
extra : moz-landing-system : lando
This patch introduces a screenshot actor, which allows the screenshot functionality to be
shared across tools, and also implements it for the toolbox itself
Differential Revision: https://phabricator.services.mozilla.com/D3341
--HG--
rename : devtools/server/actors/webconsole/screenshot.js => devtools/shared/screenshot/capture.js
extra : moz-landing-system : lando
this combines the changes that I made in bug 1464461
(https://reviewboard.mozilla.org/r/253132/diff/1#index_header) with the changes for web replay made
by Brian Hackett, along with some clean up that was done by Honza with regards to helpers being
executed. This change should not have any functional impact on the code base, but it should make it
easier to work with the evalWithDebugger functionality than it has been so far.
Differential Revision: https://phabricator.services.mozilla.com/D3311
--HG--
rename : devtools/server/actors/webconsole.js => devtools/server/actors/webconsole/eval-with-debugger.js
extra : moz-landing-system : lando
Changes to browser.search.search API:
- Change the positional parameters to an object parameter.
- Rename "engineName" to "engine", and make this an optional parameter.
- Rename "searchTerms" to "query".
Changes to browser.search.search implementation:
- Simplify gBrowser getter. None of the "!gBrowser" conditionals are
necessary, as demonstrated by the new options page+sidebar tests
(which passed even after removing the `if (!gBrowser ...)` blocks).
Use windowTracker.topWindow for consistency with our other code.
Test changes:
- Remove unneeded name / "TEST_ID" in tests
- Use SEARCH_TERM constant in more places.
- New test: Using API from options page.
- New test: Using API from sidebar.
- New test: Using API without explicit "engine" parameter.
Differential Revision: https://phabricator.services.mozilla.com/D3417
--HG--
extra : moz-landing-system : lando
This adds support for the DW_AT_ranges attribute when dumping out symbols and
adds basic support for AArch64 (64-bit ARM) on Windows in the minidump
processor.
Differential Revision: https://phabricator.services.mozilla.com/D3443
--HG--
extra : moz-landing-system : lando
Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp
Bug 1484382 - Use mozilla::ScopeExit in vm/TypeInference.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitcodeMap.cpp
Bug 1484382 - Use mozilla::ScopeExit in jit/JitFrames.cpp
Differential Revision: https://phabricator.services.mozilla.com/D3685
--HG--
extra : moz-landing-system : lando
Without this patch, hitting Alt-B was adding a character **and** moving
the cursor to the previous group, while Alt-F was also adding a character
**and** moving the cursor to the next group.
We disable the shortcut to fix this and add a test to make sure we don't
regress.
Differential Revision: https://phabricator.services.mozilla.com/D2918
--HG--
extra : moz-landing-system : lando
Bug 1438499 added an optional parameter to warnAboutClosingTabs.
In bug 1475427, the arguments to warnAboutClosingTabs changed, and instead
of passing a closing tab reference as the second argument, we now need to
pass the number of tabs as the first argument. The patch in that bug
updated the callsite in nsBrowserGlue.js to add the new argument, but
didn't remove the `null` argument that we were passing for the 'extra' tab.
Additionally, the change in bug 1475427 bails early from
warnAboutClosingTabs if the number of tabs passed is less than 2. That tab
count, too, needs to take into account multiple windows and not just the
last window iterated over.
This patch fixes both of these issues.
Differential Revision: https://phabricator.services.mozilla.com/D3807
--HG--
extra : moz-landing-system : lando
We do not have a test case in talos that has many files to be loaded on start. This change adds 100
files, each around 1000 lines long.
Differential Revision: https://phabricator.services.mozilla.com/D3308
--HG--
extra : moz-landing-system : lando
We share the inner object across sheets from the same URL, so what happens here
is that, once the sheet parses and loads, we call SetEnabled() on the first
sheet, which sets the inner bit, then calls ApplicableStateChanged.
That set actually turned the second sheet complete, so when inserting the sheet,
we think that the second sheet is already enabled, and thus in the author data,
and try to insert before it. Of course there's nothing there, so we panic.
We rely on calling SetEnabled() on all the sheets already to insert them in the
styleset / author data, so this makes it clearer and fixes the bug by moving the
state to each individual sheet.
Differential Revision: https://phabricator.services.mozilla.com/D3798
--HG--
extra : moz-landing-system : lando
Bug 1483882 removed the line that used to remove the SHADOW_TREE bit during
unbind. I missed this caller which still assumed that `IsInShadowTree() ->
GetContainingShadow()`.
That means that before that patch it was going through
nsIDocument::RemoveStyleSheet, which looks pretty wrong to me.
Fix it so that we don't remove the stylesheet (we weren't doing it before
anyway), but we don't crash.
Differential Revision: https://phabricator.services.mozilla.com/D3831
--HG--
extra : moz-landing-system : lando
This test is basically a copy of its -001 variant, with some "float:left"
sprinkled around on contained descendants.
Before this patch, this test had an additional arbitrary sizing difference as
compared to the -001 version -- there's one element that arbitrarily has class
"outer" in the -002 test whereas it has class "inner-lg" in the -001 version.
These classes have different sizing characteristics, which makes a difference
to whether scrollbars show up, because this element is not contained (though it
is a layout container itself).
This patch undoes this arbitrary difference and also adds a "float" class to
make it easier to see which elements we've sprinkled float styling onto.
Differential Revision: https://phabricator.services.mozilla.com/D3826
--HG--
extra : rebase_source : 2630420b4dfc1a307cbfe20447e66fbfecf7b0aa
Currently mozhttpd's test suite uses Python's unittest. Several tests don't
shut down started MozHttpd server instances, resulting in blocking test runs.
This patch resolves that problem by using pytest fixtures.
Differential Revision: https://phabricator.services.mozilla.com/D3764
--HG--
extra : moz-landing-system : lando
This patch add comments to IndexedDBHelper.jsm to clarify how txn.result is set.
The comments should clear up any confusion caused by previous commit message
(fix for bug 1409641).
--HG--
extra : rebase_source : 57a6f3eb569224a9e432803ef67d80f57219f7ab
When the namespace changes (e.g. due to a tab move between windows), we
may get stale transaction requests that we need to ignore. In
WebRenderBridgeParent::RecvSetDisplayList, we would automatically send
any unsent transaction data when exiting the method, but this did not
take into account the staleness. This patch ensures we only flush the
data if we actually want it.
The transaction in question that was observed and causing crashes was
UpdateImageBuffer.
We end up with three <svg:use> elements to update (lol), because the target (#c)
changes, since we create another element with that ID in the document via
outerHTML.
Differential Revision: https://phabricator.services.mozilla.com/D2650
--HG--
extra : moz-landing-system : lando
HTMLEditRules::WillDeleteSelection is complex since some variables is reused.
So I would like to clean up this to use block scope and EditorDOMPoint
before fixing bug 685799.
Differential Revision: https://phabricator.services.mozilla.com/D3761
--HG--
extra : moz-landing-system : lando
The "select" event handler workaround was originally added in bug 1379270 to make it
possible to focus and select the URL bar a little bit later. This ugly hack was to
workaround an issue with WebExtensions that override about:newtab with the
chrome_url_overrides property (the issue would be that the URL bar would not be
properly focused and selected if about:newtab was overridden).
Back in the day, this was necessary because the overriding URL was fully displayed
in the URL bar (moz-webextension://...). These days, when about:newtab is overridden,
the URL bar is still empty - we just end up showing the information about the
WebExtension overriding about:newtab to the left of the URL bar.
So I think we can remove the old workaround.
Differential Revision: https://phabricator.services.mozilla.com/D3447
--HG--
extra : moz-landing-system : lando
Disable TRR at will without needing to toggle the pref.
MozReview-Commit-ID: 1Ept6kDrjN3
Differential Revision: https://phabricator.services.mozilla.com/D3399
--HG--
extra : moz-landing-system : lando
We were checking for cross-compartment wrappers in the Debugger constructor, but this patch also fixes addDebuggee and addAllGlobalsAsDebuggees.
Differential Revision: https://phabricator.services.mozilla.com/D3495
--HG--
extra : rebase_source : 3346baa677b4eae1ed8b7b13d93c1c8c89753d97
Dorel Luca
Dave Townsend
Henri Sivonen
yulia
Rob Wu
Jonathan Kingston
Ryan VanderMeulen
Mats Palmgren
Gabriele Svelto
Franziskus Kiefer
Ted Campbell
Nicolas Chevobbe
Gijs Kruitbosch
Emilio Cobos Álvarez
Daniel Holbert
Alex Gaynor
Raphael Pierzina
Tom Tung
Andrew Osmond
Makoto Kato
Mike Conley
Daniel Stenberg
ExE Boss
Thomas Daede
Jan de Mooij
Ashley Hauck
Eitan Isaacson
Jeff Walden
Nicholas Nethercote
Gurzau Raul
Jim Chen