4eb51d8fe8
Bug 1578361 - removed unused localTransport getter on debugger-client r=ladybenko
...
This was initially added in Bug 907755 for old telemetry probes.
Differential Revision: https://phabricator.services.mozilla.com/D44444
--HG--
extra : moz-landing-system : lando
2019-09-04 11:15:40 +00:00
d0413845a9
Bug 1577780 - Add test for invoking getter in content object from Browser Console. r=Honza.
...
We're re-using the test we already have for invoking getters
in the webconsole as it is checking a lot of different cases.
Differential Revision: https://phabricator.services.mozilla.com/D44628
--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_getters.js => devtools/client/webconsole/test/browser/browser_console_content_getters.js
extra : moz-landing-system : lando
2019-09-04 09:03:44 +00:00
01653665f2
Bug 1578660 - Add missing key on EditorToolbar in App.js .r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D44630
--HG--
extra : moz-landing-system : lando
2019-09-04 09:09:24 +00:00
010f6b2666
Bug 1578283 - Don't scroll jsterm viewport when inserting a tab character. r=Honza.
...
When we wanted to insert a string in the webconsole input,
we were setting the input value, and setting the cursor
manually. But since the editor setCursor function is calling
alignLine, there could be cases where the editor scroll position
would jump, feeling awkward for the user.
It turns out we can simplify this code a lot since codeMirror
provides a replaceRange function, which is a perfect replacement
for what we were using, without having to manage the cursor position.
The only downside to that is that inserting characters this
way *does* fire a `changes` event, that we are listening to
in the JsTerm to request autocompletion (which we don't need
as we only insert characters when accepting a completion or
adding a tab).
To mitigate that, we pass a specific jsterm origin string to
replaceRange, which let's us discriminate in the changes event
listener if those changes originate from jsterm only actions.
A test is added to ensure this works as expected (the test was
failing without the fix).
Differential Revision: https://phabricator.services.mozilla.com/D44466
--HG--
extra : moz-landing-system : lando
2019-09-04 09:02:09 +00:00
9a09073dc7
Bug 1572144 - Support search result navigation. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43555
--HG--
extra : moz-landing-system : lando
2019-09-04 08:31:45 +00:00
fdea67edb5
Bug 1273656 - Add wait before trying to click in browser_html_tooltip-02.js r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D44356
--HG--
extra : moz-landing-system : lando
2019-09-04 07:52:21 +00:00
c850b60c69
Bug 1578565 - SVG and MathML elements don't follow the CSS layout model. r=pbro
...
We could be more explicit and also handle svg on the height / width stuff
(width and height don't apply to all SVG elements).
But this avoids the false positive for now.
Differential Revision: https://phabricator.services.mozilla.com/D44621
--HG--
extra : moz-landing-system : lando
2019-09-04 07:45:32 +00:00
4b6fa71ccf
Bug 1565715 - Stop preview highlight at non-element nodes.
...
By tweaking the while loop in addHighlightToTargetSiblings, the preview highlight will not continue beyond a non-text node. (Example in the case of a semi colon or a period.
Differential Revision: https://phabricator.services.mozilla.com/D44275
--HG--
extra : moz-landing-system : lando
2019-09-03 22:51:30 +00:00
9d0541854d
Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42747
--HG--
extra : moz-landing-system : lando
2019-09-03 20:57:40 +00:00
8fb7ae2f24
Bug 1577376 - UI for disable debugger statement r=jlast
...
Add menu items to both secondary panel and editor
Add a mochitest
{F1539841}
Differential Revision: https://phabricator.services.mozilla.com/D44115
--HG--
extra : moz-landing-system : lando
2019-08-31 00:50:13 +00:00
63f09e5cee
Bug 1491649 - Make useragent toolbar device and throlling select longer to display clearly. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D32346
--HG--
extra : moz-landing-system : lando
2019-09-03 18:12:35 +00:00
8fcd7c71a2
Bug 1542369 - Add method to highlight text if formTypes equals add. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D32510
--HG--
extra : moz-landing-system : lando
2019-09-03 18:11:39 +00:00
4922526a64
Bug 1567249 - Update a11y contrast calculation to make it work with applied simulation matrices, r=yzen,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42417
--HG--
extra : moz-landing-system : lando
2019-09-03 05:39:18 +00:00
f93e5fd1de
Bug 1578252 - Highlight messages that are at the same location. r=bhackett
...
Differential Revision: https://phabricator.services.mozilla.com/D44381
--HG--
extra : moz-landing-system : lando
2019-09-03 15:34:02 +00:00
e843afd6cd
Backed out 6 changesets (bug 1575682) for causing devtools failures on browser_all_files_referenced.js CLOSED TREE
...
Backed out changeset 7e60a2013e96 (bug 1575682)
Backed out changeset c44c69605b87 (bug 1575682)
Backed out changeset abee6fadcd4d (bug 1575682)
Backed out changeset e4a75438c032 (bug 1575682)
Backed out changeset 985902e9abdb (bug 1575682)
Backed out changeset 31a67b9d47ab (bug 1575682)
--HG--
rename : devtools/client/performance-new/popup/popup.xhtml => devtools/client/performance-new/popup/popup.html
2019-09-03 21:01:24 +03:00
5dcfb63635
Backed out changeset 4e344973418a (bug 1572144) for failing in browser_accessibility_mutations.js CLOSED TREE
2019-09-03 20:12:10 +03:00
45a753ed46
Backed out changeset 05f1cba504d0 (bug 1573859) for perma fails on browser_misused_characters_in_strings.js. CLOSED TREE
2019-09-03 19:40:15 +03:00
b6c64887d8
Bug 1575682 - Stop the profiler popup from "blipping" with unrendered content r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D43121
--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:09 +00:00
e898f6ca4c
Bug 1575682 - Add a mechanism for the popup to signal that its size has changed r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D43116
--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:07 +00:00
899de33c54
Bug 1575682 - Rename the recording buttons, and add a cancel button r=julienw
...
This is broken out into a separate commit since it is a layout change
for the DevTools as well. Note, that this area is still not localized.
Differential Revision: https://phabricator.services.mozilla.com/D43120
--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:03 +00:00
adcb6873db
Bug 1575682 - De-duplicate the profiler popup code r=julienw
...
This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.
Differential Revision: https://phabricator.services.mozilla.com/D43119
--HG--
rename : devtools/client/performance-new/popup/popup.html => devtools/client/performance-new/popup/popup.xhtml
extra : moz-landing-system : lando
2019-09-03 16:05:59 +00:00
39e7931b1e
Bug 1575682 - Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw
...
This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D43118
--HG--
extra : moz-landing-system : lando
2019-09-03 16:05:55 +00:00
2da89fa0ed
Bug 1575682 - Bridge the perf actor so that it can be reused with the popup r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D43117
--HG--
extra : moz-landing-system : lando
2019-09-03 16:04:22 +00:00
d8ffcbc0d8
Bug 1572144 - Support search result navigation. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43555
--HG--
extra : moz-landing-system : lando
2019-09-03 15:55:02 +00:00
a3fb20f8c6
Bug 1565375 - The pause overlay should include stepping buttons. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43516
--HG--
extra : moz-landing-system : lando
2019-08-30 22:25:46 +00:00
e57f38026d
Bug 1573859 - Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43682
--HG--
extra : moz-landing-system : lando
2019-08-30 23:34:17 +00:00
c32c68086c
Bug 1566986 - Make getSymbols an async function so that callers always get a promise and never a synchronous exception. r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D44400
--HG--
extra : moz-landing-system : lando
2019-09-03 14:30:22 +00:00
392fe89b3a
Bug 1569738, make PageInfo fission compatible r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D42978
--HG--
extra : moz-landing-system : lando
2019-08-29 20:31:19 +00:00
37211d770b
Bug 1578389 - Fix propTypes error in console. r=Honza.
...
Fix 2 proptype errors: one in App.js, and the
other one in the renderStacktrace function,
that is called by Error rep.
Differential Revision: https://phabricator.services.mozilla.com/D44467
--HG--
extra : moz-landing-system : lando
2019-09-03 13:55:45 +00:00
7663347ad2
Bug 1578326 - Make history navigation icons same color as other icons in webconsole. r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D44428
--HG--
extra : moz-landing-system : lando
2019-09-03 07:43:35 +00:00
9f40693a13
Bug 1577795 - Fix browser_webconsole_reverse_search_initial_value.js intermittent. r=Honza.
...
The failures were about pending requests to highlighters,
because we were logging node elements. Since we don't
really need to do that, we simply change the command
to not lod elements.
Differential Revision: https://phabricator.services.mozilla.com/D44367
--HG--
extra : moz-landing-system : lando
2019-09-03 07:43:33 +00:00
d65c5e0309
Bug 1556489 - P19. Fix devtools stack traces. r=honza,ochameau
...
DevTools rely on events when a new HttpChannel is opened, it needs to know when a DocumentChannel is.
Differential Revision: https://phabricator.services.mozilla.com/D40975
2019-09-03 10:19:46 +10:00
b43fd91ea2
Bug 1556489 - P11. Add nIIdentChannel interface. r=mayhemer
...
The devtools listens to http-on-opening-request event which is expected to receive a nsIHttpChannel. However future changes will make it that it's not always a nsIHttpChannel that can fire such event.
As such we create an intermediary interface nsIIdentChannel and move the subset generating such event in nsIHttpChannel there.
Differential Revision: https://phabricator.services.mozilla.com/D40968
2019-09-03 10:19:34 +10:00
fb4596cde5
Bug 1535451 - Skip browser_webconsole_trackingprotection_errors.js on fission. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D44094
--HG--
extra : moz-landing-system : lando
2019-09-02 12:03:10 +00:00
329cb69c2c
Bug 1578108 - add addons actor back; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D44375
--HG--
extra : moz-landing-system : lando
2019-09-02 15:33:29 +00:00
17ae774116
Bug 1519586 - Fix js error in browser_aboutdevtools_reuse_existing.js r=ladybenko
...
Differential Revision: https://phabricator.services.mozilla.com/D44345
--HG--
extra : moz-landing-system : lando
2019-09-02 15:22:37 +00:00
e0b09c55fe
Bug 1574401 - allow DevTools to access BrowsingContext; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D44366
--HG--
extra : moz-landing-system : lando
2019-09-02 13:24:20 +00:00
f4156a2ce9
Bug 1485383 - update emulationFront to be retrieved using getFront; r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D43953
--HG--
extra : moz-landing-system : lando
2019-09-02 10:33:34 +00:00
89cf4ed29b
Bug 1578020 - Fix horizontal spacing and RTL issues in Fonts panel; r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D44309
--HG--
extra : moz-landing-system : lando
2019-09-02 13:42:41 +00:00
7c45433d96
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl,fluent-reviewers,flod
...
Depends on D44232
Differential Revision: https://phabricator.services.mozilla.com/D44233
--HG--
extra : moz-landing-system : lando
2019-09-01 15:55:14 +00:00
2a978a3d9c
Bug 1577759 - add highlighter support for a keyboard check for non-focusable non-semantic elements. r=rcaliman
...
Depends on D44231
Differential Revision: https://phabricator.services.mozilla.com/D44232
--HG--
extra : moz-landing-system : lando
2019-09-02 12:31:03 +00:00
ed97f85766
Bug 1577759 - add a keyboard check for non-focusable non-semantic elements that are interactive with mouse only. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D44231
--HG--
extra : moz-landing-system : lando
2019-09-02 06:59:33 +00:00
aa1e1dbea8
Bug 1577756 - Run browser_console_webconsole_console_api_calls.js can run with both Fission enabled and disabled. r=Honza.
...
We also add a few console API calls, as well as pass a second
object parameter for the methods that support it, so we can
check that the content object are well displayed in the
Browser Console.
As we add a new check for console.table, I realized that
hiding and showing a consoleTable component would trigger a
new request to the server, even if we already have the table
data at hand.
I fixed this by only trying to get data from the server if
we don't have them already.
Differential Revision: https://phabricator.services.mozilla.com/D44159
--HG--
extra : moz-landing-system : lando
2019-09-02 12:29:47 +00:00
dac2ee564f
Bug 1562464 - transferred sort change r=Honza
...
Network pane of the Developer Tools
Differential Revision: https://phabricator.services.mozilla.com/D44313
--HG--
extra : moz-landing-system : lando
2019-09-02 11:06:13 +00:00
208ec08c09
Bug 1566013 - Part 3: Add mochitests r=Ola
...
Differential Revision: https://phabricator.services.mozilla.com/D43956
--HG--
extra : moz-landing-system : lando
2019-09-02 07:44:40 +00:00
b9053896d0
Bug 1566013 - Part 2: Add unit tests for the manifest reducer r=Ola
...
Differential Revision: https://phabricator.services.mozilla.com/D43955
--HG--
extra : moz-landing-system : lando
2019-09-02 08:26:32 +00:00
22cb75164e
Bug 1566013 - Part 1: Process canonical manifest and hook it with the Manifest component r=Ola
...
Differential Revision: https://phabricator.services.mozilla.com/D43954
--HG--
extra : moz-landing-system : lando
2019-09-02 06:44:14 +00:00
6694976ecd
Bug 1577834 - Remove now-useless promise array in ensureCSSErrorReportingEnabled. r=nchevobbe
...
Now that we no longer do anything when they all resolve, this can go away.
Differential Revision: https://phabricator.services.mozilla.com/D44222
--HG--
extra : moz-landing-system : lando
2019-09-02 08:22:30 +00:00
c93c7ac5af
Bug 1577074 - Instrument scripts executed from editor mode. r=rcaliman.
...
We add an extra "input" property that is filled with
either "inline" or "multiline" depending if the expression
was evaluated in regular webconsole layout or in editor mode.
The test that was checking the execute_js telemetry event is
modify to only check what it was created for (hitting enter
on incomplete expression adds new line), and a new test is
added to specifically check that the execute_js telemetry event
is recorded as we expect.
Differential Revision: https://phabricator.services.mozilla.com/D43738
--HG--
rename : devtools/client/webconsole/test/browser/browser_jsterm_multiline.js => devtools/client/webconsole/test/browser/browser_webconsole_telemetry_execute_js.js
extra : moz-landing-system : lando
2019-09-02 06:22:32 +00:00
0f6c405c91
Bug 1543782: Add test for the shortcut key which shows the suggest completion popup. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43723
--HG--
extra : moz-landing-system : lando
2019-09-02 03:29:17 +00:00
f25606bd74
Bug 1543782: Add tests in case of empty. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43722
--HG--
extra : moz-landing-system : lando
2019-09-02 03:34:40 +00:00
49bc96438b
Bug 1543782: Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43721
--HG--
extra : moz-landing-system : lando
2019-09-02 03:29:13 +00:00
7e47e03614
Bug 1543782: Show the suggestions when user presses ctrl+space. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43720
--HG--
extra : moz-landing-system : lando
2019-09-02 03:27:38 +00:00
88bc25ece4
Bug 1543782: Show the suggestions in case that the css value becomes empty. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43719
--HG--
extra : moz-landing-system : lando
2019-09-02 03:27:26 +00:00
f94fd8b49f
Bug 1578114 - Fix typo in setEmptyInstrumentationId, r=jlast.
...
Differential Revision: https://phabricator.services.mozilla.com/D44339
--HG--
extra : moz-landing-system : lando
2019-09-01 22:36:58 +00:00
5ed60064ac
Bug 1575954 - QI for nsIDocShell before setting watchedByDevtools, r=jlast.
...
Differential Revision: https://phabricator.services.mozilla.com/D44340
--HG--
extra : moz-landing-system : lando
2019-09-01 22:35:58 +00:00
c7fb1fa618
Bug 1577790 - fix dark theme best practices icon fill color. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D44234
--HG--
extra : moz-landing-system : lando
2019-08-30 20:30:57 +00:00
6dce799feb
Backed out changeset 204d32b36d7e (bug 1575240) for frequently failing devtools at devtools/client/inspector/test/browser_inspector_menu-06-other.js
2019-08-31 11:25:08 +03:00
8d53b63ee8
Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42747
--HG--
extra : moz-landing-system : lando
2019-08-30 20:43:13 +00:00
3ecbce3546
Bug 1576797 - Remove threadFront/target references from web replay tests, r=jlast.
...
Differential Revision: https://phabricator.services.mozilla.com/D43558
--HG--
extra : moz-landing-system : lando
2019-08-30 21:38:40 +00:00
611da30262
Bug 1577677 - Update language for toggling inline preview r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D44098
--HG--
extra : moz-landing-system : lando
2019-08-30 16:15:03 +00:00
3f0714c0cf
Bug 1572840 Part 5: Update test expectations. r=gl
...
https://phabricator.services.mozilla.com/D42379
Differential Revision: https://phabricator.services.mozilla.com/D43825
--HG--
extra : moz-landing-system : lando
2019-08-30 18:45:56 +00:00
2c1d514203
Bug 1572840 Part 3: Listen to fullzoom changes in the RDM pane and call the zoom viewport function. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D41467
--HG--
extra : moz-landing-system : lando
2019-08-30 18:44:56 +00:00
d6d0edef6f
Bug 1572840 Part 2: Make the RDM viewport render scaled to the viewport.zoom property. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D41465
--HG--
extra : moz-landing-system : lando
2019-08-30 18:44:29 +00:00
b13fe6a76e
Bug 1572840 Part 1: Add a zoom viewport action to RDM pane. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D41463
--HG--
extra : moz-landing-system : lando
2019-08-30 18:44:06 +00:00
3c1a5c02df
Bug 1577047 - Function calls without args should not be valid breakpoint positions. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D43884
--HG--
extra : moz-landing-system : lando
2019-08-30 14:49:25 +00:00
6f5e14995c
Backed out changeset ae73cf1c7395 (bug 1561873) for eslint failure at FrameListContent.js on a CLOSED TREE.
2019-08-30 20:39:32 +03:00
a329609891
Bug 1575364 - WebSocket Inspector Test: Limit payload size. r=Honza
...
Test that the truncated payload notification displays correctly.
Differential Revision: https://phabricator.services.mozilla.com/D42734
--HG--
extra : moz-landing-system : lando
2019-08-30 17:31:15 +00:00
48f4c00ca8
Bug 1575341 - WebSocket Inspector Test: Limit number of frames. r=Honza
...
Test that the truncated message notification displays correctly.
Differential Revision: https://phabricator.services.mozilla.com/D42719
--HG--
extra : moz-landing-system : lando
2019-08-30 17:26:40 +00:00
44d14c3f29
Bug 1576318 Part 5 - Add tests that we can preview assorted objects while replaying, and pause the debugger without making debugger requests, r=loganfsmyth.
...
Depends on D43321
Differential Revision: https://phabricator.services.mozilla.com/D43322
--HG--
extra : moz-landing-system : lando
2019-08-30 17:13:34 +00:00
ad74710129
Bug 1576318 Part 4 - Add testing method to get the debugger requests and associated stacks for the current pause, r=loganfsmyth.
...
Depends on D43320
Differential Revision: https://phabricator.services.mozilla.com/D43321
--HG--
extra : moz-landing-system : lando
2019-08-30 17:10:57 +00:00
f8e6ccaf6b
Bug 1576318 Part 3 - Avoid rerendering messages when the paused execution point has not changed, r=loganfsmyth,nchevobbe.
...
Depends on D43319
Differential Revision: https://phabricator.services.mozilla.com/D43320
--HG--
extra : moz-landing-system : lando
2019-08-30 17:07:07 +00:00
fe92dccb84
Bug 1576318 Part 2 - Use replay-friendly methods when previewing objects and getting the contents of container objects, r=loganfsmyth.
...
Depends on D43318
Differential Revision: https://phabricator.services.mozilla.com/D43319
--HG--
extra : moz-landing-system : lando
2019-08-30 17:06:05 +00:00
ec37274f10
Bug 1576318 Part 1 - Supply contents of containers and additional information needed while previewing to the ReplayDebugger, r=loganfsmyth.
...
Differential Revision: https://phabricator.services.mozilla.com/D43318
--HG--
extra : moz-landing-system : lando
2019-08-30 17:00:00 +00:00
c3820a997f
Bug 1575274 - WebSocket Inspector Test: Filtering using free text. r=Honza
...
Test for filtering messages using the filter input.
Differential Revision: https://phabricator.services.mozilla.com/D42694
--HG--
extra : moz-landing-system : lando
2019-08-30 17:04:15 +00:00
36e147f925
Bug 1561873 - Support for keyboard navigation in WS frame list. r=Honza
...
Support for keyboard navigation in WS frame list.
Differential Revision: https://phabricator.services.mozilla.com/D42897
--HG--
extra : moz-landing-system : lando
2019-08-30 17:02:46 +00:00
161a6ec7b4
Bug 1577727 - set meta data in which bugzilla product & component debugger bugs should be filed. r=jlast DONTBUILD
...
Got (accidentally?) removed in bug 1500987.
Differential Revision: https://phabricator.services.mozilla.com/D44119
--HG--
extra : moz-landing-system : lando
2019-08-30 16:40:39 +00:00
521211a377
Bug 1577467 - Remove obsolete iframe container for DevTools animation inspector; r=daisuke
...
The animation inspector is [loaded on demand by the inspector](https://searchfox.org/mozilla-central/rev/8ea946dcf51f0d6400362cc1d49c8d4808e `eacf1/devtools/client/inspector/inspector.js#937-942) as a sidebar panel via an `InspectorPanel` instance. The iframe container from index.xhtml seems to be a leftover from a time where the animation inspector was loaded differently.
No failing tests after removing iframe. Is this ok to cleanup?
Differential Revision: https://phabricator.services.mozilla.com/D43951
--HG--
extra : moz-landing-system : lando
2019-08-30 12:17:05 +00:00
a285cce793
Bug 1576484 - Bail out of getParentGridElement when the element is <html>; r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D44017
--HG--
extra : moz-landing-system : lando
2019-08-30 11:45:07 +00:00
a10ae49f67
Backed out 5 changesets (bug 1543782) for devtools failures on browser_rules_completion-on-empty.js.
...
Backed out changeset d7b6b036d777 (bug 1543782)
Backed out changeset 2081fd72fd28 (bug 1543782)
Backed out changeset 703a2947c350 (bug 1543782)
Backed out changeset 822638e9789a (bug 1543782)
Backed out changeset cb477711fa64 (bug 1543782)
--HG--
extra : histedit_source : 5f52e7a5791fcdcf9d3433aced75ac3c92c48c3b
2019-08-30 13:59:35 +03:00
434d13bdd7
Bug 1574791 - Don't emit a warning message when enabling CSS warnings. r=Honza.
...
There was a warning message displayed to indicate that
the stylesheets where parsed again for checking errors,
and that in order to see errors for CSS modified in
Javascript, the tab should be reloaded.
The jargon used there was confusing, and also this was
more a notice than an actual warning message.
In order to remove confusion, we don't emit this message
anymore, but add a title to the CSS filter button when
it's disabled. The sentence is reworded to be simpler
to understand.
Differential Revision: https://phabricator.services.mozilla.com/D44118
--HG--
extra : moz-landing-system : lando
2019-08-30 08:57:50 +00:00
abba330463
Bug 1576949 - Clicking the Editor Run button when input has text selection only evaluate selected text. r=Honza.
...
This is done by modifying the evaluateExpression action,
where we retrieve the selection of the full input.
Differential Revision: https://phabricator.services.mozilla.com/D43750
--HG--
extra : moz-landing-system : lando
2019-08-30 08:55:09 +00:00
233a01c078
Bug 1535451 - Fix browser_webconsole_trackingprotection_errors.js intermittent. r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D44112
--HG--
extra : moz-landing-system : lando
2019-08-30 08:39:26 +00:00
40a208612e
Bug 1577409 - Move natural-sort helper to fix Storage panel in remote debugging r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D43922
--HG--
rename : devtools/client/shared/natural-sort.js => devtools/shared/natural-sort.js
extra : moz-landing-system : lando
2019-08-30 07:43:12 +00:00
4c04690578
Bug 1567200 - Add telemetry for simulation menu usage, r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D42254
--HG--
extra : moz-landing-system : lando
2019-08-30 03:14:51 +00:00
55b657cc4d
Bug 1543782: Add test for the shortcut key which shows the suggest completion popup. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43723
--HG--
extra : moz-landing-system : lando
2019-08-30 03:15:13 +00:00
db9b78e4a5
Bug 1543782: Add tests in case of empty. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43722
--HG--
extra : moz-landing-system : lando
2019-08-30 03:15:06 +00:00
cfdc89eea3
Bug 1543782: Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43721
--HG--
extra : moz-landing-system : lando
2019-08-30 03:14:57 +00:00
b70e8558dd
Bug 1543782: Show the suggestions when user presses ctrl+space. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43720
--HG--
extra : moz-landing-system : lando
2019-08-30 03:14:55 +00:00
261e5bbfea
Bug 1543782: Show the suggestions in case that the css value becomes empty. r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43719
--HG--
extra : moz-landing-system : lando
2019-08-30 03:14:53 +00:00
187b9f7d6d
Bug 1577268 - Add vue extension to list of javascript mode extensions r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43981
--HG--
extra : moz-landing-system : lando
2019-08-30 00:44:31 +00:00
b1d2b988c9
Bug 1577081 - Make blackbox work from frame context menu r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43973
--HG--
extra : moz-landing-system : lando
2019-08-29 20:50:10 +00:00
257da8f0d3
Backed out 2 changesets (bug 1575240) for failures in browser_inspector_menu-06-other.js CLOSED TREE
...
Backed out changeset 0667a378d933 (bug 1575240)
Backed out changeset 74fce607d8a7 (bug 1575240)
2019-08-30 00:35:13 +03:00
23311695cd
Bug 1575240 - inspect(x) should show x in the appropriate panel (fix lint). r=jlast
2019-08-29 23:57:37 +03:00
d056cd3a51
Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42747
--HG--
extra : moz-landing-system : lando
2019-08-29 20:40:14 +00:00
09941e303d
Bug 1577079 - Fix source download feature r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D44012
--HG--
extra : moz-landing-system : lando
2019-08-29 16:21:32 +00:00
ef037077c5
Bug 1571791 - "Step in" across an await expression jumps to unexpected places. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D42723
--HG--
extra : moz-landing-system : lando
2019-08-29 16:09:47 +00:00
afdfc5639c
Bug 1576604 - Avoid array indexes as identifiers for open accordion items in Layout; r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43834
--HG--
extra : moz-landing-system : lando
2019-08-29 15:56:01 +00:00
3a9a56b002
Bug 1577282 - Part 3: Convert Spectrum to ES6 Class. r=Maliha
...
Depends on D43979
Differential Revision: https://phabricator.services.mozilla.com/D43980
--HG--
extra : moz-landing-system : lando
2019-08-29 15:01:07 +00:00
bcd4446fba
Bug 1577282 - Part 2: Move functions outside of the Spectrum prototype. r=Maliha
...
Depends on D43978
Differential Revision: https://phabricator.services.mozilla.com/D43979
--HG--
extra : moz-landing-system : lando
2019-08-29 14:47:52 +00:00
8afc61ef29
Bug 1577282 - Part 1: Move the requires before the constants and format the markup. r=Maliha
...
Differential Revision: https://phabricator.services.mozilla.com/D43978
--HG--
extra : moz-landing-system : lando
2019-08-29 14:40:52 +00:00
2f132ce44f
Bug 1572484 - Add a mochitest for expanding content-originated logged object in browser console. r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D43266
--HG--
extra : moz-landing-system : lando
2019-08-29 15:33:31 +00:00
56033d41ed
Bug 1577431 - Cleanup Browser Console when closing its window. r=ochameau.
...
We store the created DebuggerClient when opening the Browser Console
so we can close it when closing the Browser Console window.
The Browser Console window `unload` event listener is moved out of
the BrowserConsole class to the BrowserConsoleManager, so we can close
the DebuggerClient when the window is closed (plus it makes more sense
to have it here since that's where we create the window).
Finally, functions that were inlined in toggleBrowserConsole are moved
as method of the BrowserConsoleManager for clarity.
Differential Revision: https://phabricator.services.mozilla.com/D43930
--HG--
extra : moz-landing-system : lando
2019-08-29 15:31:12 +00:00
0cfab94fcf
Bug 1534445 - Use same colors as webconsole warning messages in settings panel deprecation label. r=rcaliman .
...
In order to do this properly, we create new variable in
variables.css that hold the same values as the console-warning-*
variables we have in webconsole.css.
We take this as an opportunity to replace the box shadow on
the deprecation label by an outline. I think this was done
so the border doesn't take additional height, and outline
seems perfect for this job.
Differential Revision: https://phabricator.services.mozilla.com/D43933
--HG--
extra : moz-landing-system : lando
2019-08-29 15:03:51 +00:00
ce078800eb
Bug 1555770 - update badge icons to correspond to the score of the accessibility issue. r=fvsch
...
Differential Revision: https://phabricator.services.mozilla.com/D43812
--HG--
extra : moz-landing-system : lando
2019-08-29 13:55:47 +00:00
9d237bbf60
Bug 1555770 - update contrast FAIL icon in a11y panel sidebar checks section and in inspector color picker. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43811
--HG--
extra : moz-landing-system : lando
2019-08-29 13:45:58 +00:00
2d3572b6a5
Bug 1555770 - update contrast highlighter FAIL icon to red circle with ! similar to other audit types. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D43810
--HG--
extra : moz-landing-system : lando
2019-08-29 13:45:57 +00:00
8269474069
Bug 1576652 - Remove unused state in Debugger's Accordion component; r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43492
--HG--
extra : moz-landing-system : lando
2019-08-26 21:53:00 +00:00
973268af17
Bug 1564999 - Add menu with simulation options to the a11y panel, r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D38885
--HG--
extra : moz-landing-system : lando
2019-08-29 05:01:52 +00:00
deacf348f4
Bug 1564993 - Create simulator actor and front, r=yzen,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D38884
--HG--
extra : moz-landing-system : lando
2019-08-29 04:55:45 +00:00
ac9c3d58a3
Bug 1575786 - Use unprefixed user-select property in devtools CSS; r=ladybenko,jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43217
--HG--
extra : moz-landing-system : lando
2019-08-29 10:12:25 +00:00
7c790c6c81
Bug 1522572 - Move local tab specifics out of TargetMixin. r=jdescottes,yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D41854
--HG--
extra : moz-landing-system : lando
2019-08-28 16:06:22 +00:00
09ff0064f2
Bug 1576835 - Update DAMP test writing documentation r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D43580
--HG--
extra : moz-landing-system : lando
2019-08-29 06:22:18 +00:00
29a8e7b827
Backed out changeset d870fdbf200f (bug 1575240) for Devtools failures on devtools/client/webconsole/test/browser/browser_jsterm_inspect.js. CLOSED TREE
...
--HG--
extra : amend_source : bcbaf5bd6fa8882de2b7e6a9b616d694c9d23f9b
2019-08-29 05:55:23 +03:00
3ca49b4ce2
Bug 1577068 - Show full URL as tooltip in frames r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43713
--HG--
extra : moz-landing-system : lando
2019-08-28 23:13:23 +00:00
1566cfd5fb
Bug 1463118 - Implement telemetry for pausing r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43797
--HG--
extra : moz-landing-system : lando
2019-08-28 23:12:55 +00:00
697f70a6e8
Bug 1574041 - Generalize Debugger worker lifecycle management. r=davidwalsh
...
Differential Revision: https://phabricator.services.mozilla.com/D43619
--HG--
extra : moz-landing-system : lando
2019-08-29 01:22:25 +00:00
09a2bac412
Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42747
--HG--
extra : moz-landing-system : lando
2019-08-29 00:31:46 +00:00
1ebb0ed421
Bug 1570696 - Destroy Toolbox on TabClose event for local tab targets. r=jdescottes
...
Move disconnection message out of Toolbox class in favor of toolbox-init module
as that is specific to Toolbox loaded in a tab.
We do that in order to stop automatically destroying the toolbox when the
attached target is destroyed. This will help support switching to another target
when we navigate between two documents loaded in distinct processes.
We will now destroy the toolboxes for local tabs only when TabClose event
is fired.
Differential Revision: https://phabricator.services.mozilla.com/D40233
--HG--
extra : moz-landing-system : lando
2019-08-28 15:22:26 +00:00
c48dcf7d7c
Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
...
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.
Differential Revision: https://phabricator.services.mozilla.com/D35091
--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:45 +00:00
06a2578d2d
Backed out changeset 3853d8979a55 (bug 1575240) for Devtools on devtools/client/webconsole/test/browser/browser_jsterm_inspect.js
...
--HG--
extra : rebase_source : a9ffc17ade0874f515e44152d78af257c10df334
2019-08-28 22:08:26 +03:00
b09fe526aa
Backed out 4 changesets (bug 1510569) for build bustage. CLOSED TREE
...
Backed out changeset d7db6a1935ce (bug 1510569)
Backed out changeset 03b7cf756a7f (bug 1510569)
Backed out changeset fa318eec0e76 (bug 1510569)
Backed out changeset cecb17bd8c03 (bug 1510569)
2019-08-28 21:46:40 +03:00
e0d50ea7ce
Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
...
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.
Differential Revision: https://phabricator.services.mozilla.com/D35091
--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:23 +00:00
346739d4b9
Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43446
--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-28 13:09:17 +00:00
722e0fdc59
Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D43445
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:19 +00:00
00c46e63a1
Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43444
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:21 +00:00
f025c6403a
Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D43443
--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-28 13:09:23 +00:00
511b056b80
Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D43442
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:24 +00:00
7e80772a80
Bug 1568157 - Part 5: Move the NodePicker initialization into a getter. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D43567
--HG--
extra : moz-landing-system : lando
2019-08-28 12:03:30 +00:00
8a3245ac6c
Bug 1568157 - Part 4: Replace `toolbox.walker` with the contextual WalkerFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40317
--HG--
extra : moz-landing-system : lando
2019-08-28 11:54:42 +00:00
d28c64390c
Bug 1576092 - Fix the breadcrumbs' arrow border color for white theme r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43769
--HG--
extra : moz-landing-system : lando
2019-08-28 17:45:06 +00:00
b553db9b43
Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42747
--HG--
extra : moz-landing-system : lando
2019-08-28 12:04:49 +00:00
04f5f42266
Bug 1558417 - Add onboarding UI for Editor. r=Honza.
...
The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).
We take this as an opportunity to polish the Editor UI/wording
a bit.
Differential Revision: https://phabricator.services.mozilla.com/D43621
--HG--
rename : devtools/client/debugger/images/resume.svg => devtools/client/themes/images/webconsole/run.svg
extra : moz-landing-system : lando
2019-08-28 15:42:36 +00:00
32356aa004
Backed out changeset a5bc37462cee (bug 1576835) for codespell failure at writing-perf-tests.md on a CLOSED TREE
2019-08-28 18:21:45 +03:00
70788158ec
Bug 1558371 - Improve tooltip readability in dark mode r=pbro
...
Changed the color in `.devtools-tooltip-inactive-css` to match the color of the meatball menu
Differential Revision: https://phabricator.services.mozilla.com/D43756
--HG--
extra : moz-landing-system : lando
2019-08-28 14:48:22 +00:00
faf26174a7
Bug 1576835 - Update DAMP test writing documentation r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D43580
--HG--
extra : moz-landing-system : lando
2019-08-28 14:34:19 +00:00
ad32ef1d9a
Backed out changeset 9aa911cc3fcf (bug 1558417) for failing at browser_jsterm_editor_toolbar.js on a CLOSED TREE.
2019-08-28 17:12:00 +03:00
2646ae9c6d
Bug 1577092 - Remove connectTo* helpers in debugger-server and use connectors directly r=nchevobbe
...
Depends on D43728
Differential Revision: https://phabricator.services.mozilla.com/D43729
--HG--
extra : moz-landing-system : lando
2019-08-28 13:07:56 +00:00
e12432f70d
Bug 1577092 - Change devtools server connectors to expose connectTo functions r=nchevobbe
...
Depends on D43618
Differential Revision: https://phabricator.services.mozilla.com/D43728
--HG--
extra : moz-landing-system : lando
2019-08-28 13:07:40 +00:00
02e806d54a
Backed out 6 changesets (bug 1564968) by yzen's request CLOSED TREE
...
Backed out changeset 4b7516635108 (bug 1564968)
Backed out changeset c3227d4ff4b3 (bug 1564968)
Backed out changeset 868dbd59c79e (bug 1564968)
Backed out changeset db1a396ab58e (bug 1564968)
Backed out changeset e69163dc4683 (bug 1564968)
Backed out changeset c12857bc6980 (bug 1564968)
2019-08-28 16:06:23 +03:00
c094bf25b6
Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43446
--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-27 23:37:54 +00:00
411f447380
Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D43445
--HG--
extra : moz-landing-system : lando
2019-08-27 18:17:19 +00:00
195b0a1aaf
Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43444
--HG--
extra : moz-landing-system : lando
2019-08-27 23:34:29 +00:00
14f3ce0a9b
Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D43443
--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-27 18:06:41 +00:00
07581454e5
Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D43442
--HG--
extra : moz-landing-system : lando
2019-08-28 12:12:59 +00:00
8e89cc0eb6
Bug 1575872 - Part 2: Add Jest tests r=Ola
...
Differential Revision: https://phabricator.services.mozilla.com/D43638
--HG--
extra : moz-landing-system : lando
2019-08-28 10:49:57 +00:00
ef64830e0c
Bug 1575872 - Part 1: Render a list of issues (errors and warnings) in the Manifest r=Ola,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D43637
--HG--
rename : devtools/client/application/src/components/manifest/ManifestItemWarning.css => devtools/client/application/src/components/manifest/ManifestIssue.css
rename : devtools/client/application/src/components/manifest/ManifestItemWarning.js => devtools/client/application/src/components/manifest/ManifestIssue.js
extra : moz-landing-system : lando
2019-08-28 12:20:43 +00:00
db62899801
Bug 1558417 - Add onboarding UI for Editor. r=Honza.
...
The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).
We take this as an opportunity to polish the Editor UI/wording
a bit.
Differential Revision: https://phabricator.services.mozilla.com/D43621
--HG--
rename : devtools/client/debugger/images/resume.svg => devtools/client/themes/images/webconsole/run.svg
extra : moz-landing-system : lando
2019-08-28 11:47:49 +00:00
91d20d2982
Bug 1575557 - rename webExtension to webExtensionDescriptor; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D42867
--HG--
rename : devtools/server/actors/addon/webextension.js => devtools/server/actors/descriptors/webextension.js
rename : devtools/shared/fronts/addon/webextension.js => devtools/shared/fronts/descriptors/webextension.js
rename : devtools/shared/specs/addon/webextension.js => devtools/shared/specs/descriptors/webextension.js
extra : moz-landing-system : lando
2019-08-28 10:02:57 +00:00
207370a55c
Bug 1575557 - merge webextension-proxy with webextension; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D42866
--HG--
extra : moz-landing-system : lando
2019-08-28 10:06:27 +00:00
e7dd37593b
Bug 1522571 - Unify addonTargetFront with webExtensionSpec; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D42833
--HG--
extra : moz-landing-system : lando
2019-08-28 10:01:43 +00:00
e6b2d42978
Bug 1576487 - RTL fixes to the network details panel r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43359
--HG--
extra : moz-landing-system : lando
2019-08-28 08:04:35 +00:00
e38a987dd9
Bug 1576884 - TypeError: this.intersectionObserver is null. r=Honza
...
Fix edge case.
Differential Revision: https://phabricator.services.mozilla.com/D43634
--HG--
extra : moz-landing-system : lando
2019-08-28 07:20:53 +00:00
8a65fc4677
Bug 1557170 - Add isParentInterceptEnabled trait to ServiceWorkerRegistration actor r=daisuke
...
Differential Revision: https://phabricator.services.mozilla.com/D43598
--HG--
extra : moz-landing-system : lando
2019-08-28 06:38:47 +00:00
451bc0629c
Bug 1572671 - Don't load content process server startup script if it was already loaded. r=ochameau.
...
Previously, we were simply having a flag on the ContentProcessConnector
that we would flip once we loaded the content process server startup script.
This was working fine until multi-proxy browser console.
Each time we open the Browser Console, we create a new loader in a new
compartment. Which means in the end we'll have a new ContentProcessConnector
instance, and the flag would be resetted, and thus we would load a new
content process server startup script, which finally, would emit some
packet twice, and thus would break how we manage new packet in the client.
This patch fixes that by replacing the flag by checking if the script
was already loaded.
Differential Revision: https://phabricator.services.mozilla.com/D43618
--HG--
extra : moz-landing-system : lando
2019-08-28 06:37:18 +00:00
74b4cd5282
Bug 1576841 - Enable multi-proxy WebConsole in Browser Toolbox when fission pref is true. r=ochameau.
...
We remove the multiple this.fissionSupport properties to only check
the permission in the couple place we need it.
Differential Revision: https://phabricator.services.mozilla.com/D43585
--HG--
extra : moz-landing-system : lando
2019-08-27 17:41:29 +00:00
08bc01ab37
Bug 1576814 - Skip tests that timeout r=kmag
...
Depends on D43572
Differential Revision: https://phabricator.services.mozilla.com/D43573
--HG--
extra : moz-landing-system : lando
2019-08-27 19:07:43 +00:00
22abd7da9b
Bug 1576814 - Remove fail-if tests that are now passing r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D43571
--HG--
extra : moz-landing-system : lando
2019-08-27 19:05:41 +00:00
ef58a63b92
Bug 1576165 - Prevent react warning in inline preview r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43647
--HG--
extra : moz-landing-system : lando
2019-08-28 01:24:15 +00:00
2bbe6fef7a
Bug 1576679 - Turn on inline preview by default r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43490
--HG--
extra : moz-landing-system : lando
2019-08-27 21:48:49 +00:00
fdbeea9b5f
Bug 1555333 - Toggle skipPausing when adding or enabling a breakpoint via reducers r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43512
--HG--
extra : moz-landing-system : lando
2019-08-27 20:51:10 +00:00
4ba1487439
Bug 1540117 - Part 5: Fix browser_webconsole_warning_group_content_blocking.js too by ensuring that the test image does set a cookie. r=fix CLOSED TREE
...
Differential Revision: https://phabricator.services.mozilla.com//D43671
--HG--
extra : histedit_source : c0cb5631e5195fe73d19dc36813efc3bf6284f25
2019-08-27 23:39:59 +03:00
006d44d6b7
Bug 1568157 - Part 3: Replace `toolbox.highlighter` with the contextual HighlighterFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40316
--HG--
extra : moz-landing-system : lando
2019-08-27 19:13:45 +00:00
341d06e6a0
Bug 1576586 - Enable all about:debugging tests with fission. r=jdescottes,kmag
...
All these tests seem to work fine with Fission.
Differential Revision: https://phabricator.services.mozilla.com/D43401
--HG--
extra : moz-landing-system : lando
2019-08-27 18:14:39 +00:00
933f7160c5
Bug 1573316 - RDM controls are off-center (when in centered mode) r=gl
...
Added a CSS selector to aid in centering RDM controls
Differential Revision: https://phabricator.services.mozilla.com/D43067
--HG--
extra : moz-landing-system : lando
2019-08-27 18:41:57 +00:00
73345dc559
Bug 1540117 - Part 4: Fix browser_webconsole_trackingprotection_errors.js by ensuring that the test page does set a cookie. r=fix CLOSED TREE
...
Differential Revision: https://phabricator.services.mozilla.com//D43652
--HG--
extra : histedit_source : 296fb0ecbd7b1540bba93ea1d8490629a04fa91a
2019-08-27 21:27:50 +03:00
e5b0947fe7
Bug 1574053 - allow shift-click to disable column breakpoints.
...
Allow user to disable column breakpoints with shift-click. Added mochitests to reinforce. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D43326
--HG--
extra : moz-landing-system : lando
2019-08-27 16:29:19 +00:00
d98ef83ed4
Bug 1576844 - Add a tabDetached even in content-process spec. r=yulia.
...
This event is sent from the content-process-connector in the server,
and not having it declared in the spec was causing unknown packets
error messages.
Differential Revision: https://phabricator.services.mozilla.com/D43587
--HG--
extra : moz-landing-system : lando
2019-08-27 16:36:55 +00:00
53359e3391
Bug 1097836 - Give users on Windows the choice between POSIX and Windows escaped "Copy as cURL" commands. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D42699
--HG--
extra : moz-landing-system : lando
2019-08-27 14:46:33 +00:00
ed8443d555
Bug 1575237 - Initial implementation of search for top level documents in the inspector; r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D42662
--HG--
extra : moz-landing-system : lando
2019-08-26 18:38:01 +00:00
49511b6da8
Bug 1575237 - allow access to all remote child targets' inspector fronts from the root target r=pbro,rcaliman
...
inspector front; r=!ochameau,!pbro"
Differential Revision: https://phabricator.services.mozilla.com/D43432
--HG--
extra : moz-landing-system : lando
2019-08-27 14:42:38 +00:00
ef33fe249c
Bug 1575827 - Remove references to outdated DevToolsColors MDN page; r=pbro
...
Differential Revision: https://phabricator.services.mozilla.com/D43227
--HG--
extra : moz-landing-system : lando
2019-08-27 10:21:34 +00:00
9bbc3376d9
Bug 1574159 - implement listRemoteFrames for browsingContextTarget and listRemoteTab for content process; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D42327
--HG--
extra : moz-landing-system : lando
2019-08-27 09:07:46 +00:00
7ad7d8e5c0
Bug 1574156 - implement FrameDescriptor; r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D42305
--HG--
extra : moz-landing-system : lando
2019-08-27 09:07:45 +00:00
3cdbe7c9b8
Bug 1576653 - Use a custom toolbox window title for the omniscient browser toolbox r=nchevobbe,yulia
...
Depends on D43473
Differential Revision: https://phabricator.services.mozilla.com/D43478
--HG--
extra : moz-landing-system : lando
2019-08-27 08:44:59 +00:00
1535cd608a
Bug 1576653 - Add nightly-only option to toggle devtools.browsertoolbox.fission in Browser Toolbox r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D43473
--HG--
extra : moz-landing-system : lando
2019-08-27 08:44:42 +00:00
6369cc4e7c
Bug 1575930 - Add tool-tip in search results panel. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43149
--HG--
extra : moz-landing-system : lando
2019-08-27 06:50:17 +00:00
cc7e5a59ed
Bug 1503870 - Should look good in dark mode. r=bhackett
...
Differential Revision: https://phabricator.services.mozilla.com/D43349
--HG--
extra : moz-landing-system : lando
2019-08-26 21:14:43 +00:00
00d77f3385
Bug 1574190 - Add server support for watchpoints. r=jlast
...
Lint and add test.
Add server support for watchpoints.
Differential Revision: https://phabricator.services.mozilla.com/D42926
--HG--
extra : moz-landing-system : lando
2019-08-22 22:33:08 +00:00
b08f3b6b26
Bug 1576219 - Enable DOM Mutation Breakpoints r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43273
--HG--
extra : moz-landing-system : lando
2019-08-26 20:19:39 +00:00
2fbbcd3de9
Bug 1574502 - Sidebar panels should be collapsed by default. r=davidwalsh
...
Differential Revision: https://phabricator.services.mozilla.com/D42317
--HG--
extra : moz-landing-system : lando
2019-08-26 20:11:52 +00:00
cb40a7376a
Bug 1566754 - Support for SockJS protocol. r=Honza,mhoye
...
Supports parsing SockJS WebSocket frames.
Differential Revision: https://phabricator.services.mozilla.com/D41086
--HG--
extra : moz-landing-system : lando
2019-08-26 18:49:31 +00:00
77056e86ec
Bug 1576660 - Don't allow wrapping of inline preview items r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43482
--HG--
extra : moz-landing-system : lando
2019-08-26 18:04:52 +00:00
6b7371cdb7
Bug 1575032 - Fix the Storage Inspector's variables element details panel for RTL r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42550
--HG--
extra : moz-landing-system : lando
2019-08-26 15:45:09 +00:00
e2874c0b8b
Bug 1575499 - Part 4: Add Jest tests r=Ola
...
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
This adds some Jest tests for the components.
NOTE: tests for warnings will be handled in this other bug https://bugzilla.mozilla.org/show_bug.cgi?id=1575872
Differential Revision: https://phabricator.services.mozilla.com/D43232
--HG--
extra : moz-landing-system : lando
2019-08-26 12:30:38 +00:00
62d81c33b2
Bug 1575499 - Part 3: UI fixes and CSS refactor r=Ola
...
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
- Put style rules into their own components stylesheet.
- Used theme-related colors instead of the same ones for both dark and light themes.
- Made selectors to be class-specific (so they have low specificity)
- Removed some unused CSS in `base.css`
- Fix extra blank space when a section of the manifest is empty (made the hardcoded icons array empty so this can be seen)
NOTE: The CSS/markup for the warnings will be handled in https://bugzilla.mozilla.org/show_bug.cgi?id=1575872
Differential Revision: https://phabricator.services.mozilla.com/D43231
--HG--
rename : devtools/client/application/src/components/manifest/Manifest.css => devtools/client/application/src/components/manifest/ManifestSection.css
extra : moz-landing-system : lando
2019-08-26 14:42:38 +00:00
1033de808b
Bug 1575499 - Part 2: Avoid duplicated code r=Ola
...
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
- Made each "chunk"/category of the Manifest a single component (`ManifestSection`)
- Removed the `ManifestItemIcon`, etc. to favor a single component that can used later on to provide the common layout for the different value types (strings, colors, images…) we might add in the future.
- Decoupled a bit more the props from the raw manifest object we get from platform, so it's more flexible and we don't do array transformations every time the component needs to render.
NOTE: `ManifestItemWarning` still presents some duplication. This will be handled in this other bug https://bugzilla.mozilla.org/show_bug.cgi?id=1575872
Differential Revision: https://phabricator.services.mozilla.com/D43230
--HG--
extra : moz-landing-system : lando
2019-08-26 10:15:18 +00:00
20f700885f
Bug 1575499 - Part 1: Rename ManifestView to Manifest r=Ola
...
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
`*View` suffixes are sometimes used in JS frameworks context in the same sense we use our `*Page` suffix in here. To avoid confusion –and to have a shorter name– I renamed components to just `Manifest*`
Differential Revision: https://phabricator.services.mozilla.com/D43229
--HG--
rename : devtools/client/application/src/components/manifest/ManifestView.css => devtools/client/application/src/components/manifest/Manifest.css
rename : devtools/client/application/src/components/manifest/ManifestView.js => devtools/client/application/src/components/manifest/Manifest.js
rename : devtools/client/application/src/components/manifest/ManifestViewEmpty.js => devtools/client/application/src/components/manifest/ManifestEmpty.js
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestView.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestViewEmpty.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestView.test.js => devtools/client/application/test/components/manifest/components_application_panel-Manifest.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestViewEmpty.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestEmpty.test.js
extra : moz-landing-system : lando
2019-08-26 12:31:10 +00:00
d678a3d0da
Bug 1576563 - Evaluate selected text if a selection exists in console input. r=Honza.
...
This is something Scratchpad allowed and that people
told me they were relying on. With Scratchpad being
deprecated, it makes sense to implement it in the
WebConsole as it's quite easy to do so.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D43394
--HG--
extra : moz-landing-system : lando
2019-08-26 14:28:38 +00:00
944fa1df74
Bug 1575573 - Show addon icon in breakpoints pane r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43070
--HG--
extra : moz-landing-system : lando
2019-08-23 18:33:55 +00:00
516ccd19a8
Bug 1555638 - Telemetry for WS monitoring. r=Honza
...
Add telemetry for WS monitoring.
Differential Revision: https://phabricator.services.mozilla.com/D42799
--HG--
extra : moz-landing-system : lando
2019-08-26 12:34:14 +00:00
7f5a19c884
Bug 1576085 - Don't allow evaluation results to be repeated. r=Honza.
...
With top-level await, we can now have multiple
evaluation results next to each others. Which
means that if they had the same repeatId, we
would only print the first result.
We fix that by not allowing evaluation results to
be repeated.
A mochitest is added to ensure the patch properly
fixes the issue.
Differential Revision: https://phabricator.services.mozilla.com/D43253
--HG--
extra : moz-landing-system : lando
2019-08-26 11:18:50 +00:00
afa82e0ecb
Bug 1575548 - Enable websockets in netmonitor's browser_net_ws-* tests to prevent them from failing on non-central branches. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43298
--HG--
extra : moz-landing-system : lando
2019-08-26 09:19:35 +00:00
66a26ccca9
Bug 1572332 - Move non-debugger devtools prefs into all.js and firefox.js. r=jdescottes
...
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41145
--HG--
extra : moz-landing-system : lando
2019-08-26 01:44:59 +00:00
e4dcb9887c
Bug 1575097 Part 6: Change RDM test helper function to check innerWidth instead of screen.width. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43131
--HG--
extra : moz-landing-system : lando
2019-08-25 23:56:04 +00:00
f40bd42907
Bug 1575097 Part 5: Update test to check outerWidth and screen.width and device-width media queries with meta viewport on. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D42748
--HG--
extra : moz-landing-system : lando
2019-08-25 23:54:48 +00:00
8d4c428010
Bug 1575058 - Fix assorted bugs with showing errors in the console while replaying, r=loganfsmyth.
...
Differential Revision: https://phabricator.services.mozilla.com/D42704
--HG--
extra : moz-landing-system : lando
2019-08-24 23:54:33 +00:00
611fa8b9db
Bug 1575056 - Control record/replay logging with preference, r=loganfsmyth.
...
Differential Revision: https://phabricator.services.mozilla.com/D42556
--HG--
extra : moz-landing-system : lando
2019-08-24 23:34:11 +00:00
8dfc47da59
Bug 1573507 - Improve inline preview values with reps, r=davidwalsh,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D42334
--HG--
extra : moz-landing-system : lando
2019-08-23 20:21:43 +00:00
9da1dae408
Bug 1576230 - class should be className in UserAgentInput. r=bradwerth
...
Differential Revision: https://phabricator.services.mozilla.com/D43274
--HG--
extra : moz-landing-system : lando
2019-08-23 17:52:03 +00:00
Julian Descottes
Nicolas Chevobbe
lloan
Emilio Cobos Álvarez
janelledement
Jason Laster
chujun
Megan Bailey
Maliha Islam
arthur.iakab
Noemi Erli
Razvan Maries
Greg Tatum
David Walsh
Markus Stange
Emma Malysz
Jean-Yves Avenard
Cosmin Sabou
yulia
Florens Verschelde
Yura Zenevich
monikamaheshwari
Belén Albeza
Daisuke Akatsuka
Brian Hackett
Coroiu Cristina
Brad Werth
Gurzau Raul
tanhengyeow
Sebastian Hengst
Razvan Caliman
Patrick Brosset
Brindusan Cristian
Gabriel Luong
Alexandre Poirot
Dorel Luca
Barret Rennie
Itiel
Krishnal Ciccolella
Bogdan Tara
Paul Bone
Ehsan Akhgari
Alex Rosenfeld
goncharov
Miriam
Nicholas Nethercote
Dhyey Thakore