96fcd3875f
Bug 1311277 Part 2 - Add move assignment for LinkedListElement and LinkedList. r=froydnj
...
MozReview-Commit-ID: 7NjbxamX87U
--HG--
extra : rebase_source : 578c72ee7eff740f7e7dcfd95f38f3ca8d1045a8
2016-10-19 13:30:51 +08:00
dcc36e9067
Bug 1311277 Part 1 - Convert |other| argument to Mozilla coding style. r=froydnj
...
MozReview-Commit-ID: JcEloAe5dlA
--HG--
extra : rebase_source : 8bc712551d1a0b8f4c1aec1dafc9e4fb2c5861e0
2016-10-19 13:24:23 +08:00
d1108c1e52
Bug 1311068 - remove InitializerList.h; r=botond
...
We needed this polyfill for <initializer_list> when some of our C++
standard libraries did not support said header. They all do now, so the
polyfill is redundant.
2016-10-19 00:33:14 -04:00
19d7f7bb03
Bug 1290337 - Part 22: Add moz_non_param annotation. r=ehsan,jwalden
2016-09-11 18:23:11 +09:00
de8974994d
Bug 1299284 - Remove js::IsPowerOfTwo in favor of mozilla::IsPowerOfTwo. r=sfink
...
--HG--
extra : rebase_source : c9d695c25c9e53d7b86d9718611718af9fea8598
2016-07-21 00:36:38 -07:00
cdcc9e20da
Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop
...
MozReview-Commit-ID: 1lCt0xTMV5O
2016-10-08 11:14:49 +02:00
3e934c8f5c
Bug 1305791 - Clear result.mSegments if MoveFallible failed. r=billm
...
MozReview-Commit-ID: 8UaGt1OEfhh
--HG--
extra : rebase_source : c084812d2e4d8633d049638dcd55b0b97db2c603
2016-09-30 17:37:44 +08:00
8240adec88
Bug 1230311 - add annotation to enforce that if a method is overridden also base method is called. r=nfroyd
...
MozReview-Commit-ID: AQ3Kx2qidU0
2016-10-04 17:00:17 +03:00
76b800594e
Backed out changeset d85334f696eb (bug 1285057) for implicitly depending on clang 3.8.
...
--HG--
extra : rebase_source : 472f9411c9d528d63d523c99f4842a1216bdd560
2016-09-23 15:59:55 -07:00
b605dece0c
Bug 1285057 - Blacklist UBSan detection of the GC's generic interfaces; r=sfink
...
--HG--
extra : rebase_source : f5367a8685ec462edb7e30e5ed3d274b4a9bcd0f
2016-07-07 08:59:36 -07:00
7d4ca9c88b
Bug 1303302 - Add IsDestructible trait in TypeTraits and use it for refcounted type static check. r=froydnj
...
MozReview-Commit-ID: G3YFhrJngq0
--HG--
extra : rebase_source : da0aa325eb7772c1a156440ed46be9d0d429c91e
2016-09-16 17:23:55 +10:00
6fcfa1f00e
Bug 1302233 - Introduce VsprintfLiteral to mfbt. r=froydnj
2016-09-14 20:48:45 +02:00
28d8553d1d
Bug 1299379 - Add MOZ_CONCAT for preprocessor token pasting. r=waldo
2016-09-11 15:49:50 +02:00
5cbc382303
Merge inbound to m-c a=merge
2016-09-07 17:54:24 -07:00
36e08437d0
Bug 1018486 - Part 8: Various other changes, r=smaug
...
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
722ad026a3
Bug 1297306 - part4:rename IsEnumFittingWithin with EnumTypeFitsWithin and move it to mfbt/EnumTypeTraits.h. r=froydnj
...
With this change, we could share this EnumTypeTraits between files easily.
MozReview-Commit-ID: 9Q2augati7l
--HG--
extra : rebase_source : b7d9fc95d9d7722ba3eb99ec9798a64ebdbeb484
2016-09-07 10:20:16 +08:00
99748028a6
Bug 1051567 - Make sure we resend file descriptors for the first chunk of a message. r=billm
...
Check if the buffers iterator was never consumed. This is a regression
introduced when converting ipc to use BufferList in bug 1262671.
MozReview-Commit-ID: LWAoVlI5CKJ
--HG--
extra : rebase_source : c4f16f4f90f56153c10cf1d9113c4c55748595f0
2016-08-30 18:26:59 +08:00
5a1fd6c4d4
Bug 525063 - add attribute to mark functions that initialize member variables for their parent class, in order to be scanned by clang-plugin static analysis. r=froydnj
...
MozReview-Commit-ID: 5yTnTUVLpSC
2016-08-30 10:07:03 +03:00
0b2d2c0e55
Bug 1120059 - Remove unnecessary MOZ_EXPLICIT_CONVERSION macros. r=jwalden
...
MozReview-Commit-ID: 7CX1VnBRDpk
--HG--
extra : rebase_source : 36be7e6c91d2767c5a610a2806f89efa69ff1c74
2016-07-13 15:07:52 -07:00
e4eacf065d
Bug 956338 - Add checks to WeakPtr/nsWeakReference and related classes to assert single-thread usage. r=nfroyd
...
--HG--
extra : rebase_source : 140fa149eb94f027e9319a44be0bbee34648222a
2016-08-01 13:16:16 +02:00
1c0c6ec5d4
Merge m-c to inbound. a=merge
2016-08-29 12:56:19 -04:00
c49f09db99
Bug 1297981 - Delete BufferList::FlattenBytes and Pickle::FlattenBytes. r=billm
...
MozReview-Commit-ID: G3a4DN4Lovi
--HG--
extra : rebase_source : 17818efb7578117b708636d06e6a2f5d14532c94
2016-08-25 17:15:38 +08:00
34e7d5b132
Bug 1296760 - Allow Some(nullptr) and Some(Derived*) to convert to Maybe<Base*>. r=froydnj
...
--HG--
extra : rebase_source : 478e825f476a671e07a94f483b88cbc2d4ae8d13
2016-08-24 11:12:48 -07:00
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
506dfe6ea3
Bug 1264642 - Part 4. Use BufferList to replace raw buffers in StructuredClone. r=baku r=billm r=jorendorff
...
In JS StructuredClone BufferList<SystemAllocPolicy> is typedef'd to
JSStructuredCloneData and use everywhere in gecko that stores structured
clone data.
This patch changed some raw pointers to UniquePtr<JSStructuredCloneData>
and some to stack allocated JSStructuredCloneData for better life time
management. Some parameters or methods are deleted because of changing
to the new data structure.
MessagePortMessage now has the exactly same structure with
ClonedMessageData. Maybe in the future they can be consolidated.
MozReview-Commit-ID: 1IY9p5eKLgv
2016-08-23 00:40:46 +08:00
3dcef6a932
Bug 1264642 - Part 3. Add BufferList::MoveFallible. r=billm
...
It works like a move constructor but it's fallible. It can also move
data to different but compatible AllocPolicy.
MozReview-Commit-ID: LAbPWCwnrr6
2016-08-23 00:40:46 +08:00
6f3e6b1234
Bug 1264642 - Part 2. Add BufferList::Extract and Pickle::ExtractBuffers. r=billm
...
These methods allow us to move some buffers out of a pickle with minimum
copying. It's useful when the IPC deserialized type uses BufferList to
store data and we want to take the buffers from IPC directly.
Borrowing is not suitable to use for IPC to hand out data because we
often want to store the data somewhere for processing after IPC has
released the underlying buffers.
MozReview-Commit-ID: F1K2ZMkACqq
2016-08-23 00:40:45 +08:00
e1fc3b1773
Bug 1159244 - Add release mode bounds checking with custom annotations to nsTArray, r=froydnj
...
MozReview-Commit-ID: Ljx9PwBCyTT
2016-08-15 13:29:45 -04:00
175543fda8
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
a57972337d
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
0c5ac6c90f
Bug 1294537 - Don't tag |void* p| in the don't-nullcheck placement operator new overload as MOZ_NONNULL, because that makes a double-checking assertion of non-nullness into a compiler warning. r=froydnj
...
--HG--
extra : rebase_source : b53a1c5dce924ea030f54bb41e13baf27cd3d823
2016-08-12 18:02:03 -07:00
0a6a801dc2
Bug 1294537 - introduce a non-null-checking placement operator new; r=sunfish,nbp
...
The default placement operator new is defined to always require that its
result be null-checked. A sufficiently smart compiler can remove this
check, but not all compilers are sufficiently smart. Better to have a
custom placement operator new that will remove null checks in a way
defined by the standard.
2016-08-12 22:43:49 -04:00
42824df666
Bug 1197324 - add format-string checking attribute to snprintf_literal. r=froydnj
2016-08-03 14:37:31 +02:00
23575fdec5
Bug 1248555: Introduce variants of SpecificNaN / BitwiseCast that preserve the signaling NaN bit; r=froydnj
...
MozReview-Commit-ID: 5A8p06nBqyI
--HG--
extra : rebase_source : 87ebcc9792d42c6b2e6164a639340da37b4b602c
extra : histedit_source : b4ab7c6b9f4bb7fe2cc88a3208d6fa8e6fefce08
2016-08-01 20:02:05 +02:00
489e357178
Bug 1291423: Explicitly qualify the destructor call that we invoke in Maybe::reset. r=Waldo
...
MozReview-Commit-ID: 6vQouBSxnsZ
2016-08-02 21:19:08 -07:00
9fc9590608
Bug 1289990 - Remove VS2013 workaround for TestTuple.cpp crash. r=froydnj
...
--HG--
extra : rebase_source : c5138bb0ea6a77b04030074ecebd85ba0808afa3
2016-07-27 23:13:08 -07:00
fdb4542277
Bug 1290035 - Remove the explicit Type parameter to MakeEnumeratedRange. r=Waldo
...
MozReview-Commit-ID: BtFVn9pTQpU
--HG--
extra : rebase_source : be83c74953e2fbc7ace2ce49ceebb060da394c50
2016-07-28 17:48:50 +08:00
79a0735001
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 6dFygYzTYfN
2016-07-25 16:57:30 +03:00
1feda59958
Backed out changeset 9c839b1d1397 (bug 1283395) for static build bustage CLOSED TREE
2016-07-25 08:54:47 -07:00
440264fed8
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 6dFygYzTYfN
2016-07-25 17:43:14 +03:00
6dad001d7f
Bug 1238661 - fix mozilla::SignalTrampoline to work properly with clang; r=darchons
...
mozilla::SignalTrampoline is designed to work around a bug in older ARM
kernels; it constructs a trampoline function with a NOP slide and then
calls a specified function. This feat is accomplished using inline
assembly and naked functions, which is a GCC extension where you get to
write the entire body of your function using GCC inline assembly.
Unfortunately, the particular implementation that it uses requires the
specified function's address to be loaded into a register. GCC permits
this and we use input arguments to the assembly statement to ensure that
GCC knows it shouldn't clobber the incoming argument registers when
trying to load the function's address.
clang, however, complains about the use of input parameters in naked
functions. So we need to find something that will work on both GCC and
clang.
The trick is to realize that we're a) tail-calling the specified
function and b) we don't have to worry about calling a fully-general
function. We just have to worry about calling a function inside libxul,
and we can therefore "assume" that the offset between the branch and the
called function fits into the immediate field of a Thumb (or ARM) branch
instruction. (This assumption is not strictly true; the branch range is
+/-16MB or so and libxul is actually quite a bit bigger than that. But
it works in practice, and the linker will insert branch stubs if
necessary to make things work out OK.)
The upshot is that we can use a "b" instruction instead of a "bx"
instruction, and this makes clang much happier. As a small bonus, the
stub gets ever-so-much-more efficient, which is probably the
least-significant micro-optimization ever.
2016-07-25 18:16:06 -04:00
b0efbe0ef8
Bug 1288603 - Remove NumericLimits.h because all platforms have numeric_limits<char16_t>. r=froydnj
2016-07-22 22:05:45 -07:00
336105a0de
merge mozilla-inbound to mozilla-central a=merge
2016-07-22 11:58:02 +02:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
d634a99cad
Bug 1277106 - Part 4: Remove MOZ_UTF16() macro. r=Waldo
2016-07-19 21:07:53 -07:00
8949f73d27
Bug 1277106 - Part 1: Use VS2015's real char16_t instead of aliasing wchar_t. r=Waldo
...
and remove MOZ_CHAR16_IS_NOT_WCHAR #ifdefs.
2016-07-20 22:01:43 -07:00
718ce69fb7
Backed out changeset c8e5a0703821 (bug 1283395) for bustage on a CLOSED TREE
2016-07-21 08:13:06 +02:00
d2d46ad585
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 1F5GGpQtq4x
2016-07-20 15:45:34 +03:00
3bba9b339e
Backed out 5 changesets (bug 1287623) for static build bustage CLOSED TREE
...
Backed out changeset a48daec87ec9 (bug 1287623)
Backed out changeset 248153344e15 (bug 1287623)
Backed out changeset 8aa409c9b1ce (bug 1287623)
Backed out changeset 602d4d88e806 (bug 1287623)
Backed out changeset 114da8bdc0b0 (bug 1287623)
2016-07-20 15:40:33 -07:00
155e619376
Bug 1287623, part 3 - Add more methods involving StaticRefPtr. r=froydnj
...
This patch adds a number of standard conversions to and from RefPtr<>
and already_AddRefed<>.
2016-07-20 15:19:00 -07:00
a5a3cca3f9
Bug 1287623, part 3 - Add more methods involving StaticRefPtr. r=froydnj
...
This patch adds a number of standard conversions to and from RefPtr<>
and already_AddRefed<>.
2016-07-21 09:54:17 -07:00
efea1b6545
Bug 1287243 - Optimize the type used to store Variant's tag. r=fitzgen
...
--HG--
extra : rebase_source : c7c6fd63ea50330958ef794dc28cc8890ef59bbe
2016-07-16 02:31:45 -07:00
1fe18b25cf
Bug 1232686 - Use decltype to infer Variant::match return type; r=fitzgen
...
--HG--
extra : rebase_source : 38f280cc3014b2285a79e377f1fa8edf4c5f4661
2015-12-15 07:45:22 -08:00
c329f132b7
Bug 1276573 - Add a new constructor for Range<T>. r=Waldo
...
These new constructor accepts two RangedPtr<T> arguments.
MozReview-Commit-ID: 8a3bYserLMr
--HG--
extra : rebase_source : 216de17b7a51783fe48d604b432d4dc7df6ad6eb
2016-05-30 13:58:13 +08:00
43c2748f66
Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
2016-07-08 14:39:53 -07:00
2b3b60f7b1
Bug 1277155 - Part 1: Remove snprintf() polyfills for VS2013 in Sprintf.h and #defines. r=froydnj r=mhowell
2016-06-27 20:45:03 -07:00
ab7252caa2
Bug 1267918 - Add do_AddRef(const RefPtr<T>& aObj). r=froydnj
...
This means we can return already_AddRefed<T> for any RefPtr<T>s
being held as instance variables easier.
MozReview-Commit-ID: HFHdkF8EUsK
--HG--
extra : rebase_source : df650d39c010386afcb8cb2dd48292c26fbc6501
2016-06-30 10:06:10 +12:00
e20f0f4551
Bug 1282795 - Silence warnings when MOZ_ALWAYS_{TRUE,FALSE} are passed expressions with embedded side effects, that would ordinarily trigger side effects but don't inside certain unevaluated contexts within MOZ_ASSERT, which then triggers compiler warnings with new-enough clang. You are not expected to understand this. r=froydnj
...
--HG--
extra : rebase_source : ffe6d35af74c50b04dbddc9cc3965292875c64a0
2016-06-28 17:12:14 +01:00
5e3fc1519f
Bug 525063 - renamed MOZ_INITIALIZED_OUTSIDE_CONSTRUCTOR -> MOZ_INIT_OUTSIDE_CTOR. r=nfroyd
...
MozReview-Commit-ID: GPQY8b2OM2V
2016-06-28 16:30:49 +03:00
a2712d4b0e
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-22 16:32:40 -07:00
c46c20b362
Backed out changeset 7b03f23fdde5 (bug 1255632) for bustage on a CLOSED TREE
2016-06-22 08:48:25 +02:00
358b410aaa
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-21 22:15:27 -07:00
fa9fafb015
Bug 1277896 - add Vector::initLengthUninitialized (r=waldo)
...
MozReview-Commit-ID: He6Kzr0giLU
2016-06-10 13:28:04 -05:00
6b6f143161
Bug 1278391 - add move constructor to EnumeratedArray (r=njn)
...
MozReview-Commit-ID: AQjH3xx9TSq
--HG--
extra : rebase_source : 599dc2bf76fa2921de6bf3b41c7d384db70a7ff9
2016-06-09 08:42:16 -05:00
12bac0f757
Bug 525063 - add attribute to mark member variables that should be skipped by clang plugin initialization checker. r=nfroyd
...
MozReview-Commit-ID: 4V1YcK2thiF
2016-06-09 09:32:11 +03:00
c735dfa442
Bug 1278201 - prevent writing |mRefCnt| after it's freed. r=Ms2ger
...
MozReview-Commit-ID: G7fZzrGWHmW
--HG--
extra : rebase_source : 6f311948a8d2222358aec860f2c6d6223862e814
2016-06-06 17:23:10 +03:00
97c2e11d8c
Bug 1273048 - Add MOZ_GCC_VERSION_AT_MOST macro. r=froydnj
...
MozReview-Commit-ID: 4VjAra5B6GM
--HG--
extra : transplant_source : %D3%C7C%05%7EB%24%90q%D3%22%C8%F5%8F%C7%C3%B4%00%A6%E2
2016-06-03 20:08:41 -07:00
acc84881a2
Bug 1277740 - Add const to RangedPtr<T>::operator+ and operator-. r=Waldo
...
MozReview-Commit-ID: FlHmq5eh5ph
--HG--
extra : rebase_source : 7e8939f0a9531426fa8fa742351d47f1d2351e72
2016-06-03 12:16:33 +08:00
4b68d2e1e4
Bug 1276550 - Support operator-> for RangedPtr. r=Waldo
...
MozReview-Commit-ID: EiOfo7ly34P
--HG--
extra : rebase_source : 6acbd9b3b6681f5c777e779713a21e8f808b89bf
2016-05-30 11:55:57 +08:00
e574e0eda0
Bug 1277377 - prevent unsafe C-style cast in Vector (r=waldo)
...
MozReview-Commit-ID: L0bTDSBHOeY
2016-06-02 14:38:02 -05:00
b3d842431f
Bug 1272203 (part 1) - Add mozilla::NotNull to MFBT. r=froydnj.
...
This patch implements mozilla::NotNull, which is similar but not identicial to
gsl::not_null.
The current draft(?) implementation of gsl::not_null is at
https://github.com/Microsoft/GSL/blob/master/include/gsl.h .
The main difference is that not_null allows implicit conversion from T to
not_null<T>. In contrast, NotNull only allows explicit conversion from T to
NotNull<T> via WrapNotNull().
The rationale for this is that when converting from a less-constrained type to
a more constrained type, implicit conversion is undesirable. For example, if I
changed a function f from this:
f(int* aPtr);
to this:
f(gsl::not_null<int*> aPtr);
no call sites would have to be modified. But if I changed it to this:
f(mozilla::NotNull<int*> aPtr);
call sites *would* need to be modified. This is a good thing! It forces the
author to audit the call sites for non-nullness, and encourages them to
back-propagate NotNull throughout the code.
The other difference between not_null and NotNull is that not_null disables
pointer arithmetic, which means it cannot be used with array pointers. I have
not implemented this restriction for NotNull because it seems arbitrary and
unnecessary.
2016-05-12 14:21:16 +10:00
11ef78ae89
Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj
...
--HG--
rename : mfbt/Endian.h => mfbt/EndianUtils.h
2016-05-22 13:31:11 -07:00
308608ab39
Bug 1262671 - Introduce MFBT BufferList class (r=froydnj)
2016-05-27 09:57:40 -07:00
eb2ea5c544
Bug 1269319 - Make AlignedStorage/AlignedStorage2 non-copyable to fix strict aliasing issues. r=Waldo
2016-05-19 20:57:36 +02:00
09a0151088
Bug 1209227 - Part 2: Mark mfbt::Variant as MOZ_INHERIT_TYPE_ANNOTATIONS_FROM_TEMPLATE_ARGS, r=froydnj
2016-05-19 09:34:01 -04:00
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
88fbb75f4c
Bug 1271972: wasm: Implement i64.ctz, i64.clz, i64.popcount; r=sunfish
...
MozReview-Commit-ID: 2XXloMWmbjV
--HG--
extra : rebase_source : a332d6b5c3e0cfe3d5018cdc53e4c20b80b6a52a
extra : histedit_source : d413c95a2d1bc56f8d6f0deacecf37190a612397
2016-05-11 19:00:53 +02:00
4d3ad00b0e
Bug 1269968 - Remove unnecessary deduction on RefPtr.h. r=froydnj
...
MozReview-Commit-ID: HoLyJD6oh
--HG--
extra : rebase_source : ac10cf1b3fae96ae91e7b5dd9b5a54797cec6e6d
2016-05-03 20:45:00 +02:00
df166c688f
Bug 1271022 - add Vector::podResizeToFit (r=njn)
...
MozReview-Commit-ID: 9HTY6O9GY4U
--HG--
extra : rebase_source : 55c226d23bd6dbb7b3bb21b356e64ae7499d3f0a
2016-05-09 08:59:10 -05:00
d8dc169af0
Bug 1268754 - Tweak some MFBT return values. r=Ms2ger.
...
This patch:
- Adds MOZ_MUST_USE to AllocPolicy::checkSimulatedOOM().
- Adds MOZ_MUST_USE to LZ4::decompress() (both variants) and fixes their
comments.
- Changes the return type of SplayTree::insert() from bool to void, because it
always returns true and its callers don't check the return value.
- Changes the return type of SplayTree::finishInsertion() from T* to void,
because it makes things clearer -- it was just returning the aNew argument.
- Adds MOZ_MUST_USE to a Vector::growTo() (both variants).
--HG--
extra : rebase_source : 1547cdeb9ee71d0ecec608ab474ab5e75bfc4b42
2016-04-29 13:14:34 +10:00
6b1ce5f87f
Bug 1268246 - Add a simple Poison class lifetime checker. r=froydnj
...
MozReview-Commit-ID: HpUjIaLPV7u
--HG--
extra : rebase_source : e5586cbb9d71005181671f362583a5b3b9006a4d
2016-04-29 13:54:54 -04:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
a5c843fe5f
Bug 1267550 (part 1) - Rename MOZ_MUST_USE as MOZ_MUST_USE_TYPE. r=ehsan.
...
This will allow MOZ_MUST_USE to be used for a different and more common case.
MozReview-Commit-ID: 4dQsdWjJfc6
--HG--
extra : rebase_source : 390ab56ef83d71eb6d28759a0195a79a78b153bd
2016-04-27 08:22:10 +10:00
b0359cb30b
Bug 1266404 - Allow construction of an EnumSet<T> using an initializer list r=Waldo
2016-04-28 14:25:05 +01:00
7dd2771dd7
Bug 1266402 - Add iteration to EnumSet<T> so that it can be used in range-based for loops r=Waldo
2016-04-28 14:25:05 +01:00
592be23acb
Bug 1265892 - Change Vector to use Impl::new_ consistently. r=Waldo
2016-04-26 16:26:17 -07:00
99cbfbd0dc
Bug 1259021 - Add Vector::extractRawBuffer method that doesn't copy the buffer r=Waldo
2016-04-25 13:41:25 +01:00
d5b6a661f0
Bug 1259021 - Rename Vector::extractRawBuffer to extractOrCopyRawBuffer r=Waldo
2016-04-25 13:41:25 +01:00
1999c10d91
Bug 1266294 - Remove unnecessary compiler version checks for gcc <= 4.8.0 in mfbt. r=froydnj
2016-04-17 17:08:10 -07:00
575dbe7dfd
Bug 1264827 - Part 3: Add the MOZ_NEEDS_MEMMOVABLE_MEMBERS annotation to MFBT; r=froydnj
2016-04-18 15:43:48 -04:00
558930f4e9
Backed out changeset e673dbc9848f (bug 1232686) for breaking VS2013 Builds
2016-04-16 10:57:53 +02:00
2177cca5cd
Bug 1232686 - Use decltype to infer Variant::match return type; r=fitzgen
2015-12-15 07:45:22 -08:00
67e655e4bf
Bug 1261361 - Make Vector::infallibleGrowByUninitialized check mReserved instead of mCapacity. r=Waldo
...
--HG--
extra : rebase_source : 2b6cdfae61946505b83748c016ef0b112ecf4780
2016-04-14 17:32:48 +02:00
8ed91454ea
Bug 1262663 - Clean up UniquePtr return documentation. r=Waldo
...
The prohibition against returning a UniquePtr was based on
bugs in older compilers which required an explicit Move()
to properly transfer ownership. This is no longer the case
since we now have code returning this type directly.
--HG--
extra : rebase_source : 6190b3f14b650d448f18f7611a22576701657795
2016-04-11 14:36:29 -07:00
c9a80c9abd
Bug 1263342 - don't use REFCOUNTED_VIRTUAL_TYPENAME for mfbt FunctionImplBase. r=froydnj
2016-04-08 23:14:59 -04:00
f1057b0380
Bug 1262577 - allow comparing mozilla::function with nullptr. r=froydnj
2016-04-06 15:18:01 -04:00
0ef3ab81a0
Bug 1232418 - Allow mozilla::Tuple to support equality comparison; r=Waldo
...
--HG--
extra : rebase_source : d57231f1c4a4c58715d2d552dd2e02257a73891e
2015-12-14 12:01:17 -08:00
6aeb6d5d05
Bug 1260247. In chaos mode randomly decide to start a new image load even if the image is in the image cache when allowed by spec. r=seth
...
If the image load is from the same document that cached the image we are required to use the cached version. Otherwise we should be free to ignore the cached version.
2016-04-02 13:53:12 -05:00
5790b832fa
Bug 1261452 - do_AddRef shouldn't require an rvalue-reference. r=froydnj
2016-04-01 19:14:42 -07:00
9825c57bc3
bug 1239166 - platform work to support Microsoft Family Safety functionality r=froydnj,mgoodwin,mhowell,rbarnes,vladan
...
MozReview-Commit-ID: GhpJqJB97r9
--HG--
extra : rebase_source : e943c1e4d0f008ffd6b6bb4bb63e1daf27ae2c96
2016-01-12 15:39:43 -08:00
1dd8dbc3f7
Bug 1246061. r=jandem, r=bz, r=luke, r=froydnj
...
--HG--
extra : rebase_source : 5b314d4c4c6e0b553290884be7338f8e79c22f71
2016-03-09 00:37:20 -08:00
04177e1aa2
Bug 1209100 - Back out bug 1165185 on inbound.
...
MozReview-Commit-ID: JqohyXNvjiU
--HG--
extra : rebase_source : c2165d279a6ca57a3439ebbfc081961369a42124
2016-03-21 16:16:52 -04:00
3fe18eae3b
Bug 1175546 - Update GCC to 4.8.5 and bump minimum GCC version required to build. r=froydnj
2016-03-12 09:03:37 +09:00
52f227c58b
Bug 1253678 - Rename mozilla::Function to mozilla::function. r=froydnj
...
MozReview-Commit-ID: 60RPmEsYDN2
--HG--
extra : rebase_source : 9d0bebc7362af2778d123425c56ac20553d9303b
2016-03-11 16:49:13 -05:00
30ce323e87
Bug 1255857 - Allow mozilla::UniquePtr's deleter template argument to customize the pointer type; r=froydnj
2016-03-11 15:35:43 -05:00
3508cf5f6a
Bug 1254565 - Allow passing matchers as rvalues to Variant::match. r=froydnj
...
--HG--
extra : rebase_source : 9863e7cde9ff918af22de94ca7ec29988c154bbd
2016-03-10 13:35:00 -05:00
115b647d6c
Bug 1253094, part 11 - Make DebugOnly a MOZ_STACK_CLASS. r=Waldo
...
MozReview-Commit-ID: I09tdRotoJq
--HG--
extra : rebase_source : d3a895ca6138d4e8a4ed87109434db922b9cac53
2016-02-26 15:52:08 +00:00
d75c1bad6a
Bug 1170045 - part 1 - add bulk pop support to SegmentedVector; r=erahm
...
Writing PopLastN in this way is probably a bit of a micro-optimization,
but at least it comes with tests and some comments for verifying the
goodness of the code.
2016-03-04 12:02:24 -05:00
10eb1a5af3
Bug 1170045 - part 0 - modify TestSegmentedVectors to use explicitly-updated counts; r=erahm
...
The scheme in TestSegmentedVectors to use manually-annotated points and
magic numbers corresponding to those annotations works OK for small
numbers of operations. But for testing bulk push and pop, we're going
to be doing many more operations, so let's move to recording explicitly
in code the operations we expect to see, and checking those instead.
2016-03-04 12:00:33 -05:00
550f775a8d
Bug 1252902 - remove ScopedFreePtr; r=Waldo
...
We have UniqueFreePtr as a replacement, which at least uses
more-standard machinery to do its job.
2016-03-02 11:44:27 -05:00
76173ee85d
Bug 1251723 - remove ScopedDeletePtr; r=Waldo
...
UniquePtr is more standard than ScopedDeletePtr; using standard
constructs whenever possible is preferable.
2016-02-26 15:08:03 -05:00
8429c38aa7
Bug 1248843 - Make it clearer that DebugOnly uses up space even in optimized, non-DEBUG builds. r=Waldo
...
--HG--
extra : rebase_source : 6de3e55b8a7c4272bec3b5b8b8eb5da7ad78e9cf
2016-02-19 12:57:42 +00:00
556bde5629
Bug 1252195 - part 1 - implement UniqueFreePtr; r=Waldo
...
Just like UniquePtr<T>, except that we're going to delete the allocated
memory with |free()|.
2016-02-29 10:29:13 -05:00
205b124ab5
Bug 1251496 - Introduce a servo-side data structure to represent the style set. r=heycam
2016-02-28 00:25:33 -08:00
c47a83ce36
Bug 1251769 - Remove remaining references to MOZILLA_XPCOMRT_API from mfbt. r=froydnj
2016-02-27 11:12:07 -08:00
57081a13af
Bug 1250666 - Forward Variant's move constructor argument correctly to the underlying variant type. r=waldo
2016-02-26 21:01:49 -08:00
27ae3900e1
Bug 1246841 - Allow construction of Variant values using type inference. r=waldo
...
--HG--
extra : rebase_source : 7d596149e6d3c630d62aab0d65d5a826af731bf5
2016-02-25 14:34:12 -08:00
4052eca615
Bug 1246838 - Handle const qualifiers and references better in Variant. r=waldo
...
--HG--
extra : rebase_source : 4dc9df6cb5ea9b994c5074b505471101746def83
2016-02-25 14:34:12 -08:00
2e0403bcfe
Bug 1247835 (part 0) - Minor comment and style tweaks in BinarySearch.h. r=luke.
...
--HG--
extra : rebase_source : 1e778ebbc7e297dcc2a65dbd522dd1f8c99bd790
2016-02-23 15:41:39 +11:00
9f38f2d1e0
Bug 1250196 - Part 2: Rename UniquePtr::getDeleter() to get_deleter() in order to make it compatible with std::unique_ptr; r=froydnj
2016-02-22 15:51:59 -05:00
d2510ef7a5
Bug 1248851 part 4 - Mark UniquePtr::release() MOZ_WARN_UNUSED_RESULT. r=Waldo
...
MozReview-Commit-ID: FH7t5gZ0nVG
--HG--
extra : source : d2e0a96cfa48756f0e101a089999142a703fa24c
2016-02-20 11:06:25 +08:00
f41859330d
Backed out changeset 5f729d20fd00 (bug 1249728) for bustage. r=bustage on a CLOSED TREE
2016-02-19 22:18:49 +01:00
23aabd18d7
bug 1249728 - make the nondebug ctors for DebugOnly constexpr r=froydnj
2016-02-19 15:54:38 -05:00
efe3a336f3
Bug 1248784 - Followup to add requested comment. r=froydnj DONTBUILD
2016-02-17 10:16:47 -08:00
d7835725e4
Bug 1248784 - Extract the AddRef/Release calls into a non-inner helper trait. r=froydnj
2016-02-17 10:15:19 -08:00
75abd802d9
Bug 1248784 - Rename the existing AddRefTraits to ConstRemovingRefPtrTraits. r=froydnj
2016-02-17 10:15:17 -08:00
3389490ae3
Bug 1245414, part 10 - Apply the Mozilla patches via mfbt/decimal/update.sh. r=Waldo
...
--HG--
extra : rebase_source : 791e169635d9bb13f0a7a9593007a7ed3acaf3a0
2016-02-11 19:43:14 +00:00
faa1155f4b
Bug 1245414, part 9 - Disable mfbt/decimal/fix-wshadow-warnings.patch. r=cpeterson
...
--HG--
extra : rebase_source : 6e6832aaef2fa20feac1d18c839ad2e90d468685
2016-02-11 19:07:42 +00:00
fd49e9c851
Bug 1245414, part 8 - Remove mfbt/decimal/floor-ceiling.patch now that the issue is fixed upstream. r=Waldo
...
--HG--
extra : rebase_source : 6fd88f5f2a27f29bc3e01943868ac81a232dddac
2016-02-11 19:07:42 +00:00
66a8428e62
Bug 1245414, part 7 - Update mfbt/decimal/to-moz-dependencies.patch. r=Waldo
...
--HG--
extra : rebase_source : e79b2009d89c8921f632f7ebc5bfb908b5444523
2016-02-11 19:07:42 +00:00
b8a0bc7f14
Bug 1245414, part 6 - Update mfbt/decimal/mfbt-abi-markers.patch. r=Waldo
...
--HG--
extra : rebase_source : 72a3e469b651c1f7ceddc4f7c220572e2835aab8
2016-02-11 19:07:42 +00:00
f5ad611e1f
Bug 1245414, part 5 - Update mfbt/decimal/comparison-with-nan.patch. r=Waldo
...
--HG--
extra : rebase_source : 00746c16dc88e2b87488cc95171d84b48c62b151
2016-02-11 19:07:41 +00:00
2439bc12ad
Bug 1245414, part 4 - Update mfbt/decimal/zero-serialization.patch. r=Waldo
...
--HG--
extra : rebase_source : 96cf5b120ac836157ec560da278e286b4ff70049
2016-02-11 19:07:41 +00:00
e48f82b02f
Bug 1245414, part 3 - Overwrite mfbt/decimal/Decimal.* with vanilla upstream copies. r=Waldo
...
--HG--
extra : rebase_source : 8139e78c73f1d6d4b96c7f65640d7b515abdc57e
2016-02-11 19:07:41 +00:00
dde69bf76a
Bug 1245414, part 2 - Update mfbt/decimal/update.sh to reflect Blink's switch from svn to git, and the different files we now pull. r=Waldo
...
--HG--
extra : rebase_source : 1b6c79ad740cb90d19c69ec9ed64a9a9789b27f7
2016-02-11 19:07:41 +00:00
2897f074a1
Bug 1245414, part 1 - Delete the mfbt/decimal/LICENSE* files since upstream now just uses inline comments. r=Waldo
...
--HG--
extra : rebase_source : d3be9552bc981e6c96455dc6d674c2dab87bcd36
2016-02-11 19:07:40 +00:00
d9ee752669
Add an assertion message to the assert-is-empty in LinkedList::~LinkedList, to indicate to users who hit it that it's the fault of the caller, not the fault of MFBT code. No bug, rs=froydnj
2016-02-16 13:06:20 -08:00
f3949ab1d3
Bug 1216001 part 1 - Optimize nsRange::IsNodeSelected. r=bz
2016-02-13 18:40:23 +01:00
6f93fd8916
Bug 1247412 - Add a `reverse` method to `mozilla::Vector`; r=Waldo
2016-02-11 08:33:00 +01:00
5a6ee4e222
Bug 1247535 - Fix -Wunreachable-code warning in mfbt/Poison.cpp. r=froydnj
...
mfbt/Poison.cpp:165:26: warning: will never be executed [-Wunreachable-code]
2016-02-10 22:09:53 -08:00
9d0e08b626
Back out 3 changesets (bug 1216001) for Win8 reftest failures in 1193519-sideways-lr-3.html and 1193519-sideways-lr-4.html and intermittent OS X failures in font-display-2.html
...
CLOSED TREE
Backed out changeset dbadb8fe5803 (bug 1216001)
Backed out changeset a30593ebd58e (bug 1216001)
Backed out changeset c1646ffa71b4 (bug 1216001)
2016-02-11 20:43:41 -08:00
a3c53b91a3
Bug 1216001 part 1 - Optimize nsRange::IsNodeSelected. r=bz
2016-02-12 02:13:57 +01:00
911e4a2d8b
Bug 1242812 - Only check for simulated OOM in vectors when growing beyond reserved size r=Waldo
2016-02-11 19:00:18 +00:00
6a5930b454
Bug 1247338 - really make Atomic's constructor constexpr; r=Waldo
...
Atomic's constructor is marked as constexpr, but it calls a
non-constexpr function, ToStorageTypeArgument::convert. For compilers
which require constexpr-ness on constructors to inline away the actual
constructor call, the call to ToStorageTypeArgument::convert completely
disables the constexpr-ness of the constructor. Let's fix this by
marking all relevant instances of ToStorageTypeArgument::convert as
MOZ_CONSTEXPR, thus satisfying the compiler once again.
2016-02-10 11:28:36 -05:00
0afa44b210
Bug 1232765 - Remove the workaround added in bug 1022050
2016-02-07 14:50:50 -05:00
b607eb03af
Bug 1245979 - make mfbt Function reference-counted so that it can be cheaply copied for compatibility with Skia. r=froydnj
2016-02-04 16:43:42 -05:00
ad6d42d817
Bug 1194721: Add |Saturate| template for saturation arithmetics, r=nfroyd
...
|Saturate<T>| implements saturation arithmetics for arbitrary basic
types. Operations on its value won't over- or underflow the type's
range.
2016-02-04 12:35:12 +01:00
4ff72292de
Backed out changeset 8d6c228ef008 (bug 1194721) on developers request
2016-02-03 16:25:00 +01:00
3d9f64bb3e
Bug 1194721: Add |Saturate| template for saturation arithmetics, r=nfroyd
...
|Saturate<T>| implements saturation arithmetics for arbitrary basic
types. Operations on its value won't over- or underflow the type's
range.
2016-02-03 15:16:00 +01:00
71421aec25
Bug 1243876 - fix ConvertibleTester to not cause incomplete type errors with UniquePtr and Skia. r=nfroyd
2016-01-28 16:08:27 -05:00
9668b6f572
Bug 1241901 part 3 - Add IsMemberPointer and IsScalar type traits. r=froydnj
...
--HG--
extra : source : 02269acc78bfde8d3171bf6023a5dda4cac9df3c
2016-01-30 10:33:41 +11:00
a427bd0117
Bug 1238582 - Skip simulated OOM check in the case where we're growing within reserved space; r=Waldo
...
--HG--
extra : rebase_source : a0f1db09b114478c52609de705dce4ba9a74445a
2016-01-28 10:07:14 -06:00
a240a28c7f
Bug 1080968 - Don't use constexpr on clang-cl when emulating MSVC 2013
...
constexpr-ness of things can change the ABI requirements, and MSVC 2013
doesn't support constexpr, so choosing it for clang-cl when emulating
MSVC 2013 will cause ABI incomap issues between object files compiled
with the two compilers.
This reverts part of the commit for the original bug.
2016-01-27 21:10:03 -05:00
5412728905
Bug 757969 - use __thread in ThreadLocal; r=froydnj
2016-01-22 10:33:44 -07:00
e713b8b0ac
Bug 1237201 part 8 - Make fallible Vector methods MOZ_WARN_UNUSED_RESULT. r=jwalden
...
--HG--
extra : rebase_source : fdfb0d0f592a968ee9e5852f2cc05f0873a02375
2016-01-14 22:04:36 +01:00
88d51252f9
Bug 1239479: Add comments to mfbt/XorShift128PlusRNG.h from the RNG's designer. DONTBUILD r=Waldo
...
--HG--
extra : rebase_source : b6f2dc01d0581c668923ad14708cec790795d5c1
extra : amend_source : bf55f132226390983c0601fab2989fa0f7cf3a26
2016-01-13 12:46:40 -08:00
e92b68d840
Bug 1236413 - Suppress -Wimplicit-fallthrough warning in third-party code mfbt/decimal/. r=Waldo
...
mfbt/decimal/Decimal.cpp:762:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-24 23:12:44 -08:00
bfbfcf7575
Bug 1228641 - Rename begin/size to aBegin/aSize to avoid shadow warnings; r=botond
...
On B2G/Android we get warnings if the begin/size parameters to the constructor
match the method names begin()/size(): declaration of 'size/begin' shadows
a member of 'this'.
2016-01-13 07:54:53 +09:00
fa1db4f4b7
Bug 1231378 - part 3 - Fix uninitialized members of classes in modules/libjar and mfbt, r=smaug
2016-01-12 18:16:59 +00:00
ec54e89c4c
Backed out changeset 138c4e6a9b45 (bug 1231378)
2016-01-12 15:48:55 +01:00
8cb83b4f57
Bug 1231378 - part 3 - Fix uninitialized members of classes in modules/libjar and mfbt, r=smaug
2016-01-12 13:57:34 +00:00
2b12d59585
Bug 1226376 - Part 1: Allow non-trivial constexpr constructors in MOZ_TRIVIAL_CTOR_DTOR classes, r=ehsan
2016-01-08 15:34:24 -05:00
b29099ae6d
Bug 1228641. Add a polyfill of std::initializer_list. r=froydnj
2016-01-06 22:06:35 -05:00
36e21ef4d9
Bug 1231224 part 10 - Make various Vector calls check for OOM. r=terrence
...
--HG--
extra : rebase_source : fae86eb928fc510c3d5c7a895675cf218fc15b3a
2016-01-06 21:06:25 +01:00
3171200ff5
Bug 1235277 - Define MOZ_FALLTHROUGH_ASSERT to workaround -Wunreachable-code warnings about MOZ_FALLTHROUGH in debug builds. r=botond
2015-12-27 13:27:17 -07:00
6b46b54d1f
Bug 1232694 - fix typo in Compiler.h; r=botond
2015-12-15 11:14:53 -05:00
4560db90e5
Bug 1170325 - Convert js::Vector into a template alias to mozilla::Vector with a single customized default argument. Also get rid of the CRTP support in mozilla::Vector (through mozilla::VectorBase) now that template aliasing is good enough, and make mozilla::Vector final so that people will use composition and not inheritance with it. (Inheritance plays poorly with movability and a few other things, in addition to messing up template argument deduction matching.) r=Waldo, patch sort of a tag-team between him and me
2015-07-13 12:42:52 -07:00
46bb7c80dd
Bug 1228947 - Replace mfbt/Constants.h with math.h. r=roc
...
--HG--
extra : rebase_source : 4ab2c4a917ea90055e48bd6adcb53904f2266ee0
2015-11-27 20:49:55 -08:00
5216514639
Bug 1228182 - Use division directly for generating double in XorShift128PlusRNG. r=Waldo
...
--HG--
extra : source : f090915a20c5d1281cd49a7aa7668ad77f83435a
2015-12-03 12:16:18 +11:00
90cb097793
Bug 322529 part 3 - Fix LRandom JIT code to use the new algorithm. r=arai,jwalden
2015-12-02 13:56:00 +01:00
2a82df055d
Bug 1229293 - Enforce order when setting a HierarchicalStringList, and forbid reassignment. r=gps
...
The current implementation of HierarchicalStringList allows the following:
FOO.bar = [
'foo',
'bar',
]
while
FOO.bar += [
'foo',
'bar',
]
would be invalid because of the StrictOrderingOnAppendList enforcement.
It also allows to overwrite the entire list with a subsequent
FOO.bar = [
'baz',
]
while we've explicitly forbidden such things for every other list.
While in the vicinity, fix HierarchicalStringList._get_export_variable to not
call the HierarchicalStringList constructor uselessly.
2015-12-02 11:04:37 +09:00
572059374e
Bug 1178266 - Link against libatomic when necessary. r=froydnj
2015-12-02 11:04:37 +09:00
1a83097cba
Bug 1221680 - Avoid hard errors when testing convertibility using the IsConvertible type trait. r=froydnj
...
--HG--
extra : source : ea11bb67c3510671a501724d17d9872c3455891d
2015-11-06 17:47:36 -05:00
47b5adaa34
Bug 1221368 - Change MakeTuple to decay the types of its arguments (r=froydnj)
2015-11-09 10:21:11 -08:00
e763192040
Bug 1216611 - add mozilla::MakeUniqueFallible and convert uses throughout the tree; r=Waldo
2015-11-05 16:24:24 -05:00
2e1255ee1e
Bug 939157 - RotateLeft with shift of zero gives undefined behavior. r=Waldo
2015-11-03 14:25:48 -08:00
fe5445d030
Bug 1220693 - Make mozilla::Atomic<enum class> work even on compilers that don't have <atomic>. r=froydnj
...
--HG--
extra : rebase_source : 2eb167a1b86a1a93527761a9541ea30ad213785a
2015-11-03 13:03:26 -08:00
ef4655be32
Bug 1201330 - Keep scroll handler induced layer activity active until the scroll frame becomes inactive. r=roc
...
--HG--
extra : commitid : K9ntCNQz1Fx
extra : rebase_source : ed8a567f22626d7074bbc58eb5e61baa251fe2c3
2015-10-30 16:28:53 +01:00
9985829ecc
Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj
2015-11-02 07:53:26 +02:00
c3385563ef
Backout changeset 3ced6f84960c (bug 1178266) because it was not reviewed by a peer and isn't a complete fix.
2015-10-31 07:36:49 +09:00
2fe6ba353f
Backed out changeset d5d68c0258f3 (bug 1201330)
...
--HG--
extra : rebase_source : 2b98ebd0dd0ccd247b50e4b45210137622ef4441
2015-10-30 14:44:06 +01:00
09bf18ccd8
Bug 1201330 - Keep scroll handler induced layer activity active until the scroll frame becomes inactive. r=roc
...
--HG--
extra : commitid : AV1sQewWYHl
extra : rebase_source : ef132043f3af460c1aabc531faa06752d4c9c2df
2015-10-27 17:18:03 +01:00
beffa7ff42
Bug 1178266 - Link against libatomic when necessary r=huangwenjun06
...
---
build/autoconf/toolchain.m4 | 26 ++++++++++++++++++++++++++
mfbt/moz.build | 3 +++
2 files changed, 29 insertions(+)
2015-10-29 22:19:35 +08:00
001cd79ef9
Bug 1214958 - Add operators &=, |=, and ^= to mozilla::DebugOnly. r=froydnj
...
--HG--
extra : commitid : 2f0PRWFcnzP
2015-10-19 20:42:28 -07:00
0cabb3c016
Bug 1216041 - Add ranged iterator support to mozilla::{Array,RangedArray,EnumerationArray}. r=froydnj
2015-10-20 10:16:20 +11:00
8df7b927c3
Bug 1216040 - Make ArrayLength support mozilla::EnumeratedArray. r=froydnj
2015-10-20 10:16:20 +11:00
4fa140ec32
Bug 1216038 - Deduce underlying integer type for MakeEnumeratedRange starting at 0. r=froydnj
2015-10-20 10:16:19 +11:00
0308741102
Bug 1215411 - Define MOZ_FALLTHROUGH annotation to suppress clang's -Wimplicit-fallthrough warnings. r=botond
2015-10-04 21:03:26 -07:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
483783681e
Bug 1207245 - part 4 - remove RefPtr.h; r=ehsan
...
It has been superseded by the availability of nsRefPtr.h.
2015-10-18 00:40:16 -04:00
583afa0965
Bug 1207245 - part 3 - switch all uses of mozilla::RefPtr<T> to nsRefPtr<T>; r=ehsan
...
This commit was generated using the following script, executed at the
top level of a typical source code checkout.
# Don't modify select files in mfbt/ because it's not worth trying to
# tease out the dependencies currently.
#
# Don't modify anything in media/gmp-clearkey/0.1/ because those files
# use their own RefPtr, defined in their own RefCounted.h.
find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
grep -v 'mfbt/RefPtr.h' | \
grep -v 'mfbt/nsRefPtr.h' | \
grep -v 'mfbt/RefCounted.h' | \
grep -v 'media/gmp-clearkey/0.1/' | \
xargs perl -p -i -e '
s/mozilla::RefPtr/nsRefPtr/g; # handle declarations in headers
s/\bRefPtr</nsRefPtr</g; # handle local variables in functions
s#mozilla/RefPtr.h#mozilla/nsRefPtr.h#; # handle #includes
s#mfbt/RefPtr.h#mfbt/nsRefPtr.h#; # handle strange #includes
'
# |using mozilla::RefPtr;| is OK; |using nsRefPtr;| is invalid syntax.
find . -name '*.cpp' -o -name '*.mm' | xargs sed -i -e '/using nsRefPtr/d'
# RefPtr.h used |byRef| for dealing with COM-style outparams.
# nsRefPtr.h uses |getter_AddRefs|.
# Fixup that mismatch.
find . -name '*.cpp' -o -name '*.h'| \
xargs perl -p -i -e 's/byRef/getter_AddRefs/g'
2015-10-18 00:40:10 -04:00
51d813dfae
No bug: Fix comment in mfbt/FastBernoulliTrial.h. DONTBUILD r=me
...
--HG--
extra : rebase_source : 03a213a8999d4b6b47c6e2be3a8ea06053e24184
extra : amend_source : 9181ae56e72b66bf19fe2129bfab01f0910aaad8
2015-10-16 12:21:39 -07:00
2fac3971ef
Bug 1212624 - Tests for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : 39cb2bc90342da5d5fc1379f805b1dd701a108df
2015-10-07 12:36:00 -07:00
2ac5b36223
Bug 1212624 - Implement range-based iteration for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : 9d3d1b40cab8542f4e7aaf9ffe1496c646c8291e
2015-10-07 14:19:42 -07:00
86aec2801f
Bug 1207245 - part 6a - call AddRef/Release from nsRefPtr itself, rather than a helper; r=botond
...
The problematic class is AtomicRefCountedWithFinalize, from gfx/layers/;
I don't know all the details for why that class is written the way it
is, but it is simpler to make nsRefPtr work the same way as
mozilla::RefPtr in this case.
2015-10-12 22:29:51 -04:00
833a3ce77b
Backed out 5 changesets (bug 1212624) for breaking stuff.
...
Backed out changeset cf5ffa45a4a2
Backed out changeset 0d7a968d2d64 (bug 1212624)
Backed out changeset 379edefa8e47 (bug 1212624)
Backed out changeset f73fca35daad (bug 1212624)
Backed out changeset 4f499d30a0e0 (bug 1212624)
2015-10-14 16:49:12 -07:00
c860330eec
Bug 1212624 - Tests for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : f44eac4762baa6cc47e5ea370fe19ea35aaf9c88
2015-10-07 12:36:00 -07:00
0df76da429
Bug 1212624 - Implement range-based iteration for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : fb99021b13d030e12257ed420887051c7c5f9b8c
2015-10-07 14:19:42 -07:00
23b7d3da85
Bug 1212745 - Part 1 - operator() Use perfect forwarding to avoid redundant copy. r=nfroyd
2015-10-08 11:38:00 +02:00
bf740b75f1
Bug 1212745 - Part 1 - Make mozilla::Function support pointer to member function. r=nfroyd
2015-10-11 19:53:00 +02:00
cd209ab0b5
Bug 1206357: Add mfbt/FastBernoulliTrial.h, implementing efficient random sampling. r=waldo
...
--HG--
extra : rebase_source : 63de57cd3fb3317c752f58fb7a0a71f050f198a3
2015-10-08 13:05:31 -07:00
a764ebee57
Bug 1211979 - Annotate crashes triggered by MOZ_RELEASE_ASSERT, r=froydnj
2015-10-08 17:50:58 -04:00
e4681ea6a5
Bug 1183355 - Annotate crash reports triggered by MOZ_CRASH in release builds, r=froydnj
2015-10-08 10:01:08 -04:00
5ea571ddb7
Bug 1211100 - Add Vector::infallibleEmplaceBack and use it in JSScript::initScriptCounts() r=nbp
...
--HG--
extra : rebase_source : a989ddba0bc981725a955c705a51aa495ef59ab9
2015-10-06 14:50:49 +01:00
0c816bee5c
Bug 1208357 - Fix -Wshadow warnings in mfbt/decimal. r=Ms2ger sr=Waldo
2015-09-22 20:43:29 -07:00
204777d13d
Bug 1207519 - Prevent HashTable shrink from ignoring allocation failures that may have been reported r=Waldo
2015-09-30 11:34:49 +01:00
1ae90ca7ba
Bug 1200642 - Add OOM simulation to Vector r=Waldo
2015-09-30 11:34:48 +01:00
0b41e069f3
Bug 1200642 - Add checkSimulatedOOM() to AllocPolicy r=Waldo
2015-09-30 11:34:44 +01:00
0eeafe1fa4
Merge inbound to central, a=merge
2015-09-24 16:46:34 -07:00
71808b231d
Bug 1205020 - Disable optimizations in TestTuple.cpp since it breaks the build on VS2013 Windows 10. r=froydnj
...
--HG--
extra : rebase_source : f209cc4dd8051562a4ef87313d0636f9dbee2132
2015-09-23 13:53:07 -04:00
e91dae783c
Bug 1204669 optimize out hashtable lookups caused by extra GetPrototypeBinding call, r=bz,waldo
2015-09-24 03:53:31 +03:00
50eb249b57
Bug 1207245 - part 2 - move MakeAndAddRef to nsRefPtr.h
...
A number of places depend on RefPtr.h providing this function. When we
s/RefPtr/nsRefPtr/, such places still need to be able to see this
function. Moving it to nsRefPtr.h makes it still visible before we
switch (since RefPtr.h includes nsRefPtr.h), and after we switch (since
every place that #includes RefPtr.h will now be #including nsRefPtr.h).
2015-09-22 22:23:10 -04:00
5761751aa3
Bug 1207245 - part 1 - move RefCounted<T> to its own file
...
Various bits depend on RefPtr.h to provide RefCounted<T> and RefPtr<T>.
It will be easier to manage an automatic conversion from RefPtr<T> to
nsRefPtr<T> if we split out the dependency on RefCounted<T> first.
2015-09-22 21:27:34 -04:00
d3552d7e39
Bug 1207245 - part 0 - fix why-did-we-allow-that tests in TestRefPtr.cpp
...
RefPtr.h's byref permits callees to see the incoming value of the
outparam; XPCOM's getter_AddRefs zeros outparams prior to the call, so
information doesn't leak through inadvertently. Given this difference,
we need to eliminate tests that depended on this (arguably dangerous)
behavior. The numerous assertion fixups are required because we're
removing construction and destruction of objects along the way.
2015-09-23 23:07:29 -04:00
e1252e4e42
Bug 1206356: Add mfbt/Random.h, implementing the xorshift128+ random number generator. r=waldo
...
--HG--
extra : rebase_source : 3eb009156765b341e6a2dcee9f0287ce198c439f
2015-09-23 13:59:28 -07:00
dba9d5afc5
Back out 835853a88b03 (bug 1206356) for at least Android/B2G bustage
...
CLOSED TREE
2015-09-22 18:21:32 -07:00
68cb70e9c4
Bug 1206356: Add mfbt/Random.h, implementing the xorshift128+ random number generator. r=waldo
...
--HG--
extra : rebase_source : 8694eae8a75a1b56be81826e3d9567d33a9fcdfe
2015-09-22 16:34:51 -07:00
48d19920cb
Bug 1204790 - Prefer deleted function with public access specifiers instead of private in UniquePtr. r=nfroyd
...
--HG--
extra : rebase_source : 9f711462c2e0b9865793c9f4846cb7ab6a60ef32
2015-09-15 19:18:00 +02:00
5446225d17
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
c1e26ee03e
Bug 1203314 - Make operator<< a method on unused_t. r=froydnj
...
This prevents operator overload resolution from failing when this file
is included in a file that uses Chromium IPC logging.
--HG--
extra : rebase_source : 661efe98060d405e87f828655b13c0c0a8a428e0
2015-09-10 13:17:00 +02:00
0097c41e01
Bug 1201190 - Part 3: Mark every consumer of GUARD_OBJECT as MOZ_RAII, r=ehsan
2015-09-12 16:53:33 -04:00
2c245dc4e2
Bug 1201190 - Part 2: Add MOZ_NON_TEMPORARY_CLASS and MOZ_RAII to mfbt, r=ehsan
2015-09-12 16:53:32 -04:00
1eaae658aa
Bug 1156802 - Part 2: Remove all explicit move constructors, r=ehsan
2015-09-12 12:34:45 -04:00
78627e8b5d
Bug 1198451 - Tests for mozilla::Function. r=froydnj
...
--HG--
extra : source : 11a2cd3e5c1e051c6bef843b45fe3701364e826a
2015-09-06 21:43:34 -04:00
9985fe899c
Bug 1198451 - Add a type-erased callable wrapper, mozilla::Function, to MFBT. r=froydnj
...
--HG--
extra : source : 90ac08992195f6e818a83019567e55e17a350901
2015-09-11 14:40:09 -04:00
a037228e4f
Bug 1202568 - Cherry-pick warning fixes from upstream double-conversion. r=Ms2ger
...
--HG--
extra : rebase_source : 732eec4f5748b54e42a23267b2023b303f213983
2015-09-05 00:38:04 -07:00
b5bc43ef27
Bug 1202965 (part 1) - Add MOZ_UNUSED. r=froydnj.
2015-09-09 17:01:28 -07:00
ba9de6a2f7
Backed out changeset f5b2a11c64c9 (bug 1201271) for bustage
2015-09-09 15:56:21 -07:00
3e590f4e78
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-09 15:39:10 -07:00
5d455e0375
Bug 1202317. Support PodEqual over fixed-length arrays. r=Waldo
...
--HG--
extra : commitid : CojJ669FPWd
extra : rebase_source : fd81c9367dcb9dacf9e5ba137fe9a4ef31a5853e
2015-09-07 17:07:59 +12:00
f9055a2c4d
Bug 1193600 - Add Clamp and IsPowerOfTwo to MFBT. - r=waldo
2015-09-04 13:33:10 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
2c0adde7a0
Bug 1199068 - Soothe a unused variable warning in TestSplayTree.cpp. r=nfroyd
2015-08-28 11:24:47 +08:00
99df3288e2
Bug 1197734 - Add MOZ_HAVE_CXX11_CONSTEXPR_IN_TEMPLATES on VS2015+. r=Waldo
2015-08-25 16:53:25 +09:00
672db6ba31
Bug 1189967 - Avoid including <string> from Char16.h. r=nfroyd
...
Since Char16.h is included everywhere, and MSVC 2015 uses the char16ptr_t trick
it contains, we include <string> everywhere, but that has the side effect of
breaking the build in subtle ways. One way around this would be to avoid including
Char16.h in the first place, but that requires more work than I was ready to put
in. So instead, just avoid including <string> by removing the conversion operator
for std::wstring.
2015-08-23 22:20:33 +09:00
24406b034a
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r=Waldo
...
--HG--
extra : source : c3fa493499954504073d8abeb7104f46c4f3f953
2015-08-21 09:17:18 +10:00
c3c08f5b75
Bug 1196451 - tweak comment in nsRefPtr.h to be more clear; r=botond
...
DONTBUILD because this is a comment-only fix.
2015-08-20 00:59:28 -04:00
9602783f5f
Bug 1195154 - Replace operator overloads for comparing nsRefPtr to 0 with those for comparing to nullptr. r=froydnj
2015-08-19 11:06:05 -07:00
0005d3bf06
Backed out changeset 20c6f74296e2 (bug 1195154) for causing Bug 1196115
...
--HG--
extra : rebase_source : 59356f3ff488b4000e4f3034f9c676d4afe8b49f
2015-08-19 20:43:11 +05:30
aedc156767
Bug 1195154 - Replace operator overloads for comparing nsRefPtr to 0 with those for comparing to nullptr. r=froydnj
...
--HG--
extra : source : 3303e551336985eca8b501dcc12cf6f2dddbdec3
2015-08-19 09:09:08 +10:00
f8b012d537
Bug 1192130 - Part 2: Use MOZ_NON_AUTOABLE to validate the usage of already_AddRefed, r=ehsan
2015-08-14 17:33:54 -04:00
328b8f083b
Bug 1193298 - Part 3: Delete RefPtr<T>::operator T*()&&. r=froydnj
...
I put MOZ_HAVE_REF_QUALIFIERS in Attributes.h for lack of a better
place. I didn't especially want to make a whole new file for it.
To make the tree compile, support for moving RefPtr to nsRefPtr was
needed. I chose to put the definitions in RefPtr.h instead of
nsRefPtr.h because RefPtr.h looks to be included in fewer files, so I
preferred to bloat fewer files with the extra include.
For some reason operator!() wasn't necessary here, although it seems it
is for nsRefPtr.
2015-08-11 06:45:00 -04:00
d587425b77
Bug 1179451 - Part 5: Delete nsRefPtr<T>::operator T*()&&. r=froydnj
...
--HG--
extra : rebase_source : 9e1680bb0eb7c38de14cd1974fbd03988780a3bc
2015-08-13 15:22:48 +03:00
5fb19bf30c
Bug 1193005 - delete unused function nsRefPtr::begin_assignment; r=erahm
...
We don't use it; the getter_AddRefs overload for nsRefPtr uses
StartAssignment, which is the same thing.
2015-08-11 00:23:33 -04:00
c3a87d5439
Bug 885515 - Part 2: Add MOZ_HEAP_CLASS to mfbt, r=ehsan
2015-08-09 12:42:11 -04:00
26eaf483ae
Bug 1186693 - Add exhaustive matching to mozilla::Variant; r=Waldo
2015-08-08 16:43:35 -07:00
78b4b30d08
Bug 1189894 - remove Atomics.h IntrinsicAddSub hack; r=erahm
...
This hack was only required for broken headers in GCC 4.6. Since we
only support GCC 4.7+ now, this hack is no longer necessary.
2015-07-31 22:25:21 -04:00
1ad5e05028
Bug 1056356 - Add support for nsRefPtr<const T>. r=froydnj
...
--HG--
extra : rebase_source : 7b86c6e7bc47c7b3ebc19075559cf0f7d24ededf
2015-08-05 13:52:06 -04:00
80ea0a3e53
Bug 1190823 - Move OwningNonNull.h to xpcom/base/; r=froydnj
...
--HG--
rename : dom/bindings/OwningNonNull.h => xpcom/base/OwningNonNull.h
2015-08-05 15:28:27 +03:00
f75a6aad6a
Bug 1190313 - Set MOZ_HAVE_EXPLICIT_CONVERSION on VS2015. r=nfroyd
2015-08-05 17:14:42 +09:00
Ting-Yu Lin
Nathan Froyd
Tooru Fujisawa
Jeff Walden
Sebastian Hengst
Kan-Ru Chen
Andi-Bogdan Postelnicu
Terrence Cole
Xidorn Quan
Tom Schuster
Mats Palmgren
Wes Kocher
Michael Layzell
Jeremy Chen
Michelangelo De Simone
Honza Bambas
Ryan VanderMeulen
Igor
Nathan Froyd
Benjamin Bouvier
Daniel Holbert
Chris Peterson
Cameron McCormack
Carsten "Tomcat" Book
Tom Tromey
Andrew McCreight
Boris Chiou
Chris Pearce
Seth Fowler
Luke Wagner
L. David Baron
Nicholas Nethercote
Bill McCloskey
Jan de Mooij
James Cheng
Benoit Girard
Jon Coppeard
Dan Gohman
Ehsan Akhgari
Ralph Giles
Lee Salzman
Timothy Nikkel
Bobby Holley
David Keeler
Markus Stange
Mike Hommey
Nick Fitzgerald
Jonathan Watt
Eric Rahm
Xidorn Quan
Trevor Saunders
Phil Ringnalda
Thomas Zimmermann
Morgan Phillips
Jim Blandy
Brian Birtles
Andrea Marchesini
Jeff Muizelaar
Botond Ballo
Sean Stangl
Birunthan Mohanathas
Steve Fink
Jared Wein
Olli Pettay
Robert O'Callahan
Jeff Gilbert
Makoto Kato
Nigel Babu
Aryeh Gregor