We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.
MozReview-Commit-ID: 6s78RvPFMzv
--HG--
extra : rebase_source : 009ea39eb4dac1c927aa03e4f97d8ab673de8a0e
Provide a translation of "current".
Prevent issue with the order of the word by adding another string when
we display the current ping.
MozReview-Commit-ID: AOHXGrlm2Dt
--HG--
extra : rebase_source : a2a6822b9fb562670ffdf00bbf20659123cff622
Remove the quote form the js file and add it to the string file.
MozReview-Commit-ID: JGgywPJ755J
--HG--
extra : rebase_source : df683a5be4be6d3f0d0494960bbc28cdd6620060
Add its own strings to the value of extendedTelemetryEnabled so that it
is independent of of telemetryEnabled.
MozReview-Commit-ID: 8p35LuWbiDw
--HG--
extra : rebase_source : 13b2df492cb4490c59da25cf7c8698e79aefcd91
This patch intends to obtain a 1) rough sense of the percentage of telemetry
population using Web Authentication over time, and 2) whether or not the
Authentication request was successful or errored out as a scalar. It also tracks
3) how long it takes for requests to complete as a histogram.
It counts Register (enrollment) and Sign (login) separately as we would
anticipate there being far, far more Sign uses than Register.
MozReview-Commit-ID: 8DFyKAG8XJw
--HG--
extra : rebase_source : c93eeac7a978a1d1c4b08ff1e18e2548b1045ced
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.
I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.
MozReview-Commit-ID: Gq16sNm7K2e
--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
While moving to a new window (using SwapDocShells), a pagehide event[1] is dispatched causing nsFormFillController to clean up mPwmgrInputs and mAutofillInputs for the document. This commit changes the pagehide handler to not clear the hash tables or mutation observers with persisted=true (which would also fix the same bug in password manager autocomplete).
This approach comes at the cost of increased memory (hash table entries for fields in session history) but would reduce CPU usage compared to the alternative of re-marking password manager and autofill fields upon every pageshow event. This approach also solves the issue of autofill and password manager autocomplete not working after session history navigation.
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/SwapDocShells
MozReview-Commit-ID: 8DFWuFynDex
--HG--
extra : rebase_source : 496220c356de21f627efe71dab6907b99b2facd1
The patch which originally disabled this seems to have been in error, thinking it was the cause of failing tests on try. Can't provide much more context than that.
MozReview-Commit-ID: 9h1pXVJeDCG
--HG--
extra : amend_source : 0b5bc70daa03efbee141b31e14c6b23ac35df553
The PR_SetEnv() needs the passing string been intentionally leaked. However,
nsRFPService::UpdatePref() uses PR_SetEnv() without leaking the input string.
This patch is going to fix this by using ToNewCString().
MozReview-Commit-ID: 97QQUk2sjM9
--HG--
extra : rebase_source : 10205fe2e9577d5c985572256a5e9842c46d39be
Some tests were using "secret" APIs to get at telemetry knowledge from various
processes in various ways. Adjust them so that they work with the new ways of
doing things.
MozReview-Commit-ID: 2iBL00HVGyg
Previously we assumed count histograms were always present in payloads.
This was an erroneous assumption as count histograms were only 0 if they were
session histograms, or if they were from subsession histograms from subsessions
_after_ a subsession when they held a non-0 value.
So let's just treat count histograms as normal histograms from now on, without
any of this "sometimes 0" nonsense. This simplifies the code, tests, and our
understanding... and _should_ have few/zero downstream effects since the
existing behaviour was so poorly-understood (though exactly tested).
MozReview-Commit-ID: BH108ksygGw