Disabled all instances of test_event_listener_leaks.html scattered across the `dom/` test suite.
There exists a bug, 1530894 to track the failures, which has seen no movement for the 3 weeks it has been on file for.
Differential Revision: https://phabricator.services.mozilla.com/D23755
--HG--
extra : moz-landing-system : lando
And make font-size computation work on the whole font of the parent, not just
accounting for the parent's font-size.
Differential Revision: https://phabricator.services.mozilla.com/D20656
--HG--
extra : moz-landing-system : lando
Small updates to the version control documents regarding
upgrading `robustcheckout.py`. I noticed that we still
reference `build-puppet` from it's former home on hgmo
and don't include OpenCloudConfig in our list of places
we need to vendor `robustcheckout` changes.
Differential Revision: https://phabricator.services.mozilla.com/D23742
--HG--
extra : moz-landing-system : lando
This test uses a Document with a fixed-width meta viewport. This test
simulates resizing the RDM pane from a wide landscape size to a small
square size, and back again. It does this again with meta viewport
support turned on.
Differential Revision: https://phabricator.services.mozilla.com/D22438
--HG--
extra : source : 2fa518cb0dfc656c6f0c5d5dfbad38348be6f31f
There are two viewports: the layout (or content) viewport, and the visual
viewport. This change ensures that we are both setting and checking the
visual viewport size, which is the size shown in the RDM control bar.
It is still possible to get the layout viewport with getContentSize().
Differential Revision: https://phabricator.services.mozilla.com/D22437
--HG--
extra : source : afaf26d7df4235daef3157d74b3bcd69761c6393
This test ensures that when meta viewport width is fixed, and a viewport
is requested with zero width, the viewport is assigned a height equal to
the scaled display height.
Differential Revision: https://phabricator.services.mozilla.com/D22436
--HG--
extra : source : 5bdf0ad9dc6639dd86499fded67183f77407a8ee
Currently the MobileViewportManager leaves somethings permanently changed
even after it is destroyed: it may have changed the resolution of
the Document, and it may have set a fixed size for the visual viewport.
Both of these changes need to be un-done to return to normal display of
the Document.
Differential Revision: https://phabricator.services.mozilla.com/D17999
--HG--
extra : source : 088dc24eabc75eea96301d50550e0a8817f5f809
Once nsIPresShell::SetVisualViewportSize is called, we currently have
no way to restore the default viewport sizing behavior. This corrects that.
We need the default behavior to get correctly-placed scrollbars when
turning off meta viewport handling in Responsive Design Mode panes.
Differential Revision: https://phabricator.services.mozilla.com/D20593
--HG--
extra : source : 178210eb72baa05f877b3a35e0c94d0b23880d13
This fixes a problem in an edge case that we are evidently not testing.
If width is 0 and height is auto, we are currently setting height to
the unscaled (not CSS units) display height value.
In addition to this fix, this patch does two drive-by cleanups of code
that uses "defaultScale":
The redundantly-defined defaultPixelScale is removed.
The masking block-level definition of defaultScale is renamed to bestFitScale.
Differential Revision: https://phabricator.services.mozilla.com/D16774
--HG--
extra : source : 9eebe767ef20b9ec635d90fc9844cf7dbe3403de
Also update ScrollFrameHelper::LayoutScrollbars() to correctly handle
overlay scrollbars when zoomed in in RDM.
Differential Revision: https://phabricator.services.mozilla.com/D20591
--HG--
extra : source : 6a84e97d0e62839c3028a3c3ac89cd944f8e39e5
Due to the p1 patch, the first time we get the result back from NS_ShouldSecureUpgrade is always asynchronously.
This means that the first http request could be completed slower than the http requests opened after the first one. There are some tests affected by this change, since these tests assume that http requests should be completed in the same order as these requests were created.
This patch fixes the tests by introducing a new method in nsIHttpProtocolHandler. This method returns a promise and makes sure the HSTS data is ready to read synchronously when the promise is resolved.
Once the HSTS is ready to read, the order of open/close channels will be the same.
Differential Revision: https://phabricator.services.mozilla.com/D21683
--HG--
extra : moz-landing-system : lando
1. Make nsHttpChannel::OnBeforeConnect async.
2. There are two ways to get the result from NS_ShouldSecureUpgrade. One is getting the result synchronously from the input reference and the other is via the provided callback.
Note that the callback is only used when the storage is not ready to read at startup.
Differential Revision: https://phabricator.services.mozilla.com/D20191
--HG--
extra : moz-landing-system : lando
It's not very easy to understand on its current state, and it causes subtle bugs
like bug 1533654.
It could be simpler if we centralized where the interactions between properties
are handled. This patch does this.
This patch also changes how MathML script sizes are tracked when scriptlevel
changes and they have relative fonts in between.
With this patch, any explicitly specified font-size is treated the same (being a
scriptlevel boundary), regardless of whether it's either an absolute size, a
relative size, or a wide keyword.
Relative lengths always resolve relative to the constrained size, which allows
us to avoid the double font-size computation, and not give up on sanity with
keyword font-sizes.
I think given no other browser supports scriptlevel it seems like the right
trade-off.
Differential Revision: https://phabricator.services.mozilla.com/D23070
--HG--
extra : moz-landing-system : lando
This is the low-risk fix for this issue, that we should get into 67.
What's going on here is that font-family is tracked via the font list, from the
POV of the style system the font list is generally just the
RefPtr<SharedFontList>, but in Gecko there's also mDefaultGenericId.
The way we end up with the right mDefaultGenericId is fishy at best, bogus at
worst. I left various fixmes over time related to a bunch of this code.
After my patch, we end up with a mDefaultGenericId of serif, rather than the
right one (none).
The parent font always has none because nsLayoutUtils::ComputeSystemFont always
sets it to none if the font is known.
Before my patch, PrefillDefaultForGeneric with aGenericId of none (from the
parent), which makes it the default generic id for the current language, serif
in this case.
Before my optimization, apply_declaration_ignoring_phase called
copy_font_family_from, which resets both the font list _and_ the default
generic.
This patch achieves the same effect by not having the first mutation in the
first place.
This code is still terribly fishy in any case, all the _skip_font_family stuff
is just ridiculous. I'll try to clean up a bit after this, but for 68.
Differential Revision: https://phabricator.services.mozilla.com/D23026
--HG--
extra : moz-landing-system : lando
Add histograms to count fingerprinting and cryptomining blocking states per page load.
Differential Revision: https://phabricator.services.mozilla.com/D20389
--HG--
extra : moz-landing-system : lando
This is needed if we want to handle cases like the reporter's example or Google
Images. Rendering the old image upscaled is much better than not rendering
anything while it's loading.
I added a test for the reframing bit, but I don't know how to add a test for the
second bit.
Differential Revision: https://phabricator.services.mozilla.com/D23127
Bug 1472637 makes the decision of whether to construct an image frame not depend
on this, so this is sound.
We need to avoid reframing to fix this bug because otherwise we lose track of
the previously painted image.
Differential Revision: https://phabricator.services.mozilla.com/D23127
This test uses a Document with a fixed-width meta viewport. This test
simulates resizing the RDM pane from a wide landscape size to a small
square size, and back again. It does this again with meta viewport
support turned on.
Differential Revision: https://phabricator.services.mozilla.com/D22438
--HG--
extra : moz-landing-system : lando
There are two viewports: the layout (or content) viewport, and the visual
viewport. This change ensures that we are both setting and checking the
visual viewport size, which is the size shown in the RDM control bar.
It is still possible to get the layout viewport with getContentSize().
Differential Revision: https://phabricator.services.mozilla.com/D22437
--HG--
extra : moz-landing-system : lando
This test ensures that when meta viewport width is fixed, and a viewport
is requested with zero width, the viewport is assigned a height equal to
the scaled display height.
Differential Revision: https://phabricator.services.mozilla.com/D22436
--HG--
extra : moz-landing-system : lando
Currently the MobileViewportManager leaves somethings permanently changed
even after it is destroyed: it may have changed the resolution of
the Document, and it may have set a fixed size for the visual viewport.
Both of these changes need to be un-done to return to normal display of
the Document.
Differential Revision: https://phabricator.services.mozilla.com/D17999
--HG--
extra : moz-landing-system : lando
Once nsIPresShell::SetVisualViewportSize is called, we currently have
no way to restore the default viewport sizing behavior. This corrects that.
We need the default behavior to get correctly-placed scrollbars when
turning off meta viewport handling in Responsive Design Mode panes.
Differential Revision: https://phabricator.services.mozilla.com/D20593
--HG--
extra : moz-landing-system : lando
This fixes a problem in an edge case that we are evidently not testing.
If width is 0 and height is auto, we are currently setting height to
the unscaled (not CSS units) display height value.
In addition to this fix, this patch does two drive-by cleanups of code
that uses "defaultScale":
The redundantly-defined defaultPixelScale is removed.
The masking block-level definition of defaultScale is renamed to bestFitScale.
Differential Revision: https://phabricator.services.mozilla.com/D16774
--HG--
extra : moz-landing-system : lando
Edwin Gao
David Walsh
Emilio Cobos Álvarez
Martin Balfanz
Andrea Marchesini
Connor Sheehan
Steve Fink
shindli
Brad Werth
Kershaw Chang
Yuan Cheng
berkay.barlas
Eitan Isaacson
jlashton
Sebastian Hengst
David Walsh
Erica Wright
Vincent Lequertier