Граф коммитов

78 Коммитов

Автор SHA1 Сообщение Дата
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Kris Maglione 125c4e077a Bug 1509968: Disable subprocess performance task in ccov builds. r=aswan 2019-01-11 20:46:57 -08:00
Mark Banner 0304564ac7 Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:40 +00:00
Csoregi Natalia 9e970681f2 Backed out 2 changesets (bug 1415483) for multiple failures e.g. on test_message_manager_ipc.html. CLOSED TREE
Backed out changeset d00748de66fc (bug 1415483)
Backed out changeset 8dea94258f54 (bug 1415483)
2018-12-11 19:30:57 +02:00
Mark Banner 1abdc8687f Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13754

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:44 +00:00
Gijs Kruitbosch 000eca920e Bug 1498697 - stop polling when there's nothing to poll, restart when processes are re-added, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D8962

--HG--
extra : moz-landing-system : lando
2018-10-30 19:34:22 +00:00
Gregory Mierzwinski 19ecc0e49a Bug 1496791 - Disable linux64-jsdcov completely. r=jmaher
This patch removes linux64-jsdcov from the available builds on taskcluster along with any hacks used to run it. It also removes any 'coverage' entries that were added to skip tests.

Differential Revision: https://phabricator.services.mozilla.com/D7919

--HG--
extra : moz-landing-system : lando
2018-10-05 21:06:25 +00:00
Mark Banner 29ebe3f3a8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : f76738612cb5f78787e9fae8f8c563d5ff5f33d1
2018-07-25 11:00:35 +01:00
Narcis Beleuzu d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner d95c1526b8 Bug 1478308 - Remove unnecessary ChromeUtils.imports in toolkit/ r=mikedeboer
MozReview-Commit-ID: 45Tfs2ZZ06r

--HG--
extra : rebase_source : 10f2f734c883a1ac85b5dee21df119a4c6ae2898
2018-07-25 11:00:35 +01:00
Markus Stange c3f987ce74 Bug 1466620 - Fix a typo in subprocess/docs/index.rst. r=kmag
MozReview-Commit-ID: 6X5J8Vjb3zl

--HG--
extra : rebase_source : e242c37a3a10e89a76b4987386ca26e3fad516e7
2018-06-04 13:15:46 -04:00
Kris Maglione a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Kris Maglione 202290f6bb Bug 1451215: Run codespell on code. r=aswan
MozReview-Commit-ID: HIilZTKcQUY

--HG--
extra : rebase_source : 48ba4b4ac06f6d146ce81050da6c60b6f7c3fbfc
extra : amend_source : cba3e4c100a57889851eaaffff3696d1285655ea
2018-04-03 22:22:07 -07:00
Florian Quèze c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou 9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione 6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Mark Banner db162e24be Bug 1430923 - Change existing instances of 'let EXPORTED_SYMBOLS = ' to use 'var'. r=mossop
MozReview-Commit-ID: A1mX6j9RPrZ

--HG--
extra : rebase_source : a861a48192ca9e90ab7a3642c0bfb59350b5f879
2018-01-16 23:08:35 +00:00
Dustin J. Mitchell 26d48b3202 Bug 1403519 - only build docs when necessary r=gps
This marks **/docs/** as exclusively docs, and code that is autodoc'd as
inclusively docs.

That means that a change that purely modifies documentation files will *only*
run `docs` tasks, while a change that modifies autodoc'd source code will
*additionaly* run `docs` tasks.  The tasks do not run by default.

MozReview-Commit-ID: G9tOK0AwtrI

--HG--
extra : rebase_source : 8dd971e5c9b0eb5f47895664a4ea49442f303ecb
extra : source : 0881de9b2b5e36ec37cc866f1d4af109da57a919
2017-10-02 18:22:56 +00:00
Noemi Erli 1c9bbfbebc Backed out 2 changesets (bug 1403519) for bustage on \python\mozbuild\mozbuild\test\frontend\test_reader.py on a CLOSED TREE
Backed out changeset f53f8adcd578 (bug 1403519)
Backed out changeset 5b293bcd3fc7 (bug 1403519)
2018-01-17 07:23:40 +02:00
Dustin J. Mitchell 00f03c413e Bug 1403519 - only build docs when necessary r=gps
This marks **/docs/** as exclusively docs, and code that is autodoc'd as
inclusively docs.

That means that a change that purely modifies documentation files will *only*
run `docs` tasks, while a change that modifies autodoc'd source code will
*additionaly* run `docs` tasks.  The tasks do not run by default.

MozReview-Commit-ID: G9tOK0AwtrI

--HG--
extra : rebase_source : 8dd971e5c9b0eb5f47895664a4ea49442f303ecb
extra : source : 0881de9b2b5e36ec37cc866f1d4af109da57a919
2017-10-02 18:22:56 +00:00
Margareta Eliza Balazs a331a849a4 Backed out changeset 6d539e4a02bd (bug 1403519) for lint failures on a CLOSED TREE 2018-01-11 22:32:27 +02:00
Dustin J. Mitchell 522245f2f2 Bug 1403519 - only build docs when necessary r=gps
This marks **/docs/** as exclusively docs, and code that is autodoc'd as
inclusively docs.

That means that a change that purely modifies documentation files will *only*
run `docs` tasks, while a change that modifies autodoc'd source code will
*additionaly* run `docs` tasks.  The tasks do not run by default.

MozReview-Commit-ID: G9tOK0AwtrI

--HG--
extra : rebase_source : 8dd971e5c9b0eb5f47895664a4ea49442f303ecb
extra : source : 0881de9b2b5e36ec37cc866f1d4af109da57a919
2017-10-02 18:22:56 +00:00
Kris Maglione c9964bc1d0 Bug 1421459: Follow-up: Fix ESLint bustage.
MozReview-Commit-ID: 1S5ToxLynvB

--HG--
extra : rebase_source : 7351c7332dc4c1328f13e8ab443ed372578510e6
2017-12-08 12:03:59 -08:00
Mark Banner 4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Geoff Brown c75b1f5993 Bug 1410017 - Skip xpcshell test_subprocess_getEnvironment.js on coverage builds; r=me,test-only 2017-10-19 14:06:14 -06:00
Greg Mierzwinski dd30784f5b Bug 1400728 - Disable 'test_subprocess.js' on linux64-jsdcov. r=jmaher
This patch prevents the test 'toolkit/modules/subprocess/test/xpcshell/test_subprocess.js' from running on linux64-jsdcov in the xpcshell suite.

MozReview-Commit-ID: 3dOyN9eSVer

--HG--
extra : rebase_source : 08d74c66b7cc4fb3980f6cef7624196bffd0ab28
2017-10-08 21:56:56 -04:00
Masatoshi Kimura 8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
Doug Thayer 038481f251 Bug 1362786 - (1) Increase subprocess BUFFER_SIZE r=kmag
While 4KiB is a decently sized buffer, bumping it to 32 on my
machine reduced the time for getSymbolsFromNM from 12s to 8s. If
32 is too large for the typical use of this, then we can instead
just parameterize this so that we can specify as large a buffer
as we want for our use case.

MozReview-Commit-ID: 3wGpHzQ9uZ5

--HG--
extra : rebase_source : d36d530dabed3b087c183408bcfbbea868bc85b0
2017-07-21 10:20:36 -07:00
Andrew Halberstadt 21a03ad73c Bug 1383120 - Enable no-arbitrary-setTimeout eslint rule on xpcshell tests, r=mossop
MozReview-Commit-ID: 6DqLaZ9n5EM

--HG--
extra : rebase_source : 5f1264bb3ea23005c91557e5db4ce5f9e167ce9a
2017-07-26 09:08:07 -04:00
Johan Lorenzo 29cda0e191 Bug 1380628 - test_subprocess_environmentAppend fails on the new taskcluster windows instances r=kmag
MozReview-Commit-ID: CI6WGeWwBGo

--HG--
extra : rebase_source : 6b291e338c82a1e5f729a4f443fa0a546f2d14cf
2017-07-17 10:57:19 +02:00
Kris Maglione 510b6f7b72 Bug 1377180: Pass PATH environment variables with partial environment on Windows. r=aswan
MozReview-Commit-ID: JwqvmHJpFcL

--HG--
extra : rebase_source : 6d6acb4cbee0a5cf5d5e45f879c6efb1f46819f2
extra : amend_source : a7762c101531632e34ad1a4cb606202103ee888f
2017-06-29 11:50:39 -07:00
Florian Quèze 7375dcec46 Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop. 2017-06-22 12:51:43 +02:00
Andrew Swan 820b147630 Bug 1338327 Handle .cmd files with spaces in subprocess r=kmag
MozReview-Commit-ID: 9zr97CyY5in

--HG--
extra : rebase_source : 733b47dc230a7809960d8790e88e9616544b0bc1
2017-06-12 14:51:32 -07:00
Kris Maglione b8d0c25853 Bug 1371548: Accept invalid stderr handles when spawning subprocesses. r=aswan
MozReview-Commit-ID: B8FKavo7ksT

--HG--
extra : rebase_source : d2697519cfa2e26fa618c1789b5b9cfe0972f59a
2017-06-10 16:35:14 -07:00
Stephen A Pohl 630acd56de Bug 1364984 - Ensure that our sandbox and tests can handle temp directory paths using symlinks on macOS. r=haik,aswan 2017-06-07 20:40:58 -04:00
Kris Maglione 9c37be53dc Bug 1370027: Part 1 - Cleanly handle a subprocess child being reaped by NSPR. r=aswan
The first time any other code in the parent process uses NSPR (usually via
nsIProcess) to spawn a new process, it spawns a thread to contuously wait for
any child process to exit. This thread winds up reaping our child processes
before we get the chance to wait for them, which leads us to continuously poll
for them to exit.

We don't have a good way to handle this, but checking the error status of
waitpid at least prevents us from failing catastrophically.

MozReview-Commit-ID: 75Z1yUHUmjy

--HG--
extra : rebase_source : db45f781190b6fc84873c32c611134326736a1ba
2017-06-06 16:00:53 -07:00
Mark Banner d1dfdb8a14 Bug 1367232 - Clean up various ESLint global definitions in toolkit/. r=mossop
MozReview-Commit-ID: Hhm4YBansg1

--HG--
extra : rebase_source : 3cb49159fa3f5dae12e4eb21f22e747850fdf184
2017-05-19 09:22:48 +01:00
Florian Quèze 16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze 5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Mark Banner 585bf398ea Bug 1342459 - Enable no-undef on browser/base, and clean up unnecessary no-undef references. r=mossop
MozReview-Commit-ID: KVrAnAjMD1E

--HG--
extra : rebase_source : 7a9651c055e2c6e959d42d08e5be9de2e2265346
2017-04-03 11:46:56 +01:00
Kris Maglione 0638745d18 Bug 1352893: Handle non-UTF-8 data in Unix environment variables. r=mstange
MozReview-Commit-ID: 5aRVYQICc7O

--HG--
extra : rebase_source : 6244a8ba08bad6da90496f27e9bb4eaace5e6fb9
extra : amend_source : f997353c8b075c989ace2790ae73330fd375b558
2017-04-02 18:46:10 -07:00
Mark Banner bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Kris Maglione 3a889a957c Bug 1340735 - Terminate process when failing to attach it to job group. r=mhowell
MozReview-Commit-ID: BVCPRFH6TV2

--HG--
extra : rebase_source : b765bf337bed6b983b2c3012c67f979f2faac771
2017-02-17 15:30:24 -08:00
Kris Maglione 17c8da5586 Bug 1321637: Fix execution of batch files with spaces in path. r=mhowell,aswan
MozReview-Commit-ID: 8Q3KFLnXEkl

--HG--
extra : rebase_source : 2a5fa3acfb89c8492da23eee3e0340fd534fc026
2017-01-22 16:23:33 -08:00
Mark Banner 16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Mark Banner 582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
2017-01-09 10:12:26 +00:00