We only need to default `browser.urlbar.merino.enabled` to true. If the user has
opted in (either through the modal or by toggling on the data collection pref in
the prefs UI), then `quicksuggest.dataCollection.enabled` will also be true and
we'll fetch Merino suggestions. Otherwise it will be false and we won't fetch
Merino suggestions. That logic is implemented here:
https://searchfox.org/mozilla-central/rev/9a5f36b0ddb9cb8ae556fc5b45f8ccea0f0da6f8/browser/components/urlbar/UrlbarProviderQuickSuggest.jsm#144
Note this defaults the pref to true for everyone, even users in offline. It make
senses now that we have a separate toggle for data collection in the preferences
UI. Even offline users can opt in to Merino and data collection.
I also updated the various sets of prefs for test suites so that the Merino
endpoint URL is empty when running tests so they don't hit the network. I could
have forced `merino.enabled` to false instead, but setting the endpoint URL has
a couple of benefits, although admittedly they're very small:
* It runs a little more of the Merino code path (i.e., calls
`_fetchMerinoSuggestions`)
* It lets Merino tests set only one pref, the endpoint URL, instead of two, both
the endpoint pref and enabled pref
Differential Revision: https://phabricator.services.mozilla.com/D131988
Currently, many of the test harnesses are relying on the default value of this
pref to turn it off. Once the default value switches to 'true', they will all
suddenly start running with fission.
We explicitly set it to false to avoid this. Tasks that enable fission via
config will override this value.
Once the default value is switched and riding the trains, we can look into
removing this and adding configuration to disable rather than enable it.
Differential Revision: https://phabricator.services.mozilla.com/D129309
Bug 1529323 changed prefers-color-scheme to follow the Firefox theme. This
means that dev-edition has a dark prefers-color-scheme by default, because it
uses the dark theme.
Reftests rely on light color-schemes among other things because about:blank
draws a dark background when the user prefers a dark color scheme if it has no
opener.
Differential Revision: https://phabricator.services.mozilla.com/D128676
Bug 1529323 changed prefers-color-scheme to follow the Firefox theme. This
means that dev-edition has a dark prefers-color-scheme by default, because it
uses the dark theme.
Reftests rely on light color-schemes among other things because about:blank
draws a dark background when the user prefers a dark color scheme if it has no
opener.
Differential Revision: https://phabricator.services.mozilla.com/D128676
* Add a new browser.startup.couldRestoreSession.count which counts up (max 2) each time we *could* restore a session
* Show the new infobar notification when that count reaches 1 (i.e. skip it on the first startup after update)
* New strings for the notification - including an inline icon image for the ☰
* The notification's button opens the app menu.
* Allow Opt-out with a pref value of -1, and opt-out the testing user by default so our perf tests don't trip on it.
Differential Revision: https://phabricator.services.mozilla.com/D125904
Adds a pref to perform about:blank document loads which have system
triggering principals within the existing process, rather than doing a
process switch. This can be used in performance tests which load
about:blank and do not expect process switches.
Differential Revision: https://phabricator.services.mozilla.com/D122405
NPAPI plugins are no longer supported. MozPaintWait and MozPaintWaitFinished events are no longer sent -- they came exclusively from nsPluginInstanceOwner, which was removed in bug 1682030.
Differential Revision: https://phabricator.services.mozilla.com/D114021
See the comments as for this might be unexpected. The tests could be
fixed but seems like footgunny, so for now this seems better.
For future reference, the line causing the events getting dispatched to
the wrong document is the IsPrimaryFramePaintSuppressed call in
PuppetWidget::GetCurrentWidgetListener(), which causes
widget->DispatchEvent from nsContentUtils::SendMouseEvent to dispatch
the event to the wrong page.
Differential Revision: https://phabricator.services.mozilla.com/D109807
This dates back to a time before the browser console where the normal content
console could optionally show chrome code messages. Today it serves no use.
Differential Revision: https://phabricator.services.mozilla.com/D108130
Bug 1357785 accidentally omitted the flag on the interface itself. This patch makes thing consistent to prevent potential confusion in feature detection.
Differential Revision: https://phabricator.services.mozilla.com/D107742
Bug 1357785 accidentally omitted the flag on the interface itself. This patch makes thing consistent to prevent potential confusion in feature detection.
Differential Revision: https://phabricator.services.mozilla.com/D107742
TLS error report sending was disabled by default in bug 1579906. The server
that ingested these reports has been decommissioned as well, so this patch
removes this dead code.
Differential Revision: https://phabricator.services.mozilla.com/D99405
Recording events involved asking whether they should go in the event ping or
not, and also whether we hit the limit for how many are allowed in a ping.
These values are stored in prefs which aren't terribly accessible off the main
thread, even if the event recording is.
Both of these prefs have been set in stone in their default values for over two
years now, so we can safely remove them and their scaffolding. Huzzah!
Differential Revision: https://phabricator.services.mozilla.com/D96102
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Patch by Bernard Igiri <bigiri@mozilla.com>
Replacing async events with async method calls that use JSWindowActors to communicate with the parent process.
This will simplify these calls, bring the relevant code into local scope, and eliminate the need for MessageChannel.
Eliminating the MessageChannel dependency allows us to move the ASRouter initialization out of ASRouterFeed and into
JSWindowActors.
Differential Revision: https://phabricator.services.mozilla.com/D71796
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
I would redirect Glean-sent pings instead of suppressing them, but network
errors seem to be causing unrelated failures in
toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js
Differential Revision: https://phabricator.services.mozilla.com/D88980
Drew Willcoxon
criss
Niklas Goegge
afinder
Chris H-C
Andrew Halberstadt
Emilio Cobos Alvarez
Marian-Vasile Laza
Sam Foster
Andrei Oprea
Nika Layzell
Nan Jiang
Sonia Singla
Michael Cooper
Csoregi Natalia
Julian Descottes
David Parks
Valentin Gosu
imoraru
James Graham
Marco Bonardo
Kagami Sascha Rosylight
Ted Campbell
Dorel Luca
Dana Keeler
Sylvestre Ledru
Ricky Stewart
Jared Wein
Bogdan Tara
Mihai Alexandru Michis
Bernard Igiri
Punam Dahiya
Cosmin Sabou
Christoph Kerschbaumer