The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
With APZ this is handled because starting a swipe interrupts the PanGesture input block, and momentum events don't start a new input block so APZ ignores them.
--HG--
extra : commitid : 83ArxgT5QUT
extra : rebase_source : afccf434dc0e309f972ff9851efc018374f0f5f6
Having this event means that we don't have to wait for content to find out whether it's scrollable in the case that no swipe should be happening anyway.
IGNORE IDL because I'm only changing comments in the IDL files.
--HG--
extra : commitid : 22814fSLcIz
extra : rebase_source : e51b4db26333275c9bcb3fd7fece78b7d3653275
This was intended for a snapshot-based overscroll animation which we're not going to use because APZ solves the same problem in a much better way.
--HG--
extra : commitid : BlfYHzREaWB
extra : rebase_source : c2b503dc9ed3b9a49ebb9626447dfedc627d1b4f
NSEvent timestamps are relative to the system start time, not to the reference date.
--HG--
extra : commitid : shDNTICmQP
extra : rebase_source : 2f45dc0e8acc83d5c7379554dfdd6090af694c89
extra : histedit_source : 75add13c0cbcafdafb14e052edea67bd4a0317e2
This is motivated by three separate but related problems:
1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).
2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).
3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.
The solve this, this patch does the following:
1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
Masayuki Nakano
Steven Michaud
Jonathan Watt
Nicholas Nethercote
Markus Stange
Xidorn Quan
Ryan VanderMeulen
Benoit Girard
Chris Manchester
Matt Woodrow
Nick Robson
Kyle Huey