It's possible for gBrowser.selectedTab to be set to null. This should be a no-op, but this
part of webrtcUI that tabbrowser calls doesn't handle the case, and causes an exception to
be thrown. This patch allows the no-op case to occur properly.
Differential Revision: https://phabricator.services.mozilla.com/D76736
These features allow the indicator to not pull focus from the originating window, which
is important to maintain user task continuity, especially for screenreader users.
Differential Revision: https://phabricator.services.mozilla.com/D76735
The lifetime of the template is tied to the lifetime of the RegExpShared, and every RegExpShared is tenured, so there's no point allocating this in the nursery.
Depends on D76754
Differential Revision: https://phabricator.services.mozilla.com/D76755
This is a silly thing to support, but I'd rather support it here than push an irregexp patch upstream to make it possible to reject this as a syntax error.
Differential Revision: https://phabricator.services.mozilla.com/D76751
We have evidence that some sites have disabled ciphersuites with SHA-1-based
MACs due to attacks against SHA-1 (disregarding the fact that these attacks
don't necessarily apply to HMAC-SHA-1) while still relying on RSA key exchange.
Before this patch, PSM did not enable any ciphersuites with RSA key exchange
and non-SHA-1-based MACs. Consequently, Firefox would be unable to connect to
these sites while other browsers would.
This patch enables TLS_RSA_WITH_AES_128_GCM_SHA256 and
TLS_RSA_WITH_AES_256_GCM_SHA384, which are the only two ciphersuites (other
than grease) that Chrome enables that Firefox did not (before this patch).
Differential Revision: https://phabricator.services.mozilla.com/D76543
`StaticAnalysisMonitor` uses `clang-tidy` config dictionary in order to
match different options for the checkers that are being used. For this `StaticAnalysisMonitor`
modifies this dictionary. The dictionary not being a deep copy of the original one, the
modifications are echoed in the initial dictionary thus having the potential to lead to
unexpected behavior from `clang-tidy` when generating the checkers list.
Differential Revision: https://phabricator.services.mozilla.com/D76834
The original patch add `run-on-projects` to `TEST_VARIANTS`, but nothing
currently looks at that. Move it into a `replace` block, which gets merged with
the task definition.
This is enough to handle this specific change, but if more control is needed
per-test, we should revisit how this is handled. Fission supports
`fission-run-on-projects` and `fission-tier` to override those values based on
the variants, but it would probably make sense to generalize those to have more
general way of specifying variant-specific configuration.
Differential Revision: https://phabricator.services.mozilla.com/D76772
Changes:
Current in-tree code will simply print `{path}` as many times as it reads a path.
This change will ensure that paths that have been read are output to the screen, which is much more useful.
Differential Revision: https://phabricator.services.mozilla.com/D76729
This code was not being built any more.
GeckoView requires Android OS version 4.3 (API Level 18). I'm not sure what the
corresponding ANDROID_VERSION macro constant for API Level 18 is, but it's
definitely higher than 16.
Differential Revision: https://phabricator.services.mozilla.com/D73940
In order to retrieve the list of impacted element for a given CSS warning,
we are evaluating a document.querySelector expression,
using the cssSelector we get from the error itself.
But if the warning message comes from an iframe, we are not retrieving the
impacted elements, only items from the top-level document.
By storing the target actor id a message is emitted from directly in the message
itself, we can retrieve the target front, and use it to do the evaluation against
the right target.
This is not enough though, as non-remote frame don't have a dedicated target,
and we'll be back at square one, using the top-level document to do the evaluation.
In order to fix that, we're passing the innerWindowID to the evaluateJSAsync method,
so it can be used on the server to retrieve the window instance we need.
A test is added to ensure this feature works as expected for iframes, and it
passes with or without fission enabled.
Differential Revision: https://phabricator.services.mozilla.com/D75811
This will allow resource consumers to have a direct access to the target front
a resource was issued from.
At the moment we only use it in the console, where the targetFront is placed
on the console messages.
Differential Revision: https://phabricator.services.mozilla.com/D76790
This patch attempts to fix the long-running customv8 toolchain tasks by adding a --force to the `fetch v8` call. This additional option prevents `fetch` from checking for existing .gclient files (which should never exist) to help with the long delay we are seeing in this call.
Differential Revision: https://phabricator.services.mozilla.com/D76857
This patch surfaces the timeout value for ADBDevice.
It also adds the ability to run a single test with
mach perftest-test and a new --skip-lint option
to skip black/flake8
Differential Revision: https://phabricator.services.mozilla.com/D76791
This patch updates the vendored `attrs` python module from v18.1.0 to v19.1.0 since the older version fails in some pytest features.
Differential Revision: https://phabricator.services.mozilla.com/D76713
This patch fixes a bug where a PosixPath is attempted to be used rather than a string path. There's also a regression in the coverage test run in `./mach perftest-test` on some platforms that is fixed by this patch (the attrs module being used by pytest is too old, so we update during setup). Lastly, a regression test is added to the browsertime tests to ensure that the command only contains knowingly compatible types.
Depends on D76713
Differential Revision: https://phabricator.services.mozilla.com/D76599
Mike Conley
Bogdan Tara
Byron Campen [:bwc]
David Major
Iain Ireland
Sylvestre Ledru
Tom Schuster
alwu
Michael Kaply
Dana Keeler
Andi-Bogdan Postelnicu
Tom Prince
Agi Sferro
Liang-Heng Chen
egao
Sebastian Hengst
Markus Stange
Kartikaya Gupta
Erica Wright
Tarik Eshaq
Emilio Cobos Álvarez
Nan Jiang
Nicolas Chevobbe
Belén Albeza
Gregory Mierzwinski
Tarek Ziadé
Nihanth Subramanya