The code was knowingly broken (because of bug 585123). But that bug is closed,
and the broken code is causing asserts to fire in bug 1624488 because well, it's
broken ;)
Differential Revision: https://phabricator.services.mozilla.com/D68973
--HG--
extra : moz-landing-system : lando
This is cleaner and allows to reuse this logic for some experiments I have :)
Differential Revision: https://phabricator.services.mozilla.com/D67354
--HG--
extra : moz-landing-system : lando
Changing this pref can cause serious breakage with fission, as multiple URLs
from the same origin will not be sent to the same process. By locking the pref,
we'll prevent people from accidentally breaking their experience.
Differential Revision: https://phabricator.services.mozilla.com/D68894
--HG--
extra : moz-landing-system : lando
This patch fixes a couple bugs in WasmIonCompile for multi-value calls:
* Stack result areas were not being correctly aligned
* GVN would consider MWasmDerivedPointer instances to be equivalent if
they had the same base pointer but different offsets
Differential Revision: https://phabricator.services.mozilla.com/D68989
--HG--
extra : moz-landing-system : lando
Stop generating line/column and breakpoint SrcNotes for self-hosted code.
They have minimal value since the realm is very restricted and use 40kB of
bytecode space.
Note that self-hosted functions still have initial lineno/column information
and this only concerns the fine-grained locations within a function.
Differential Revision: https://phabricator.services.mozilla.com/D68943
--HG--
extra : moz-landing-system : lando
The byte readers in WasmOpIter.h do not themselves signal error beyond
returning false. The caller must always signal a proper error (or
delegate to another caller who does the signaling), or the decoding
error will ultimately be signaled as an OOM.
Differential Revision: https://phabricator.services.mozilla.com/D68957
--HG--
extra : moz-landing-system : lando
Instead of at a later point. This prevents stuff getting out of sync during that
time, which can cause assertions to fire.
Differential Revision: https://phabricator.services.mozilla.com/D68978
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
[css-flexbox] Move justify-content-space-between.html to WPT
This CL migrates this test out of
third_party/blink/web_tests/css3/flexbox and into the WPT-specific
directory, adding links to the relevant specs and a test assertion
describing its purpose and renames it to
justify-content_space-between-002.html.
Bug: 1063749
Change-Id: Ib4c2a87c230e1e8865be868e7bfc7d5273bcc865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121639
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754076}
--
wpt-commits: 87d5aa9c7d0863bdf310778449365bb515e787b3
wpt-pr: 22461
Automatic update from web-platform-tests
[css-flexbox] Move min-size-auto.html from css3/flexbox to WPT
This CL migrates this test out of
third_party/blink/web_tests/css3/flexbox and into the WPT-specific
directory, adding links to the relevant specs and a test assertion
describing its purpose and renames it to
flex-minimum-size-002.html
Bug: 1063749
Change-Id: I1bb8d941d41a61c984b6431808302eb3d051a50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123500
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754073}
--
wpt-commits: a2c62c8f3ee7ee9ce9cec23e28f4fa2bd5c040df
wpt-pr: 22495
Automatic update from web-platform-tests
Ignore test suite third_party/ directories for lint
See https://github.com/web-platform-tests/rfcs/issues/46
--
wpt-commits: a0d78a7e1b038652bc6d65170f3e994475ecff9c
wpt-pr: 22498
Automatic update from web-platform-tests
[css-flexbox] Move flex-item-contains-strict.html test to WPT
This CL moves flex-item-contains-strict.html test from
css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, a proper title,
and test description.
Bug: 1063749
Change-Id: I5559de07cc72a44a36ed39c951562a156dfeabca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123695
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754029}
--
wpt-commits: 1d7656ff988d83460ee4d120b8aaa2ceb6edb53f
wpt-pr: 22485
Automatic update from web-platform-tests
[css-flexbox] Migrate flexbox-height-with-overflow-auto.html to WPT
As part of this move, the test was renamed to flexbox-overflow-auto-002.html.
BUG=1063749
R=dgrogan@chromium.org
Change-Id: I35b258bed47050051139020a1fc3147d08333fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120544
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754006}
--
wpt-commits: 7058baaa1d48f57f6829e03518a2662b229e2908
wpt-pr: 22480
Automatic update from web-platform-tests
[css-flexbox] Move columns-center-with-margins.html test from css3/flexbox to WPT
Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.
Bug: 1063749
Change-Id: I46beff57bed22cd3b1795c10d7195ad7cfdd2324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121938
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753932}
--
wpt-commits: a11782a293251324be969b6ad59d4e99a9850dfa
wpt-pr: 22471
Automatic update from web-platform-tests
Fix fetch-request-css-cross-origin.https.html
The upstream change [1] updated assert_throws_dom() but it seems
the test wasn't updated together. Update the test to pass a
constructor to follow changes which are done by the upstream change.
[1] 4ba5bc3847
Bug: 1054772
Change-Id: Icb6edae96758445a861634e330072c364084ee4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123571
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753924}
--
wpt-commits: 169a1410bfe8e517d79852144555dd49ea1f597a
wpt-pr: 22486
Automatic update from web-platform-tests
[css-flexbox] Move flex-flow-2.html test from css3/flexbox to WPT
This CL moves flex-flow-2.html test from css3/css-flexbox
to external/wpt/css/css-flexbox with WPT styles, adding links
to the relevant specs, and test description.
And, this CL renames it to flex-flow-013.html to be aligned
with existing flex-flow-foo.html tests.
Bug: 1063749
Change-Id: I4cd766d7045bb778a3c27061c68141ad64455b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121116
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753919}
--
wpt-commits: d1386dd632359290bf91eb6f0de76fc5d01fbdd7
wpt-pr: 22456
Automatic update from web-platform-tests
[css-flexbox] Move intrinsic-width-orthogonal-writing-mode.html to WPT
Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.
Bug: 1063749
Change-Id: Iff9dc7fece854d8500a6ce2ff62625197a36cab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120842
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753916}
--
wpt-commits: 704ff1def0e174a9e3a9388b749c45f15c8bae4d
wpt-pr: 22462
Automatic update from web-platform-tests
[css-flexbox] Move flex-flow-auto-margins-no-available-space-assert.html test to WPT
This CL moves flex-flow-auto-margins-no-available-space-assert.html
test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT
styles, adding links to the relevant specs, and test description.
Bug: 1063749
Change-Id: I6775022c3fc8572f78e7ec19ad88b91dfdcb7a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120665
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753900}
--
wpt-commits: 35d0775e049ee7ad3582b44f7ea376dcae4150c5
wpt-pr: 22459
Automatic update from web-platform-tests
Missing ClearNeedsStyleRecalc() for ::first-letter.
A FirstLetterPseudoElement is marked for style recalc when the text node
the first letter belongs to is removed from the DOM tree. On the next
style recalc, if the first-letter's originating element is inside a
subtree marked for layout tree re-attachment, or one of its descendants
are marked for re-attachment, we delay the first-letter style update
until UpdateFirstLetterPseudoElement is called for the
kRebuildLayoutTree or kAttachLayoutTree phases. For the former, we call
RecalcStyle which will ClearNeedsStyleRecalc, but ofr the
kAttachLayoutTree phase, we called StyleForLayoutObject without clearing
the dirty flag.
Bug: 1064595
Change-Id: Ibebb9c358b473f61b1cff49a7c5ec43bf6894408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122347
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753806}
--
wpt-commits: a5094e5aa21dede70be07dc94f41ad7e8ca6d48b
wpt-pr: 22479