Added a test verifying that all experimental preferences have a default value.
Updated all experimental preferences to have a default value.
Differential Revision: https://phabricator.services.mozilla.com/D106959
And fix existing users of course.
The frame loader one is the only one slightly scary (but if it causes
trouble we could make nsObjectLoadingContent::Unlink a no-op).
Differential Revision: https://phabricator.services.mozilla.com/D107269
This avoids an issue where we end up with invalid sizes if the metadata in a
webm file has a greater resolution than the in band video data.
Differential Revision: https://phabricator.services.mozilla.com/D107725
This patch
- adds several test files derived from bipbop.mp4. These files are re-encodes
that used vp8 and opus. One reference file is added with metadata that is
correct, and several others are added with bad metadata (it doesn't match the
stream resolution).
- adds these files to the `gPlayTests` to ensure we can play them.
Differential Revision: https://phabricator.services.mozilla.com/D107723
Whether or not we use a native texture or something else is affected by our
backend and the size of the texture. This patch adds a new function to
centralize that logic in TextureHost, and applies it in callsites that were
checking the backend to determine an image type.
Differential Revision: https://phabricator.services.mozilla.com/D106568
Depends on D107099
With the previous patch, we are waiting for toolbox open before creating contexts.
This makes some tests a bit racy if they are only waiting for toolbox open. They should also wait for the context to be ready.
Firing an event from the devtools_page seems to work fine for this but don't hesitate to suggest a better approach.
Differential Revision: https://phabricator.services.mozilla.com/D107100
Depends on D106426
Without this patch queue, `createDescriptorForTab` was not caching its descriptors, so each call to it would yield a new descriptor.
Since the webextension codebase really needs to use a different target from the one used by the DevTools toolbox, suddenly sharing the Toolbox's descriptor was an issue.
Addressing it with an explicit parameter to make this expectation from the webextension codebase a bit clearer for us.
Differential Revision: https://phabricator.services.mozilla.com/D107052
Since the submetric deals with IPCPayload, the submetric needs to know its
label. We could add that to CounterMetric::Child, but adding an optional label
to the child variant of CounterMetric looked strange.
So instead, I introduce the Labeled*Metric types.
Well, LabeledStringMetric and LabeledBooleanMetric are just re-exports.
But LabeledCounterMetric knows its label in non-parent processes.
And in parent processes it just acts like a normal CounterMetric, thanks to the
metric traits.
To figure out how to handle all these types it encouraged me to remove lambdas
from the MLA FFI and solve it with hygienic identifier capture instead. Bonus.
Here's hoping I don't regret this additional level of abstraction later.
Differential Revision: https://phabricator.services.mozilla.com/D107667
Firefox sometimes caches intermediate certificates from verified connections in
case they are useful in the future. This operation involves modifying the NSS
cert database, and so should only be done on the socket thread (ideally when it
is idle).
Differential Revision: https://phabricator.services.mozilla.com/D106230
This enables the module that queries OS storage for client certificates when
TLS client authentication is requested by a server. This applies to macOS and
Windows only.
Differential Revision: https://phabricator.services.mozilla.com/D107558
Whether or not we use a native texture or something else is affected by our
backend and the size of the texture. This patch adds a new function to
centralize that logic in TextureHost, and applies it in callsites that were
checking the backend to determine an image type.
Differential Revision: https://phabricator.services.mozilla.com/D106568
I also noticed while trying out this patch that the context menu navigation
icons really need to also scale with the font size, so I've fixed that here
along with the submenu arrows.
Differential Revision: https://phabricator.services.mozilla.com/D107570
Just return a simplified set of operations (basically rects to fill and the
thumb, which is a bit more complicated but not all that much).
Differential Revision: https://phabricator.services.mozilla.com/D107688
This reftest seems to have strange interactions with the reftest harness on
Android. Disable this for now until we have a better idea what's going on.
Differential Revision: https://phabricator.services.mozilla.com/D107781
Overlays for content prompts that are opened with tabdialog box occupy the entire browser viewport when RDM is opened. This is because `.dialogStack` is `position: fixed` to remove it from the grid layout and to avoid issues with scrolling when the simulated viewport is larger than the device viewport. The simulated viewport causing overflow is the reason why `position: absolute` might not be what we want to use here.
Now we have to deal with the problem of the overlay covering other browser UI.. To deal with this, this patch reuses the resize observer to store the `.browserStack` sizes so that `.dialogStack` can use these values to resize the modal overlay when other browser UI occupy the space of the browserStack (such as DevTools or the findbar).
Differential Revision: https://phabricator.services.mozilla.com/D107501
Currently if the region/locale default is hidden, the search service will try and revert to the first non-hidden engine, this might be a shopping or dictionary based engine which is not as useful as a general search engine.
Differential Revision: https://phabricator.services.mozilla.com/D106783
* `_format_metadata()` had unused parameters
* `debugger_args` weren't used after being `shellutil.split(...)`
* There was dead python2-specific-code after a `return` statement
Differential Revision: https://phabricator.services.mozilla.com/D106970