<!-- Please describe your changes on the following line: -->
This patch will fix the -webkit-linear-gradient direction issue in Stylo. I decided to NOT change the behavior of Servo, because according to the webcompat spec the webkit prefixed version should just be an alias of non-prefixed version. But we might want to remove support for old syntax like "-webkit-linear-gradient(top, ...)" (without "to"), because they are not in the spec anymore.
The Gecko layout system use different coordinate systems for prefixed and non-prefixed version, so I did a conversion, but for Servo I keep the modern version only.
Since I believe we should not support old syntax in Servo, so I'm not going to put the test in Servo. I'll submit my test cases to the Gecko wpt test instead.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix [Bug 1372821](https://bugzilla.mozilla.org/show_bug.cgi?id=1372821)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because test will be submitted to the Gecko side
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 9070ca1c3c058b8f13eb7dac4d075007468eff30
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 63a2ee9b59dbe7766e66602dec8a9e7e3bb5eacd
In particular, this fixes:
* Restyling of <area> elements that reuse the primary frame mapping for the
image map.
* Restyling of children of display: contents elements when the display:
contents element generates a hint.
* Restyling of out-of-flows (if my analysis in the bug is right).
* Restyling of the ::backdrop pseudo-element.
* Restyling of the Viewport frame.
I only managed to do a reftest for the second one, but the rest of them are
covered by the assertions added.
MozReview-Commit-ID: E7QtiQ1vPqu
--HG--
extra : rebase_source : 89085d96103ca743ba95ba61feeac68d24e8d307
In some cases the click command can trigger the closing of the
currently selected tab or window. To not cause a hang when waiting
for a response from the removed framescript, the tab and window
closing events have to be observed. Also the command has to return
immediately.
MozReview-Commit-ID: 9WeXryrKEJr
--HG--
extra : rebase_source : a7a23cf19e55eecbf957d48c2182a601d63d0909
Beside Errno 57 there is also Errno 107 (Transport endpoint is not
connected) which can happen in case of an unexpected crash/shutdown
of Firefox. Then calling shutdown() on the socket to stop the
communication will fail.
This is most likely a race and can happen after receiving a reply
from the server, and before sending another command.
MozReview-Commit-ID: 3S5Ko4XVUAJ
--HG--
extra : rebase_source : 59d79ab5da2c4e67b64bc90501660a7603a993c8
Tests are causing issues for us due to slow running builds and
delayed creation of minidump files. Also we don't see a value
yet to have those tests running for ASAN. Once bug 1348961 is
fixed we could re-evaluate.
MozReview-Commit-ID: BZHa1O5F6ep
--HG--
extra : rebase_source : 28e1977607eb803c4167315cf32f56e5b2e0ba31
In case of delayed shutdowns of Firefox we currently miss to detect the
created minidump files because the mozcrash mock gets removed right after
the crash causing command has been executed. To prevent this the mock
has to be active from setUp until tearDown.
Also we should not silently ignore the case that the minidump folder
cannot be deleted. Because it means no crash happened, or the folder
has not been created.
MozReview-Commit-ID: KncJ5BHi7M5
--HG--
extra : rebase_source : 63c947b0a7fe16de0eed19a8e0359721d9f4051d
Reorder imports so that global ones are done before local imports.
MozReview-Commit-ID: 7xA9XQlxlj4
--HG--
extra : rebase_source : b144401c5c6c47e87beab669f76f2b61fb79e5b6
It will help a lot for debugging when the outer window id of the
content window gets logged when the frame script gets registered.
MozReview-Commit-ID: D64A1nPEs6l
--HG--
extra : rebase_source : 0e592e10cb1a0979f4331b92dbfcfc905e737120
The testcase file clicks.html contains a couple of elements which are
not in use, and makes it hard to keep an overview what's actually used.
Lets refactor it to only keep what's really needed.
MozReview-Commit-ID: D9PVWUSmOHr
--HG--
extra : rebase_source : 0ecc3400c7e291f7923db1e93884b1d279a5e6e9
This commit
- adds onboarding tour notification
- shows still not completed onboarding tour notifications in order
- opens target tour from tour notification for the target tour
MozReview-Commit-ID: AwLtwjoeARQ
--HG--
extra : rebase_source : 264531cf8aaf3f636faecf790a269d0166188f8a
When debugging the test failures in this test, I noticed that the info() messages indicated we *were* using
moz-extension icon references even when we shouldn't be - they just didn't include the 'fox.svg' bit.
When pausing in the debugger, you can see that all the buttons are blank - we don't load any icon in this case.
This seemed bad, so I updated the test to actually check if we're using a moz-extension URI at all,
and then updated the implementation to actually make it work.
MozReview-Commit-ID: GGXaivJrzxj
--HG--
extra : rebase_source : a64bed37e1fb27c164a0543a0465038d251c709d
This also paves up the ground to be able to fix#16825.
Source-Repo: https://github.com/servo/servo
Source-Revision: 79ee821bef68e371b104a7af4fb657460362ff1d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0417d1054406027072f6567bb6f123d3e9d5efc8
Change how comments are handled due to ESLint's 4 reworked comment handling.
MozReview-Commit-ID: BG4cvbhy45Z
--HG--
extra : rebase_source : 8fc4d40bf2a8cb74be7964c9d308c056edf51058
Generally we use computed values for `@font-face` rule descriptors but that descriptor is a bit different than the others in gecko side. It accepts strings instead of unsigned integer(which is computed value of this property). So we had to use SpecifiedValue for that in here.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1355364](https://bugzilla.mozilla.org/show_bug.cgi?id=1355364)
Source-Repo: https://github.com/servo/servo
Source-Revision: 2843eb5ddf0c8170854eb420774bd5a34bc6710d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 16c60065370286715fd5a8459c7707b858e1504c
With JSM global sharing, the Debugging object is no longer a property
directly on the global of the Sqllite object. Instead of going through
this back door, add a setter method to Sqllite and use that.
MozReview-Commit-ID: HVCZ4Zb42q7
--HG--
extra : rebase_source : d54a0a143c2cd89a8543fd8b3f938abdbec96859
When you start new composition during converting with Mozc in e10s mode, the following things occur:
1. Mozc commits previous composition.
2. Gecko dispatches eCompositionCommit event.
3. Mozc sets new composition string (skipping composition start signal).
4. Gecko dispatches eCompositionStart and eCompositionChange event.
5. Selection is changed asynchronously.
6. Gecko sets position of IME windows.
At #4, Gecko stores start of composition as selection start, then, trying to adjust it at #5. However, new selection is caret position in new composition string. Therefore, it's not used for the adjustment. This causes that stored composition start offset is always the start of the previous composition (if the previous patch didn't change EnsureToCacheSelection() behavior). So, IMContextWrapper needs to compute proper composition start offset in this case.
The simplest fix is, modifying selection at #2 as which will be occurred in focused editor. So, this patch makes the selection cache collapsed to the end of committing string.
Note that actual selection may be different if JS changes selection and/or the text in the focused editor. However, it doesn't matter. IMContextWrapper should behave as expected while current composition is active.
MozReview-Commit-ID: 221mDUd8yRP
--HG--
extra : rebase_source : 571b2de85ed6ea1fdadea73b7f95507937cc60e9
IMContextWrapper::EnsureToCacheSelection() always queries actual selection when the caller needs selected string. However, this may be expensive and this is bad behavior for the following patch because it wants to emulate selection range until receiving next selection change notification.
Therefore, this patch makes IMContextWrapper::Selection store selected string instead of just its length like other native IME handlers
Additionally, this patch renames IMContextWrapper::mSelectedString to IMContextWrapper::mSelectedStringRemovedByComposition for making the difference between it and the new string in Selection clearer.
MozReview-Commit-ID: 3bygvW7sKf4
--HG--
extra : rebase_source : b0835b8c1607ecd647444a4d984980943a6fd570
Evan Tseng
Anthony Ramine
Mark Banner
Kartikaya Gupta
Mantaroh Yoshinaga
Matt Howell
Shing Lyu
Emilio Cobos Álvarez
Xidorn Quan
David Burns
Henrik Skupin
Fischer.json
Masatoshi Kimura
Gijs Kruitbosch
Henri Sivonen
Rail Aliiev
Nazım Can Altınova
Brad Werth
Andrew McCreight
James Graham
Raajit Raj
Bobby Holley
John Lin
J. Ryan Stinnett
Masayuki Nakano