Added the shared accordion css to the console's index file so
that the xhr request tabs get the accordion style updates.
Differential Revision: https://phabricator.services.mozilla.com/D64587
--HG--
extra : moz-landing-system : lando
This patch adds more test cases so we also check
deep-properties with the same shared value can
still be expanded.
A helper is added so it's easier to visualize the
actual state of the scopes panel.
Differential Revision: https://phabricator.services.mozilla.com/D64543
--HG--
extra : moz-landing-system : lando
CLOSED TREE
Backed out changeset 0ee1ac6bab06 (bug 1609942)
Backed out changeset 2357c3d7aa4a (bug 1616847)
--HG--
extra : histedit_source : 2b51afa3c551d06d8ca8b3a35ab0466be1921400
This prevents the popup to cover the eager evaluation result.
In order for the popup to be able to appear outside of the
toolbox, we pass the useXulWrapper option to the HTMLTooltip.
Differential Revision: https://phabricator.services.mozilla.com/D62431
--HG--
extra : moz-landing-system : lando
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.
With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.
Differential Revision: https://phabricator.services.mozilla.com/D63488
--HG--
extra : moz-landing-system : lando
The RDM toolbar currently scrolls with the page when there is overflow in `.browserStack`. This is because the browser viewport can be set to a size larger than browser window. The solution here sets makes the toolbar `position: fixed` and utilizes the `ResizeObserver` to adjust the size of the device modal/selector to take up the size of the browser stack.
Differential Revision: https://phabricator.services.mozilla.com/D63245
--HG--
extra : moz-landing-system : lando
If we try to wrap an inner whose outer has navigated out of process,
then we'll get a remote window proxy, not a window proxy.
This was happening during the JS devtools test
browser_webconsole_block_mixedcontent_securityerrors.js
Differential Revision: https://phabricator.services.mozilla.com/D64217
--HG--
extra : moz-landing-system : lando
This enables about:profiling everywhere, and removes the ifdefs. I can confirm that it
does not break things on a full Beta simulation in my manual tests. The DevTools panel
cannot be enabled. The popup cannot be enabled either.
Differential Revision: https://phabricator.services.mozilla.com/D63706
--HG--
extra : moz-landing-system : lando
This commit adds tests for the profiler popup, and migrates some of the
older ones to use about:profiling instead.
Differential Revision: https://phabricator.services.mozilla.com/D62915
--HG--
rename : devtools/client/performance-new/test/browser/browser_popup-env-restart-button.js => devtools/client/performance-new/test/browser/browser_aboutprofiling-env-restart-button.js
rename : devtools/client/performance-new/test/browser/browser_popup-features-disabled.js => devtools/client/performance-new/test/browser/browser_aboutprofiling-features-disabled.js
rename : devtools/client/performance-new/test/browser/browser_popup-end-to-end-click.js => devtools/client/performance-new/test/browser/browser_popup-record-capture.js
extra : moz-landing-system : lando
This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.
The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.
This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.
Differential Revision: https://phabricator.services.mozilla.com/D62914
--HG--
extra : moz-landing-system : lando
This commit removes the old popup implementation, but does not implement the new one
yet. This is in a follow-up commit. The client is in a bit of an awkard state where
it is mid-transition to a new architecture. Some of the code comments and documentation
were updated to reflect the changes coming up.
Differential Revision: https://phabricator.services.mozilla.com/D62913
--HG--
extra : moz-landing-system : lando
The presets in recording-utils.js couldn't be shared via the ChromeUtils.import
mechanism. When they were in recording-utils.js they could only be loaded in
via the DevTools require() loader. This commit changes it so that they are
stored in a jsm, and are also injected to each UI interface where the
ChromeUtils.import function is available (only in the initializers).
Differential Revision: https://phabricator.services.mozilla.com/D62912
--HG--
extra : moz-landing-system : lando
If the profiler unexpectedly stops, this is fine, as the new recording infrastructure
is most likely in control of it. This was leading to lots of spurious errors when
working on the new about:profiling infrastructure.
Differential Revision: https://phabricator.services.mozilla.com/D62911
--HG--
extra : moz-landing-system : lando
This enables about:profiling everywhere, and removes the ifdefs. I can confirm that it
does not break things on a full Beta simulation in my manual tests. The DevTools panel
cannot be enabled. The popup cannot be enabled either.
Differential Revision: https://phabricator.services.mozilla.com/D63706
--HG--
extra : moz-landing-system : lando
This commit adds tests for the profiler popup, and migrates some of the
older ones to use about:profiling instead.
Differential Revision: https://phabricator.services.mozilla.com/D62915
--HG--
rename : devtools/client/performance-new/test/browser/browser_popup-env-restart-button.js => devtools/client/performance-new/test/browser/browser_aboutprofiling-env-restart-button.js
rename : devtools/client/performance-new/test/browser/browser_popup-features-disabled.js => devtools/client/performance-new/test/browser/browser_aboutprofiling-features-disabled.js
rename : devtools/client/performance-new/test/browser/browser_popup-end-to-end-click.js => devtools/client/performance-new/test/browser/browser_popup-record-capture.js
extra : moz-landing-system : lando
This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.
The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.
This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.
Differential Revision: https://phabricator.services.mozilla.com/D62914
--HG--
extra : moz-landing-system : lando
This commit removes the old popup implementation, but does not implement the new one
yet. This is in a follow-up commit. The client is in a bit of an awkard state where
it is mid-transition to a new architecture. Some of the code comments and documentation
were updated to reflect the changes coming up.
Differential Revision: https://phabricator.services.mozilla.com/D62913
--HG--
extra : moz-landing-system : lando
The presets in recording-utils.js couldn't be shared via the ChromeUtils.import
mechanism. When they were in recording-utils.js they could only be loaded in
via the DevTools require() loader. This commit changes it so that they are
stored in a jsm, and are also injected to each UI interface where the
ChromeUtils.import function is available (only in the initializers).
Differential Revision: https://phabricator.services.mozilla.com/D62912
--HG--
extra : moz-landing-system : lando
If the profiler unexpectedly stops, this is fine, as the new recording infrastructure
is most likely in control of it. This was leading to lots of spurious errors when
working on the new about:profiling infrastructure.
Differential Revision: https://phabricator.services.mozilla.com/D62911
--HG--
extra : moz-landing-system : lando
Make the JSON tree view more accessible.
1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.
Differential Revision: https://phabricator.services.mozilla.com/D28274
--HG--
extra : moz-landing-system : lando
Hubert Boma Manilla
Andrew McCreight
Nicolas Chevobbe
Outvi V
2cl
Narcis Beleuzu
Marcos Cáceres
Ciure Andrei
chujun
Cosmin Sabou
Jason Laster
Kris Maglione
Micah Tigley
Florens Verschelde
Julien Wajsberg
Sebastian Zartner
Tanny_m
Arthur Iakab
Daisuke Akatsuka
Greg Tatum
Noemi Erli
Andreea Pavel
Dickson Tan