Previously, only an outdated hard-coded subset was being exposed.
This meant that missing relations such as details and error message were not exposed in the DevTools Accessibility Inspector.
We now expose all relations in the RelationType enum so we don't need to keep this up to date.
Differential Revision: https://phabricator.services.mozilla.com/D193008
Updates the Firefox source docs related to Translations
language identification to reflect that fastText is no
longer used by Translations, and that we use CLD2 only.
Depends on D192659
Differential Revision: https://phabricator.services.mozilla.com/D192660
Removes the infrastructure to download language-identification
dependencies for Translations via Remote Settings. This was used
only for the fastText LanguageIdEngine code. The current
language detector, CLD2, lives in tree and does not require
Remote Settings dependencies.
Depends on D192657
Differential Revision: https://phabricator.services.mozilla.com/D192658
Removes the source code for the Translations LanguageIdEngine
which utilized fastText as its underlying mechanism.
Depends on D192656
Differential Revision: https://phabricator.services.mozilla.com/D192657
Removes the browser.translations.languageIdentification.useFastText
pref, making CLD2 the only option for language identification
for Translations.
Differential Revision: https://phabricator.services.mozilla.com/D192656
Gecko starts referring computed style to consider whether block or inline and
`HTMLEditUtils::IsEmptyNode` is used with them to check a node like these:
https://searchfox.org/mozilla-central/rev/40d51bef58b8e901d6ab4b60dd280f372a0e417d/editor/libeditor/HTMLEditUtils.h#543,554
However, `IsEmptyNode` still checks only the tag names when the caller wants
to treat "list items" and/or "table cells" are visible (not empty). Therefore,
this mismatch may cause the assertion failure reported in the bug.
From code design point of view, `HTMLEditUtils::IsListItem` and
`HTMLEditUtils::IsTableCell` should refer the computed style. However, the
former is mostly used for checking the logical structure of HTML, and in the
latter case, we should keep the table structure even if table cells are styled
as inline because browsers do not support table structure recreation except
the Gecko specific editing UI (called inline table editor). Therefore, it does
not make sense that we would change them.
Instead, we should change `IsEmptyNode` which is used only for visibility check.
So, using computed style is always reasonable.
Note that this patch changes the behavior in some edge cases. The method always
treat a list item or a table cell which contains a sub-list or a sub table.
However, I would not like to add new `EmptyCheckOption` for it to check the
complicated style check. Therefore, this patch changes the behavior to treat
them visible if and only if they have another list item or another table cell.
Basically, `<table>` and list elements should have a least one table cell or
one list item. Therefore, this change should not appear in the web apps in the
wild.
Differential Revision: https://phabricator.services.mozilla.com/D192442
wgpu dx12 requests to Texture that if its usage has STORAGE_BINDING, D3D12 resource needs to have D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS.
The equivalent of D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS in D3D11 is D3D11_BIND_UNORDERED_ACCESS. Therefore, D3D11 textures in ExternalTextureD3D11 also require D3D11_BIND_UNORDERED_ACCESS if STORAGE_BINDING is used.
Differential Revision: https://phabricator.services.mozilla.com/D192976
When the injected code is used by elfhack, the debug info is thrown away
because elfhack doesn't know what to do with it, but in the case of
relrhack, the normal linker can handle it, so there's no reason not to
include the debug info anymore.
Differential Revision: https://phabricator.services.mozilla.com/D192904
As the comment said, adding these dependencies was showing good results
back when it was done. 6~7 years later, things have changed, and
removing them makes the build faster across the board (tested from -j4
to -j48, they're up to 10% faster, with the biggest difference at -j16
and -j24)
Differential Revision: https://phabricator.services.mozilla.com/D192045
When gtest is not linked as part of the build, the source files that are
generated for it are not necessarily created during the build, so we
won't be able to find them when packaging them. We make this an allowed
situation. Ideally, we'd "just" figure out which files these are, and
not emit them in the list of generated sources, but at the moment, it's
a lot of work to be able to do so.
Differential Revision: https://phabricator.services.mozilla.com/D193003
Updates the Firefox source docs related to Translations
language identification to reflect that fastText is no
longer used by Translations, and that we use CLD2 only.
Depends on D192659
Differential Revision: https://phabricator.services.mozilla.com/D192660
Removes the infrastructure to download language-identification
dependencies for Translations via Remote Settings. This was used
only for the fastText LanguageIdEngine code. The current
language detector, CLD2, lives in tree and does not require
Remote Settings dependencies.
Depends on D192657
Differential Revision: https://phabricator.services.mozilla.com/D192658
Removes the source code for the Translations LanguageIdEngine
which utilized fastText as its underlying mechanism.
Depends on D192656
Differential Revision: https://phabricator.services.mozilla.com/D192657
Removes the browser.translations.languageIdentification.useFastText
pref, making CLD2 the only option for language identification
for Translations.
Differential Revision: https://phabricator.services.mozilla.com/D192656
This was done erroneously in an earlier code fix that was trying to fix
the showing and hiding of the menubar. It is not necessary to hide the
nav toolbox when the menubar is animated away. The nav toolbox will be
hidden when the user moves the cursor out of the nav toolbox area.
Differential Revision: https://phabricator.services.mozilla.com/D192972
We introduce a different rust type for `<line-name-list>` for subgrid,
which keeps `repeat()` information at computed time. At this moment,
we don't expand `repeat()`.
Also, we precompute the possible expanded list length, so we can expand
`repeat(auto-fill)` in a single iteration in nsGridContainerFrame. If we
don't have this precompution, we have to go through `<line-name-list>`
first to know how many items we have after expanding `repeat(Integer)`.
Differential Revision: https://phabricator.services.mozilla.com/D192876
When .rel.plt and .relr.dyn are the same size, after the section header
for .relr.dyn has been updated, it matches the condition for .rel.plt,
and we ended up undoing the change.
Differential Revision: https://phabricator.services.mozilla.com/D192981
In bug 1755863, we introduce two async APIs in `nsIClipboard` to make async
clipboard API reads the clipboard data asynchronously. When reading, async
clipboard API first check the available types, and then retrieve the actual data
for that type. This process has a potential race condition: the clipboard content
might change between the time between the time we check the types and when we
retrieve the data. Although we currently fetch the actual data immediately after
checking available types (in line with the spec), this minimizes the chance of
encountering this race condition. However, if we would like to support retrieving
the data only when `getType()` is invoked (bug 1691825), this potential race
condition could become a significant issue.
Furthermore, bug 1777448 aims to have a way to track the clipboard data and suppress
the paste context menu when the clipboard data originates from a same-origin page.
This also requires a better way to track read requests, clipboard content and
invalidate the request when the system's clipboard content is changed.
After some refacting around nsBaseClipboard, all platform now use sequence
number to track clipboard content, so `nsIAsyncGetClipboardData` can be associated
with a sequence number and deemed invalid if the associated sequence number isn't
matched the latest system value.
With these new API, it also becomes possible to write some tests.
Depends on D191409
Differential Revision: https://phabricator.services.mozilla.com/D182108
The PDF Viewer notification bar became unused in bug 1705327, which is well over two years ago, hence it seems reasonable to stop shipping this code when it's not being used.
Differential Revision: https://phabricator.services.mozilla.com/D193056
Makoto Kato
James Teh
Norisz Fay
Emilio Cobos Álvarez
Erik Nordin
Byron Campen
Jim Blandy
Masayuki Nakano
sotaro
Cristina Horotan
Mike Hommey
Brad Werth
Andrew Halberstadt
Boris Chiou
Dana Keeler
Paul Zuehlcke
John Schanck
Razvan Cojocaru
Edgar Chen
Jonas Jenwald
Mozilla Releng Treescript
Erich Gubler
Heitor Neiva