M Hamdy
67d215f8de
Bug 606655 - delete cookies UI option AskMeEveryTime and its related comments and tests. r=mak
...
--HG--
extra : rebase_source : 242a074db54395e4b285110286e7692f26b57daa
2015-10-08 09:13:00 +02:00
Andrew McCreight
0ff7248107
Bug 1210517 - Create nsVariant directly rather than via do_CreateInstance(). r=froydnj
...
The goal here is to leave creation stuff mostly for JS, so we can
convert it entirely over to a non-threadsafe cycle-collected version
without breaking any existing C++ users.
I didn't do this for a remaining use in nsGlobalWindow.h to avoid
including nsVariant.h all over the place.
2015-10-07 08:17:42 -07:00
Ehsan Akhgari
4ff5a15c06
Bug 1208897 - Fix an initialization order bug in DOMStorageDBThread; r=baku
...
This is found by Viva64. The error is in fact benign since the
StatementCache constructor takes a reference to the nsCOMPtr
passed to it, and stores it for later use, so nothing bad
happens at runtime, but still we should not be using uninitialized
members to initialize other members with.
2015-09-28 09:08:44 -04:00
Chris Peterson
71920a9550
Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium
2015-09-22 21:39:03 -07:00
Nicholas Nethercote
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Michael Layzell
c98f12f1ae
Bug 536509 - Update localStorage to use common StorageAllowedForWindow logic, r=ehsan
2015-08-28 10:10:28 -04:00
Aidin Gharibnavaz
c36bffa713
Bug 929846 - Considering key size when calculating quota usage. r=jdm
2015-08-17 15:19:30 -07:00
Kyle Huey
76e3009ab8
Bug 1179909: Refactor stable state handling. r=smaug
...
This is motivated by three separate but related problems:
1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).
2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).
3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.
The solve this, this patch does the following:
1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
2015-08-11 06:10:46 -07:00
Honza Bambas
d2501443bc
Bug 1192194 - Make DOMStorageDBThead::mDBReady atomic. r=smaug
...
--HG--
extra : rebase_source : d4a9c888ef83efcfddf58c8e447f0f4b440a0c6a
2015-08-07 05:00:00 -04:00
Honza Bambas
2f0e0c40f6
Bug 1189426 - Don't assert false in DOMStorageDBThread::InsertDBOp when we failed to open the database. r=smaug
...
--HG--
extra : rebase_source : 4638dee9e96bdabf47b35b513857cbefdc2606b0
2015-08-06 11:08:00 -04:00
Nicholas Nethercote
35a54c92f0
Bug 1182977 (part 2) - Use PLDHashTable::Iterator in dom/storage/. r=khuey.
...
--HG--
extra : rebase_source : 7aeac7d3d093bb3360de179b8259bc98449b308e
2015-07-22 00:02:15 -07:00
Nicholas Nethercote
4cebc0675d
Bug 1182977 - Use PLDHashTable::Iterator in dom/storage/. r=khuey.
2015-07-21 23:54:12 -07:00
Michael Layzell
811eb00946
Bug 1184971 - Expose cookieBehavior and cookieLifetimePolicy preference variants from nsICookieService. r=ehsan
...
--HG--
extra : rebase_source : 7cfe37db0fe858f42aceda2ef90a5fa69560b86e
2015-07-17 08:01:00 +02:00
Carsten "Tomcat" Book
af1ca050c6
Backed out changeset 2f4b5acae553 (bug 1184971) for causing OS X Memory Leaks
...
--HG--
extra : rebase_source : 8a69fbfd8f30276036a80929e2f04b1e22d60341
2015-07-21 10:27:44 +02:00
Michael Layzell
30664f5e8d
Bug 1184971 - Expose cookieBehavior and cookieLifetimePolicy preference variants from nsICookieService. r=ehsan
2015-07-17 08:01:00 +02:00
Michael Layzell
9d564ec2dd
Bug 1173523 - Part 1: Expose an nsIPrincipal from nsIPermission rather than a host string, appId, and isInBrowserElement, r=ehsan
2015-07-16 14:49:22 -04:00
Wes Kocher
ff2f0d32cf
Backed out 24 changesets (bug 1173523, bug 1172080, bug 817007, bug 1165263) for android reftest bustage CLOSED TREE
...
Backed out changeset 84fe04b2e7d1 (bug 1172080)
Backed out changeset 0ff004760a1f (bug 1172080)
Backed out changeset af147585ad55 (bug 1165263)
Backed out changeset c3af8ebb6db0 (bug 1165263)
Backed out changeset cd3f33a888fe (bug 1165263)
Backed out changeset e5db39044a1e (bug 1165263)
Backed out changeset c01c9ed77061 (bug 1165263)
Backed out changeset fb723aaa4267 (bug 1165263)
Backed out changeset f754e52e74dc (bug 1165263)
Backed out changeset c6bda3a0afd6 (bug 817007)
Backed out changeset bfa100253349 (bug 817007)
Backed out changeset b787b3f9aadc (bug 1173523)
Backed out changeset 4a0676b73f77 (bug 1173523)
Backed out changeset 82034a4560c5 (bug 1173523)
Backed out changeset 4bdb91114c7a (bug 1173523)
Backed out changeset 72406261eccc (bug 1173523)
Backed out changeset 541b6faf7196 (bug 1173523)
Backed out changeset 1caac4569616 (bug 1173523)
Backed out changeset 0d4f9f9e1b4e (bug 1173523)
Backed out changeset 2d5661eb966c (bug 1173523)
Backed out changeset 89833c0bb0cd (bug 1173523)
Backed out changeset ea64d70eacfe (bug 1173523)
Backed out changeset a8e4f1c0c445 (bug 1173523)
Backed out changeset cf498d466b85 (bug 1173523)
2015-07-14 14:00:32 -07:00
Michael Layzell
56a5f8273e
Bug 1173523 - Part 1: Expose an nsIPrincipal from nsIPermission rather than a host string, appId, and isInBrowserElement, r=ehsan
2015-07-14 15:06:15 -04:00
Birunthan Mohanathas
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Michael Layzell
dbe075d5b8
Bug 1180993 - Part 3: Correct use sites of functions which return already_AddRefed. r=ehsan
2015-07-10 08:36:00 -04:00
Emanuel Hoogeveen
7d1e52f2ff
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00
Juan Gomez
258ad59e3f
Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
2015-07-03 18:29:00 -07:00
Ryan VanderMeulen
5f5c327690
Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage.
2015-06-25 19:48:42 -04:00
Juan Gomez
702a59d135
Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
...
--HG--
extra : rebase_source : 2ecbe6c1dd8a7ad8dc529b53349ad431cf1116c9
2015-06-24 14:11:00 -04:00
Blake Kaplan
d06a4e2fcb
Bug 1173573 - Fix possible crash initializing sessionstorage. r=honzab
2015-06-23 11:22:00 +02:00
Blake Kaplan
3d74d0b549
Bug 1151840 - Make a couple of messages urgent to deal with CPOWs properly. r=billm
2015-06-11 18:53:31 -07:00
Ms2ger
f994d03624
Bug 1017758
- Use infallible getters for appId/isInBrowserElement/unknownAppId; r=bz
2015-05-13 17:59:08 +02:00
Andrew McCreight
9e8f4b219e
Bug 1152551, part 2 - Fix mode lines in dom/. r=jst
2015-05-03 15:32:37 -04:00
Andrew McCreight
da5ed6f5cd
Bug 1152551, part 1 - Remove leading tabs in dom/. r=baku
...
Also, remove trailing whitespace in nsXMLContentSink.cpp
2015-05-03 15:32:33 -04:00
David Major
ebde6b9f4f
Bug 1157835: Remove the MSVC_ENABLE_PGO flag from the build system. r=glandium
...
--HG--
extra : rebase_source : 0c47c99bb8b92f8361a51fd81b20a2cc8647a986
2015-04-27 19:59:27 -04:00
Boris Zbarsky
d36060dc11
Bug 1157898 part 5. Eliminate the remaining non-ErrorResult consumers of ErrorResult::ErrorCode and make it protected. r=peterv
2015-04-27 09:18:52 -04:00
Boris Zbarsky
1e816696de
Bug 1157898 part 4. Add ErrorResult::ErrorCodeIs() and use it in various places to get rid of ErrorCode(). r=peterv
2015-04-27 09:18:52 -04:00
Andrea Marchesini
e6f385fb3d
Bug 1148527 - Indentation fix after bug 1145631, r=ehsan
2015-03-27 18:52:19 +00:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Boris Zbarsky
dc24477d79
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Nicholas Nethercote
242708cf72
Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
Andrew McCreight
d3826daa16
Back out Bug 1127201 (part 2) for various problems.
2015-02-06 15:04:32 -08:00
Nicholas Nethercote
d34f0301b8
Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
Mike Hommey
a35dbaeebf
Bug 1126593 - Add a global fallible instance, so that using fallible works directly, everywhere. r=njn
...
--HG--
rename : memory/mozalloc/fallible.h => memory/fallible/fallible.h
2015-02-02 09:56:13 +09:00
Marco Bonardo
1e36234414
Bug 1010717 - add nsIRunnable support to the DOM Storage thread. r=mayhemer
2015-01-28 00:00:18 +01:00
Kyle Huey
7c82e6dd0a
Bug 1121673: Use move references in IPDL. r=bent
2015-01-16 11:58:52 -08:00
Ehsan Akhgari
881f4d3f00
Bug 1118609 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/storage; r=baku
2015-01-07 10:22:00 -05:00
Peter Van der Beken
dcda2ba9bb
Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz.
...
--HG--
extra : rebase_source : 89c476cd9436530b2df5acc903909e34188417a0
2014-10-07 11:44:49 +02:00
Patrick Wang (Chih-Kai Wang)
6f5608b972
Bug 1032125: Part 2: Prevent DOM Storage from sending IPC after Nuwa ready. r=khuey
2014-09-30 22:13:25 +08:00
Carsten "Tomcat" Book
1287213a18
Backed out changeset e193cf8cb616 (bug 1032125) for causing regressions
2014-09-22 12:45:22 +02:00
Patrick Wang (Chih-Kai Wang)
ed69d4eeba
Bug 1032125: Part 2: Prevent DOM Storage from sending IPC after Nuwa ready. r=khuey
2014-09-19 17:12:10 +08:00
Carsten "Tomcat" Book
131958c0e9
Backed out changeset f945fb33b616 (bug 1032125)
2014-09-18 15:13:53 +02:00
Patrick Wang (Chih-Kai Wang)
fc52a5a754
Bug 1032125: Part 2: Prevent DOM Storage from sending IPC after Nuwa ready. r=khuey
2014-09-18 10:29:45 +08:00
Ehsan Akhgari
0653303071
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
...
--HG--
extra : rebase_source : 01709017e97fdc96d1d53eb881efc1792118edc4
2014-09-01 20:49:25 -04:00
Phil Ringnalda
117bb1a341
Backed out 6 changesets (bug 1060982
, bug 1061058, bug 1060987, bug 1061060, bug 1060930) for build bustage
...
CLOSED TREE
Backed out changeset c23b8418e6be (bug 1060987)
Backed out changeset a8cddc6bdffc (bug 1061060)
Backed out changeset b5af5cbdac3f (bug 1060982
)
Backed out changeset 4912d451011a (bug 1060930)
Backed out changeset bdacbf453238 (bug 1061058)
Backed out changeset da6c71a8f5ae (bug 1060987)
2014-09-01 16:48:51 -07:00
Ehsan Akhgari
6c932dea6c
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
2014-09-01 18:00:53 -04:00
Birunthan Mohanathas
defd5128d0
Bug 1058101 - Move dom/src/storage/ into dom/. r=mccr8
...
--HG--
rename : dom/src/storage/DOMStorage.cpp => dom/storage/DOMStorage.cpp
rename : dom/src/storage/DOMStorage.h => dom/storage/DOMStorage.h
rename : dom/src/storage/DOMStorageCache.cpp => dom/storage/DOMStorageCache.cpp
rename : dom/src/storage/DOMStorageCache.h => dom/storage/DOMStorageCache.h
rename : dom/src/storage/DOMStorageDBThread.cpp => dom/storage/DOMStorageDBThread.cpp
rename : dom/src/storage/DOMStorageDBThread.h => dom/storage/DOMStorageDBThread.h
rename : dom/src/storage/DOMStorageIPC.cpp => dom/storage/DOMStorageIPC.cpp
rename : dom/src/storage/DOMStorageIPC.h => dom/storage/DOMStorageIPC.h
rename : dom/src/storage/DOMStorageManager.cpp => dom/storage/DOMStorageManager.cpp
rename : dom/src/storage/DOMStorageManager.h => dom/storage/DOMStorageManager.h
rename : dom/src/storage/DOMStorageObserver.cpp => dom/storage/DOMStorageObserver.cpp
rename : dom/src/storage/DOMStorageObserver.h => dom/storage/DOMStorageObserver.h
rename : dom/src/storage/PStorage.ipdl => dom/storage/PStorage.ipdl
rename : dom/src/storage/moz.build => dom/storage/moz.build
2014-08-30 21:43:46 -07:00