nsHTMLEditor::SetFinalSize]
- A one line fix in HideResizers() which prevents the
reported crash by setting mIsResizing to false. I assume
we can't be resizing if the resize handles are being hidden.
The assertion and null check in SetFinalSize() are just because
I'm paranoid, but they should never be triggered if HideResizers()
is called first.
- The changes in StartResizing() makes it so that we don't create
a new mouse motion listener if we already have one. We were
creating a new listener each time we clicked on the handles, and
never unregistering the old one ... this meant that the old
listeners could be triggered if the editor were ever destroyed
and the document left in tact ... allowing us to crash because the
listeners keep an un-addref'd pointer to the HTMLEditor. Note that
this crash is not likely to be hit in Mozilla since we always
destroy the document and editor in Composer and MailCompose, but
it can happen in an embedding context.
r=glazman@netscape.comsr=sfraser@netscape.com
r=edburns
SECTION: classes changes
M build.xml
- Removed spurious linebreak on Kyle's create.webclient.scripts.
M classes_spec/org/mozilla/webclient/BrowserControlCanvas.java
- Bugfix from Daniel Park
M classes_spec/org/mozilla/webclient/test/EMWindow.java
- Leverage new CurrentPage2 interface to display the Selection object.
M classes_spec/org/mozilla/webclient/wrapper_native/CurrentPageImpl.java
M classes_spec/org/mozilla/webclient/wrapper_nonnative/CurrentPageImpl.java
- Implement new methods from CurrentPage2.
M src_moz/CurrentPageActionEvents.cpp
M src_moz/CurrentPageActionEvents.h
M src_moz/CurrentPageImpl.cpp
M src_moz/gtk/GtkBrowserControlCanvasStub.cpp
M src_moz/gtk/StubFunctions.h
Native details for CurrentPage2.
SECTION: New files
A classes_spec/org/mozilla/webclient/Selection.java
A classes_spec/org/mozilla/webclient/CurrentPage2.java
A classes_spec/org/mozilla/webclient/wrapper_native/SelectionImpl.java
memcpy continued to be exported. This is to be "bug compatible" with old
libnspr4.so binaries that exported memcpy by accident because we did not
include <string.h> in optimized builds.
characters that should be escaped. the fix for that is in nsSmtpDelegateFactory.cpp.
thanks to nrt@dial.pipex.com for the patch, and cls for testing.
the same problem existed for nntp, in nsNNTPProtocol.cpp
the rest is some code cleanup I had sitting around.
jpierre%netscape.com
rogerl%netscape.com
cavin%netscape.com
pkw%us.ibm.com
nicolson%netscape.com
sspitzer%netscape.com
timeless%mozdev.org
dbaron%dbaron.org
bryner%netscape.com
suresh%netscape.com
kin%netscape.com
samuel%sieb.net
edburns%acm.org
blizzard%redhat.com
locka%iol.ie
roc+%cs.cmu.edu
burnus%gmx.de
ssu%netscape.com
katakai%japan.sun.com
justdave%syndicomm.com
seawood%netscape.com
varga%netscape.com
oeschger%netscape.com
jst%netscape.com
wtc%netscape.com
kyle.yuan%sun.com
smontagu%netscape.com
bzbarsky%mit.edu
dougt%netscape.com
gerv%gerv.net
cltbld%netscape.com
darin%netscape.com
mkaply%us.ibm.com