They currently silently pass and early-exit under several conditions, which is really confusing if you're trying to actually run them properly. They should either be marked as skipping or failing to hint to the developer that something strange is happening. It appears that skip-if simply doesn't function correctly when applied to these tests, so fail-if is used. fail-if is also useful because it forces anyone introducing a new platform to evaluate how these tests should handle it.
MozReview-Commit-ID: CPYdL242bGc
--HG--
extra : rebase_source : 243ede16d4015969a6abfd64e6071131ce5a9f2a
This is useful for legacy addons as we increasingly lockdown filesystem access
in content processes.
MozReview-Commit-ID: AZbsSFpbIvt
--HG--
extra : rebase_source : 56dfe91ac9fbeb0bd48dc8a2f87ed6038e7521cc
As part of network security, we currently crash the main process in NeckoParent::GetValidatedOriginAttributes if the SerializedLoadContext is null. This makes it difficult to find out who created the channel that has a null SLC. Adding this assertion to the child allows us to get a nice stack trace and maybe identify the root cause.
MozReview-Commit-ID: 7rz91oEaiRi
--HG--
extra : rebase_source : b411e1e9494623bacb506a2f820902a3f7aa7c2a
Invalidating a window's shadow is really slow and leads to flickering. Now that
arrow panels don't change their contents during the panel opening animation any
more, their shape stays the same after the first paint, so we don't need the
shadow invalidation functionality for them any more. And as far as I know, we
don't use transparent popups with changing shapes anywhere else.
The system still computes the shadow for the first paint of the window (which
happens during the orderFront call), and it updates the shadow whenever the
window resizes. But not when its size stays the same and only what we draw in
the content is updated.
MozReview-Commit-ID: 138PjbrSFrc
--HG--
extra : rebase_source : fed1c653ca3d88ef8b4e8e55a7d42b29e17a1624
In the process of adding those tests, I realized the cleanup was
not effective. There were some bugs for Immutable List (we can't
use delete in a withMutation callback), and in object/arrays (we
we're using Array.includes with another array as a parameter).
These were fixed, and the new tests are now passing.
MozReview-Commit-ID: NrKjLuu25
--HG--
extra : rebase_source : cdbdfdc7f5b2a1e3c71cb76cfcd42db5204332ff
Disable toolkit/content/tests/widgets/test_popupanchor.xul on linux machines as it permanently fais when running with Ubuntu 16.04.
MozReview-Commit-ID: HSX6xC8dG8k
--HG--
extra : rebase_source : c270b3456c92da2b49daa30cf44308b6880f5ea9
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
This also adds the icons in non-photon. They seem to work fine there, so I don't think this is a problem.
MozReview-Commit-ID: GkvT3i2jnD1
--HG--
extra : rebase_source : 80d33d329b5740328aa82dd5401475264700e57a
Disable toolkit/content/tests/chrome/test_panel_anchoradjust.xul on linux machines as it permanently fails when running on Ubuntu 16.04.
MozReview-Commit-ID: FOW9zgKYcAU
--HG--
extra : rebase_source : a590ff1dec5abd04ac97efcf03e4bcd61612626a
This patch prevents a part of the test from creating a notify-focus event at random times later in the test by taking care of it as soon as it can be received. It also removes an unecessary focus call.
MozReview-Commit-ID: DJJaKmaT5wm
--HG--
extra : rebase_source : 1ea997d75657a8f8394b0d708b36d9773a683f6e
This patch fixes failures for widget/tests/test_composition_text_querycontent.xul when it is run on ubuntu 16.04. It adds some missing handling for pre-test position change notifications and also adds some handling for after-test position change notifications.
MozReview-Commit-ID: 1t8NuxJqkOo
--HG--
extra : rebase_source : ddae0da39a087c5742e31fbae9d7930b95695f1e
Once the |aPayload| argument to profile_add_marker() became a UniquePtr the
default value of nullptr caused compilation difficulties that could only be
fixed by #including ProfilerMarkerPayload.h into lots of additional places
(because the UniquePtr<T> instantiation required the T to be fully defined). To
get around this I just split profile_add_marker() into two functions, one with
1 argument and one with 2 arguments.
The patch also removes the definition of PROFILER_MARKER_PAYLOAD in the case
where MOZ_GECKO_PROFILER isn't defined. A comment explains why.
Bug 1357829 added a third kind of sample, in addition to the existing
"periodic" and "synchronous" samples. This patch cleans things up around that
change. In particular, it cleans up TickSample, which is a mess of semi-related
things.
The patch does the following.
- It removes everything from TickSample except the register values and renames
TickSample as Registers. Almost all the removed stuff is available in
ThreadInfo anyway, and the patch adds a ThreadInfo argument to various
functions. (Doing it this way wasn't possible until recently because a
ThreadInfo wasn't available in profiler_get_backtrace() until recently.)
One non-obvious consequence: in synchronous samples we used to use a value of
0 for the stackTop. Because synchronous samples now use ThreadInfo directly,
they are able to use the proper stack top value from ThreadInfo::mStackTop.
This will presumably only improve the quality of the stack traces.
- It splits Tick() in two and renames the halves DoPeriodicSample() and
DoSyncSample().
- It reorders arguments in some functions so that ProfileBuffer (the output) is
always last, and inputs are passed in roughly the order they are obtained.
- It adds a comment at the top of platform.cpp explaining the three kinds of
sample.
- It renames a couple of other things.
--HG--
extra : rebase_source : 4f1e69c605102354dd56ef7af5ebade201e1d106
Alexis Beingessner
Alessio Placitelli
Gijs Kruitbosch
Emilio Cobos Álvarez
Alex Gaynor
Valentin Gosu
Markus Stange
bechen
gasolin
Nicolas Chevobbe
Greg Mierzwinski
Mike de Boer
Carsten "Tomcat" Book
Dragana Damjanovic
Christoph Kerschbaumer
Jan Odvarko
Sebastian Hengst
steveck-chung
Nicholas Nethercote
Mats Palmgren
Andrew Osmond