Delay the initialisation of the pref until the toolbar has been initialised.
MozReview-Commit-ID: JxQajZ4wrCR
--HG--
extra : rebase_source : 42f936c5a3e6b7f8cdce1703d7d74883fc806d1c
The test that checked console api stubs was failing because we were trying
to reach the server while the connection was closed, which throws an error.
This patch filters-out log messages in the console output so we don't get
unwanted server communication. The output is not important here since we
are only listening to the consoleAPICall event.
MozReview-Commit-ID: Ay5fQ1CSbLx
--HG--
extra : rebase_source : 4790d8d198165141f0ba07900991302ff6b25062
The bug was failing because we were calling the server but the connection was already closed.
In order to prevent such things, we check the number of nodes of the tree, and if it has only
one, then we wait on a mutation that will ensure that server calls are done.
MozReview-Commit-ID: 7kHAkYs2I4K
--HG--
extra : rebase_source : 0204960d4ea3cca8bd9614908a730a0d4d6b4e69
This is mainly changing the props we pass to the ObjectInspector,
and removing actions, state properties and reducers that we used to
handle in the console but are now managed by the ObjectInspector
itself.
MozReview-Commit-ID: F2GabDqDjPe
--HG--
extra : rebase_source : 3b14762dc082229ed32fdfc2f8ad9177e7c48a41
All the changes here were already reviewed in Github.
MozReview-Commit-ID: GmQ3BOFIXPh
--HG--
extra : rebase_source : 7100241eed928829dc06b03598e0d197a7775090
Shield experiments interfer with core features of Firefox which can
cause tests run via Marionette or geckodriver to fail. Resetting the
API URL will make sure that no experiments can be downloaded.
MozReview-Commit-ID: HnE49jfnen7
--HG--
extra : rebase_source : 2fa6cf86ddce798eba88a41d227768f149cccc70
Sometimes Robocop is confused when are multiple `R.id.menu` UI components shown on screen,
one is the menu button on toolbar and otehrs are context menus on Activity Stream.
To access the menu on toolbar, a simple fix is access toolbar first and use it to find its child.
MozReview-Commit-ID: Jw4sTLeR3li
--HG--
extra : rebase_source : 337c3df3ffd36a4d26547b994aba3ce7647bafc8
Shield experiments interfer with core features of Firefox which can
cause tests run via Marionette or geckodriver to fail. Resetting the
API URL will make sure that no experiments can be downloaded.
MozReview-Commit-ID: HnE49jfnen7
--HG--
extra : rebase_source : 9cec29085032318e9e8467d6d754afe0890ae645
Currently line linters (linters that open a file and process it line by line,
by applying a regex for example), don't handle directories. If a directory is
passed in, it will try to 'open' it, which fails. Directories can get hit if
the linter has a directory in its include directive or if the user passes in
--no-filter.
This patch modifies LineLinters so that if a directory is detected, we search
for all relevant files under that directory. If 'extensions' is used, we'll
look for only files with appropriate extensions. Otherwise we assume the
linter wants every file.
MozReview-Commit-ID: D9lzTNuQTob
--HG--
extra : rebase_source : 0b952c06eae28b67b687813ff7e75b231b2dd4d3
In bug 1361258, we unified the initialization sequence on mac, and
chose to make the zone registration happen after jemalloc
initialization.
The order between jemalloc init and zone registration shouldn't actually
matter, because jemalloc initializes the first time the allocator is
actually used.
On the other hand, in some build setups (e.g. with light optimization),
the initialization of the thread_arena thread local variable can happen
after the forced jemalloc initialization because of the order the
corresponding static initializers run. In some levels of optimization,
the thread_arena initializer resets the value the jemalloc
initialization has set, which subsequently makes choose_arena() return
a bogus value (or hit an assertion in ThreadLocal.h on debug builds).
So instead of initializing jemalloc from a static initializer, which
then registers the zone, we instead register the zone and let jemalloc
initialize itself when used, which increases the chances of the
thread_arena initializer running first.
--HG--
extra : rebase_source : 4d9a5340d097ac8528dc4aaaf0c05bbef40b59bb
isalloc_validate is the function behind malloc_usable_size. If for some
reason malloc_usable_size is called before mozjemalloc is initialized,
this can lead to an unexpected crash.
The chance of this actually happening is rather slim on Linux
and Windows (although still possible), and impossible on Mac, due to the
fact the earlier something can end up calling it is after the
mozjemalloc zone is registered, which happens after initialization.
... except with bug 1399921, which reorders that initialization, and
puts the zone registration first. There's then a slim chance for the
zone allocator to call into zone_size, which calls malloc_usable_size,
to determine whether a pointer allocated by some other zone belongs to
mozjemalloc's.
And it turns out that does happen, during the startup of the
plugin-container process on OSX 10.10 (but not more recent versions).
--HG--
extra : rebase_source : 331d093b03add7b2c2ce440593f5aeccaaf4dd1f
In bug 1361258, we unified the initialization sequence on mac, and
chose to make the zone registration happen after jemalloc
initialization.
The order between jemalloc init and zone registration shouldn't actually
matter, because jemalloc initializes the first time the allocator is
actually used.
On the other hand, in some build setups (e.g. with light optimization),
the initialization of the thread_arena thread local variable can happen
after the forced jemalloc initialization because of the order the
corresponding static initializers run. In some levels of optimization,
the thread_arena initializer resets the value the jemalloc
initialization has set, which subsequently makes choose_arena() return
a bogus value (or hit an assertion in ThreadLocal.h on debug builds).
So instead of initializing jemalloc from a static initializer, which
then registers the zone, we instead register the zone and let jemalloc
initialize itself when used, which increases the chances of the
thread_arena initializer running first.
--HG--
extra : rebase_source : 4d9a5340d097ac8528dc4aaaf0c05bbef40b59bb
We're getting relatively frequent intermittent shutdown crashes when stream
filters are added during ts_paint tests. Skipping favicon.ico stream filters
should prevent that until we have a more reliable fix.
Henrik Skupin
Erica Wright
Luca Greco
Mark Banner
abhinav
Dão Gottwald
Nicolas Chevobbe
Tim Nguyen
FSeita
Rob Wood
Steve Armand
Kartikaya Gupta
Sebastian Hengst
Jing-wei Wu
James Cheng
Andrew Halberstadt
Scott Wu
gasolin
Rex Lee
Phil Ringnalda
Mike Hommey
Mason Chang
Jeff Gilbert
Kris Maglione
Myk Melez
Jim Chen