This patch introduces a notion of "changed" count during bookmark deletions, and firms up
our deletion logic to ensure we're counting affected records correctly.
Changes are mostly clearer comments describing what's going on, as well tests to ensure
we're doing the right thing.
One logical change is that this patch drops an additional call to updateBookmarks. AFAIK,
that call is unnecessary. It doesn't achieve its stated goal of writing first (it performs
a select first), and since we're doing a deletion, the "bump timestamps of an old parent
in case parent changed" logic is unused).
MozReview-Commit-ID: 9B1FW9pgsf1
--HG--
extra : rebase_source : dd8f10c58fd0042f94072bb99c28dc4545165dd5
Changed assertion from using harness class ping variable to local variable in test. That way, popping the ping doesn't affect
outcome of test. Also check that ping is not None.
MozReview-Commit-ID: AEDJmhJHUxv
--HG--
extra : rebase_source : 9b4b8ae01a036788b47941b15f5e3b12ae9030cc
The canonical geckodriver source code no longer lives on GitHub, but
in mozilla-central's testing/geckodriver directory. Linking through
searchfox.org because it provides a better UI than hg.mozilla.org.
MozReview-Commit-ID: LmnviuC7Z9Y
--HG--
extra : rebase_source : 23f0e669bd719c595300d4e7ac38bc12f4937f57
Upgrades the mozrunner crate dependency by pinning it to 0.4.1. With `./mach vendor rust' I could not find any other way to force a new version to be downloaded because cargo, as far as I understand, does not yet support using crates.io as a fallback.
This patch also pins the mozprofile and mozversion dependencies exactly, although this is strictly not needed yet because they we have the latest versions vendored in-tree.
MozReview-Commit-ID: 8emDKbiYd0S
--HG--
extra : rebase_source : c153506f481255b2f9362e94da3254013ad522ab
Overhaul of geckodriver's README to include more detailed information
about picking up prepared profiles from the filesystem using the args
capability in moz:firefoxOptions. It also includes a short example
on running Firefox in headless mode, which is available on some modern
Firefoxen on certain systems.
Also updates build instructions now that geckodriver lives in-tree.
MozReview-Commit-ID: AoJtpULBctH
--HG--
extra : rebase_source : 3697262f7050778ee1bc81ff4c26d51bf2cf86d4
Removes .version file ignore from .gitignore and creates a
testing/geckodriver/.hgignore rule file for parity with git.
MozReview-Commit-ID: HXgbLxeleAl
--HG--
extra : rebase_source : 8c1f919a77351378a580ab161e9660c5868e881f
On macOS, the file-write* permission type contains numerous sub-permissions (see
bug for full listing). Restrict the ones we allow to only the two we need:
file-write-create and file-write-data. This primarily reduces kernel attack
surface, I'm not aware of any bad things that could be done directly with the
removed permissions.
MozReview-Commit-ID: 3VvjFesy2qx
--HG--
extra : rebase_source : 934ec17c44c9ef3d7fab29919d66cf1a55d57697
Allow for either the usual 3 base process count or with activity-stream both 3 or 4 counts.
MozReview-Commit-ID: 2VQuq4KpBPK
--HG--
extra : rebase_source : 1c846f3d07da477ebf6564532116c6dc1ceaf882
We were prefix-matching the rust srcdir when hyperlinking
symbols, but then appending the relative source path to
the top level repo url, resulting in broken links.
Instead, link to the srcdir url at github.
MozReview-Commit-ID: 33tSMM96Vie
--HG--
extra : rebase_source : 13d5638d4029e40077c0ba8de34a64d3ff9e92be
This change preserves the existing semantics of the webrender_bindings code,
although it may result in creating unnecessary clips. A follow-up bug will be
filed to make clip optional in the C++ interface, and avoid passing it in places
where it is not necessary.
MozReview-Commit-ID: KMeBumpgDXL
--HG--
extra : rebase_source : 9ec04e1e8f0b985532908460958f30ed42e220bd
This patch is pretty hard to read and review. It only changes styles in
Photon flavor to match designer's design. Includes layout, dimension,
colors....etc. Australis flavor should not aware of this patch.
MozReview-Commit-ID: 9ROK1NcwJfC
--HG--
extra : rebase_source : d280919e2ef43d072b4762e84e80f7bc3002bfdd
We draw curve for Toolbar only in Australis flavor.
Also change resource naming for highlight color to be consistent with
Phton flavor.
MozReview-Commit-ID: E7cFuJs3r6h
--HG--
extra : rebase_source : 1bf7d1557a3b614d7c2b8c3f743d4247353e45c8
Some views in BrowserToolbar is Themed-view, and should be notified by any
normal/private mode changing.
MozReview-Commit-ID: 8hkizdsf0AO
--HG--
extra : rebase_source : 24e5e3a281af23d40dcff766b91d5692633b4ff1
Stop button is in Awesome bar to stop page loading, to let it becomes
ThemedImageButton to support Private mode.
MozReview-Commit-ID: CzbCyx1Mxc4
--HG--
extra : rebase_source : edc17213daae80112602cd8b2d28e546f6a391ab
PageAction are views which be added to awesomebar dynamically, for
example "Reader mode icon".
Now let it becomes ThemedImageButton to support Private mode.
MozReview-Commit-ID: HQXgJWL19Oz
--HG--
extra : rebase_source : 8428d005875c1c1b24e72fb9ef431060b8b02b5a
Grigory Kruglov
John Dorlus
Andreas Tolfsen
Johan Lorenzo
Alex Gaynor
Sylvestre Ledru
Ed Lee
Ralph Giles
Patrick Brosset
Mike Conley
Sebastian Hengst
friedger
Jonathan Kingston
Ray Lin
Kartikaya Gupta
Thomas Wisniewski
Julian_Chu