d6a168786b
Bug 1674902: Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie
...
`HRESULT` is `typedef`'d as `long`, so this patch harmonizes the return codes.
Differential Revision: https://phabricator.services.mozilla.com/D95597
2020-11-03 16:54:48 +00:00
ab1951c79c
Bug 1675051 - run Linux DevEdition tests as the expected tier 1. r=jmaher DONTBUILD
...
The migration of the task images from Ubuntu 16.04 to Ubuntu 18.04 in
bug 1602863 added the Ubuntu version to the platform. The platform of Linux x64
DevEdition didn't get added and used the default tier 2. We don't run tests
for Linux 32-bit anymore.
Differential Revision: https://phabricator.services.mozilla.com/D95754
2020-11-03 16:48:53 +00:00
5f04ebe1d9
Bug 1654758 - [devtools] Remove usage of actorHasMethod in responsive/ui module r=bradwerth
...
All the backward compatibility code can be removed.
"setMaxTouchPoints" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1500672 (FF77)
"simulateScreenOrientationChange" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1357774 (FF69)
"captureScreenshot" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1579133 (FF71)
Differential Revision: https://phabricator.services.mozilla.com/D95313
2020-11-03 16:48:25 +00:00
d55fc399a4
Bug 1654752 - [devtools] Remove actorHasMethod usage in animation inspector r=daisuke
...
The related backward compatibility code was only to support FF62 or older and can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D95309
2020-11-03 16:47:55 +00:00
5cbc223129
Bug 1672706 - Document when and how metric types need to store the metric ID. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95736
2020-11-03 16:32:20 +00:00
76cc3466d9
Bug 1674728 - Apply clippy suggestions for the FOG code base. r=chutten
...
All these were detected by running:
cargo clippy --manifest-path /home/jer/mozilla/src/gecko/toolkit/components/glean/api/Cargo.toml
which is the same as this:
mach lint --linter clippy toolkit/components/glean/api/ -W
but the latter fails to parse out which file the warnings are for.
Differential Revision: https://phabricator.services.mozilla.com/D95510
2020-11-03 14:13:18 +00:00
b171782687
Bug 1674728 - Allow clippy to run correctly on FOG code. r=chutten
...
When running clippy, the linter, `MOZ_TOPOBJDIR` is not set
(and the `metrics.rs` file might not even be generated yet),
so we need to manually define some things we expect from it so the rest of the build can assume
it's there.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1674726 .
Differential Revision: https://phabricator.services.mozilla.com/D95509
2020-11-03 14:01:14 +00:00
33ddae7383
Bug 1672706 - Receive and pass on the metric ID for labeled metrics. r=chutten
...
This removes the last left-over test files for integration tests.
Differential Revision: https://phabricator.services.mozilla.com/D95018
2020-11-03 14:01:12 +00:00
4e3ea8b36d
Bug 1672706 - Take the metric ID for a UUID metric r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95508
2020-11-03 14:01:09 +00:00
adfdea8ef7
Bug 1672706 - Store the metric ID in an event metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95017
2020-11-03 14:01:07 +00:00
bf3fc70500
Bug 1672706 - Wait for Glean to initialize before submitting a ping in the test. r=chutten
...
This also moves the tests into the code file itself.
Differential Revision: https://phabricator.services.mozilla.com/D95016
2020-11-03 14:01:04 +00:00
c8c0ee387b
Bug 1672706 - Store the metric ID in a string list metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95015
2020-11-03 15:41:21 +00:00
702548a107
Bug 1672706 - Store the metric ID in a timing distribution metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95507
2020-11-03 15:41:21 +00:00
2b0cce4873
Bug 1672706 - Store the metric ID in a memory distribution metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95013
2020-11-03 14:00:58 +00:00
7f021fb6cc
Bug 1672706 - Take the metric ID for a timespan metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95012
2020-11-03 10:37:45 +00:00
e14589dea7
Bug 1672706 - Take the metric ID for a string metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95011
2020-11-03 10:37:43 +00:00
f126e6877a
Bug 1672706 - Take the metric ID for a datetime metric. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95010
2020-11-03 10:37:35 +00:00
c42d4c34da
Bug 1672706 - Take the metric ID for a boolean metric. r=chutten
...
This moves the tests to allow for test-only functionality.
This will allow to more easily test IPC behavior in pure Rust.
Differential Revision: https://phabricator.services.mozilla.com/D95009
2020-11-03 10:37:33 +00:00
6a3d120349
Bug 1672706 - Store metric ID in counter & replay counter metrics from IPC. r=chutten
...
This now ensures we can:
1. Look up a metric by its (numeric) ID again (which is cheaper than
carrying around strings.
2. Replay counter increments coming in from the IPC buffer
Differential Revision: https://phabricator.services.mozilla.com/D95008
2020-11-03 10:37:25 +00:00
fea87bf0c6
Bug 1672706 - Turn the metric ID into an opaque type around the integer representation. r=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D95007
2020-11-03 10:37:23 +00:00
b840112c1e
Bug 1672706 - Stop unimplemented metric types from breaking the build. r=chutten
...
Not all types have corresponding C++ implementations (for the C++ and JS API) yet.
To avoid too much work right now we skip auto-generating any code for
these types for now until we do have them.
Differential Revision: https://phabricator.services.mozilla.com/D95006
2020-11-03 10:37:15 +00:00
f71723139d
Bug 1674909: Mark LazyInstantiator::GetRootAccessible as nodiscard; r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D95593
2020-11-03 02:05:32 +00:00
ea163d7b6b
Bug 1674357 - [devtools] Remove lifetime from DevTools protocol r=ochameau,devtools-backward-compat-reviewers
...
Depends on D95299
The lifetime feature seems unused in DevTools. Removing it should have no impact.
Differential Revision: https://phabricator.services.mozilla.com/D95302
2020-11-03 16:43:52 +00:00
bf2c944982
Bug 1573300 - Make BlobEvent's data attribute non-nullable. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D95693
2020-11-03 15:44:34 +00:00
68568f67a5
Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers
...
Using `visibility` preserves frames of the content inside the dialog,
which we rely on to print the preview `<browser>` element.
This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.
I'd rather fix it in the front-end (by not trying to print a
`display: none` <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).
It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.
Differential Revision: https://phabricator.services.mozilla.com/D95501
2020-11-03 16:35:34 +00:00
9168a9f524
Bug 1674405 - [devtools] Extract StyleSheet, StyleSheets and MediaRule fronts to individual files r=daisuke,devtools-backward-compat-reviewers
...
Depends on D95329
Differential Revision: https://phabricator.services.mozilla.com/D95330
2020-11-03 16:35:51 +00:00
3ad5aa0547
Bug 1674405 - [devtools] Extract StyleSheet, StyleSheets and MediaRule specs to individual files r=daisuke,devtools-backward-compat-reviewers
...
Depends on D95328
Differential Revision: https://phabricator.services.mozilla.com/D95329
2020-11-03 15:56:12 +00:00
bcd5dded83
Bug 1674405 - [devtools] Extract StyleSheet, StyleSheets and MediaRule actors to individual files r=daisuke
...
Depends on D95299
The actors/stylesheets.js file contained three actors.
This change moves each actor in its own file.
Differential Revision: https://phabricator.services.mozilla.com/D95328
2020-11-02 18:42:53 +00:00
a311d05ca5
Bug 1654760 - [devtools] Remove usage of actorHasMethod in SwatchColorPickerTooltip r=rcaliman
...
This backward compatibility code can be removed
"getBackgroundColor" was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1568053 (FF70)
Differential Revision: https://phabricator.services.mozilla.com/D95315
2020-11-03 16:34:58 +00:00
c2b12f7822
Bug 1674674 - Transcode HashNumber for ParserAtoms. r=arai
...
Include the HashNumber in XDR data so we don't need to recompute it and can
speed up interning of these known-to-be-unique ParserAtoms.
Differential Revision: https://phabricator.services.mozilla.com/D95466
2020-11-03 15:49:00 +00:00
d015e18aaf
Bug 1674674 - Use HashSet::putNew when interning ParserAtom for XDR. r=arai
...
We currently assert that XDR'd ParserAtoms are unique, but still use the
slightly slower lookupForAdd APIs. Instead, the patch uses putNew which
avoids an extra comparison on hash collisions.
Also greatly simplify the Char16LE case which is only used for XDR and can
safely assume no static strings or non-wide atoms are passed.
Differential Revision: https://phabricator.services.mozilla.com/D95465
2020-11-03 15:48:58 +00:00
76f3cd487b
Bug 1674674 - Remove ParserAtomsTable::internLatin1Seq. r=arai
...
This is the same code as internChar16Seq if we chose the right
parameterization, so simplify the code a little.
Differential Revision: https://phabricator.services.mozilla.com/D95464
2020-11-03 15:48:55 +00:00
8616d7df07
Bug 1674869 - Cleanup XDRScriptStencil to improve perf. r=arai
...
Now that XDR checks for correct endianness, we can use codeBytes for more
complex structures. We also move the function to StencilXdr namespace.
Differential Revision: https://phabricator.services.mozilla.com/D95587
2020-11-03 15:48:53 +00:00
f250a1e107
Bug 1663924 - Use IDB_TRY in DatabaseConnection::UpdateRefcountFunction. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D93971
2020-11-03 16:10:57 +00:00
403dbf217d
Bug 1649094 - [geckodriver] Update changeset for the 0.28.0 release. r=webdriver-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D95303
2020-11-03 16:19:07 +00:00
ab551c6519
Bug 1674825 - Update libcubeb to 4e851e. r=cubeb-reviewers,kinetik
...
Differential Revision: https://phabricator.services.mozilla.com/D95549
2020-11-03 15:45:30 +00:00
2ab836d606
Bug 1674825 - Prepare build system and vendoring script for the new AAudio backend. r=cubeb-reviewers,kinetik
...
Differential Revision: https://phabricator.services.mozilla.com/D95548
2020-11-03 16:01:59 +00:00
335696dd36
Bug 1674436 - Share Prepare/Execute functions across JIT test cases. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D95384
2020-11-03 14:34:06 +00:00
8dbc84d482
Bug 1674599 - Wait for l10n to finish before resizing window. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D95692
2020-11-03 15:50:01 +00:00
ae74e57f04
Backed out 6 changesets (bug 1674902) for build bustage on a CLOSED TREE
...
Backed out changeset e4f63ba14348 (bug 1674902)
Backed out changeset 9f6e1866a7c3 (bug 1674902)
Backed out changeset a71e810d79d0 (bug 1674902)
Backed out changeset 071d1d593deb (bug 1674902)
Backed out changeset e88b258d7013 (bug 1674902)
Backed out changeset d1f72c3f70a0 (bug 1674902)
2020-11-03 17:47:35 +02:00
58f2daf6b8
Bug 1675010 - Make sure to cleanup in actor for docshell/test/browser/browser_bug422543.js. r=kashav
...
Differential Revision: https://phabricator.services.mozilla.com/D95732
2020-11-03 14:32:41 +00:00
5d542cad2e
Bug 1599610 - Unskip browser_bug422543 test for Fission. r=kashav
...
Differential Revision: https://phabricator.services.mozilla.com/D95676
2020-11-03 14:32:56 +00:00
2852676254
Bug 1674902: Part 6 - mscom::ActivationContext cleanup; r=Jamie
...
I just wanted to add a better explanation for what the magic `2` constant
is for.
Differential Revision: https://phabricator.services.mozilla.com/D95602
2020-11-03 02:53:33 +00:00
a89d1612fa
Bug 1674902: Part 5 - Some mscom::ApartmentRegion cleanup; r=Jamie
...
Just some additional annotations
Depends on D95600
Differential Revision: https://phabricator.services.mozilla.com/D95601
2020-11-03 02:50:21 +00:00
331db9d8d2
Bug 1674902: Part 4 - mscom/Ptr.h cleanup; r=Jamie
...
Some cleanup in our smart pointer stuff: Using `move` semantics lets us avoid
needing to hack around our static analysis.
Depends on D95599
Differential Revision: https://phabricator.services.mozilla.com/D95600
2020-11-03 02:45:39 +00:00
3b4cad3543
Bug 1674902: Part 3 - Add IsCurrentThreadNonMainMTA to mscom/Utils.h; r=Jamie
...
This is a new check that I'd like to use in some future patches.
Depends on D95598
Differential Revision: https://phabricator.services.mozilla.com/D95599
2020-11-03 02:35:51 +00:00
fb52f1b26c
Bug 1674902: Part 2 - Use CLSID_NULL instead of a distinct null CLSID; r=Jamie
...
Just a quick patch to reference an existing zeroed-out GUID instead of
instantiating a new one.
Depends on D95597
Differential Revision: https://phabricator.services.mozilla.com/D95598
2020-11-03 02:11:13 +00:00
8e3b8ba2bb
Bug 1674902: Part 1 - s/uint32_t/long/ for return codes in mscom/Utils.h; r=Jamie
...
`HRESULT` is `typedef`'d as `long`, so this patch harmonizes the return codes.
Differential Revision: https://phabricator.services.mozilla.com/D95597
2020-11-03 02:09:17 +00:00
0babf608a7
Bug 1674433 - Add ability to hide the top site section's title. r=mikedeboer
...
Differential Revision: https://phabricator.services.mozilla.com/D95342
2020-11-03 15:23:05 +00:00
a1d2ede4fe
Bug 1674564 - Make ServiceWorkerShutdownBlocker::MaybeInitUnblockShutdownTimer robust against re-entrance r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D95545
2020-11-03 08:19:58 +00:00
Aaron Klotz
Sebastian Hengst
Julian Descottes
Jan-Erik Rediger
Andreas Pehrson
Emilio Cobos Álvarez
Ted Campbell
Simon Giesecke
Henrik Skupin
Paul Adenot
Nicolas B. Pierron
pbz
Cristina Coroiu
Andreas Farre
Dão Gottwald
Jens Stutte