Граф коммитов

507 Коммитов

Автор SHA1 Сообщение Дата
Markus Stange f1e72b72af Bug 1321907 - Hook up the GPU process to the profiler. r=dvander
MozReview-Commit-ID: 8Xq3FPprAF8

--HG--
extra : rebase_source : 5fc143275081bd736574051e90b3dfa821a4be9a
2017-03-21 19:39:13 -04:00
David Anderson 8082fe14ae Remove references to the Direct3D9 compositor. (bug 1318558 part 1, r=mattwoodrow) 2017-03-08 00:17:36 -08:00
Georg Fritzsche be604ef5af Bug 1313326 - Part 1 - Support recording events in child processes. r=dexter,froydnj 2017-02-14 14:43:51 +01:00
Carsten "Tomcat" Book d0bd960945 merge mozilla-inbound to mozilla-central a=merge 2017-03-06 10:53:27 +01:00
Matt Woodrow ef5a44cc58 Bug 1340117 - Batch ReadLock intializer into a separate IDPL message to avoid hitting the file descriptor limit. r=dvander 2017-02-27 16:12:12 +13:00
Kan-Ru Chen 44755dd101 Bug 1344074 - make sure ParamTraits<mozilla::Array<T, Length>>::Read use the correct type. r=mattwoodrow
MozReview-Commit-ID: Id4pvQJe6A4

--HG--
extra : rebase_source : 7e674812ab2b8af79caf2239d3db5aa31f7b40b0
2017-03-03 19:46:00 +08:00
Sebastian Hengst 53a7c500b2 Backed out changeset a6db4cae9990 (bug 1313326) for failing browser_UsageTelemetry_content.js on Linux x64 asan and debug (at least). r=backout on a CLOSED TREE 2017-03-01 19:48:09 +01:00
Georg Fritzsche 5094a3ae8d Bug 1313326 - Part 1: Support recording events in child processes. r=dexter, r=froydnj 2017-02-14 14:43:51 +01:00
Morris Tseng 33d74b040e Bug 1340871 - Add CompositorUseANGLE info to TextureFactoryIdentifier. r=nical
MozReview-Commit-ID: GjlZS6T2i0p
2017-02-23 16:46:56 +08:00
Georg Fritzsche ea73f15059 Bug 1339749 - Refactor Telemetry IPC code. r=chutten
--HG--
rename : toolkit/components/telemetry/TelemetryComms.h => toolkit/components/telemetry/ipc/TelemetryComms.h
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.cpp => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.cpp
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.h => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.h
2017-02-15 16:25:40 +01:00
David Anderson da43dac799 Store the child process thread id in CrashReporterHost. (bug 1338281 part 2, r=billm) 2017-02-15 14:44:29 -08:00
Carsten "Tomcat" Book 5447789960 Backed out changeset 3a90f1f64d8d (bug 1339749) for bustage on a CLOSED TREE
--HG--
rename : toolkit/components/telemetry/ipc/TelemetryComms.h => toolkit/components/telemetry/TelemetryComms.h
rename : toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.cpp => toolkit/components/telemetry/TelemetryIPCAccumulator.cpp
rename : toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.h => toolkit/components/telemetry/TelemetryIPCAccumulator.h
extra : amend_source : 2f4229556609103157901609fee02aaedcdb8606
2017-02-15 16:10:29 +01:00
Georg Fritzsche ce683a039f Bug 1339749 - Refactor Telemetry IPC code. r=chutten
--HG--
rename : toolkit/components/telemetry/TelemetryComms.h => toolkit/components/telemetry/ipc/TelemetryComms.h
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.cpp => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.cpp
rename : toolkit/components/telemetry/TelemetryIPCAccumulator.h => toolkit/components/telemetry/ipc/TelemetryIPCAccumulator.h
2017-02-15 10:37:17 +01:00
Daniel Holbert 452a3b8454 Bug 1339609: Add #include for gfxPrefs.h to all source code that calls gfxPrefs APIs. r=jgilbert
MozReview-Commit-ID: GxWehmDYB3t

--HG--
extra : rebase_source : cd994e5c6abf777f77c5a708cbfb2f6afc49a44c
2017-02-14 14:01:59 -08:00
Ryan Hunt b782e91daf Bug 1337487 - Disable WebRender on windows when the GPU process is disabled r=kats
--HG--
extra : amend_source : 0203452b319c21331f1f0ebcd74e3f843b7785e1
2017-02-09 00:33:54 -06:00
Ryan Hunt 5e2990dc18 Merge m-c to graphics 2017-02-07 09:05:18 +00:00
Kartikaya Gupta 17c87e25f6 Bug 1337085 - Update RenderThread startup/shutdown to use a runtime flag rather than a compile-time one. r=sotaro
MozReview-Commit-ID: AVIEzb8MiGV
2017-02-06 22:22:44 -05:00
Brad Lassey a5e07b93bf bug 1303096 - Stop sending sync messages soon after content process start-up r=billm 2017-02-05 00:52:38 -05:00
sotaro 9365cc91a5 Bug 1335658 - Init RenderThread in GPUParent r=nical,kats 2017-02-03 10:22:49 +09:00
Ryan Hunt 3fe2c02ee1 Merge m-c to graphics 2017-01-27 10:07:37 -06:00
Kartikaya Gupta ca041b7c5a Merge m-c to graphics
MozReview-Commit-ID: FOyS87VawTT
2017-01-25 08:52:04 -05:00
David Anderson b0238351a0 Allow controlling the GPU process from xpcshell. (bug 1321492 part 8, r=mattwoodrow) 2017-01-26 16:35:55 -08:00
David Anderson 23572be8d6 Add memory reporting message support to PGPU. (bug 1321492 part 6, r=rhunt, r=erahm) 2017-01-26 16:35:54 -08:00
Kartikaya Gupta fdeff3fcd5 Merge m-c to graphics
MozReview-Commit-ID: 98wqjDW1RVK

--HG--
rename : browser/modules/CaptivePortalWatcher.jsm => browser/base/content/browser-captivePortal.js
rename : browser/modules/test/browser_CaptivePortalWatcher.js => browser/base/content/test/captivePortal/browser_CaptivePortalWatcher.js
rename : browser/base/content/test/plugins/browser_clearplugindata.html => browser/components/extensions/test/browser/file_clearplugindata.html
rename : modules/freetype2/src/gzip/zconf.h => modules/freetype2/src/gzip/ftzconf.h
extra : amend_source : b630126e257a8e2900ac0c3c735398a96ccd25e1
2017-01-23 09:45:48 -05:00
Kartikaya Gupta b66c471aef Merge m-c to graphics
MozReview-Commit-ID: LyU2woFOt7O
2017-01-18 13:48:56 -05:00
Kartikaya Gupta c7fda3b4ca Merge m-c to graphics
MozReview-Commit-ID: KzmBdQoXRRI
2017-01-17 09:01:06 -05:00
Kartikaya Gupta 1f7f98193e Bug 1326421 - Add a compositor option for WebRender being enabled or not. r=dvander
MozReview-Commit-ID: LeQRgKSn0Ql
2017-01-13 15:16:51 -05:00
Kartikaya Gupta 1f97dac250 Back out 4 csets from bug 1326421 because of various test failures. r=backout 2017-01-13 17:07:59 -05:00
Kartikaya Gupta c9bbaf820c Bug 1326421 - Add a compositor option for WebRender being enabled or not. r=dvander
MozReview-Commit-ID: LeQRgKSn0Ql
2017-01-13 15:16:51 -05:00
Alessio Placitelli 932126d970 Bug 1278556 - Enable child process scalar recording. r=chutten, f=gfritzsche,froydnj
MozReview-Commit-ID: IddrszBX0f5
2017-01-16 05:12:00 +01:00
David Anderson 89d48ae344 Use CompositableHandle in ImageNotification. (bug 1323957 part 3, r=mattwoodrow)
--HG--
extra : rebase_source : 2e5b108e68c2774f61776481ad9c4fa558923e38
2017-01-17 18:47:06 -08:00
Kartikaya Gupta ac6cc8ce06 Bug 1330037 - Propagate the CompositorOptions to all CompositorWidget instances. r=dvander
MozReview-Commit-ID: DFeeo2WNmhZ

--HG--
extra : rebase_source : d40bea7f726df007e3f079bb9576e1cbe17e3460
2017-01-12 17:29:42 -05:00
Kartikaya Gupta a6072f9a62 Bug 1330037 - Provide the CompositorBridgeParent with a CompositorOptions during construction that it holds for eternity. r=dvander
MozReview-Commit-ID: JnvNHUCF0AX

--HG--
extra : rebase_source : cf353f3397070c3133cf7eae8f0602a63f049e50
2017-01-12 17:29:41 -05:00
Kartikaya Gupta 6c437b31b9 Bug 1330037 - Introduce a CompositorOptions struct that holds options on a per-compositor basis. r=dvander
MozReview-Commit-ID: Kja7zpCDmp3

--HG--
extra : rebase_source : 001c841957ca7abe0ae3b3793b674e1986e4575c
2017-01-12 17:29:41 -05:00
David Anderson 9497d97e91 Send SimpleLayerAttributes separately from CommonLayerAttributes. (bug 1332567 part 6, r=mattwoodrow) 2017-01-24 16:41:18 -08:00
David Anderson 73fc4d8599 Rename the GPU process prefs. (bug 1330554, r=milan) 2017-01-16 23:51:24 -08:00
Carsten "Tomcat" Book a39a8fecdb Backed out changeset 74d2f566ed65 (bug 1331818) for memory leaks in url = about:support 2017-02-06 10:29:24 +01:00
David Anderson 849544ac0c Disabled "Terminate" button in about:support if no GPU process is running. (bug 1331818, r=gwright) 2017-02-05 21:56:00 -08:00
Sebastian Hengst 122ebc553b Backed out changeset e9d8a75a0dcc (bug 1303096) for failing various tests on Android 4.3 debug (e.g. test_saveHeapSnapshot_e10s_01.html). r=backout 2017-02-05 10:26:28 +01:00
Brad Lassey ecdf363246 bug 1303096 - Stop sending sync messages soon after content process start-up r=billm 2017-02-05 00:52:38 -05:00
George Wright 301ac256ca Bug 1324095 - Add GPU_PROCESS_INITIALIZATION_TIME_MS to track how long the GPU process takes to initialise excluding fork/xpcom initialisation times r=dvander,data-review=bsmedberg 2017-01-03 15:13:36 -05:00
Randall Barker f0c7845480 Bug 1328752 - part 1, Add UiCompositorController r=dvander 2017-01-20 11:01:29 -08:00
David Anderson 504484a456 Remove PLayer. (bug 1323539 part 2, r=mattwoodrow) 2016-12-21 10:43:47 -05:00
George Wright 5391bc3a05 Bug 1317796 - Rebucket and rename GPU_PROCESS_LAUNCH_TIME_MS to cater for launch times up to 64000ms r=dvander data-review=bsmedberg 2016-12-08 11:20:43 -08:00
Carsten "Tomcat" Book 9dd582c3dd Merge mozilla-central to autoland 2016-11-29 11:50:17 +01:00
Nathan Froyd 2ebbd09068 Bug 1320752 - remove mozilla/Function.h; r=gerald
We have std::function available now, which is likely to be somewhat more
efficient.
2016-11-28 11:03:53 -05:00
Daosheng Mu 9fb4892439 Bug 1316279 - Part 1: Fix gfxPrefs support for WebVR in out-of-process compositing; r=kip
MozReview-Commit-ID: 13tPgT0uDDi

--HG--
extra : rebase_source : 76de1955e928a5102d7d23b4baf2a3070309afd6
2016-11-23 09:40:54 +08:00
Matt Woodrow 1985af695f Bug 1319626 - Part 2: Add BorderLayer class and basic support for them. r=mstange
--HG--
extra : rebase_source : de87afc8015649fb5f4a7c4da5f4dc49e19f3d85
2016-11-24 18:11:30 +13:00
Carsten "Tomcat" Book 831c1e052a Backed out changeset 4909935f8081 (bug 1319626) 2016-11-24 17:02:32 +01:00
Carsten "Tomcat" Book 61849e269d merge mozilla-inbound to mozilla-central a=merge 2016-11-24 16:41:59 +01:00
Matt Woodrow 15af88120a Bug 1319626 - Part 2: Add BorderLayer class and basic support for them. r=mstange 2016-11-24 18:11:30 +13:00
Matt Woodrow b6a9ac8a28 Bug 1317862 - Part 1: Add TextLayer class and basic support for them. r=mstange 2016-11-24 18:11:29 +13:00
Daosheng Mu ab3dd3ce52 Bug 1318618 - Support nsCString data type in gfxPrefs; r=dvander
MozReview-Commit-ID: w5051nuVR5

--HG--
extra : rebase_source : 3af34967b0c9c432c6b77014479be98bd0f54387
2016-11-23 09:38:02 +08:00
George Wright 0a46071cca Bug 1297790 - Add GPU process feature status to the Telemetry environment r=dvander,gfritzsche data-review=bsmedberg 2016-11-21 15:10:11 -05:00
Jan Beich d5d5525615 Bug 1317757 - Explicitly include header for SprintfLiteral(). r=milan
MozReview-Commit-ID: K8O6AMKPGzN

--HG--
extra : rebase_source : e4799231edf44437577754e36903b61e2a512b9c
2016-11-15 18:58:29 +00:00
Carsten "Tomcat" Book e7ca75286b Merge mozilla-central to inbound 2016-11-16 14:53:15 +01:00
Kan-Ru Chen f8100451db Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Carsten "Tomcat" Book 8cfa5253e8 merge mozilla-inbound to mozilla-central a=merge 2016-11-15 12:26:41 +01:00
Milan Sreckovic 92fe1aae29 Bug 1316988: Change the wording of the error message. r=rhunt
MozReview-Commit-ID: GB1sF1APkBJ

--HG--
extra : rebase_source : 7f3c8673cffd223b2e366f7cb6728dc4abc7a90c
2016-11-11 17:51:25 -05:00
Ryan Hunt bd2880400d Bug 1317512 - Prevent overflow when using device reset prefs. r=milan
--HG--
extra : rebase_source : f79e755a62aa882a883c2341ffe1a035d2201885
2016-11-14 17:27:14 -06:00
David Anderson 2c5e03e62e Don't reset devices for each tab when the compositor resets. (bug 1316788, r=rhunt) 2016-11-14 11:47:01 -08:00
Matt Woodrow 77e78d9558 Bug 1316221 - Force VideoBridge shutdown to happen before the compositor thread is destroyed. r=dvander 2016-11-11 15:02:32 +13:00
Ryan Hunt 13190be4e0 Bug 1316476 - Limit the amount of device resets we allow with the gpu process. r=dvander
--HG--
extra : rebase_source : 7d1b74ad7573b91ea28e9cf015fc6d24c104f646
2016-11-09 20:57:04 -06:00
Carsten "Tomcat" Book 846adaea6c merge mozilla-inbound to mozilla-central a=merge 2016-11-09 16:38:04 +01:00
Carsten "Tomcat" Book 1d94331de7 Backed out changeset 364305744e4c (bug 1297790) for test bustage 2016-11-09 10:26:27 +01:00
George Wright dd8ff04b54 Bug 1297790 - Add GPU process feature status to the Telemetry environment r=dvander,gfritzsche data-review=bsmedberg 2016-11-09 03:18:32 -05:00
Matt Woodrow f880884b57 Bug 1315510 - Automatically recreate VideoDecoderManager if the GPU process crashes. r=dvander 2016-11-08 15:21:35 +13:00
Kartikaya Gupta c19a47d368 Bug 1315974 - Have the CompositorBridgeChild take a LayerManager instead of a ClientLayerManager. r=dvander
MozReview-Commit-ID: CPTCQgIl5ad

--HG--
extra : rebase_source : dabc583be1de1700c35444e517070455349ea9b8
2016-11-08 10:42:19 -05:00
George Wright 51a59d1d02 Bug 1314426 - Add a method to nsIDOMWindowUtils to terminate the GPU process and get the GPU process pid r=smaug,dvander 2016-11-07 14:22:48 -05:00
David Anderson ec7cac2aa1 Fix shutdown crash in VsyncBridgeChild when the GPU process is enabled. (bug 1314816, r=mattwoodrow) 2016-11-02 16:45:38 -07:00
Matt Woodrow 5375ddbb83 Bug 1300681 - Use gfxVars for DXVA blacklist prefs so that they work in the GPU process. r=dvander,gerald 2016-11-03 09:57:18 +13:00
Matt Woodrow 3b4d158ee3 Bug 1314189 - Only create a RemoteVideoDecoder if the current LayerManager is using the GPU process. r=dvander 2016-11-03 09:57:15 +13:00
Matt Woodrow 9e56f22190 Bug 1314186 - Resync LayerTreeId mappings to the GPU process if it restarts. r=dvander 2016-11-03 09:55:07 +13:00
Edwin Flores 12c57c38dd Bug 1309277 - Allow D3D9 without component alphaa - r=mattwoodrow 2016-11-02 10:55:07 +00:00
Bill McCloskey b47737ed9f Bug 792652 - Move FatalError to IProtocol (r=dvander)
This patch moves FatalError to IProtocol. I had to make a few changes.
- I added a ProtocolName() method to find the name of the protocol.
- I gave the two-argument version of FatalError its own name. Otherwise
  C++ doesn't like there to be two virtual methods with the same name
  in cases where one is overridden and the other isn't (as happens
  in IToplevelProtocol).
2016-11-08 15:22:45 -08:00
Ryan Hunt 8ee59ed7da Bug 1313199 - Sync a device reset from GPU process to main process. r=dvander
--HG--
extra : rebase_source : 4daf0427fee802cd986d7439c0e27eddbf671311
2016-11-06 13:01:52 -06:00
Ryan Hunt fec86bdccd Bug 1313199 - Allow sending reset compositor messages over IPDl. r=dvander
--HG--
extra : rebase_source : 6d949e758d35e40702aa8e8022a6482ed7dbe280
2016-11-06 12:56:53 -06:00
Wes Kocher 4b3d16605a Backed out 18 changesets (bug 792652) for build bustage on linux64 a=backout CLOSED TREE
Backed out changeset 90eaf6aec002 (bug 792652)
Backed out changeset ddd915ab4a48 (bug 792652)
Backed out changeset 95eff6c45cae (bug 792652)
Backed out changeset 75855b5a9ab9 (bug 792652)
Backed out changeset b658ebaad5d7 (bug 792652)
Backed out changeset 2ba36b8ac60c (bug 792652)
Backed out changeset 94fcd3bf3f34 (bug 792652)
Backed out changeset cf9c4164eb43 (bug 792652)
Backed out changeset 59e6d0a4f35b (bug 792652)
Backed out changeset bdf86b8b9c43 (bug 792652)
Backed out changeset 8edf4b247250 (bug 792652)
Backed out changeset 63a3c8e4016e (bug 792652)
Backed out changeset e3e496eab991 (bug 792652)
Backed out changeset 5a1e3136323a (bug 792652)
Backed out changeset dbbe3a8c00e7 (bug 792652)
Backed out changeset 1829d5358808 (bug 792652)
Backed out changeset 004cd692ba6d (bug 792652)
Backed out changeset 92e7fee81fa2 (bug 792652)
2016-11-08 12:05:28 -08:00
Bill McCloskey 35fc224b71 Bug 792652 - Move FatalError to IProtocol (r=dvander)
This patch moves FatalError to IProtocol. I had to make a few changes.
- I added a ProtocolName() method to find the name of the protocol.
- I gave the two-argument version of FatalError its own name. Otherwise
  C++ doesn't like there to be two virtual methods with the same name
  in cases where one is overridden and the other isn't (as happens
  in IToplevelProtocol).
2016-11-08 11:32:30 -08:00
Phil Ringnalda 27a5b8d2ae Backed out changeset d537051ade6a (bug 1315510) for nsTArray_base leaks and a fondess for crashing
CLOSED TREE

MozReview-Commit-ID: KD3jAkCg0O7
2016-11-07 22:18:21 -08:00
Matt Woodrow 7afb98ff2b Bug 1315510 - Automatically recreate VideoDecoderManager if the GPU process crashes. r=dvander 2016-11-08 15:21:35 +13:00
David Anderson 223ed063da Fix UI process not properly waiting for the GPU process to finish launching. (bug 1314127, r=rhunt) 2016-10-31 16:03:41 -07:00
David Anderson ec2b48ff8b Send accumulated GPU process telemetry to the UI process. (bug 1304494 part 3, r=gfritzsche) 2016-10-30 22:35:57 -07:00
David Anderson ea1b39856a Ensure we start the Telemetry singleton in the GPU process. (bug 1304494 part 1, r=gfritzsche) 2016-10-30 22:35:56 -07:00
George Wright 119e15b6b3 Bug 1297790 - Add telemetry probes for GPU process launch/launch-time/abort r=dvander
MozReview-Commit-ID: LgrdMOSZn8J
2016-10-20 11:33:40 -04:00
Wes Kocher 78f5a63960 Backed out changeset 0a1486cf11b2 (bug 1297790) for browser_UsageTelemetry_content_aboutHome.js failures a=backout CLOSED TREE
--HG--
extra : rebase_source : 8d082316cd6603b1c5f1e8408249b77afe271a7d
2016-10-28 15:44:51 -07:00
George Wright 809a0bbfbb Bug 1297790 - Add telemetry probes for GPU process launch/launch-time/abort r=dvander 2016-10-28 16:21:08 -04:00
Wes Kocher 7aeeee11d0 Backed out 2 changesets (bug 1309200) for build bustage on a CLOSED TREE a=backout
Backed out changeset b5ad7d04ed43 (bug 1309200)
Backed out changeset 1563a66b64d8 (bug 1309200)
2016-10-28 10:22:47 -07:00
Nicolas Silva 9af48bd777 Bug 1309200 - Add gfx::Factory::GetDefaultSoftwareBackend. r=Bas 2016-10-28 18:27:37 +02:00
David Anderson 9db9ae327f Move ownership of LogForwarder to Moz2D. (bug 1310397, r=mattwoodrow) 2016-10-15 13:04:00 -07:00
Kartikaya Gupta e6f4f137d8 Bug 1275314 - Allow flushing in-progress checkerboard reports in the GPU process as well. r=dvander
MozReview-Commit-ID: CXLzkiloHW
2016-10-15 08:45:02 -04:00
David Anderson c69dfea9a5 Don't double-call EnsureProcessTerminated when killing the GPU process. (bug 1310111, r=billm) 2016-10-14 23:27:32 -07:00
Wes Kocher aeac5ac648 Backed out changeset 73a60f9b3c2f (bug 1275314) for GTest bustage CLOSED TREE
--HG--
extra : histedit_source : 5498a231b3e43706e93835242d246489697dcd9c%2C1ba18b3300a0dfd8b03881bf431334be1f866eb8
2016-10-14 14:52:44 -07:00
Kartikaya Gupta b5ab2ae9ac Bug 1275314 - Allow flushing in-progress checkerboard reports in the GPU process as well. r=dvander
MozReview-Commit-ID: 3EPv8hh7Zxh
2016-10-14 15:38:01 -04:00
David Anderson a3280f1c79 Move GPU process XPCOM shutdown to ProcessChild::CleanUp. (bug 1308398 part 3, r=billm) 2016-10-12 00:08:37 -07:00
David Anderson 790d6541fc Fix VsyncBridgeParent leaking on GPU process shutdown. (bug 1308398 part 2, r=mattwoodrow) 2016-10-12 00:08:36 -07:00
David Anderson 087728d181 Ensure nsThreadManager is started before IPC in the GPU process. (bug 1308398 part 1, r=billm) 2016-10-12 00:08:36 -07:00
Sotaro Ikeda 1d3ceeff04 Bug 1306521 - Handle VP9 colorspace BT.709 on BasicCompositor r=nical,jwwang,jya,jrmuizel 2016-10-11 19:46:28 -07:00
David Anderson 43c76f1bba Use CrashReporterHost/Client in the GPU process. (bug 1278717 part 3, r=billm) 2016-10-11 14:25:41 -07:00
George Wright 375da61c8b Bug 1297828 - Ensure gfx logging works in the GPU process r=dvander 2016-10-07 11:28:41 -04:00