Граф коммитов

14992 Коммитов

Автор SHA1 Сообщение Дата
Brad Werth ee1bf29b7a Bug 1561227 Part 3: Make RDM UI save and restore resolution when responding to a full zoom change. r=mtigley
This change makes the RDM content frame script listen to the new
PreFullZoomChange event, and treat that as a trigger to save the
existing resolution. The content window will send 2 resize events
as it adjusts to the new RDM pane size set by the front end. After
these events are received, the resolution is restored and a new
event is fired that indicates the work of zooming is complete.

Differential Revision: https://phabricator.services.mozilla.com/D48624

--HG--
extra : moz-landing-system : lando
2019-10-24 23:42:48 +00:00
Gabriel Luong 48625f2f06 Bug 1550804 - Add color scheme simulation to the inspector. r=pbro
This adds a color scheme simulation toggle button in the rules view,
which will toggle between 4 different states: default, dark, light,
and no-preference.

This feature is currently hidden away under a preference:
devtools.inspector.color-scheme-simulation.enabled

The final UI/UX still needs to be figured out, however, this initial step is
to land the ability to prototype this feature.

Differential Revision: https://phabricator.services.mozilla.com/D49833

--HG--
extra : moz-landing-system : lando
2019-10-25 19:28:02 +00:00
Ciure Andrei c0740c9722 Backed out changeset b5095678aa15 (bug 1591446) for causing debugger-tests node to perma fail CLOSED TREE 2019-10-25 21:30:18 +03:00
Brian Hackett 081b4af474 Bug 1591446 - Use right context when closing project file search, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D50620

--HG--
extra : moz-landing-system : lando
2019-10-25 17:33:28 +00:00
Andreea Pavel 02bbc55a55 Backed out changeset e69e9a6aa261 (bug 1491811) for failing dt at e.g. browser_inspector_textbox-menu.js on a CLOSED TREE 2019-10-25 20:18:11 +03:00
Michael Ratcliffe cc663bcc1d Bug 1491811 - Rules: replace custom checkbox with -moz-appearance:checkbox r=fvsch
***
Bug 1491811 - Get screenshots of Rule View with native checkboxes

Differential Revision: https://phabricator.services.mozilla.com/D49305

--HG--
extra : moz-landing-system : lando
2019-10-24 11:36:30 +00:00
Nicolas Chevobbe 9dc42c00ce Bug 1590633 - Remove Reps launchpad. r=Honza.
This means we can also cleanup the package.json,
and remove file that were only needed for the
launchpad.

Differential Revision: https://phabricator.services.mozilla.com/D50174

--HG--
extra : moz-landing-system : lando
2019-10-25 12:08:17 +00:00
Nicolas Chevobbe 66887be8da Bug 1589346 - Fix navigation to debugger from console on prettified sources. r=loganfsmyth.
This revert the changes made in Bug 1587839, except the added test.
The safer fix to be uplifted is to only fix the original issue
in the SmartTrace component, where we remove any sourceId we might
have when creating the new mapped frame.

We also modify the browser_dbg-pretty-print-console test to ensure
clicking on a prettified location in the console does open the
debugger with the expected location.

Differential Revision: https://phabricator.services.mozilla.com/D50173

--HG--
extra : moz-landing-system : lando
2019-10-25 12:16:52 +00:00
Daniel Varga 2d8c1c6548 Backed out changeset fac6219649be (bug 1587839) on request by nchevobbe DONTBUILD
--HG--
extra : rebase_source : 7704b8ca8bdaf66bc68d488fd81a824f5bfc6678
2019-10-25 14:56:44 +03:00
Nicolas Chevobbe 69c6356c7e Bug 1591061 - Enable browser_toolbox_console_new_process on debug builds. r=bhackett.
The test takes a long time to run, so we request a longer
timeout.

Differential Revision: https://phabricator.services.mozilla.com/D50567

--HG--
extra : moz-landing-system : lando
2019-10-25 11:48:59 +00:00
Nicolas Chevobbe 940c844ce7 Bug 1589376 - Remove compact mode related proptypes. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D50566

--HG--
extra : moz-landing-system : lando
2019-10-25 10:34:54 +00:00
Mustafa edf7049113 Bug 1588444 - Show formatted data over collapsed raw data. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D50459

--HG--
extra : moz-landing-system : lando
2019-10-25 11:37:02 +00:00
Mustafa 304c0696ac Bug 1587750 - fix isJSON healper function. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49294

--HG--
extra : moz-landing-system : lando
2019-10-25 10:20:26 +00:00
Coroiu Cristina 9068a14016 Bug 1580323 -Disable browser_dbg-quick-open.js on mac and linux debug for frequent failures. r=egao
Differential Revision: https://phabricator.services.mozilla.com/D50569

--HG--
extra : moz-landing-system : lando
2019-10-25 09:13:46 +00:00
Nicolas Chevobbe 28e37b5b09 Bug 1587839 - Fix navigation to debugger from console on prettified sources. r=loganfsmyth.
This revert the changes made in Bug 1587839, except the added test.
The safer fix to be uplifted is to only fix the original issue
in the SmartTrace component, where we remove any sourceId we might
have when creating the new mapped frame.

We also modify the browser_dbg-pretty-print-console test to ensure
clicking on a prettified location in the console does open the
debugger with the expected location.

Differential Revision: https://phabricator.services.mozilla.com/D50173

--HG--
extra : moz-landing-system : lando
2019-10-25 06:21:18 +00:00
Csoregi Natalia a377414b6d Backed out 8 changesets (bug 1561227) for failures on browser_viewport_resizing_scrollbar.js. CLOSED TREE
Backed out changeset 8117cafb3a20 (bug 1561227)
Backed out changeset 635534927ffc (bug 1561227)
Backed out changeset 693b0dd88f2b (bug 1561227)
Backed out changeset 257bc09f49af (bug 1561227)
Backed out changeset 1b63d555c6c1 (bug 1561227)
Backed out changeset 677da957ddcb (bug 1561227)
Backed out changeset f8b8e593316f (bug 1561227)
Backed out changeset 849e1cf51a8f (bug 1561227)

--HG--
rename : devtools/client/responsive/test/browser/browser_viewport_zoom_toggle.js => devtools/client/responsive/test/browser/browser_toggle_zoom.js
2019-10-25 02:35:11 +03:00
Gurzau Raul a11233a256 Backed out changeset 5eb5f44dcf96 (bug 1550804) for failures at browser_parsable_css.js on a CLOSED TREE. 2019-10-25 02:03:36 +03:00
Gabriel Luong 7bd0dc6499 Bug 1587789 - Remove isXBLAnonymous functions defined and used in the inspector. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D50517

--HG--
extra : moz-landing-system : lando
2019-10-24 21:05:44 +00:00
alexdominguezg 78e89d3ba7 Bug 1565978 - Stop changing the currently selected row in Network with left and right keys. r=fvsch
Unbind the ArrowLeft and ArrowRight keys in the request list and messages list, keeping only ArrowUp and ArrowDown, to be consistent with tree navigation and more predictable in RTL UI layout.

Differential Revision: https://phabricator.services.mozilla.com/D49457

--HG--
extra : moz-landing-system : lando
2019-10-24 20:56:50 +00:00
Gabriel Luong f950443d4d Bug 1550804 - Add color scheme simulation to the inspector. r=pbro
This adds a color scheme simulation toggle button in the rules view,
which will toggle between 4 different states: default, dark, light,
and no-preference.

This feature is currently hidden away under a preference:
devtools.inspector.color-scheme-simulation.enabled

The final UI/UX still needs to be figured out, however, this initial step is
to land the ability to prototype this feature.

Differential Revision: https://phabricator.services.mozilla.com/D49833

--HG--
extra : moz-landing-system : lando
2019-10-24 20:39:00 +00:00
Brad Werth 180df98ec0 Bug 1561227 Part 8: Update expectations for existing tests. r=botond
The change to await snapshotWindow is something that should have been
done in Bug 1573254.

Differential Revision: https://phabricator.services.mozilla.com/D47510

--HG--
extra : moz-landing-system : lando
2019-10-24 16:50:53 +00:00
Brad Werth 327fb0df8f Bug 1561227 Part 7: Add a test of meta viewport resizing with full zoom. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D44504

--HG--
extra : moz-landing-system : lando
2019-10-24 16:50:31 +00:00
Brad Werth fff96c2e72 Bug 1561227 Part 6: Rename an existing RDM zoom test in anticipation of adding related tests. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D44503

--HG--
rename : devtools/client/responsive/test/browser/browser_toggle_zoom.js => devtools/client/responsive/test/browser/browser_viewport_zoom_toggle.js
extra : moz-landing-system : lando
2019-10-24 16:50:09 +00:00
Brad Werth bc08d2af3e Bug 1561227 Part 5: Define a helper function for setting RDM zoom and use it in existing tests. r=botond
This helper function awaits the new custom event sent by the RDM pane
frame script when zooming is done, then waits for the reflow to be
complete also. After this is done, resolution and window and content
sizes all have their correct, final values.

Differential Revision: https://phabricator.services.mozilla.com/D47366

--HG--
extra : moz-landing-system : lando
2019-10-24 16:49:46 +00:00
Brad Werth 9d15dc5761 Bug 1561227 Part 4: Make RDM force the UI ZoomChild Actor to cache its zoom level. r=mconley,gl
The ZoomChild actor normally caches its full zoom level only when it is
changed, then emits a FullZoomChange event. That event causes problems
with Responsive Design Mode, which receives the event after other
similar events that carry the full zoom level of the RDM pane content.
The RDM UI pane itself always stays at 1.0 zoom. This change makes the
ZoomChild cache its initial fullZoom level as soon as possible, which
prevents the first RDM zoom change from sending the unwanted event.

Differential Revision: https://phabricator.services.mozilla.com/D49793

--HG--
extra : moz-landing-system : lando
2019-10-24 20:35:01 +00:00
Brad Werth 21b357260e Bug 1561227 Part 3: Make RDM UI save and restore resolution when responding to a full zoom change. r=mtigley
This change makes the RDM content frame script listen to the new
PreFullZoomChange event, and treat that as a trigger to save the
existing resolution. The content window will send 2 resize events
as it adjusts to the new RDM pane size set by the front end. After
these events are received, the resolution is restored and a new
event is fired that indicates the work of zooming is complete.

Differential Revision: https://phabricator.services.mozilla.com/D48624

--HG--
extra : moz-landing-system : lando
2019-10-24 16:49:01 +00:00
Gurzau Raul 4e686f7962 Backed out changeset f3fee3ded743 (bug 1550804) for many devtools failures e.g. browser_markup_accessibility_focus_blur.js on a CLOSED TREE. 2019-10-24 21:39:31 +03:00
Gabriel Luong 627912f5f2 Bug 1550804 - Add color scheme simulation to the inspector. r=pbro
This adds a color scheme simulation toggle button in the rules view,
which will toggle between 4 different states: default, dark, light,
and no-preference.

This feature is currently hidden away under a preference:
devtools.inspector.color-scheme-simulation.enabled

The final UI/UX still needs to be figured out, however, this initial step is
to land the ability to prototype this feature.

Differential Revision: https://phabricator.services.mozilla.com/D49833

--HG--
extra : moz-landing-system : lando
2019-10-24 17:23:18 +00:00
Alexandre Poirot be1b551d62 Bug 1588741 - Descriptors.getTarget may return unattached targets when called in parallel. r=jdescottes
The race isn't trivial to reproduce and the test do not reproduce it.
But this was making target list tests to fail.

Differential Revision: https://phabricator.services.mozilla.com/D48856

--HG--
extra : moz-landing-system : lando
2019-10-23 16:33:42 +00:00
Itiel 6721412f26 Bug 1590306 - Force LTR on the shortcut key in the welcome box r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D50083

--HG--
extra : moz-landing-system : lando
2019-10-24 07:41:55 +00:00
Julian Descottes b6846ec07b Bug 1590823 - Fix scrollbars in accessibility panel by using --devtools-toolbar-height instead of --accessibility-toolbar-height r=fvsch
The accessibility panel is calculating the height of some of its containers by doing 100vh - toolbar height.
But the accessibility panel was relying on a local variable --accessibility-toolbar-height which was actually not used to set the height of the toolbar.
So when the toolbar height increased of 1px, all those calculations became wrong.

The --accessibility-toolbar-height is now the same as --theme-toolbar-height so I propose to remove the local variable and only use the devtools one.

Differential Revision: https://phabricator.services.mozilla.com/D50291

--HG--
extra : moz-landing-system : lando
2019-10-24 07:03:51 +00:00
Nicolas Chevobbe 494422872e Bug 1585923 - Rename MenuButton doc prop to toolboxDoc. r=jdescottes.
This should make it more obvious what kind of document
the component is expecting.

Differential Revision: https://phabricator.services.mozilla.com/D50240

--HG--
extra : moz-landing-system : lando
2019-10-24 05:56:10 +00:00
Gabriel Luong fd32c2b962 Bug 1574506 - Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D49990

--HG--
extra : moz-landing-system : lando
2019-10-23 04:38:13 +00:00
Brian Hackett 7fabe60cdf Bug 1444064 Part 3 - Add test that OBT web console listens to new processes, r=nchevobbe.
Depends on D48864

Differential Revision: https://phabricator.services.mozilla.com/D48865

--HG--
extra : moz-landing-system : lando
2019-10-23 17:39:02 +00:00
Belén Albeza c4bf55ef42 Bug 1583705: Fix capitalization of heading when no manifest is available r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D50045

--HG--
extra : moz-landing-system : lando
2019-10-23 11:15:28 +00:00
Brian Hackett 8fd4f4e0e2 Bug 1444064 - Add ToolboxTask object for communicating with the browser toolbox during tests, r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D48773

--HG--
extra : moz-landing-system : lando
2019-10-23 14:10:59 +00:00
Greg Tatum 9157afe622 Bug 1588295 - Change popup test to use the js feature rather than stackwalk; r=gerald
This test is relying on a profiler feature that is not available in every
platform. This patch changes it to use the "js" feature, which should be
supported everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D49948

--HG--
extra : moz-landing-system : lando
2019-10-23 14:07:47 +00:00
Greg Tatum de7682bba8 Bug 1588192 - Fix the TypeScript require function in the initializers; r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D49012

--HG--
extra : moz-landing-system : lando
2019-10-23 13:49:27 +00:00
Nicolas Chevobbe 9b4c9080e0 Bug 1590707 - Don't display outline on CodeMirror scrollbars. r=fvsch.
Differential Revision: https://phabricator.services.mozilla.com/D50201

--HG--
extra : moz-landing-system : lando
2019-10-23 12:41:12 +00:00
Itiel 844a131a81 Bug 1590311 - Fix 'Copy All Changes' button styling for RTL. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D50115

--HG--
extra : moz-landing-system : lando
2019-10-23 12:17:45 +00:00
Daisuke Akatsuka 22b7417018 Bug 1588964: Update jest test for the unsupported browsers. r=ladybenko
Depends on D49519

Differential Revision: https://phabricator.services.mozilla.com/D49520

--HG--
extra : moz-landing-system : lando
2019-10-23 08:59:29 +00:00
Daisuke Akatsuka 3d16270968 Bug 1588964: Add tests for the unsupported browsers. r=rcaliman,ladybenko
Depends on D49518

Differential Revision: https://phabricator.services.mozilla.com/D49519

--HG--
extra : moz-landing-system : lando
2019-10-23 09:08:17 +00:00
Daisuke Akatsuka a5519b8c66 Bug 1588964: Show the browsers support status. r=rcaliman,ladybenko
Depends on D49378

Differential Revision: https://phabricator.services.mozilla.com/D49518

--HG--
extra : moz-landing-system : lando
2019-10-23 09:11:46 +00:00
Daisuke Akatsuka db043e87f2 Bug 1589858: Add a test whether the rule view is available or not when plural styles which are defined in media query block are set for visited link. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D50156

--HG--
extra : moz-landing-system : lando
2019-10-23 11:20:28 +00:00
Julian Descottes ab49d009e4 Bug 1590630 - Fail DevTools metrics test explicitly when DEBUG_JS_MODULES is enabled r=daisuke
DEBUG_JS_MODULES will make the BrowserLoader load different versions of some React files.
This confuses our metrics test that checks against duplicated modules and relies on a strict whitelist.
We fail the test explicitly since this performance metrics test should really only be run without DEBUG modules.

Differential Revision: https://phabricator.services.mozilla.com/D50160

--HG--
extra : moz-landing-system : lando
2019-10-23 09:12:28 +00:00
Daisuke Akatsuka d0f08fcdda Bug 1590003: Lazily load the compatibility lib and the dataset. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D50159

--HG--
extra : moz-landing-system : lando
2019-10-23 07:30:15 +00:00
jaril efb5fa8565 Bug 1581918 - Add an experimental badge to Replay in the settings panel
Differential Revision: https://phabricator.services.mozilla.com/D50007

--HG--
extra : moz-landing-system : lando
2019-10-23 00:33:24 +00:00
Jason Laster ff017ca271 Bug 1590241 - Enable WebReplay appears in DevEdition. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D50145

--HG--
extra : moz-landing-system : lando
2019-10-23 00:51:00 +00:00
Dorel Luca 03762f81ac Backed out changeset bddcd12198e7 (bug 1574506) for Devtools failures in devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js. CLOSED TREE 2019-10-23 00:31:21 +03:00
Gabriel Luong 1bf9113bfe Bug 1590187 - Remove actorhasMethod check for getIsPrintSimulationEnabled. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D49971

--HG--
extra : moz-landing-system : lando
2019-10-21 21:34:27 +00:00
Gabriel Luong 070bb394ee Bug 1574506 - Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D49990

--HG--
extra : moz-landing-system : lando
2019-10-22 18:53:20 +00:00
Brian Hackett 611ae752a0 Bug 1589864 - Copy over prefs when starting the browser toolbox, r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D49829

--HG--
extra : moz-landing-system : lando
2019-10-22 14:12:35 +00:00
David Walsh 7b3b189a0a Bug 1590029 - Show blocking button in multiple row view r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49929

--HG--
extra : moz-landing-system : lando
2019-10-22 08:50:17 +00:00
David Walsh ede10d7d14 Bug 1590119 - Ensure matched blocking URLs are sent to server r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49955

--HG--
extra : moz-landing-system : lando
2019-10-22 08:53:18 +00:00
Julien Wajsberg bed13567fb Bug 1589122 - Add a simple check to the xpcshell test r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D49646

--HG--
extra : moz-landing-system : lando
2019-10-22 08:14:07 +00:00
Julien Wajsberg 333cd53ceb Bug 1589122 - Rename some arguments from settings to prefs where appropriate r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D49645

--HG--
extra : moz-landing-system : lando
2019-10-22 08:14:00 +00:00
Julien Wajsberg 2ef21585f6 Bug 1589122 - Add and use functions to translate values between the stored preferences and the state r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D49644

--HG--
extra : moz-landing-system : lando
2019-10-22 08:13:58 +00:00
Julien Wajsberg 6ab2fdc4a0 Bug 1589122 - Add comments to the functions called when using the shortcut keys r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D49733

--HG--
extra : moz-landing-system : lando
2019-10-22 08:13:56 +00:00
Julien Wajsberg 75ff79ea60 Bug 1589122 - Fix the default interval in reducers r=canaltinova
This value isn't really used, nevertheless it's good to have it to the
right value for documentation reason and consistency.

Differential Revision: https://phabricator.services.mozilla.com/D49643

--HG--
extra : moz-landing-system : lando
2019-10-22 08:13:55 +00:00
Julien Wajsberg 2ca92e3b9a Bug 1589122 - Appropriately configure the default interval pref in microseconds r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D49642

--HG--
extra : moz-landing-system : lando
2019-10-22 08:13:47 +00:00
Julien Wajsberg 75f5c38006 Bug 1589122 - Rename getDefaultRecordingSettings to getDefaultRecordingPreferences r=canaltinova
This also renames various variables from "settings" to "preferences" to
make it clearer that the values are about actual preferences stored in
the user profile.

Differential Revision: https://phabricator.services.mozilla.com/D49641

--HG--
extra : moz-landing-system : lando
2019-10-22 08:13:46 +00:00
Gerald Squelart 93254141e5 Bug 1583430 - Profiler popup feature "No Periodic Sampling" - r=julienw
Expose the Gecko Profiler feature "nostacksampling" as "No Periodic Sampling".

Differential Revision: https://phabricator.services.mozilla.com/D49231

--HG--
extra : moz-landing-system : lando
2019-10-22 06:23:28 +00:00
Florens Verschelde 6de3972afb Bug 1589233 - Align CodeMirror line-height with Debugger in Inspector, Style Editor and Console editor; r=gl,nchevobbe
We have a few CodeMirror instances where we're using the default line height (`line-height: normal`), resulting in a line-height in the 13-14.5px range (depending on the font, OS, resolution). By contrast, the Debugger uses 15px explictly, and that's a style we're trying to generalize.

This patch sets a 15px line-height for:
- Inspector: the CodeMirror instance used in the markup view for "Edit as HTML" and in event tooltips
- Style Editor: the main editor instance
- Console: the jsterm but only in editor mode (since the output uses a 14px line-height on purpose, the jsterm in standard mode keeps this 14px line-height to minimize visual jumps when sending a command)

Differential Revision: https://phabricator.services.mozilla.com/D49593

--HG--
extra : moz-landing-system : lando
2019-10-21 14:18:07 +00:00
Florens Verschelde 750b0e8dc2 Bug 1589961 - Improve UI alignment in Request Blocking pane, align with XHR Breakpoints style; r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49859

--HG--
extra : moz-landing-system : lando
2019-10-21 22:18:44 +00:00
Jim Porter 9354dfda4a Bug 1557447 - Profiler support for IPC information; r=nika,smaug
This adds the ability to add profile markers for both the sender and recipient
sides of IPC messages. These can then be correlated with one another in the
profile visualization. For the UI component of this patch, see
<https://github.com/firefox-devtools/profiler/pull/2172>.

Differential Revision: https://phabricator.services.mozilla.com/D42226

--HG--
extra : moz-landing-system : lando
2019-10-21 20:51:07 +00:00
Brendan Dahl 48a59e061b Bug 1583314 - Skip or port XBL tests to shadow DOM. r=bzbarsky
Where possible I ported tests to use the shadow DOM. The following could
potentially be ported, but don't think it worth of it:
  test_bug414907.xul - uses children nodes in constructor which is very
different in shadow DOM world
  test_bug233643.xul - really tests XBL behavior
  test_anonymous_content.py - bug on file already to create shadow DOM
test from scratch

Differential Revision: https://phabricator.services.mozilla.com/D49341

--HG--
rename : devtools/client/inspector/test/browser_inspector_highlighter-xbl.js => devtools/client/inspector/test/browser_inspector_highlighter-custom-element.js
extra : moz-landing-system : lando
2019-10-21 20:21:20 +00:00
Julien Wajsberg efcb99116b Bug 1590115 - Add getSymbolsFromThisBrowser back r=canaltinova
This function is used in several locations and at least two files, so
it's useful to have it exist as a named and exported function.

Differential Revision: https://phabricator.services.mozilla.com/D49945

--HG--
extra : moz-landing-system : lando
2019-10-21 17:00:28 +00:00
Nicolas Chevobbe 18d056c8b3 Bug 1561281 - Fix debugger zombie highlighters. r=davidwalsh.
Differential Revision: https://phabricator.services.mozilla.com/D36300

--HG--
extra : moz-landing-system : lando
2019-10-21 14:02:05 +00:00
Nicolas Chevobbe 01b488d7ee Bug 1561281 - Remove toolbox getHighlighter `isGrip` parameter. r=davidwalsh.
Some panels, like the debugger, might handle both nodeFronts and grips
at the same time, so there's no way to know ahead of time which kind
of object we're going to deal with.
This patch remove the isGrip parameter, and perform a check on the
passed object to see if it's a nodeFront instance or not.

Differential Revision: https://phabricator.services.mozilla.com/D49399

--HG--
extra : moz-landing-system : lando
2019-10-21 08:27:11 +00:00
Florens Verschelde 06c5b1ea26 Bug 1589757 - Update Debugger Main Thread and Worker icons; r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D49789

--HG--
extra : moz-landing-system : lando
2019-10-21 13:50:34 +00:00
Florens Verschelde 3a64027cdb Bug 1590059 - Stop search result header text from overflowing its container; r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D49906

--HG--
extra : moz-landing-system : lando
2019-10-21 13:47:50 +00:00
Nicolas Chevobbe 02cfc079ff Bug 1588999 - Rename ObjectClient to ObjectFront. r=ochameau.
The object-client.js file is now a proper protocol.js front,
but is still named after a client.
This is confusing, so we rename and move the file next to other
fronts, and update all consumers to the new terminology.

Differential Revision: https://phabricator.services.mozilla.com/D49878

--HG--
rename : devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/object-client.js => devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/object-front.js
rename : devtools/shared/client/object-client.js => devtools/shared/fronts/object.js
extra : moz-landing-system : lando
2019-10-21 12:07:10 +00:00
Marco Vega a22744ceae Bug 1587602 - Source footer - the loading icon shown when pretty-printing a source is static and misaligned. r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D48939

--HG--
extra : moz-landing-system : lando
2019-10-21 11:29:25 +00:00
Belén Albeza b29a6fde04 Bug 1579795 - Part 3: Test the fetchManifest action separately r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49596

--HG--
extra : moz-landing-system : lando
2019-10-21 10:51:30 +00:00
Belén Albeza ac8c98c2d3 Bug 1579795 - Part 2: Reorganize jest tests folder structure r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49595

--HG--
rename : devtools/client/application/test/components/.eslintrc.js => devtools/client/application/test/node/.eslintrc.js
rename : devtools/client/application/test/components/babel.config.js => devtools/client/application/test/node/babel.config.js
rename : devtools/client/application/test/components/__snapshots__/components_application_panel-App.test.js.snap => devtools/client/application/test/node/components/__snapshots__/components_application_panel-App.test.js.snap
rename : devtools/client/application/test/components/components_application_panel-App.test.js => devtools/client/application/test/node/components/components_application_panel-App.test.js
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap
rename : devtools/client/application/test/components/manifest/components_application_panel-Manifest.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-Manifest.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestColorItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestColorItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestEmpty.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestEmpty.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIconItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIconItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIssue.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssue.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIssueList.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssueList.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestJsonLink.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestJsonLink.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestLoader.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestLoader.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestPage.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestPage.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestSection.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestSection.test.js
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap
rename : devtools/client/application/test/components/routing/components_application_panel-PageSwitcher.test.js => devtools/client/application/test/node/components/routing/components_application_panel-PageSwitcher.test.js
rename : devtools/client/application/test/components/routing/components_application_panel-Sidebar.test.js => devtools/client/application/test/node/components/routing/components_application_panel-Sidebar.test.js
rename : devtools/client/application/test/components/routing/components_application_panel-SidebarItem.test.js => devtools/client/application/test/node/components/routing/components_application_panel-SidebarItem.test.js
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkerList.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerList.test.js
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkerListEmpty.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerListEmpty.test.js
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkersPage.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkersPage.test.js
rename : devtools/client/application/test/components/fixtures/Chrome.js => devtools/client/application/test/node/fixtures/Chrome.js
rename : devtools/client/application/test/components/fixtures/Services.js => devtools/client/application/test/node/fixtures/Services.js
rename : devtools/client/application/test/components/fixtures/data/constants.js => devtools/client/application/test/node/fixtures/data/constants.js
rename : devtools/client/application/test/components/fixtures/fluent-l10n.js => devtools/client/application/test/node/fixtures/fluent-l10n.js
rename : devtools/client/application/test/components/fixtures/stub.js => devtools/client/application/test/node/fixtures/stub.js
rename : devtools/client/application/test/components/fixtures/unicode-url.js => devtools/client/application/test/node/fixtures/unicode-url.js
rename : devtools/client/application/test/components/helpers/helpers.js => devtools/client/application/test/node/helpers.js
rename : devtools/client/application/test/components/jest.config.js => devtools/client/application/test/node/jest.config.js
rename : devtools/client/application/test/components/package.json => devtools/client/application/test/node/package.json
rename : devtools/client/application/test/components/setup.js => devtools/client/application/test/node/setup.js
rename : devtools/client/application/test/components/yarn.lock => devtools/client/application/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-21 10:50:28 +00:00
Belén Albeza 0197fabfc9 Bug 1579795 - Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D49594

--HG--
extra : moz-landing-system : lando
2019-10-21 10:47:40 +00:00
Nicolas Chevobbe 5c94cfcc44 Bug 1576568 - Enable editor mode everywhere. r=Honza.
The focus previous element function needed to be modified
in order to not find non-visible elements.

Differential Revision: https://phabricator.services.mozilla.com/D49729

--HG--
extra : moz-landing-system : lando
2019-10-21 08:39:42 +00:00
Nicolas Chevobbe 517642a768 Bug 1589867 - Fix browser_parsable_css.js failure on beta. r=Honza.
The rotate property is only enabled on Nightly.
For beta, we need to use transform: rotate instead.

Differential Revision: https://phabricator.services.mozilla.com/D49847

--HG--
extra : moz-landing-system : lando
2019-10-21 08:31:52 +00:00
Jason Laster 2afc34bfe4 Bug 1581249 - The timeline should show breakpoint hits. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D49804

--HG--
extra : moz-landing-system : lando
2019-10-18 22:20:09 +00:00
Gabriel Luong 107b49e65e Bug 1568860 - Part 3: Use the contextual WalkerFront in the fonts view. r=ochameau
Depends on D49637

Differential Revision: https://phabricator.services.mozilla.com/D49639

--HG--
extra : moz-landing-system : lando
2019-10-18 08:43:09 +00:00
Gabriel Luong a92d6c2648 Bug 1568860 - Part 2: Make getAllFonts fission compatible. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D49637

--HG--
extra : moz-landing-system : lando
2019-10-18 19:30:03 +00:00
Julian Descottes feec1c039b Bug 1589617 - Stop catching search shortcuts from other panels in the Inspector r=gl,fvsch
Using cmd+F in the Console/Debugger after using the inspector will be caught by inspector code and will not show the panel's search ui.

Differential Revision: https://phabricator.services.mozilla.com/D49756

--HG--
extra : moz-landing-system : lando
2019-10-18 19:02:18 +00:00
Gabriel Luong 324fdd5ca6 Bug 1588728 - Add a check for this._highlightedNodeFront in _hideBoxModel. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D49632

--HG--
extra : moz-landing-system : lando
2019-10-18 18:43:49 +00:00
Gabriel Luong 7a5b8a6a4f Bug 1583654 - Use the subgridToParentMap to check that the node was previously a subgrid. r=pbro
The previous condition didn't fully check that the grid node was previously a subgrid.
So, we run into a scenario where we refresh the page and a "display-change" event is hit
after a new root is loaded, and the grid highlighter is restored and hidden because
the check will pass as long as the node is a grid container.

Differential Revision: https://phabricator.services.mozilla.com/D49659

--HG--
extra : moz-landing-system : lando
2019-10-18 17:57:09 +00:00
Alexandre Poirot 6bdf5b1a87 Bug 1496025 - Remove Promises actor r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D49636

--HG--
extra : moz-landing-system : lando
2019-10-18 15:31:32 +00:00
Oana Pop Rus 6bb6defd96 Backed out 3 changesets (bug 1579795) for causing devtools node failures. on a CLOSED TREE
Backed out changeset 141f065f3788 (bug 1579795)
Backed out changeset eb0eaf505108 (bug 1579795)
Backed out changeset 193f93f381cd (bug 1579795)

--HG--
rename : devtools/client/application/test/node/.eslintrc.js => devtools/client/application/test/components/.eslintrc.js
rename : devtools/client/application/test/node/components/__snapshots__/components_application_panel-App.test.js.snap => devtools/client/application/test/components/__snapshots__/components_application_panel-App.test.js.snap
rename : devtools/client/application/test/node/babel.config.js => devtools/client/application/test/components/babel.config.js
rename : devtools/client/application/test/node/components/components_application_panel-App.test.js => devtools/client/application/test/components/components_application_panel-App.test.js
rename : devtools/client/application/test/node/fixtures/Chrome.js => devtools/client/application/test/components/fixtures/Chrome.js
rename : devtools/client/application/test/node/fixtures/Services.js => devtools/client/application/test/components/fixtures/Services.js
rename : devtools/client/application/test/node/fixtures/data/constants.js => devtools/client/application/test/components/fixtures/data/constants.js
rename : devtools/client/application/test/node/fixtures/fluent-l10n.js => devtools/client/application/test/components/fixtures/fluent-l10n.js
rename : devtools/client/application/test/node/fixtures/stub.js => devtools/client/application/test/components/fixtures/stub.js
rename : devtools/client/application/test/node/fixtures/unicode-url.js => devtools/client/application/test/components/fixtures/unicode-url.js
rename : devtools/client/application/test/node/helpers.js => devtools/client/application/test/components/helpers/helpers.js
rename : devtools/client/application/test/node/jest.config.js => devtools/client/application/test/components/jest.config.js
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap
rename : devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap
rename : devtools/client/application/test/node/components/manifest/components_application_panel-Manifest.test.js => devtools/client/application/test/components/manifest/components_application_panel-Manifest.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestColorItem.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestColorItem.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestEmpty.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestEmpty.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIconItem.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestIconItem.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssue.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestIssue.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssueList.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestIssueList.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestItem.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestItem.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestJsonLink.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestJsonLink.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestLoader.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestLoader.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestPage.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestPage.test.js
rename : devtools/client/application/test/node/components/manifest/components_application_panel-ManifestSection.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestSection.test.js
rename : devtools/client/application/test/node/package.json => devtools/client/application/test/components/package.json
rename : devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap => devtools/client/application/test/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap
rename : devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap => devtools/client/application/test/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap
rename : devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap => devtools/client/application/test/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap
rename : devtools/client/application/test/node/components/routing/components_application_panel-PageSwitcher.test.js => devtools/client/application/test/components/routing/components_application_panel-PageSwitcher.test.js
rename : devtools/client/application/test/node/components/routing/components_application_panel-Sidebar.test.js => devtools/client/application/test/components/routing/components_application_panel-Sidebar.test.js
rename : devtools/client/application/test/node/components/routing/components_application_panel-SidebarItem.test.js => devtools/client/application/test/components/routing/components_application_panel-SidebarItem.test.js
rename : devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap => devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap
rename : devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap => devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap
rename : devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap => devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap
rename : devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerList.test.js => devtools/client/application/test/components/service-workers/components_application_panel-WorkerList.test.js
rename : devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerListEmpty.test.js => devtools/client/application/test/components/service-workers/components_application_panel-WorkerListEmpty.test.js
rename : devtools/client/application/test/node/components/service-workers/components_application_panel-WorkersPage.test.js => devtools/client/application/test/components/service-workers/components_application_panel-WorkersPage.test.js
rename : devtools/client/application/test/node/setup.js => devtools/client/application/test/components/setup.js
rename : devtools/client/application/test/node/yarn.lock => devtools/client/application/test/components/yarn.lock
2019-10-18 18:38:49 +03:00
Julian Descottes e0b8367100 Bug 1589597 - Remove outdated header in aboutdebugging jest test r=ladybenko
Depends on D49711

I was a bit confused but we just forgot to remove this in Bug 1548465

Differential Revision: https://phabricator.services.mozilla.com/D49716

--HG--
extra : moz-landing-system : lando
2019-10-18 15:12:10 +00:00
Julian Descottes 60510cfe3b Bug 1589597 - Rename compatibility jest test folder to node r=ladybenko
Depends on D49709
Following the naming convention decided in RFC Bug 1564431

Differential Revision: https://phabricator.services.mozilla.com/D49710

--HG--
rename : devtools/client/inspector/compatibility/test/components/.eslintrc.js => devtools/client/inspector/compatibility/test/node/.eslintrc.js
rename : devtools/client/inspector/compatibility/test/components/babel.config.js => devtools/client/inspector/compatibility/test/node/babel.config.js
rename : devtools/client/inspector/compatibility/test/components/__snapshots__/components-compatibility-IssueItem.test.js.snap => devtools/client/inspector/compatibility/test/node/components/__snapshots__/components-compatibility-IssueItem.test.js.snap
rename : devtools/client/inspector/compatibility/test/components/__snapshots__/components-compatibility-IssueList.test.js.snap => devtools/client/inspector/compatibility/test/node/components/__snapshots__/components-compatibility-IssueList.test.js.snap
rename : devtools/client/inspector/compatibility/test/components/components-compatibility-IssueItem.test.js => devtools/client/inspector/compatibility/test/node/components/components-compatibility-IssueItem.test.js
rename : devtools/client/inspector/compatibility/test/components/components-compatibility-IssueList.test.js => devtools/client/inspector/compatibility/test/node/components/components-compatibility-IssueList.test.js
rename : devtools/client/inspector/compatibility/test/components/jest.config.js => devtools/client/inspector/compatibility/test/node/jest.config.js
rename : devtools/client/inspector/compatibility/test/components/package.json => devtools/client/inspector/compatibility/test/node/package.json
rename : devtools/client/inspector/compatibility/test/components/setup.js => devtools/client/inspector/compatibility/test/node/setup.js
rename : devtools/client/inspector/compatibility/test/components/yarn.lock => devtools/client/inspector/compatibility/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 14:05:12 +00:00
Julian Descottes 473f4a1c2f Bug 1589597 - Rename framework jest test folder to node r=ladybenko
Depends on D49708
Following the naming convention decided in RFC Bug 1564431

Differential Revision: https://phabricator.services.mozilla.com/D49709

--HG--
rename : devtools/client/framework/test/jest/.eslintrc.js => devtools/client/framework/test/node/.eslintrc.js
rename : devtools/client/framework/test/jest/README.md => devtools/client/framework/test/node/README.md
rename : devtools/client/framework/test/jest/components/__snapshots__/debug-target-info.test.js.snap => devtools/client/framework/test/node/components/__snapshots__/debug-target-info.test.js.snap
rename : devtools/client/framework/test/jest/components/debug-target-info.test.js => devtools/client/framework/test/node/components/debug-target-info.test.js
rename : devtools/client/framework/test/jest/jest.config.js => devtools/client/framework/test/node/jest.config.js
rename : devtools/client/framework/test/jest/package.json => devtools/client/framework/test/node/package.json
rename : devtools/client/framework/test/jest/yarn.lock => devtools/client/framework/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 14:01:55 +00:00
Julian Descottes 0066803de3 Bug 1589597 - Rename accessibility jest test folder to node r=ladybenko
Depends on D49707
Following the naming convention decided in RFC Bug 1564431

Differential Revision: https://phabricator.services.mozilla.com/D49708

--HG--
rename : devtools/client/accessibility/test/jest/.eslintrc.js => devtools/client/accessibility/test/node/.eslintrc.js
rename : devtools/client/accessibility/test/jest/README.md => devtools/client/accessibility/test/node/README.md
rename : devtools/client/accessibility/test/jest/babel.config.js => devtools/client/accessibility/test/node/babel.config.js
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-prefs.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-prefs.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-row-value.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-row-value.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-tree-filter.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-tree-filter.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-controller.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-controller.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-filter.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-filter.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-progress-overlay.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-progress-overlay.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/badges.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/badges.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/contrast-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/contrast-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/keyboard-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/keyboard-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/keyboard-check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/keyboard-check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/text-label-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/text-label-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/text-label-check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/text-label-check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/accessibility-prefs.test.js => devtools/client/accessibility/test/node/components/accessibility-prefs.test.js
rename : devtools/client/accessibility/test/jest/components/accessibility-row-value.test.js => devtools/client/accessibility/test/node/components/accessibility-row-value.test.js
rename : devtools/client/accessibility/test/jest/components/accessibility-tree-filter.test.js => devtools/client/accessibility/test/node/components/accessibility-tree-filter.test.js
rename : devtools/client/accessibility/test/jest/components/audit-controller.test.js => devtools/client/accessibility/test/node/components/audit-controller.test.js
rename : devtools/client/accessibility/test/jest/components/audit-filter.test.js => devtools/client/accessibility/test/node/components/audit-filter.test.js
rename : devtools/client/accessibility/test/jest/components/audit-progress-overlay.test.js => devtools/client/accessibility/test/node/components/audit-progress-overlay.test.js
rename : devtools/client/accessibility/test/jest/components/badge.test.js => devtools/client/accessibility/test/node/components/badge.test.js
rename : devtools/client/accessibility/test/jest/components/badges.test.js => devtools/client/accessibility/test/node/components/badges.test.js
rename : devtools/client/accessibility/test/jest/components/check.test.js => devtools/client/accessibility/test/node/components/check.test.js
rename : devtools/client/accessibility/test/jest/components/contrast-badge.test.js => devtools/client/accessibility/test/node/components/contrast-badge.test.js
rename : devtools/client/accessibility/test/jest/components/keyboard-badge.test.js => devtools/client/accessibility/test/node/components/keyboard-badge.test.js
rename : devtools/client/accessibility/test/jest/components/keyboard-check.test.js => devtools/client/accessibility/test/node/components/keyboard-check.test.js
rename : devtools/client/accessibility/test/jest/components/text-label-badge.test.js => devtools/client/accessibility/test/node/components/text-label-badge.test.js
rename : devtools/client/accessibility/test/jest/components/text-label-check.test.js => devtools/client/accessibility/test/node/components/text-label-check.test.js
rename : devtools/client/accessibility/test/jest/fixtures/Services.js => devtools/client/accessibility/test/node/fixtures/Services.js
rename : devtools/client/accessibility/test/jest/fixtures/devtools-utils.js => devtools/client/accessibility/test/node/fixtures/devtools-utils.js
rename : devtools/client/accessibility/test/jest/fixtures/l10n.js => devtools/client/accessibility/test/node/fixtures/l10n.js
rename : devtools/client/accessibility/test/jest/fixtures/plural-form.js => devtools/client/accessibility/test/node/fixtures/plural-form.js
rename : devtools/client/accessibility/test/jest/fixtures/stub.js => devtools/client/accessibility/test/node/fixtures/stub.js
rename : devtools/client/accessibility/test/jest/helpers.js => devtools/client/accessibility/test/node/helpers.js
rename : devtools/client/accessibility/test/jest/jest.config.js => devtools/client/accessibility/test/node/jest.config.js
rename : devtools/client/accessibility/test/jest/package.json => devtools/client/accessibility/test/node/package.json
rename : devtools/client/accessibility/test/jest/setup.js => devtools/client/accessibility/test/node/setup.js
rename : devtools/client/accessibility/test/jest/yarn.lock => devtools/client/accessibility/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 13:56:15 +00:00
Julian Descottes 64a2f38fd4 Bug 1589597 - Rename aboutdebugging jest test folder to node r=ladybenko
Following the naming convention decided in RFC Bug 1564431

Differential Revision: https://phabricator.services.mozilla.com/D49707

--HG--
rename : devtools/client/aboutdebugging/test/jest/.eslintrc.js => devtools/client/aboutdebugging/test/node/.eslintrc.js
rename : devtools/client/aboutdebugging/test/jest/README.md => devtools/client/aboutdebugging/test/node/README.md
rename : devtools/client/aboutdebugging/test/jest/babel.config.js => devtools/client/aboutdebugging/test/node/babel.config.js
rename : devtools/client/aboutdebugging/test/jest/components/__snapshots__/shared-message.test.js.snap => devtools/client/aboutdebugging/test/node/components/__snapshots__/shared-message.test.js.snap
rename : devtools/client/aboutdebugging/test/jest/components/shared-message.test.js => devtools/client/aboutdebugging/test/node/components/shared-message.test.js
rename : devtools/client/aboutdebugging/test/jest/jest.config.js => devtools/client/aboutdebugging/test/node/jest.config.js
rename : devtools/client/aboutdebugging/test/jest/package.json => devtools/client/aboutdebugging/test/node/package.json
rename : devtools/client/aboutdebugging/test/jest/setup.js => devtools/client/aboutdebugging/test/node/setup.js
rename : devtools/client/aboutdebugging/test/jest/yarn.lock => devtools/client/aboutdebugging/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 13:42:50 +00:00
Belén Albeza 04e8ccaf1c Bug 1579795 - Part 3: Test the fetchManifest action separately r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49596

--HG--
extra : moz-landing-system : lando
2019-10-18 13:42:48 +00:00
Belén Albeza de84d86c5f Bug 1579795 - Part 2: Reorganize jest tests folder structure r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49595

--HG--
rename : devtools/client/application/test/components/.eslintrc.js => devtools/client/application/test/node/.eslintrc.js
rename : devtools/client/application/test/components/babel.config.js => devtools/client/application/test/node/babel.config.js
rename : devtools/client/application/test/components/__snapshots__/components_application_panel-App.test.js.snap => devtools/client/application/test/node/components/__snapshots__/components_application_panel-App.test.js.snap
rename : devtools/client/application/test/components/components_application_panel-App.test.js => devtools/client/application/test/node/components/components_application_panel-App.test.js
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestColorItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIconItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssue.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestIssueList.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestItem.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestJsonLink.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestLoader.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestPage.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap => devtools/client/application/test/node/components/manifest/__snapshots__/components_application_panel-ManifestSection.test.js.snap
rename : devtools/client/application/test/components/manifest/components_application_panel-Manifest.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-Manifest.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestColorItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestColorItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestEmpty.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestEmpty.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIconItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIconItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIssue.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssue.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestIssueList.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestIssueList.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestItem.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestItem.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestJsonLink.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestJsonLink.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestLoader.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestLoader.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestPage.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestPage.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestSection.test.js => devtools/client/application/test/node/components/manifest/components_application_panel-ManifestSection.test.js
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-Sidebar.test.js.snap
rename : devtools/client/application/test/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap => devtools/client/application/test/node/components/routing/__snapshots__/components_application_panel-SidebarItem.test.js.snap
rename : devtools/client/application/test/components/routing/components_application_panel-PageSwitcher.test.js => devtools/client/application/test/node/components/routing/components_application_panel-PageSwitcher.test.js
rename : devtools/client/application/test/components/routing/components_application_panel-Sidebar.test.js => devtools/client/application/test/node/components/routing/components_application_panel-Sidebar.test.js
rename : devtools/client/application/test/components/routing/components_application_panel-SidebarItem.test.js => devtools/client/application/test/node/components/routing/components_application_panel-SidebarItem.test.js
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerList.test.js.snap
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkerListEmpty.test.js.snap
rename : devtools/client/application/test/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap => devtools/client/application/test/node/components/service-workers/__snapshots__/components_application_panel-WorkersPage.test.js.snap
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkerList.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerList.test.js
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkerListEmpty.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkerListEmpty.test.js
rename : devtools/client/application/test/components/service-workers/components_application_panel-WorkersPage.test.js => devtools/client/application/test/node/components/service-workers/components_application_panel-WorkersPage.test.js
rename : devtools/client/application/test/components/fixtures/Chrome.js => devtools/client/application/test/node/fixtures/Chrome.js
rename : devtools/client/application/test/components/fixtures/Services.js => devtools/client/application/test/node/fixtures/Services.js
rename : devtools/client/application/test/components/fixtures/data/constants.js => devtools/client/application/test/node/fixtures/data/constants.js
rename : devtools/client/application/test/components/fixtures/fluent-l10n.js => devtools/client/application/test/node/fixtures/fluent-l10n.js
rename : devtools/client/application/test/components/fixtures/stub.js => devtools/client/application/test/node/fixtures/stub.js
rename : devtools/client/application/test/components/fixtures/unicode-url.js => devtools/client/application/test/node/fixtures/unicode-url.js
rename : devtools/client/application/test/components/helpers/helpers.js => devtools/client/application/test/node/helpers.js
rename : devtools/client/application/test/components/jest.config.js => devtools/client/application/test/node/jest.config.js
rename : devtools/client/application/test/components/package.json => devtools/client/application/test/node/package.json
rename : devtools/client/application/test/components/setup.js => devtools/client/application/test/node/setup.js
rename : devtools/client/application/test/components/yarn.lock => devtools/client/application/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 15:08:49 +00:00
Belén Albeza 2aa79ee974 Bug 1579795 - Part 1: Improve error handling when fetching the manifest r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D49594

--HG--
extra : moz-landing-system : lando
2019-10-18 13:42:32 +00:00
Nicolas Chevobbe 7008343fe7 Bug 1589592 - Fix GridElementWidthResizer in RTL languages. r=Honza.
When starting to resize, we store the direction of the
controlled element in the state.
When resizing, we check the current element direction
to set the appropriate width to the controlled element.
A test is added to ensure the resizer works as expected
in RTL languages elements.

Differential Revision: https://phabricator.services.mozilla.com/D49719

--HG--
rename : devtools/client/shared/components/test/mochitest/test_GridElementWidthResizer.html => devtools/client/shared/components/test/mochitest/test_GridElementWidthResizer_RTL.html
extra : moz-landing-system : lando
2019-10-18 13:05:51 +00:00
Nicolas Chevobbe 959807c018 Bug 1589592 - Fix console editor Run button icon in RTL. r=Honza.
Since we want the button to be placed on the right side
in RTL languages and we don't have logical properties
on background-position yet, we display the icon in
a :before pseudo element which will adapt for both LTR
and RTL languages. The icon is then mirrored in RTL.

Differential Revision: https://phabricator.services.mozilla.com/D49718

--HG--
extra : moz-landing-system : lando
2019-10-18 12:46:46 +00:00
Nicolas Chevobbe 92088e98e0 Bug 1589592 - Fix Console Editor styling in RTL languages. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D49717

--HG--
extra : moz-landing-system : lando
2019-10-18 12:46:58 +00:00
Nicolas Chevobbe eae5d8a518 Bug 1577896 - Fix GridElementResizer on overflowing container. r=fvsch.
We remove the pseudo elements we were using to draw the borders and
put them on the grid elements instead.
We make the GridElementResizer 6px and translate it so there's
handle on "both sides" of the splitter.

Differential Revision: https://phabricator.services.mozilla.com/D45302

--HG--
extra : moz-landing-system : lando
2019-10-18 10:17:48 +00:00
Nicolas Chevobbe 431636d12a Bug 1577783 - Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro,rcaliman.
We retrieve the right NodeFront from a given grip, which we
can then tell the inspector panel to select.

Differential Revision: https://phabricator.services.mozilla.com/D48810

--HG--
extra : moz-landing-system : lando
2019-10-18 09:07:42 +00:00
Nicolas Chevobbe ca1e2e0939 Bug 1587701 - Use toolbox's getNodeFrontFromNodeGrip in highlight method. r=pbro.
This allow us to retrieve the appropriate nodeFront from a grip,
and thus the right highlighterFront to highlight a given element.
We also need to cache the highlighter front used for the current
highlight, as we need to use the same front for unhighlighting,
and this saves us a few server round-trip to get the right front.

Differential Revision: https://phabricator.services.mozilla.com/D48809

--HG--
extra : moz-landing-system : lando
2019-10-18 09:07:25 +00:00
jaril 696cf3b52a Bug 1588997 - Convert ObjectClient to protocol.js front. r=nchevobbe.
- Converted the ObjectClient into an protocoljs Front
- Converted the SymbolIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the PropertyIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the EnvironmentClient into a protocoljs Front and moved it to devtools/shared/fronts
- Modified calls to `DebuggerClient.release()` so that it tries to call the ObjectFront's release method first, and falls back on `DebuggerClient.release()` if there's no object front
- Changed reps so that it instantiates only one ObjectClient per grip
- Changed tests so that they expect what the Front's request method resolves to where applicable (i.e. ObjectFront.allocationStack resolves to allocationStack, not a packet object with an allocationStack property)
- Changed callbacks provided to ObjectClient methods to be chained to the ObjectFront methods (e.g. ObjectClient.getScope(callback) changed to ObjectFront.getScope().callback())
- Changed tests to use async/await (test_framebindings-x.js, test_functiongrips-x.js, test_objectgrips-x.js)
- Changed tests to expect protocoljs to throw an error string instead of an error object (test_objectgrips-fn-apply-03.js, test_threadlifetime-02.js, test_pauselifetime-03.js)

Differential Revision: https://phabricator.services.mozilla.com/D48182

--HG--
rename : devtools/shared/client/environment-client.js => devtools/shared/fronts/environment.js
rename : devtools/shared/client/property-iterator-client.js => devtools/shared/fronts/property-iterator.js
rename : devtools/shared/client/symbol-iterator-client.js => devtools/shared/fronts/symbol-iterator.js
extra : moz-landing-system : lando
2019-10-17 16:06:25 +00:00
Daniel Varga 8fdca46bc7 Backed out changeset 2923afce519a (bug 1557447) for browser chrome failure at tools/profiler/tests/browser/browser_test_feature_preferencereads.js. On a CLOSED TREE 2019-10-18 07:54:09 +03:00
Jim Porter 80bfcd6e57 Bug 1557447 - Profiler support for IPC information; r=nika
This adds the ability to add profile markers for both the sender and recipient
sides of IPC messages. These can then be correlated with one another in the
profile visualization. For the UI component of this patch, see
<https://github.com/firefox-devtools/profiler/pull/2172>.

Differential Revision: https://phabricator.services.mozilla.com/D42226

--HG--
extra : moz-landing-system : lando
2019-10-18 02:56:02 +00:00
Daisuke Akatsuka 693696fb70 Bug 1588962: Add a test whether reflect the rule change. r=rcaliman
Depends on D49534

Differential Revision: https://phabricator.services.mozilla.com/D49535

--HG--
extra : moz-landing-system : lando
2019-10-18 01:34:49 +00:00
Daisuke Akatsuka 23c975fc2b Bug 1588962: Reflect the changes on the rule view. r=rcaliman
Depends on D49520

Differential Revision: https://phabricator.services.mozilla.com/D49534

--HG--
extra : moz-landing-system : lando
2019-10-18 01:35:14 +00:00
Dorel Luca efd52379da Backed out changeset cd4dc0ae3364 (bug 1557447) for Browser-chrome failures in build/src/obj-firefox/dist/include/mozilla/BlocksRingBuffer.h 2019-10-18 03:59:06 +03:00
Chris Muldoon 4ac0b74222 Bug 1577673 - Continue to Here does not pause. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D48178

--HG--
extra : moz-landing-system : lando
2019-10-17 23:53:36 +00:00
Jim Porter 641b95fb72 Bug 1557447 - Profiler support for IPC information; r=nika
This adds the ability to add profile markers for both the sender and recipient
sides of IPC messages. These can then be correlated with one another in the
profile visualization. For the UI component of this patch, see
<https://github.com/firefox-devtools/profiler/pull/2172>.

Differential Revision: https://phabricator.services.mozilla.com/D42226

--HG--
extra : moz-landing-system : lando
2019-10-17 23:39:42 +00:00
David Walsh 215bc3accf Bug 1589272 - Enforce minimum width for debugger's sidebar panels r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49522

--HG--
extra : moz-landing-system : lando
2019-10-17 20:17:45 +00:00
Michael Ratcliffe 620e2c9464 Bug 1472200 - Only the Rules panel is displayed if enabling 3-Pane Inspector while the right Inspector section is at minimum width r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49270

--HG--
extra : moz-landing-system : lando
2019-10-16 19:08:46 +00:00
Sorin Davidoi fd9d2baa6d Bug 1588637 - perf: Reduce memory allocation, avoid regular expressions and layout trashing r=davidwalsh
Apply the following optimizations:
 - Don't use regular expressions where they can be avoided
 - Reduce unnecessary memory allocations (e.g. avoid doing a map and a filter by writing the code in an imperative fashion)
 - Reduce layout trashing by using `rAF` and `setTimeout`
 - Perform cheaper checks first in conditional statements

See commit messages for more details.

Differential Revision: https://phabricator.services.mozilla.com/D49214

--HG--
extra : moz-landing-system : lando
2019-10-16 18:44:13 +00:00
David Walsh 25f15897bf Bug 1589269 - Enforce minimum width for search and blocking panels r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49517

--HG--
extra : moz-landing-system : lando
2019-10-17 09:53:35 +00:00
David Walsh 347d07cd09 Bug 1589160 - Update tab language for request blocking r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D49465

--HG--
extra : moz-landing-system : lando
2019-10-17 10:04:36 +00:00
David Walsh 0843a344a5 Bug 1583042 - Change devtools debugger shortcut r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D47502

--HG--
extra : moz-landing-system : lando
2019-10-17 07:29:45 +00:00
Nicolas Chevobbe 7ef8a79951 Bug 1589001 - Rename (web)consoleClient variables and properties to webConsoleFront. r=Honza.
The webconsole actor now has an associated front for some
time, but the naming of variables and properties didn't
reflect that (most weren't updated and were still calling
it a client).
This patch tries to rename all those variables so it's more
obvious we're dealing with an actual front.

Differential Revision: https://phabricator.services.mozilla.com/D49401

--HG--
extra : moz-landing-system : lando
2019-10-17 10:16:46 +00:00
Bogdan Tara 7e9efc5de3 Backed out changeset 29bc3ebe8b4e (bug 1588997) for browser_ext_devtools_panels_elements_sidebar.js && browser_ext_find.js failures CLOSED TREE
--HG--
rename : devtools/shared/fronts/environment.js => devtools/shared/client/environment-client.js
rename : devtools/shared/fronts/property-iterator.js => devtools/shared/client/property-iterator-client.js
rename : devtools/shared/fronts/symbol-iterator.js => devtools/shared/client/symbol-iterator-client.js
2019-10-17 10:51:19 +03:00
jaril e1c2cd6db5 Bug 1588997 - Convert ObjectClient to protocol.js front. r=nchevobbe.
- Converted the ObjectClient into an protocoljs Front
- Converted the SymbolIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the PropertyIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the EnvironmentClient into a protocoljs Front and moved it to devtools/shared/fronts
- Modified calls to `DebuggerClient.release()` so that it tries to call the ObjectFront's release method first, and falls back on `DebuggerClient.release()` if there's no object front
- Changed reps so that it instantiates only one ObjectClient per grip
- Changed tests so that they expect what the Front's request method resolves to where applicable (i.e. ObjectFront.allocationStack resolves to allocationStack, not a packet object with an allocationStack property)
- Changed callbacks provided to ObjectClient methods to be chained to the ObjectFront methods (e.g. ObjectClient.getScope(callback) changed to ObjectFront.getScope().callback())
- Changed tests to use async/await (test_framebindings-x.js, test_functiongrips-x.js, test_objectgrips-x.js)
- Changed tests to expect protocoljs to throw an error string instead of an error object (test_objectgrips-fn-apply-03.js, test_threadlifetime-02.js, test_pauselifetime-03.js)

Differential Revision: https://phabricator.services.mozilla.com/D48182

--HG--
rename : devtools/shared/client/environment-client.js => devtools/shared/fronts/environment.js
rename : devtools/shared/client/property-iterator-client.js => devtools/shared/fronts/property-iterator.js
rename : devtools/shared/client/symbol-iterator-client.js => devtools/shared/fronts/symbol-iterator.js
extra : moz-landing-system : lando
2019-10-16 17:09:35 +00:00
David Walsh 34cd114993 Bug 1576145 - Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D45248

--HG--
extra : moz-landing-system : lando
2019-10-17 02:04:45 +00:00
Daisuke Akatsuka 1cfc17bb27 Bug 1588961: Add a test for the event that the selected node is changed. r=rcaliman
Depends on D49377

Differential Revision: https://phabricator.services.mozilla.com/D49378

--HG--
extra : moz-landing-system : lando
2019-10-17 01:30:56 +00:00
Daisuke Akatsuka 0e91f94568 Bug 1588961: Update the content when the selected node is changed. r=rcaliman
Depends on D49256

Differential Revision: https://phabricator.services.mozilla.com/D49377

--HG--
extra : moz-landing-system : lando
2019-10-16 14:34:26 +00:00
Miriam b43fd031d9 Bug 1582304: Ensure you can add a watchpoint to property within a bucket, prototype, or default properties.
Differential Revision: https://phabricator.services.mozilla.com/D49496

--HG--
extra : moz-landing-system : lando
2019-10-17 00:45:31 +00:00
Logan Smyth 6e3be305df Bug 1581530 - Re-apply usage of .enable/.disable accidentally reverted in Bug 997119. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49382

--HG--
extra : moz-landing-system : lando
2019-10-16 18:13:41 +00:00
zhaogang bd399a64e2 Bug 1578752 - Pass event listener column to debugger for more accurate pretty print. r=davidwalsh
Now the event listener tooltip url in the inspector will have an additional column part for generated file, which will be parsed as location.column to debugger, and the debugger pretty print can correctly create and use source map. It's the same bug as [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1045237 | Bug 1045237]], [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1134798 | Bug 1134798 ]], and [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1175911 | Bug 1175911 ]]

Differential Revision: https://phabricator.services.mozilla.com/D48812

--HG--
extra : moz-landing-system : lando
2019-10-16 23:03:15 +00:00
Florens Verschelde 995baa5ff2 Bug 1588796 - New search-in-file highlight style in Debugger and Style Editor; r=davidwalsh,gl
Differential Revision: https://phabricator.services.mozilla.com/D49439

--HG--
extra : moz-landing-system : lando
2019-10-16 22:12:30 +00:00
Ciure Andrei e2d920bc53 Backed out changeset 48816580680d (bug 1583042) for causing browser_ext_commands_onCommand.js to perma fail CLOSED TREE 2019-10-17 01:36:27 +03:00
David Walsh 6ded71ab21 Bug 1583042 - Change devtools debugger shortcut r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D47502

--HG--
extra : moz-landing-system : lando
2019-10-16 17:18:18 +00:00
jaril 7628563796 Bug 1504025 - Fixed replay line indicator to display properly r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49327

--HG--
extra : moz-landing-system : lando
2019-10-16 19:06:11 +00:00
Gabriel Luong 307fdf196f Bug 1568126 - Part 3: Use the contextual WalkerFront in the markup view event handlers. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D49346

--HG--
extra : moz-landing-system : lando
2019-10-16 18:19:02 +00:00
Cosmin Sabou 1e37dfb648 Backed out changeset 7bcfcf9c5a8a (bug 1583042) for browser chrome failures on browser_ext_commands_onCommand.js CLOSED TREE 2019-10-16 19:21:42 +03:00
David Walsh 047a6a5f5c Bug 1583042 - Change devtools debugger shortcut r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D47502

--HG--
extra : moz-landing-system : lando
2019-10-16 15:07:25 +00:00
Mellina Y. 3d366d4c4a Bug 1582658 - Enable ESLint for all of devtools/client/storage/test/. r=miker
Differential Revision: https://phabricator.services.mozilla.com/D47679

--HG--
extra : moz-landing-system : lando
2019-10-16 13:50:08 +00:00
alessandro 378c81687d Bug 1541411 - Enforce Title Case on labels across panels. r=fvsch
Enforced Title Case on all the labels listed in the bug description for all panels except the Debugger.

Differential Revision: https://phabricator.services.mozilla.com/D49109

--HG--
extra : moz-landing-system : lando
2019-10-16 11:15:00 +00:00
Nicolas Chevobbe 3469d5121d Bug 1587839 - Pass the sourceId to sourcemap service subscribe callback. r=loganfsmyth.
The sourceId is then used in the various places where we call the sourcemap service.
A test is added in the console to make sure that we do navigate to the mapped
location in the debugger.

Differential Revision: https://phabricator.services.mozilla.com/D49103

--HG--
extra : moz-landing-system : lando
2019-10-16 00:16:55 +00:00
Daisuke Akatsuka 38f4dd72f0 Bug 1587690: Add jest tests for components. r=ladybenko
Depends on D48950

Differential Revision: https://phabricator.services.mozilla.com/D49256

--HG--
extra : moz-landing-system : lando
2019-10-16 01:32:48 +00:00
Daisuke Akatsuka 4d4cbd6fa5 Bug 1587690: Add a test for CSS property issues. r=ladybenko
Depends on D48949

Differential Revision: https://phabricator.services.mozilla.com/D48950

--HG--
rename : devtools/client/inspector/compatibility/test/.eslintrc.js => devtools/client/inspector/compatibility/test/browser/.eslintrc.js
extra : moz-landing-system : lando
2019-10-15 14:02:34 +00:00
Daisuke Akatsuka b09ad6a127 Bug 1587690: Implement simple issue list UI. r=rcaliman,ladybenko
Depends on D48948

Differential Revision: https://phabricator.services.mozilla.com/D48949

--HG--
extra : moz-landing-system : lando
2019-10-15 07:27:25 +00:00
Daisuke Akatsuka 9192aeb547 Bug 1587690: Implement basic Redux flow. r=rcaliman,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D48948

--HG--
extra : moz-landing-system : lando
2019-10-16 01:24:48 +00:00
jaril 23830a0484 Bug 1579928 - Reflect proper message order in the console for evaluations during replay r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49229

--HG--
extra : moz-landing-system : lando
2019-10-15 20:56:27 +00:00
Gabriel Luong 7225b50741 Bug 1568126 - Part 2: Make InspectorStyleChangeTracker work with fission. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D48607

--HG--
extra : moz-landing-system : lando
2019-10-15 18:21:50 +00:00
Armando Ferreira 1b620ea961 Bug 1523868 - Add a doorhanger options menu in console toolbar - Part 1.
Differential Revision: https://phabricator.services.mozilla.com/D47979

--HG--
extra : moz-landing-system : lando
2019-10-15 17:04:30 +00:00
Narcis Beleuzu 072545a7c3 Bug 1587777 - Fix Linting on constants.js . CLOSED TREE 2019-10-15 20:44:17 +03:00
Narcis Beleuzu 749a47cb03 Bug 1587777 - Fix Linting on constants.js . CLOSED TREE 2019-10-15 20:14:52 +03:00
David Walsh 55204b4619 Bug 1587777 - Implement request blocking toolbar button r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D48914

--HG--
extra : moz-landing-system : lando
2019-10-15 16:32:33 +00:00
David Walsh d920e3e85f Bug 1584988 - Only allow files to be dropped onto HAR overlay r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D48982

--HG--
extra : moz-landing-system : lando
2019-10-15 15:29:51 +00:00
Greg Tatum 037581be8e Bug 1588086 - Fix the multi-modal getSymbolTable; r=julienw
The function had the wrong argument parameters, and it wasn't
fetching the latest list of objdirs.

Differential Revision: https://phabricator.services.mozilla.com/D49006

--HG--
extra : moz-landing-system : lando
2019-10-15 11:25:18 +00:00
Dorel Luca 4bb1aa3b3b Backed out changeset 03643a08fe82 (bug 1523868) for Node failure in Unexpected token y in JSON at position 0. CLOSED TREE 2019-10-15 18:42:20 +03:00
Razvan Caliman 9b1cea50c2 Bug 1581850 - Ensure target elements are highlighted when hovering selectors in DevTools Style Editor. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D46155

--HG--
extra : moz-landing-system : lando
2019-10-15 13:24:21 +00:00
Armando Ferreira 05826d08b2 Bug 1523868 - Add a doorhanger options menu in console toolbar - Part 1.
Differential Revision: https://phabricator.services.mozilla.com/D47979

--HG--
extra : moz-landing-system : lando
2019-10-15 15:31:32 +00:00
Sorin Davidoi 6a6c20a378 Bug 1588262 - fix(devtools/debugger/sources): Display project root header inline r=davidwalsh
Uses flex display the information inline.

Differential Revision: https://phabricator.services.mozilla.com/D49059

--HG--
extra : moz-landing-system : lando
2019-10-15 14:33:21 +00:00
Florens Verschelde dec9e481a5 Bug 1588294 - Project search results style tweaks, new highlight colors; r=davidwalsh
- Use tabular numbers in search input message to reduce layout shifts that impact the loader icon
- Use new highlight colors in search results
- Use standard code font-family (platform-dependent) and font-size (11px); change result row height to 18px (from 16px)
- Add row hover background color, similar to Network request list
- And a few more spacing tweaks

Differential Revision: https://phabricator.services.mozilla.com/D49091

--HG--
extra : moz-landing-system : lando
2019-10-15 14:08:30 +00:00