Automatic update from web-platform-tests
[css-nesting] Don't emit invisible rules inside @page
The parsing code for @page leans on the code from CSS Nesting,
which recently gained special behavior for trailing declarations
(crbug.com/1517290). This special behavior affects how an inner rule
relates to its outer style rule (/selector), which is not relevant
for @page.
Bug: 1517290
Change-Id: I755f8b2675f8e5c988c8ea5afdf03c84b779da83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272554
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258458}
--
wpt-commits: 5480e40cca136e14699392842c91488745b17cfc
wpt-pr: 44495
Automatic update from web-platform-tests
[Grid] Fix resolution of alignment properties for subgridded items
There was an issue with the `align-*` and `justify-*` properties and
subgridded items where, if its parent subgrid was orthogonal to the root
grid that considered such item for sizing, then the alignment properties
were incorrectly resolved relative to the root grid's writing mode.
Fixing this behavior making sure that we always resolve the alignment
properties of a grid item relative to its parent grid's writing mode.
Adding test coverage to the WPT suite for this issue.
Bug: 1521978
Change-Id: I7d929ff1589632964e38100b5ba44a484df954b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260028
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258172}
--
wpt-commits: cc83935a037f4280b4dee6c5386beb615bd4ebe5
wpt-pr: 44371
Automatic update from web-platform-tests
VT: Handle document shutdown gracefully.
This patch does two things:
- After dom callback is finished, ensures that we have a view before
continuing. We skip the transition otherwise.
- When document is shutting down, skip any transition that is
outstanding. This is due to the fact that the execution context (dom
window) can notify of its destruction after document is destroyed.
However, the transition is owned by the document (via supplement), so
it can be destroyed before this notification and cause CHECKs
due to invalid state in the style tracker dtor.
R=khushalsagar@chromium.org
Fixed: 324109585
Change-Id: I64eaa886f89c89762cd3d5d8b5ad3b0fa4a1a4bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5273560
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258056}
--
wpt-commits: bd7709893dbd04881db5b7d25d82fdd24178c9a5
wpt-pr: 44453
Automatic update from web-platform-tests
sensors: Make virtual sensors always remember and report the latest reading
This concerns a discussion that started in https://crrev.com/c/5249795:
the idea is to make a virtual sensor leak fewer implementation details,
such as the fact that the current reading is lost when the sensor is
deactivated. This should not be observable from e.g. a web test, as
there is nothing mandating that this happen in the first place.
From an API user's perspective, once a reading is added to a virtual
sensor (including if this happens before a Sensor instance is created in
Chromium) it remains present until it is replaced by another one, even
if the sensor is stopped and reactivated. This is complemented by the
behavior added in https://crrev.com/c/5245506, in which any pending
reading (or, with this CL, the latest reading) is stashed until it can
be published.
In other words, a VirtualPlatformSensor now respects the following two
invariants:
1. Once a reading is set, it will remain set until it is replaced with
another reading.
2. Said reading will be added to the shared buffer and clients will be
notified whenever the sensor is activated.
While here, revert the part of https://crrev.com/c/5245506 that renamed
PlatformSensor::IsActiveForTesting() to is_active(), as this is no
longer needed.
Bug: 1520919, 1506995
Change-Id: I205432cbf196376f67a6bc1c84d69302ffe739ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272509
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1258046}
--
wpt-commits: effd91d0c3ea64f8c75f7fe0714d98f96a78dc2a
wpt-pr: 44444
Automatic update from web-platform-tests
Test to account for links wrapped in `svg` (#44461)
--
wpt-commits: 11f539a39cc30d82c4a89e134cc2d9495a2ee147
wpt-pr: 44461
Automatic update from web-platform-tests
Implement view-transition-class selector matching
Selector checker now matches classes from selector to classes
from pseudo-element.
The classes aren't saved on the pseudo-element, but rather in the
ViewTransitionStyleTracker, in the element map.
Bug: 1519997
Change-Id: Iee74bb5d8e6f1ced0edfbcdc1ac9eec32497e97f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253451
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257975}
--
wpt-commits: 50cdae7b23a8ab23a1ebeacc71d254105c710b15
wpt-pr: 44322
Automatic update from web-platform-tests
Establish display item fragment scope for atomic inlines.
We already did this when painting text items and inline box items
(non-atomic inlines), but we also need to do it when painting atomic
inlines.
Although it's rather unusual for an atomic inline LayoutObject to be
associated with multiple fragment items, it may happen if an atomic
inline is associated with a text-overflow ellipsis (that's a fragment
item of type kGeneratedText).
A text-overflow ellipsis fragment item is associated with the last
LayoutObject that fits before the ellipsis, and if this happens to be an
atomic inline (e.g. an image), it will be that one.
To explain what went wrong in the test included: There's a SPAN with two
lines inside. Two fragment items are created for the SPAN. The item on
the first line gets fragment ID 0, and the one one the second line gets
ID 1. On the second line there's an image followed by something that
gets clipped by overflow, and there will be a text-overflow ellipsis.
The image is the last (and only, actually) object that fits, so the
ellipsis gets associated with that object. Two fragment items are
created for the image object, first the image itself, and then the
ellipsis. They get a fragment ID of 0 and 1, respectively.
When painting the SPAN on the second line, we establish a fragment item
scope for it, and the ID is 1. When we paint the actual image, we didn't
establish a scope, so that ID 1 was used for the image as well (even
though its fragment ID is 0). When painting the ellipsis afterwards, we
establish a scope, with ID 1. Because of this we got the same display
item client (from the layout object) painted twice with the same
fragment ID.
Bug: 41493875
Change-Id: I5fc87fc086ecd3c4367dca7c3ad94c22c031f7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272607
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257896}
--
wpt-commits: a79f9cb445a5d21b0ac31dacea77b5edfb60e37a
wpt-pr: 44469
Automatic update from web-platform-tests
Add coverage for `webkit` prefixed historical interface (#44462)
Hi Team,
It was supported by Safari / WebKit until recently and it was removed weeks ago, I think it would be good to add coverage for it.
Thanks!
--
wpt-commits: 54a180f690f8d315fccadc1cd773f95f241428ca
wpt-pr: 44462
Automatic update from web-platform-tests
Move monolithic-overflow-* from css/printing to css/css-page. (#44422)
Ideally, css/printing/ should be emptied. Here's a step in that
direction.
See https://github.com/web-platform-tests/wpt/issues/42937
I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.
Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}
Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
--
wpt-commits: 0f06b11a0ecd9df6f881ebbe6b0dbc5516794de9
wpt-pr: 44422
Automatic update from web-platform-tests
Always call superclass in HTMLLabelElement::DefaultEventHandler
HTMLLabelElement::DefaultEventHandler does not currently call up to
HTMLElement::DefaultEventHandler in many cases. This patch makes sure
that HTMLLabelElement always calls up to HTMLElement, which makes
<label>s in <button>s work.
WebKit's HTMLLabelElement already does this in all branches of
HTMLLabelElement::defaultEventHandler since 2017:
fec9c1dd14b9bad3158f
Fixed: 1523168
Change-Id: Ib9d0a63befbb930b9595bcc89fb5955050c97b2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260750
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257674}
--
wpt-commits: 3c00d743109ae3d06e874e56dd9287f3ded06f44
wpt-pr: 44370
Automatic update from web-platform-tests
allow old headless mode for chrome (#44445)
* allow old headless mode for chrome
While Wptrunner's '--headless' means the new headless mode, allow
passing binary arg '--headless' to chrome directly to enable the
old headless mode
--
wpt-commits: 09de1c20d1d31f66bb7174c896f0a63fb41b59b4
wpt-pr: 44445
Automatic update from web-platform-tests
Correctly handle printing of overflowing monolithic OOFs.
We need to make sure that we create enough pages to contain tall
monolithic out-of-flow positioned descendants, including any overflow
inside of them.
Similar support for in-flow elements was added in CL:5029779, where we
at the same time stopped synthesizing missing pages after layout, but
instead started to trust layout. However, that was premature, since
out-of-flow positioned descendants of course need special treatment.
Bug: 41496759
Change-Id: If52a4b1ad50ec55dbdabc6456b47a299404f7d25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272404
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257469}
--
wpt-commits: 734e3b9058ae83e689e9344e0776693d01e56adb
wpt-pr: 44421
Automatic update from web-platform-tests
[EditContext] Ensure textupdate fires for backspace/delete in <canvas>
When the active EditContext's associated element is a <canvas>, we
fail to fire the textudpate event when the user hits backspace/delete.
The reason is that for these keystrokes, EnabledInEditableText is
used to determine whether the command is enabled, and this includes
a check that the selection is contained in the focus. For <canvas>
this will never be the case because <canvas> cannot contain selection.
Fix this by always treating the command as enabled if there is an
active EditContext, since an EditContext should always have the
opportunity to handle these commands.
Update some existing text input and text deletion tests to run for
<canvas> in addition to <div>.
Bug: 1517103, 999184
Change-Id: Id8d4509ed6b22a4516d9bfa2c4a05b234eea78de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5251988
Reviewed-by: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1257455}
--
wpt-commits: 12a51d92951f2858e1ad74a4412279e645e67a61
wpt-pr: 44303
Automatic update from web-platform-tests
[shared storage] Allow creating multiple worklets per Window context
Explainer PR: https://github.com/WICG/shared-storage/pull/130
How:
- Introduce sharedStorage.createWorklet() method. In this patch,
we still restrict the script to same origin. Ultimately, we will
support cross-origin script/worklet (for the createWorklet() API).
- Also, move the document service Remote to a window supplement
class: This is a forward-looking change (e.g. it'll enable
constructing the worklet via `new SharedStorageWorklet()` / not
needing to exist along with the `sharedStorage` object, although
this isn't in the current proposal).
Bug: 1218540
Change-Id: I5bf64bdf6648a76875748b194e5dbceeb1400624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5209102
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257412}
--
wpt-commits: a973f277c12becac99d26f79d1a51e3f2efd452a
wpt-pr: 44060
Automatic update from web-platform-tests
Fully implement bidi for a line's trailing spaces (UAX#9 L1)
Per UAX#9 L1, any spaces that after line breaking would fall logically
at the end of a line must be reset to the paragraph's initial
embedding level, regardless of the embedding level of those spaces in
the paragraph. Until now, Blink only had partial support for this.
The reason this was hard to implement in Blink is because the
direction of text is computed in a per-paragraph level, splitting the
text into items with a given direction and embedding level. Those
items are then split into item results when line breaking, but item
results must have the same direction as the item.
As part of line breaking, some item results are produced which only
have trailing spaces. The partial support, implemented in
crrev.com/c/2505486, consisted of marking these results with the
`has_only_trailing_spaces` flag, and using this flag to distinguish
them when reordering the item results.
This patch builds on top of that partial fix by adding a final
processing step to line breaking, which splits item results so that
trailing spaces (with a different embedding level as the paragraph)
are split into its own item result, and by marking all trailing spaces
item results as `has_only_trailing_spaces`.
This also fixes bug 1514753, where having a item result with non-base
direction which had logically trailing spaces was causing the text
(rather than the spaces) to hang, because
`LineInfo::ComputeTrailingSpaceWidth` assumed that UAX#9 L1 held.
This patch also modifies some existing WPT tests to make them use a
monospace Arabic webfont (since it's not guaranteed that all OS's have
one), and by changing the widths slightly to work around bug 1409445.
Bug: 316409, 1514753
Change-Id: I1eb751b457d413b5099dad8f95badba9a1b3e5fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5199988
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Andreu Botella <abotella@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1257309}
--
wpt-commits: c635cb4ef1a21ff07e210f2733f97ccb01c0ed15
wpt-pr: 44076
Automatic update from web-platform-tests
Moved position-try-order into wpt/ from wpt_internal/
Now part of the spec draft
Bug: 40279608
Change-Id: I35546256c8460bfa46d1b9b7607e008d069cbd6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272498
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257259}
--
wpt-commits: aee2a77919002424ba9ef9c302d0716ceff81ea2
wpt-pr: 44434
Automatic update from web-platform-tests
[wdspec] Add type hint parameter for context_created and context_destroyed user context tests
Depends on D200024
Differential Revision: https://phabricator.services.mozilla.com/D200032
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920
gecko-commit: 0237b0c99f398a9c4ac048bbdf029d8bc16e3771
gecko-reviewers: webdriver-reviewers, whimboo
--
[wdspec] Always assert user context in assert_browsing_context
Depends on D200032
This should ensure good coverage of the user_context field
Differential Revision: https://phabricator.services.mozilla.com/D200181
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920
gecko-commit: 8a66a3b89c40f8a8f3195f6a92c0c3d2af587b21
gecko-reviewers: webdriver-reviewers, whimboo
--
[wdspec] Add various user_context tests for browsingContext.create
Depends on D200181
Differential Revision: https://phabricator.services.mozilla.com/D200182
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874920
gecko-commit: 1c00d395406fc5b994ce1a16d8625ba85d57a8bd
gecko-reviewers: webdriver-reviewers, whimboo
--
wpt-commits: 173d73bd3e9494739ba4f1036fe2f4895b4d31b9, 6c85d26559cb2cc5e8c331232d7201c26294bd8f, ed10c1277cbf7aba87b4d37d926b967c6545903d
wpt-pr: 44418
Automatic update from web-platform-tests
Add tests for zstd content-encoding (#44393)
* add zstd tests and separate into folders
* add bad input tests and make window size test tentative
* add https to bad input test
--
wpt-commits: 2453380d880f99191dc00b14b4c183fe7364766b
wpt-pr: 44393
Automatic update from web-platform-tests
serial: Migrate Web Serial MojoJS based tests to internal folder
This CL migrate Web Serial MojsJS based tests to internal folder
temporary. We will move it back once Web Serial Testing specification
for test-only interface is defined.
Bug: 1524403
Change-Id: I75323dfe2a649348e23c333e1a635cf8cc9ba806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259047
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Alvin Ji <alvinji@chromium.org>
Reviewed-by: Alvin Ji <alvinji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257126}
--
wpt-commits: 39e3ec25444f35acd4129eb589c052e9d7ee0a32
wpt-pr: 44374
Automatic update from web-platform-tests
[wptrunner] Plumb expectations `wpttest.{Test -> (Subtest)Result}` (#44424)
This allows vendors to override expectations at runtime via
browser-specific result converters. Instead of constructing
`(Subtest)Result`s directly, executors should use the newly introduced
`Test.make_{subtest_,}result()`, which have the same signatures but
default to passing through the testloader-read expectations.
This is a pure refactor; no functional changes intended.
Successor to: https://github.com/web-platform-tests/wpt/pull/44134#issuecomment-1920055927
--
wpt-commits: a68f313a50899795e1e6660b7398544d340f1652
wpt-pr: 44424
Automatic update from web-platform-tests
Remove declarative shadow DOM polyfill
Declarative shadow DOM is standard [1] and implemented in all
modern browsers. This removes a polyfill that isn't needed in WPT
any longer.
[1] https://html.spec.whatwg.org/multipage/scripting.html#attr-template-shadowrootmode
Bug: N/A
Change-Id: Ie9bfdf24f75901cf9a476844a76065e5a18a6815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263643
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257013}
--
wpt-commits: 5eb84ee7e7fd03bbe975fb7b655d75310e8dd71b
wpt-pr: 44387
Automatic update from web-platform-tests
Render <button> and <datalist> in <select>
Now that the HTML parser allows <button> and <datalist> in <select>,
this patch modifies the UA shadowroot of <select> to slot the <button>
and <datalist> and render them. If a <button> is provided with no
<datalist>, then the native popup is used. If a <datalist> is provided
with no <button>, then the native button is used.
Bug: 1511354
Change-Id: I36f88f73949aa2cba502231ed2d68c1738e47946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230929
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257004}
--
wpt-commits: 803ab2a07109c4d4ab1f30928e93e865909362ab
wpt-pr: 44154
Automatic update from web-platform-tests
Support iframe scroll margin
This change adds support to observe out of viewport targets inside
scrollable same origin iframes using intersection observers with
scrollMargin, by crossing the iframe boundary when collecting
intermediate scrollers.
R=szager
Bug: 1503290
Change-Id: Iaf5482a67e8eb37000d54fb9529df5c16f86e644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240906
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1256994}
--
wpt-commits: c0b9c868430562422a8a46b495714a2aa9c087b7
wpt-pr: 44237
Automatic update from web-platform-tests
Don't reject same site prefetches with no-referrer
The referring URL as computed by the referrer policy for the prefetch
request was incorrectly being used to determine whether a prefetch was
cross site. This value is only meant to be used for the prefetch
request. The omission of the URL made it look like a cross site
prefetch, so the cookie eligibility check was applied.
We now use the initiating origin to determine whether a prefetch is
cross site.
Bug: 1524338
Change-Id: Id154effae55c539fff7cd733327fc9029c53b03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263133
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1256905}
--
wpt-commits: 1120ba99036f61a02a3cbca05dcd0b2c0c39fcc0
wpt-pr: 44389
Anders Hartvoll Ruud
moz-wptsync-bot
Anne van Kesteren
Rune Lillesveen
L. David Baron
Joey Arhar
Ethan Jimenez
Vladimir Levin
Raphael Kubo da Costa
Ahmad Saleem
Noam Rosenthal
Morten Stenshorne
Blink WPT Bot
sisidovski
Weizhong Xia
Dan Clark
Yao Xiao
Dominic Farolino
Andreu Botella
Nidhi Jaju
Alvin Ji
Jonathan Lee
Mason Freed
Traian Captan
Kevin McNee