Android's drag and drop API will set a dropped item on `drop` event. But other
platforms will be set during `dragstart` event.
Editor's drag and drop event listener checks current dropped item on some
events such as `dragover` event in
`EditorEventListener::DragEventHasSupportingData`. Since there is no way to
set dropped item on `dragover` event, GeckoView will set temporary dropped
item with MIME type.
Differential Revision: https://phabricator.services.mozilla.com/D200618
It is unnecessary to join path with path separator when adding classpath
as file collection.
Also, javadoc's sourcepath argument have to use OS related path separator.
Default is OS related path separator, so we should use it instead.
Differential Revision: https://phabricator.services.mozilla.com/D201038
This makes the Yelp suggestion UI closer to the spec. Summary:
* Always set `isRichSuggestion: true` so that the bottom "Yelp · Sponsored" text
is visible when the row is not a top pick.
* For the top pick treatment, the icon itself should be 38px and centered in a
52px box with a border.
* For the non-top-pick treatment, the icon size should be 24px.
* Currently rich suggestion rows with 24px icons aren't properly aligned with
the icons and text in other rows. We have some rules that fix this for rows
with 16px icons and non-rich suggestions. The problem happens for any row
whose icon is smaller than the 28px icon of most rich suggestion rows, so I
added a rule to cover 24px icons.
* Add `HIGHLIGHT.TYPED` to the title, but I need to verify this with Loren
References:
* [Figma](https://www.figma.com/file/Vx9PB3b4oU1ilLwqZVq8r4/Yelp-suggestions?type=design&node-id=406%3A14439&mode=design&t=Q1UyIltVH2bniMwp-1)
* [Spec doc](https://docs.google.com/document/d/13ByGyGK-gMRX5hz9Buj3Xo6Q19hnu2oOvvI1DS29PCs/edit?usp=sharing)
Depends on D201182
Differential Revision: https://phabricator.services.mozilla.com/D201184
The fork server replaces the process's `argv` and `environ` with
heap-allocated strings received over IPC; if those strings are later
unlinked from those vectors, they will be seen as leaked. Also, we
have an implementation of `setproctitle` (a BSD feature that has to be
emulated somewhat hackily on Linux) which copies the process's original
`argv` and `environ` strings into the heap so the original space can be
reused; this can also cause (finite) leaks when those strings are later
discarded.
Given that we already tell Valgrind to ignore leaks caused by use of
`setenv` and similar, this patch likewise suppresses those leaks.
Differential Revision: https://phabricator.services.mozilla.com/D201190
ExtractSubrect calls were not getting forwarded on SourceSurfaceRecording, causing us to do unnecessary readbacks
when hitting the CopySurface fallback path. SourceSurfaceWebgl actually implements ExtractSubrect already, but it
was never being used since the switch over to the DrawTargetRecording infrastructure.
Differential Revision: https://phabricator.services.mozilla.com/D201701
This is only used to calculate the block-start border of the overall table,
not and is unused after. Use `Maybe<>` to reflect it as such.
Differential Revision: https://phabricator.services.mozilla.com/D197930
This moves handling of the preferences and log value setting into ConsoleInstance, which is where the preferences
are received. It also makes ConsoleInstance add a listener on the preferences service so that updates are triggered.
The functionality is already covered by dom/console/tests/test_jsm.xhtml
Differential Revision: https://phabricator.services.mozilla.com/D199657
On some Mali GPUs glPushDebugGroup and other functions from the
extension GL_KHR_debug always raise a GL_OUT_OF_MEMORY error. In debug
builds we automatically enable debug markers, as well as panicking
when encountering a GL error. This causes the GPU process to crash
repeatedly at startup, eventually falling back to software
webrender. To avoid this, we block the extension on affected devices.
Differential Revision: https://phabricator.services.mozilla.com/D201579
For some other patches, we need to be able to have the user's saved engine settings loaded into the search engine objects striaght away.
Currently, they are generally not loaded until sometime later, and in the case of engines loaded in `loadEnginesFromSettings`,
they are actually loaded twice.
Additionally, I think it makes more sense to pass the data in when they are constructed.
Differential Revision: https://phabricator.services.mozilla.com/D201270
This could never have run properly as _alias isn't available on SearchEngine, only alias is.
Bug 1879555 has been filed to potentially address this in future.
Differential Revision: https://phabricator.services.mozilla.com/D201269
Makoto Kato
Denis Palmeiro
Emilio Cobos Álvarez
Drew Willcoxon
Shane Hughes
John Schanck
Alexandre Poirot
Michael Froman
Nicholas Rishel
Stanca Serban
Jed Davis
Travis Long
Valentin Gosu
Erich Gubler
James Teow
Narcis Beleuzu
Joel Maher
Mozilla Releng Treescript
Ben Visness
Lee Salzman
Sammy Khamis
David Shin
Matthew Gaudet
Mark Banner
Jamie Nicol
Brad Werth
Kelsey Gilbert
Nicolas Silva
Alexandra Borovova
Karandeep