A single transition value that includes 'none' for transition-property is
valid, so we should store whole specified values (if it's valid). Whereas,
the spec [1] clearly says for the case where there are multiple entries;
If there is more than one <single-transition> in the shorthand, and any of
the transitions has none as the <single-transition-property>, then the
declaration is invalid.
'none 2s linear 2s' is a test case for the former, '1s width, 2s none' is a
test case for the latter.
Note that with this patch, 'transition: none' is serialized as 'none 0s ease 0s'
instead of 'none' but it matches Gecko.
[1] https://drafts.csswg.org/css-transitions/#single-transition
MozReview-Commit-ID: 3o3z5GFyMqh
--HG--
extra : rebase_source : c553af804124c0c76554fb8ad007e78e2813d321
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1397122
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: c0c43da1f90afc37ac9d78bb7ef0f52cf02f2611
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 22db9b32cc829408d2a04a42941069c07a00ea13
By the time the LocaleService destructor is called, by definition sInstance
has been cleared and its preference observers have been removed, since both
are strong references. In practice, this doesn't seem to cause trouble, but it
does lead to worrying warnings at shutdown in debug builds, which are annoying
red herrings when debugging other issues.
MozReview-Commit-ID: IalOigr2GWN
--HG--
extra : rebase_source : f86a8e81b91c639dedaca85e5bc3b53d54e01645
extra : histedit_source : 643b76de0d29ca4890ac4dd4175259989a63688e
Just removing or rewording stale stuff.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8065eac0ebcadcdab0fd3649cf9e18c591d47ed6
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6cf44e72d503154f38c84a8ba3b210ac2d18e0b6
This is effectively not going to happen, per
https://github.com/w3c/csswg-drafts/issues/1766
Source-Repo: https://github.com/servo/servo
Source-Revision: 9c0abfea239077bc490ed8a2d4a7c32ba782942d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6131b7b2610f82b5888e54841a02e09e59ba5a05
The nsIU2FToken and its implementors are no longer needed; the soft token was
re-implemented into dom/webauthn/U2FSoftTokenManager.cpp during the WebAuthn
implementation. When the dom/u2f/ code changed to the implementation from
WebAuthn, the old synchronous version became dead code.
This patch removes the dead code.
MozReview-Commit-ID: 2yDD0tccgZr
--HG--
extra : transplant_source : %B3%96Te%E7%02%08%98%1A%B2%FA%1C%40%C4J%BC%B2%85j%81
- This patch reworks the U2F module to asynchronously call U2FManager,
which in turn handles constructing and managing the U2FTokenManager
via IPC.
- Add U2FTransaction{Parent,Child} implementations to mirror similar ones for
WebAuthn
- Rewrite all tests to compensate for U2F executing asynchronously now.
- Used async tasks, used the manifest parameters for prefs and scheme,
and generally made these cleaner.
NOTE TO REVIEWERS:
Since this is huge, I recommend the following:
keeler - please review U2F.cpp/h, the tests, and the security-prefs.js. Most
of the U2F logic is still in U2F.cpp like before, but there's been
some reworking of how it is called.
ttaubert - please review U2FManager, the Transaction classes, build changes,
and the changes to nsGlobalWindow. All of these should be very
similar to the WebAuthn code it's patterned off.
MozReview-Commit-ID: C1ZN2ch66Rm
--HG--
extra : transplant_source : %EA%98%D2%87C%FD%CC%A5%3D%B5%9B%1C%DA%A5J%CD%05%94%13%0D
This is a simplification. GetRootScrollFrameAsScrollableExternal() is just a
wrapper around its non-"External" version, GetRootScrollFrameAsScrollable(), so
we might as well just directly call *that* version. All of the callers here
are inside of libxul, so they don't need the special "External" version.
MozReview-Commit-ID: GGMMDAlJ9xu
--HG--
extra : rebase_source : a3bd19a6300d0ce66f38fb8433db20b4ec03abfb
This is just simplifying things by eliminating a layer of now-unnecessary
abstraction.
MozReview-Commit-ID: 1MBagjYXbCD
--HG--
extra : rebase_source : a0e7e78ef4925efd00eac969ae126d1ba3f4f607
These functions are now dead code. And really, they were already dead code
even before this patch-stack -- they were only called in never-evaluated
(and now-deleted) #else clauses.
MozReview-Commit-ID: AeY6Z3ybmsv
--HG--
extra : rebase_source : deb51373f4d32580ab2ffb71c5c078132e4a76a6
This patch drops all MOZILLA_INTERNAL_API checks (and the bodies of any
associated "#else" clauses) from these files. The basic assumption here is
that MOZILLA_INTERNAL_API is #defined in all (supported) compilation units that
#include these files, so the checks are superfluous and the #else clauses are
dead code.
(If this assumption is mistaken and there is some .cpp file in our codebase
that #includes this header and yet does not have MOZILLA_INTERNAL_API, we will
find out via bustage on treeherder.)
MozReview-Commit-ID: 8dHJFBDVHwT
--HG--
extra : rebase_source : 476a6e2de8468dea2e26e11f415c3868326126e5
Since NoFocusState is am empty struct used in the |mData| variant in
FocusTarget, we need to add a Reader and a Writer for IPC for NoFocusState so we
can properly read and write the |mData| variant. The NoFocusState Read and Write
methods do not read or write anything, since NoFocusState does not contain any
data. This is done by creating a helper class EmptyStructSerliazer and
inheritting from EmptyStructSerializer for the NoFocusState specialization.
The |Read| and |Write| methods for FocusTarget are updated by removing the read
and write code for the individual types of |mData| and instead makes use of the
IPC read and write methods for Variant.
MozReview-Commit-ID: 3159sp6FLek
--HG--
extra : rebase_source : ff82797c26abffbd8bbcc465dc40c621be3257d0
Updates FocusState::Update to use a matcher on the the mData variant. This
replaces a switch statement that was used to unpack the mData union, prior to
making mData a variant.
FocusTargetDataMatcher has three match methods, which are largely unmodified
from the three cases of the original switch statement. The constructor takes two
arguments: a reference to |this| (FocusState) and a copy of the
|sequenceNumber|. |sequenceNumber| was added to the constructor to avoid passing
in a reference to |target|, since we only needed the |sequenceNumber| property
from |target|.
MozReview-Commit-ID: FkjQm8oGysM
--HG--
extra : rebase_source : 4ef8da00fe0925ed5a477063449e83bf601f49ee
FocusTarget.h
* Adds Variant property to FocusTarget
* Adds RefLayerId typedef for uint64_t
* Adds empty struct for the case where there is no focus target
* Adds operator== for ScrollTargets struct
* Updates mData from union to mozilla::variant
* Removes FocusTargetType enum
* Removes FocusTargetData union
* Removes mType property
FocusTarget.cpp
* Updates methods using mData to use proper variant methods
* Removes references to mType, instead using the appropriate
variant methods
MozReview-Commit-ID: BAarVxSGDtJ
--HG--
extra : rebase_source : 47ca7243619a756408cf1ee406b94890d083da3b
* VariantWriter construction switched to use aggregate initialization
* Call to AsVariant was inappropriately called via |paramType| when it should
have been called via |mozilla|
* |Next::Read| call in VariantReader specialization was missing the |result|
argument
MozReview-Commit-ID: Izany7iDX0k
--HG--
extra : rebase_source : 7387e72100c7d2ba8fcfd1e5a3b6d0ce6be6c740
Youtube has now deprecated flash embeds completely, meaning
enablejsapi in embeds will no longer work. We can now rewrite these to
use HTML5, as any functionality related to the js api will no
longer function anyways.
MozReview-Commit-ID: kZTwpyLaYw
--HG--
extra : rebase_source : 7b6516183a4c7de8fe47fb328e4f28f3ad7bc03f
I haven't tested this because it's very time-consuming for such a simple
change.
MozReview-Commit-ID: 7f4LLlBbrLw
--HG--
extra : rebase_source : ce8fbbbf2a745395f0986fd76442f72743dc68ca
This adds a loadReplace option into the updateOptions object for tabs.update()
which, when set to true, will cause the loading of the new URL to replace the
current URL in the tab's history.
MozReview-Commit-ID: KZTuEl7cgb0
--HG--
extra : rebase_source : 24f006fe197f56b3102cb00e226d53036b9ba93b
This is a change to permit interacting with the U2FTokenManager from
the dom/U2F context in addition to the dom/WebAuthn one.
MozReview-Commit-ID: BvP5BY2wVYi
--HG--
extra : transplant_source : %BEt%83%DBq%1C%1E%AE%24%D3%81%94%ACK%08%9C9%3F%0D%EF
We already measure (in Rust code) the things hanging off it, but overlooked the
object itself. This patch adds measurement on the C++ side.
--HG--
extra : rebase_source : f7daf62b4ec43cdc95034ffcb2a3aca27d995ae3
Sebastian Hengst
Phil Ringnalda
Zibi Braniecki
Hiroyuki Ikezoe
Kris Maglione
Geoff Brown
Andrei Oprea
Emilio Cobos Álvarez
Daosheng Mu
J.C. Jones
Jonathan Kingston
Daniel Holbert
Jeff Hajewski
Kyle Machulis
Michael Comella
Bob Silverberg
Alexis Beingessner
Lorena Diaconescu
Kit Cambridge
Nomis101
Nicholas Nethercote
David Keeler
Honza Bambas
David Parks
Ryan VanderMeulen
Jim Mathies