Given that both 'close' and 'close_chrome_window' wait for the underlying
tab or window to be closed, there is not need to explicitely wait in tests.
MozReview-Commit-ID: HOGgqzkNE9d
--HG--
extra : rebase_source : 0a1b197d499c9c2528e67e61172d90579f7ad696
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1388625
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: c811a1aa7745c848870af226e249e14baaa4ccc3
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 585bc173dd1a11827f705340f637f528903e46ac
Prior to this patch we always passed APP_SHUTDOWN as the reason when
shutting down and uninstall a temporary addon, even if the same addon
was installed permanently. Now we send an appropriate reason.
Also untangled a bunch of stuff that had been added to the test case
for temporary-addon-installed-over-permanently-installed-addon and
then extended the basic test to cover this scenario.
MozReview-Commit-ID: 7rgfpiRYcFu
--HG--
extra : rebase_source : e916e040000838b22d6f30ac226115e953f2a3a9
This test is about webextension themes but it was stuck into an
unrelated test of temporary addon installation. Move it to a
more appropriate place.
MozReview-Commit-ID: FMNmGuUJrWo
--HG--
extra : rebase_source : 5cc4cb6fa7c8d3ca397af4a9b2198cad33015ec6
Unlike Gecko, Stylo currently invokes a needless RequestRestyle(Standard)
for this test case (bug 1388560). For this reason, the check right after
re-attaching the orphaned element passes accidentally.
MozReview-Commit-ID: JUG1dgMUQEX
--HG--
extra : rebase_source : a86d72a41c160edc30f83d82179ebe1226b842de
Actually we have a chance to run styling process when we attach an orphaned
element to a document in this test setup. Precisely, we can process a restyle
between rAF callbacks and Promise.then() callback for waitForAnimationFrames().
So if we call RequestRestyle(Layer) when we attach the element to the document
(bug 1388557), the animation starts restyling in the first frame. *BUT* this
behavior will also change once our micro tasks handling becomes the HTML spec
compliance (bug 1193394). When the micro tasks handling changes, we should also
fix a bunch of test cases and test utilities in bug 1388557.
MozReview-Commit-ID: GyH1ofGhXOP
--HG--
extra : rebase_source : 3536c315960150960fd43286b205c03c584d53ca
DOMWindowUtils.isStyledByServo checks not only the preference value but also
STYLO_FORCE_ENABLED value. This is important especially when we run test on
our CI. On our CI, the preference value is false but just STYLO_FORCE_ENABLED
is set.
MozReview-Commit-ID: FKEd5LFwcxf
--HG--
extra : rebase_source : 1ffd8a68a8339babed14f441bf2d69c9ffd9e3ee
We filp the display value of display tree after each property, which
means if we put the iframes there, we are rebuilding style for the
two subdocuments repeatedly. This doesn't really make sense. We are
flipping display tree for restoring #elementf, not for the iframes.
MozReview-Commit-ID: B9bRDrlt0HJ
--HG--
extra : rebase_source : 3762605a782098d5d804342766d4ca6ad971fdf8
After landing bug 1205983, mPreviousDictionary is unused. So we should remove unused GetCurrentDictionary calls.
MozReview-Commit-ID: 20GAyoiEWCN
--HG--
extra : rebase_source : 6abc0e50073c836a99a699e1de8103a3faacf071
The original duration I wrote is calculated from the m3u8 file this is too accurate without error tolerant.
The state machine will update playback position periodically(UpdatePlaybackPositionPeriodically)
according to the clockTime or max end time from A/Vsink.
So the duration will be variant that I should consider to set the value to a more relaxed value.
MozReview-Commit-ID: GGwkhvzz8sI
--HG--
extra : rebase_source : c0465f7aef7a41e999e8c4c3429957fa56336239
Luke Chang
Boris Zbarsky
Henrik Skupin
Mark Hammond
Matthew Noorenberghe
Andrew Swan
Andrew Halberstadt
Phil Ringnalda
Hiroyuki Ikezoe
Evan Tseng
Xidorn Quan
Brian Birtles
Makoto Kato
Wes Kocher
ffxbld
Aki Sasaki
Sebastian Hengst
Julian Descottes
Ricky Chien
Dão Gottwald
James Cheng