We change this assertion to a normal to ease the crash problem from
users and will do a further investigation to know the root cause.
Differential Revision: https://phabricator.services.mozilla.com/D71525
We change this assertion to a normal to ease the crash problem from
users and will do a further investigation to know the root cause.
Differential Revision: https://phabricator.services.mozilla.com/D71525
Bug 1630629 moved the check UseWebRenderDCompWin before it had been
initialized. This moves it below so that DirectComposition isn't
disabled everywhere.
Differential Revision: https://phabricator.services.mozilla.com/D71498
We invalidate for more things than just frames advancing (if we are redecoding and still showing the same frame as before discarding for example). So there is no reason that the dirty rect and a frame being advanced should be linked.
Differential Revision: https://phabricator.services.mozilla.com/D71483
This is actually a one line change. The rest is just removing unneeded parameters.
The composited frame used to be valid for animations that had finished because we saved a separate composited frame, and since the animation had finished it was the final frame, so it had to be valid to display.
Now we don't have a separate composited frame so we only have a valid frame to display if we've decoded up to the current frame. For non-finished animations RequestRefresh will clear mCompositedFrameInvalid, but for finished animations we have to clear it, the easiest place is when we know we are fully decoded.
This problem caused img.decode to never fulfill or reject because we never sent out any frame update notifications because mCompositedFrameInvalid was always false because mAnimationFinished was always true. So we didn't get the invalidation that flipping mCompositedFrameInvalid to false when a full decode finished would cause.
Differential Revision: https://phabricator.services.mozilla.com/D70838
Cleanup the visibility of members and methods to better reflect what is and
isn't internal details. Move the XDR signature to exist only within the
JSScript.cpp file.
Depends on D71467
Differential Revision: https://phabricator.services.mozilla.com/D71469
Move the flag definitions to the enums header, but leave the wrapper types in
SharedStencil.h since they are less universal.
Differential Revision: https://phabricator.services.mozilla.com/D71467
The `request-blocking-enable-bar` has no `display: flex` and a
fixed height with overflow hidden. As a result of this, the add
button that shoulf have been placed next to the enable option
was pushed down out of view.
As a result, the add button was hidden for quite some time.
Based on the discussion in the bug report, it was decided to
remove the button altogether because a simple enter does the job
and user didn't seem to notice it missing thus proving it didn't
hinder the user experience.`
Differential Revision: https://phabricator.services.mozilla.com/D71269
We invalidate for more things than just frames advancing (if we are redecoding and still showing the same frame as before discarding for example). So there is no reason that the dirty rect and a frame being advanced should be linked.
Differential Revision: https://phabricator.services.mozilla.com/D71483
This is actually a one line change. The rest is just removing unneeded parameters.
The composited frame used to be valid for animations that had finished because we saved a separate composited frame, and since the animation had finished it was the final frame, so it had to be valid to display.
Now we don't have a separate composited frame so we only have a valid frame to display if we've decoded up to the current frame. For non-finished animations RequestRefresh will clear mCompositedFrameInvalid, but for finished animations we have to clear it, the easiest place is when we know we are fully decoded.
This problem caused img.decode to never fulfill or reject because we never sent out any frame update notifications because mCompositedFrameInvalid was always false because mAnimationFinished was always true. So we didn't get the invalidation that flipping mCompositedFrameInvalid to false when a full decode finished would cause.
Differential Revision: https://phabricator.services.mozilla.com/D70838
RawWordField had to be split in RawWordField (writer takes uintptr_t) and
RawPointerField (writer takes `const void*`).
Differential Revision: https://phabricator.services.mozilla.com/D71309
Justin Wood
aarushivij
Kershaw Chang
Emilio Cobos Álvarez
Bingjing Yan
pbz
Tim Huang
Sebastian Streich
Stefan Hindli
Christoph Kerschbaumer
Jeff Muizelaar
Mihai Alexandru Michis
Paul Bone
Timothy Nikkel
Ted Campbell
Daniel Varga
Arash Fotouhi
alex
Kriyszig
Makoto Kato
Logan Smyth
Gijs Kruitbosch
Markus Stange
Tom Schuster
Jan de Mooij
Cosmin Sabou
Bogdan Tara