To avoid unnecessary cloning of nsIInputStream, add a hasPostData
boolean attribute to tell whether a nsISHEntry has populated postData.
Differential Revision: https://phabricator.services.mozilla.com/D173237
Add activeSessionHistoryEntry attribute to CanonicalBrowsingContext to
expose the existing implementation of
CanonicalBrowsingContext::GetActiveSessionHistoryEntry.
Differential Revision: https://phabricator.services.mozilla.com/D173235
Before this patch, these tests compare the string "CLIP" used as a green rect's
clip-path, with the reference case just being plain green text. Unfortunately,
there's no guarantee that the text's antialiased fringes will produce precisely
the same rendered result, when comparing these two modes of rendering; so this
setup can produce some spurious test-failures, with large numbers of
mismatching pixels along the antialiased edges of the characters.
The Ahem font can help here, by reducing the amount of curves and antialiasing,
and by removing the choice-of-default-font as a source of cross-browser &
cross-platform variability in these tests.
So: this patch switches these tests to use the Ahem font, with a reduced
font-size (and standard font-weight) to keep the string approximately the same
length. I've also adjusted the text's y-position in some of the tests (the
"text-over-a-polygon" tests), so that it's easier to visually distinguish the
bar of Ahem text from the polygon. I've also changed the test to use "X" as
the only rendered character, since it's specially defined to produce a square
glyph, per https://web-platform-tests.org/writing-tests/ahem.html
With this patch, these tests pass in Firefox, with no fuzzy annotation required.
Differential Revision: https://phabricator.services.mozilla.com/D173917
Bug 1734020 already extended the overall timeout for the test suite in verify mode, but individual tests remained capped at their initial timeout value.
This changeset aims to multiply the timeout by 2 for individual tests when MOZ_CHAOSMODE=0xfb is set in the environment variables.
Differential Revision: https://phabricator.services.mozilla.com/D173930
In Bug 1815557 we set a display:grid on a rule that
matched both the pseudo-class panel and the class
toggle one.
We don't want to make change to the class toggle
panel, so we revert the changes to only apply them
to the pseudo-class panel.
Differential Revision: https://phabricator.services.mozilla.com/D173861
Automatic update from web-platform-tests
Fix console error in anonymous-iframe/worker-cookies SW test
Fixes the following console error that appears when running
anonymous-iframe/worker-cookies.tentative.https.window.html?worker=service_worker:
CONSOLE ERROR: Uncaught (in promise)
ReferenceError: add_completion_callback is not defined
Bug: None
Change-Id: I613b8adf0105d0798c6807896437d12f3c10e22e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350542
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119288}
--
wpt-commits: 1b93b258c8257e5361c2f41c7dd1b1a9e43f8dea
wpt-pr: 39073
Automatic update from web-platform-tests
BiDi: consolidate BiDi fixtures in webdriver/tests/support/fixtures_bidi
This fixtures file is already globally included in
webdriver/tests/conftest.py via `pytest_plugins`.
Stop having webdriver/tests/bidi/conftest.py be a duplicate of the
support fixture.
--
wpt-commits: 969b345fb0c50a5fff56ea3a081629fd95c24ff9
wpt-pr: 38732
Automatic update from web-platform-tests
[@scope] Allow CSSNestingType::kScope without having a parent rule
Scopes without a <scope-start> selector are scoped to the owner node's
parent. The selectors within such @scope rules should parse according
to the behavior of CSSNestingType::kScope (i.e. relative rules allowed,
implicit :scope descendant if needed), even though there is no
parent rule. Therefore this CL changes CSSSelectorParser to check
for `nesting_type` instead of `parent_rule_for_nesting` when setting
the initial value of in_nested_style_rule.
Bug: 1280240
Change-Id: Ie8d90b8ef059e519919b89a13b93d340d0917d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345880
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119277}
--
wpt-commits: e9ef5fdaa91bd718b3479f437015d5c82dce85ea
wpt-pr: 39050
Automatic update from web-platform-tests
[@scope] Enable nesting features within @scope's body
This CL passes a parent rule and accompanying CSSNestingType
to the ConsumeRuleList call which handles @scope's body. This has
the following effects:
- A :scope descendant compound is implicitly inserted if the selector
is not scope-containing.
- The parent selector (&) now refers to the <scope-start>
selector list.
- Relative selectors are enabled.
The code to resize the arena in ConsumeStyleRule must now be detached
from whether or not parent_rule_for_nesting is nullptr. This is because
we can now enter ConsumeStyleRule with parent_rule_for_nesting!=nullptr
without another call to ConsumeStyleRule below us on the stack
(via ConsumeScopeRule).
Bug: 1280240
Change-Id: Ibe6b1e40e22d535a094b0ec464ae119952b015f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4272459
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119257}
--
wpt-commits: 00b9747943d4c008b366cb42a2b50d5717189e0e
wpt-pr: 39005
Automatic update from web-platform-tests
Drop Python 3.6 support from tools/
This replaces the 3.6-based CI jobs with Python 3.7, and drops 3.6
from test configurations.
It also updates requirements files that have specific pinned package
versions for 3.6, but does not attempt to update dependencies in
general (either through requirements or pinned).
--
wpt-commits: 8cf108d380ee91ef2667a05dd2389ad5cd6d6529
wpt-pr: 38911
Automatic update from web-platform-tests
LayoutMedia: Should not handle OOF boxes
After LayoutMediaNGContainer task, LayoutMedia could be a container of
its OOF descendants, but NGReplacedLayoutAlgorithm has no ability to lay
out OOF boxes.
This CL fixes the issue by making LayoutMedia children OOF containers
by forcing paint containment.
Bug: 1425520
Change-Id: I19e10c9a94341cba376883bf544ef69ea413dca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349736
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119211}
--
wpt-commits: 78f0f7dfccc8ea071919199e9c36d0dc87c8b19f
wpt-pr: 39076
Automatic update from web-platform-tests
Include Ahem in mask-text-001.svg and reference
This test references Ahem, but never includes the stylesheet.
--
wpt-commits: 1a963a601aa0ce5dd7eb88cd70af32f38f5307d0
wpt-pr: 39074
Automatic update from web-platform-tests
view-transitions: Ensure elements in the transition are stacking contexts.
This change ensures that the rendering constraints added by
view-transition-name continue to apply even if the property is removed,
if they are participating in an ongoing transition.
Change-Id: I8eb485233eefe1282baf15eb8bbdbd6a42f14f02
Fixed: 1424312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4343032
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119071}
--
wpt-commits: 2bf9cc74a8b58bb0af9ae9d31f9919e8a3b56205
wpt-pr: 39063
Automatic update from web-platform-tests
Fix a TextIterator crash in Greek text-transform
CSS text-transform can change text length in either ways, resulting in
more or fewer characters in LayoutText. The former case is more well
known and has been largely worked around.
Now that we see the latter case being possible, this patch works around
it in TextIterator to avoid reaching a NOTREACHED().
Fixed: 1424324
Bug: 750990
Change-Id: I4b8ba886bcacc06e9e491badb30af98d0f22c37c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351287
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119018}
--
wpt-commits: ceb972b009e1b43c589dce3f36b050121493d2e0
wpt-pr: 39064
Automatic update from web-platform-tests
De-flake two tests
These tests were timing out because window.screenX and window.screenY
were never set during the test run, leading to the code to wait 15
seconds before giving up trying to find them. But once it gave up,
it got the correct result, because there is no expected_screenX
or expected_screenY for these tests anyway.
Tests are:
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-width.html
Fixed: 1048149
Change-Id: I9e9620254b0e9284923e7a683213b1c0721ffc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347589
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118959}
--
wpt-commits: cb19b01d65d9677bf53223322e32211c190eee5c
wpt-pr: 39060
Automatic update from web-platform-tests
[anchor-position] Make `anchor` attribute work for non-popovers
This patch reimplements how we mark elements that are implicit anchors.
Previously it was only marked for popover element's implicit anchors,
and now it works for all implicit anchors. This is done by a new class
AnchorElementObserver that observes all possible changes in implicit
anchor and replaces the old PopoverAnchorObserver.
This patch also reveals two existing issues:
1. Element::GetElementAttribute() may return non-null result even if
the element is out of tree scope. As fixing the bug is out of the
scope here, this patch just works around it. crbug.com/1425215 was
filed.
2. popover-anchor-idl-property.html has some bugs that made it pass
previously. This patch fixes those bugs.
Fixed: 1417346
Change-Id: I798977ab1ed7df0c528b7eb98c64fc04476e6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338487
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118933}
--
wpt-commits: e1dabe08c494d1b7aaf5e2e9437b71e51997c299
wpt-pr: 39041
Automatic update from web-platform-tests
[anchor-position] Use scroll-adjusted IMCB for position fallback
Previously, we've been using the inset-modified containing block for
position fallback, which doesn't work well with scrolling.
This patch fixes the issue by using the scroll-adjusted IMCB instead,
which was introduced earlier on the spec side [1].
As an implementation detail, this patch also calculates and stores
the non-overflowing scroll ranges [2] for each fallback position, so
that we can still use composited scrolling, and need to invalidate
layout only when we have scrolled out of that range.
This patch also adds WPT tests under various writing modes and
directions to cover all the new code paths.
[1] https://drafts4.csswg.org/css-anchor-position-1/#determine-the-position-fallback-styles
[2] https://github.com/w3c/csswg-drafts/issues/8059#issuecomment-1444616906
Bug: 1418725
Change-Id: If9e104c6ac3c51ccdfc4fa7d3cf9cbffcc5af46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292618
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118926}
--
wpt-commits: e2169b6b0b5ca89b61b976f512e9ad52bace8597
wpt-pr: 38998