This is the only version of lodash that actually ships with Firefox.
We have some package.json files that also reference lodash but they are used for tests only.
Differential Revision: https://phabricator.services.mozilla.com/D39223
--HG--
extra : moz-landing-system : lando
When the browser session is remote controlled, a visual cue is
shown to the user by turning the background of the address bar
striped yellow. This is to warn the user that it is not safe to
use this session for any sensitive browsing.
With the relatively recent addition of the tracking protection icon
to the far-most left of the address bar, the orange background is
broken off by the white background of the identities box. This gives
a slight inconsistency when the browser is under remote controlled
(i.e. when --marionette is passed).
This patch removes the white background of the identities box so
that the striped orange background covers the entire surface of
the address bar. This gives a slightly more coherent visual impression.
Differential Revision: https://phabricator.services.mozilla.com/D40037
--HG--
extra : moz-landing-system : lando
On Windows in Python 2, the subprocess module requires the use of bytes with
the 'env' argument. For that reason, we would sometimes use byte strings with
'os.environ' like so:
os.environ[b"FOO"] = b"bar"
However, this is a failure with Python 3 as 'os.environ' must only be used with
the text type. This patch creates a new 'setenv' helper that ensures we create
new environment with 'bytes' on Python 2, and 'text' on Python 3.
Differential Revision: https://phabricator.services.mozilla.com/D38237
--HG--
extra : moz-landing-system : lando
We don't need this margin since the layout of the identity icon has been
updated. And we change the 'margin-inline-end' to make the spaces
between magnifying glass icon balanced.
Differential Revision: https://phabricator.services.mozilla.com/D39976
--HG--
extra : moz-landing-system : lando
This provides the basic functionality, but certainly not all the bells and whistles. Future work may add summaries and totals, better reftest support, better web-platform support, more flexible filtering, etc.
Differential Revision: https://phabricator.services.mozilla.com/D39224
--HG--
extra : moz-landing-system : lando
It could lead to a ref-cycle leak if it was added as listener to a
MediaStreamTrack but the underlying track in the graph was never created, so
that the TracksCreatedListener never received NotifyOutput or NotifyRemoved
events.
Differential Revision: https://phabricator.services.mozilla.com/D39658
--HG--
extra : moz-landing-system : lando
This is inherently large, because modifying these bits of DOMMediaStream and
MediaStreamTrack affects all consumers and producers of all DOMMediaStreams and
MediaStreamTracks.
Things are generally much simpler now.
Producers of tracks now create a MediaStream in the graph, add it to a
MediaStreamTrackSource subclass that takes ownership of it, and add the source
to a MediaStreamTrack. Should the producer need a DOMMediaStream it is now much
simpler to create as the only thing needed is the current window. The stream is
a rather simple wrapper around an array of MediaStreamTracks.
HTMLMediaElement is still not as straight forward as other consumers since it
consumes the DOMMediaStream directly, as opposed to a set of tracks.
The new MediaStreamRenderer helper class helps bridge the gap between this fact
and the new track-based MediaStreamGraph interface, as it needs to juggle
registering multiple audio tracks for audio output. This hooks into existing
HTMLMediaElement logic and brings a welcome simplification to all the glue
previously needed there.
Differential Revision: https://phabricator.services.mozilla.com/D37934
--HG--
extra : moz-landing-system : lando
This ensures all clones of the original track also receives the new muted state.
Differential Revision: https://phabricator.services.mozilla.com/D37933
--HG--
extra : moz-landing-system : lando
Normally a track in mUpdateTracks is cleared by ExtractPendingInput, when that
track's ending is processed. However, if the SourceMediaStream is destroyed
before an ended track is processed, the track including it's buffered segment
in mUpdateTracks will leak until the SourceMediaStream is destroyed.
This might not be until late XPCOM Shutdown when the cycle collector shuts down,
which is too late to release graphics resources.
Depends on D37931
Differential Revision: https://phabricator.services.mozilla.com/D37932
--HG--
extra : moz-landing-system : lando
A legit case that fails this assert is:
- CloseAudioInput() on main thread for last non-webaudio MediaStream
- AudioContext closes on main thread
- CloseAudioInputImpl() on graph thread sets next driver to an output-only audio
driver since there are AudioNodeStreams still present
- AudioContext's Close operation is applied on graph thread, first all
AudioNodeStreams are suspended, making the graph consider itself as having no
audio tracks present. Then we check the next driver, which is an audio driver
per above. This fails the assert.
Differential Revision: https://phabricator.services.mozilla.com/D37931
--HG--
extra : moz-landing-system : lando
So that paint doesn't reenter on layout, or mess with incomplete frame trees, or
what not.
I just early-returned rather than only skipping the PaintWhileInterruptingJS
call because I don't think we should be running untrusted scripts in the first
place when IsSafeToRunScript() is false.
Differential Revision: https://phabricator.services.mozilla.com/D39913
--HG--
extra : moz-landing-system : lando
Writing disabled: if foo was a common mistake. The easiest fix is just to
require that 'if ' at the start of a string is quoted (one could also
fix this by interpreting these as real conditions, but that would be
more involved, and this fixes the immediate problem of invalid metadata).
Depends on D4952
Differential Revision: https://phabricator.services.mozilla.com/D4953
--HG--
extra : moz-landing-system : lando
This fixes the cases where we had an if condition on the same line as
as a key, which ends up with the condition being treated as a string.
Differential Revision: https://phabricator.services.mozilla.com/D4952
--HG--
extra : moz-landing-system : lando
See https://github.com/whatwg/html/issues/4810.
I accidentally changed its behavior in bug 1547985 due to an embarrassing typo.
Turns out that my typo made us follow the spec, but the spec is not what we or
anybody else implemented. Fun times. I added a test accounting for the proposed
spec change.
There's a different divergence between what does abscenter map to. Other
browsers don't map `abscenter` at all, looks like, but it's in the spec.
We may want to remove it, but for now I've left it in the test.
Differential Revision: https://phabricator.services.mozilla.com/D39928
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Update webxr_test_asserts and align xr layout_tests usage of asserts
Updates webxr_test_asserts with chromium's more verbose asserts for
easier debugging of tests, and removes the asserts from xr-test-utils
so that all asserts can be referenced from webxr_test_asserts.
Bug: 985156
Change-Id: Ie8d2ca70dd18a7e1759fe2b4d83b02076fcf91c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715916
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680180}
--
wpt-commits: b94e0af56342652cf059d085758b0a229f3a38fb
wpt-pr: 18012
Automatic update from web-platform-tests
Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky
Replacing the getElementById by the creation of a new element to ensure
that the test will not be flaky.
Changing also the name of the function to be coherent with the test itself.
Bug: 978554
Change-Id: I8848b18f6d7f6201cce57069c5f4047d4d2f61e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693189
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677456}
--
Fix promises in tranferFromImageBitmap-ToBlob-offscreen.html
The test previously used promises incorrectly:
testTransferFromImageBitmapToBlobOffscreen did not return the promise
produced by convertToBlob up to promise_test, which caused the assertion
(inside testCanvas) to flakiy escape promise_test. In addition, the test
did not wait for pngImage to load before drawing it to canvas.
This change also fixes the name of the test to be more accurate
(transferToBlob -> convertToBlob).
--
wpt-commits: 88a0c99744a4941af3907dfbb3853e3c23b00f04, 811dc186a0946a67e2b1ae59c0e92ccfeb69371d
wpt-pr: 17747
Automatic update from web-platform-tests
[LargestContentfulPaint] Add type to supportedEntryTypes
This CL adds 'largest-contentful-paint' to PerformanceObserver's
supportedEntryTypes, and adds a test. It also fixes a typo in the
LayoutShift supportedEntryTypes test title.
Bug: 965505
Change-Id: I6954f8abbdf27640413d790e05ff72aa945a248b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713295
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680131}
--
wpt-commits: 2e53b93235999c9c9272859c2b2beadb96ef1f09
wpt-pr: 17975
Automatic update from web-platform-tests
Fix WebGLLayer test expectations
The xrWebGLLayer tests didn't have their expectations wrapped in t.step
so their failures were reported as timeouts, rather than the actual
error.
xrWebGLLayer_viewports expected the device init viewport to match the
output viewport, which is not a specced behavior, and contradicts the
webxr-test-api spec which calls this out as unsupported, so that part
has also been reverted.
Bug: 986672
Change-Id: I23713956f6b0bd3d432f0e6e6fdc9d015d509099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715237
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680125}
--
wpt-commits: 66cf52a5ffde8f409ebef4052ec0d1f30383875d
wpt-pr: 18004
Christian Holler
Julian Descottes
Honza Bambas
jaril
André Bargull
Kendall Werts
Andreas Tolfsen
Dão Gottwald
Andreas Pehrson
Tooru Fujisawa
Joel Maher
Andrew Halberstadt
Tim Huang
Nupur Baghel
Florens Verschelde
Geoff Brown
Liang-Heng Chen
Florin Strugariu
Emilio Cobos Álvarez
James Graham
Brindusan Cristian
Olli Pettay
Mihai Alexandru Michis
moz-wptsync-bot
autofoolip
Alex Cooper
Juanmi Huertas
Jack Steinberg
Nicolás Peña Moreno