This patch changes our Windows file-description metadata from "Firefox" to "Mozilla Firefox" in order to work around an issue on Windows 10.
To be clear: This patch does NOT change any branding normally presented to a typical user. Short of attaching a debugger, the only way to see this change is to right-click firefox.exe and choose Properties then Details.
We're doing this because Windows 10 ships with an appcompat fix called DamThrottleControl that applies to any firefox.exe with product name and description equal to the string "Firefox". I have no idea what that fix was intended to do, but Nightly and DevEdition appear to be doing fine without it. In any case, the appcompat fix comes with the side effect of loading user32.dll very early in our process, which allows AppInit_DLLs to sneak in before our blocklist initializes. That's bad (and it fails a mochitest). This patch evades the Windows appcompat engine by making us no longer match the string that it's testing for.
--HG--
extra : rebase_source : b4d09da3e49233b72b58725e20480b3999a02989
The various getters and setters are in a confusing order. This patch puts them
in a more sensible order. It also streamlines the comments, which were
generally low-value and in some cases incorrect.
MozReview-Commit-ID: 3ngzZDSt0JI
--HG--
extra : rebase_source : 8a5a66f65621889483d2df9f4487194172f70804
In an attempt to make the code that renames shortcuts during PostUpdate more
reliable, this patch switches to renaming the existing shortcut files instead
of deleting them and creating new ones, removes unused code dealing with icons,
and deduplicates the code by adding a new macro.
MozReview-Commit-ID: EnE2dGrunx2
--HG--
extra : source : 7173059b5ccfc60c86e1a1106b5c572e188d5fea
In some places, editor computes index from child node for collapsing selection
at the child node. However, it's expensive. Therefore, editor should use
Selection::Collapse(const RawRangeBoundary&) as far as possible.
MozReview-Commit-ID: LF2MwASuXzZ
--HG--
extra : rebase_source : b7afc35c0d9d88845391b6f18de57cbff1935ae4
Selection should have Collapse() methods which take RawRangeBoundary instead of
a set of container and offset in it. Then, if caller know only child node but
doesn't know offset in the container, neither callers, Selections nor nsRange
needs to compute offset. This makes them avoid calling expensive method,
nsINode::IndexOf().
MozReview-Commit-ID: 79IRajLe1FE
--HG--
extra : rebase_source : a8ce52ff1654974461d5ecfed98b73d9cca34133
Update our in-tree copy of libogg to the latest upstream release.
This fixes an issue handling corrupt streams when packets are
continued between framing pages, along with some minor portability
fixes.
MozReview-Commit-ID: 3Vixrru4gLV
--HG--
extra : rebase_source : be30a403c32ec777c57ca95fcc642abf875188ae
For local runs it can be helpful to skip tests are expected to time
out. This adds a --skip-timeout flag that will skip tests that are
expected to time out on the current platform.
It doesn't solve the problem that the metadata might be over-specific
in the case that the expectation data isn't universal across all platforms.
MozReview-Commit-ID: 7S4EsVKv33P
--HG--
extra : rebase_source : 7e18bbcefc7350465bae799c27454a13da64a32e