This permission was added in API 16, and is only enforced in API 19+.
(It's benign to add it to APKs installed on API 15.)
We want to declare it explicitly so that the bouncer APK and the main
APK have the same permission set. There appears to be some fanciness
with Gradle's implied permission system where the bouncer APK does not
request READ implicitly where-as the main APK does request READ
implicitly. This just makes things explicit (and uniform).
MozReview-Commit-ID: LBblAPa0duV
--HG--
extra : rebase_source : 616fa58ccd9063088abb14240265a20ac4e48da7
extra : histedit_source : abf6211896e99cc7b53f9c36714d056f0d44d63f
In the wild, the Robotium Maven dependency is not being fetched.
Let's see if this forces it to be downloaded.
MozReview-Commit-ID: 3Fhm4Aj40Jp
--HG--
extra : rebase_source : 7b1071ef36ff4600e303ac9e0c7dc0b998fad705
extra : histedit_source : 6568e7aa28e60897b8fe96904dcb2bc296945222
Pinned sites should be deleted directly, however I'm not confident enough
in my knowledge of sync to be certain that we won't end up with deleted
pinned sites in our table.
(We use normal bookmark deletion for removing pinned sites.)
MozReview-Commit-ID: SSLDkSXWlI
This fixes an edge case that is most likely to happen to new users if they pin a site followed
by removing one or more suggested sites. This results in the topsites table containing
less sites than needed, leading to some pinned sites being displayed in a higher
than expected position. This also broke unpinning since our code assumes
that a topsites physical position corresponds to its DB position (which prior
to this patch was not the case).
MozReview-Commit-ID: JgTUa55eXnz
This variable was renamed to be positive instead of negative but the value/usage wasn't adapted.
MozReview-Commit-ID: H1DeZMmvTXC
--HG--
extra : amend_source : a83d5ae3f1c7525031c17cdb4fa0f4950f6aa7c2
The queue of pending block indexes was implemented using nsDeque where
item pointers were perverted into pure 32-bit numbers, causing a size
mismatch on 64-bit platforms, which was picked by VS2015.
Note: We're using a deque because we need to implement a 'contains' method,
which would be unreasonably-difficult with a pure queue.
MozReview-Commit-ID: HpDBIwgSs9
--HG--
extra : rebase_source : d396e7677a51cac787202dd63653890f19626bf8
This MANIFEST.in contained the wrong file name,
external-media-tests-requirements.txt rather than requirements.txt.
MozReview-Commit-ID: A0zJihjoxzf
--HG--
extra : rebase_source : ddc462d754d234af04ed5a37885b89f9187a3942
DONTBUILD CLOSED TREE
--HG--
extra : rebase_source : 25f0600425dec249f838ed221dde71d401571eb9
extra : amend_source : 49f7ccab9e47083df9e8b7776acc6de73a880473
I don't think we can rely on the bookmarks being created in a specific order, although that mostly seems to happen,
so rather than check for an exact list of bookmarks returned from getRecent(), we can just check that the bookmarks
we get back are in reverse chronological order and that the 4 most recently created bookmarks are returned.
MozReview-Commit-ID: DhT7raJRe7N
--HG--
extra : transplant_source : 8%24%A6%3F%87%CD%17M%EC%B0%C4%3A%F3iP%EB%BA%DE%B5%F4
Gijs Kruitbosch
Brian Grinstead
Nick Alexander
James Long
Andrzej Hunt
Carsten "Tomcat" Book
Phil Ringnalda
Karl Tomlinson
Greg Weng
JerryShih
Nick Fitzgerald
Michael Ratcliffe
Gabriele Svelto
Sebastian Kaspari
Victor Porof
JW Wang
Thomas Nguyen
Gerald Squelart
Ceridwen
Benjamin Peterson
Alessio Placitelli
Franziskus Kiefer
bsilverberg
Nick Thomas
Paolo Amadini