<!-- Please describe your changes on the following line: -->
Adding a `--progress` flag to git commands in test-perf to try to avoid the timeouts we're seeing at http://build.servo.org/builders/linux-nightly/builds/581/steps/test/logs/stdio
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 8c1af9cce7197104dda76873be6c713e0b0d3866
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7a1d217d458222e072c59547947912a519e028d5
It was added in bug 683127 as a forced include for nspr, and
accidentally became unused after bug 1230117, but it turns out that all
versions of Android we care about nowadays (and probably back then) now
support dladdr.
--HG--
extra : rebase_source : 024244627c215de2d35e2f4595b7612eb1723996
When looping through the debugger helper links during our
dl_iterate_phdr implementation, we effectively race with other threads
dlclose()ing libraries while we're working.
We do have a (rather involved) check in place to ensure that elf headers
are readable. But it turns out in practice, some dlclose() do happen
between the check and the actual read of the elf headers.
Unfortunately, we can't lock the system linker while we're looping, so a
better approach is to only loop through the libraries we loaded, and
rely on the system dl_iterate_phdr to iterate over the (remaining)
system libraries.
Unfortunately (again), Android versions < 5.0 don't have a system
dl_iterate_phdr, so we have to rely on the old iterator when it's not
present.
--HG--
extra : rebase_source : 3fd07589ed1939411ef72f481b7c72f761d53701
We're going to introduce two code paths that need to fill dl_phdr_info
from different iterators, so first move the code to a separate class,
that both code paths will be able to call.
--HG--
extra : rebase_source : a50663ad8d15d4f7a28d7138824003df5edd7f1c
The same exists in mozilla/MacroArgs.h, avoiding a macro redefined warning
when building on non-Android.
--HG--
extra : rebase_source : 6e3502ddf9deb96b29e3663f5867f852a2912401
This fixes InspectorUtils.getCSSValuesForProperty to return the
correct values for box-shadow and text-shadow. It also takes a small
step toward the goal of getting rid of
InspectorUtils.cpp:PropertySupportsVariant, in favor of having all
variants listed in nsCSSPropList.h.
MozReview-Commit-ID: Dwh5s0IvYTX
--HG--
extra : rebase_source : eba2d3e7337af63c264bf3d596740f311c4aa017
This is a minor cleanup to test_bug877690.html that factors out the
list of colors into a separate variable, to make future tests a bit
simpler to write and understand.
MozReview-Commit-ID: JkSBJQxLdxW
--HG--
extra : rebase_source : 3398c07bc582b678184a08962c5066bc65729510
The initial motivation for this patch, was to prevent command lines that are
too long on Windows. To that end, there is a cap to the number of paths that
can be run per job. For now that cap is set to 50. This will allow for an
average path length of 160 characters, which should be sufficient with room to
spare.
But another big benefit of this patch is that we are running more things in
parallel. Previously, mozlint ran each linter in its own subprocess, but that's
it. If running eslint is 90% of the work, it'll still only get a single
process. This means we are wasting cores as soon as the other linters are
finished.
This patch chunks the number of specified paths such that there will be N*L
jobs where 'N' is the number of cores and 'L' is the number of linters. This
means even when there's a dominant linter, we'll be making better use of our
resources. This isn't perfect of course, as some paths might contain a small
number of files, and some will contain a very large number of files. But it's
a start
A limitation to this approach is that if there are fewer paths specified than
there are cores, we won't schedule enough jobs per linter to use those extra
cores. One idea might be to expand specified directories and individually list
all the paths under the directory. But this has some hairy edge cases that
would be tough to catch. Doing this in a non-hacky way would also require a
medium scale refactor.
So I propose further parallelization efforts be destined for follow-ups.
MozReview-Commit-ID: JRRu13AFaii
--HG--
extra : rebase_source : 242fb71fe0af8bd2a981bd10a7216bb897fe00ac
This allows it to be used as an expression, which I'd like to do very soon.
Source-Repo: https://github.com/servo/servo
Source-Revision: 5355265c7481ef5f1a9d869927ad8bb1d8d8357b
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9b23c993998c53ed11530072ad6a92beae158a07
Downstream npm package already depends node package, no need to
specify it explicitly. Also, node package refers to the latest NodeJS
but npm package can be built against an older version.
MozReview-Commit-ID: KeuSFEKeStw
--HG--
extra : rebase_source : ac3ab14519f4edd8bcb5b77cad64eeaed16d2751
Dispose the native call queue when disposing a window object, so we
don't end up with stale calls in the queue that can cause crashes.
MozReview-Commit-ID: J1HNOXKAX6E
--HG--
extra : rebase_source : 9a3ec940c19513d29c692d4e550fa3fd046d73f9
Respect MOZ_DISABLE_GMP_SANDBOX so that the GMP sandbox
can be disabled from the command line.
MozReview-Commit-ID: HLHQ6ImrzGe
--HG--
extra : rebase_source : 54335b6f612f5b09e2680ec6e6dee70f37a99e2b
Have `./mach boostrap` update users to at least rust 1.23.0,
which is the current stable release.
MozReview-Commit-ID: 7ukx7shu07e
--HG--
extra : rebase_source : 82ea7fd65901f0e9e00e961d157cf113d82b1d4e
The underlying issue here is that the pres shell was already being torn down
when we flush.
The less risky change here is to just change the assertions instead of
IsSafeToFlush too, but the !isSafeToFlush || mViewManager assertion was also
firing already, because we null out the view manager from Destroy.
So this change is effectively idempotent behavior-wise (we tighten a bit the
view manager assertion, but that should be fine).
Just let me know if you want me to just loosen the assertions, but I think the
IsSafeToFlush change is nicer too.
MozReview-Commit-ID: 240qLlLi7RE
--HG--
extra : rebase_source : df5dacb849a93e62f90e278c0d99f1034b341b79
Don't use the parent node options when creating new folder nodes, since they should retain
their original options.
Additionally, we can filter nodes in the queries rather than building a lot of nodes that
will be filtered out.
MozReview-Commit-ID: MmlGDe5QgV
--HG--
extra : rebase_source : 66eea325825007266e08424630b092b9e8d75b67
The current specifications for installation of Servo in Arch Linux fails to run due to requirement of fonts.
The fix is just to include the required package in the required dependencies list in README.md.
<!-- Please describe your changes on the following line: -->
I added the required font package for Arch Linux in the README file. This is in accordance with the comments on the bug #12107, which deals with similar requirements for Gentoo
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because - The changes are in README file
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 47b3693d7564b32813746c1dbb6ef29dbb08ffaf
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4f4e37887cd4f1b5c03608067f8c59ab140fb038
Updating to latest devtools-launchpad add adding the
disablePostCSS option fixes the postCSS errors.
Remove the netmonitor from babelExclude and add the
rewrite-lazy-getter loader fixes the issues about the use
of the object spread operator.
MozReview-Commit-ID: 4wRHuR4q7fz
--HG--
extra : rebase_source : c94063664063ba18d2bb466e99519e701707d6e6
It's causing problems on arm and mac builders and making it impossible to land changes.
Source-Repo: https://github.com/servo/servo
Source-Revision: 4089e388dd0f98dea3af8ee367c9deb4cfb0e26a
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 24d95edc91070d6ef0adedce6650d15724bfd867
The WebDriver Element Send Keys command is meant to run the HTML
unfocussing steps after clearing the element. When HTMLElement.blur()
is called on the root document element (<html>) it is the <body>
that is in focus when the unfocussing steps have run.
The same applies in the case of typing into an <iframe> element.
The controlling element of the <iframe> is the <body>, as this is
the element ath will receive focus should you blur the frame.
MozReview-Commit-ID: 19Ox3W9CF8O
--HG--
extra : rebase_source : fe0f3c1f035908a1a9581c2e28749b387db471a5
A couple of commands were not running the appropriate unfocussing
steps as the WebDriver standards says they should.
MozReview-Commit-ID: FyuRvkct19m
--HG--
extra : rebase_source : fe37727126a6907f6182d166a035b4f368118df9
Instead of generating custom focus events when interacting with elements,
we can run the HTMLElement.focus() function will do the correct thing.
Before this patch we only simulated focus events, whereas this
patch will actually focus the element.
MozReview-Commit-ID: IoBV2ngqOA5
--HG--
extra : rebase_source : c133a8ac7fc91dfa373a9d8adbc3f30d2441c46d
Renames the interaction.focusElement, which also happened to move
the caret in textual form controls, to interaction.moveCaretToEnd,
focussed solely on moving the caret. It doesn't make sense to
coalesce these two operations into one function.
MozReview-Commit-ID: 2QxV8FllW8J
--HG--
extra : rebase_source : f95973c3bd5759d4b60467f88720ea66c0511873
We must close cache iterators before shutting down CacheIndex because they hold reference to CacheIndex which causes that CacheIndex is not destroyed when it's dereferenced in CacheIndex::Shutdown.
--HG--
extra : amend_source : d74243f4eb4f4073ecc72ac9b331091456a91504
The original logic I wrote had the condition backwards.
MozReview-Commit-ID: IFIS8vZLgd4
--HG--
extra : rebase_source : 9f9baeb2f6284c551fb63f139d6f5942569890fd
This demotes a MOZ_RELEASE_ASSERT in the SAB case for SC write to a
run-time check. The reason is that the clone policy must conform to
the clone scope, specifically, if the scope is DifferentProcess then
the policy must deny SAB.
The check was an assert previously because we mistakenly thought that
we controlled all the callers, but we do not - the TestingFunction
serialize() has a permissive API and instead of adding a lot of
complexity there we should change the assert to a run-time check. The
code is more resilient as a result anyway.
Also document this quirk in the SC header file.
--HG--
extra : rebase_source : 4b632fe57bc9ebf3f38210b1ffad11fde57befa6
Including ARM64 implementations here because they are easy, and will be
needed by the Wasm baseline compiler anyway.
--HG--
extra : rebase_source : 5baab6faed8fcd4c5b661e40ac011da051573a0a
extra : intermediate-source : 6d7fa52e38fbd7f9d106b8bbacca51d3907bd4f7
extra : source : 724822b1b806b8f7ce6af0d3891be1e4a450ffe9
Including ARM64 stubs here because it simplifies code in the Wasm
baseline compiler, and doesn't hurt.
--HG--
extra : rebase_source : 58933b501248f2f53cb88117f93662f1ae3f9bfe
extra : source : f217aeea295bac03a323917292560ba1f491b0fb
Alan Jeffrey
Mike Hommey
Robert Helmer
Tom Tromey
Zibi Braniecki
Glenn Watson
Andrew Halberstadt
Emilio Cobos Álvarez
Jan Beich
Coroiu Cristina
Jim Chen
Haik Aftandilian
Ralph Giles
Edouard Oger
Kartikaya Gupta
Marco Bonardo
Gurzau Raul
Csoregi Natalia
Thom Chiovoloni
Aki Sasaki
pandusonu2
Nicolas Chevobbe
Yury Delendik
Josh Matthews
abhinav
Simon Fraser
Andreas Tolfsen
Henri Sivonen
Michal Novotny
Tom Prince
Lars T Hansen
Julian Descottes