ec62d45a35
Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv
...
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.
Differential Revision: https://phabricator.services.mozilla.com/D89148
2020-09-08 07:40:30 +00:00
ffb37d08c1
Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89147
2020-09-02 15:03:06 +00:00
ebcfb83228
Bug 1660751 - QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88004
2020-09-08 07:40:46 +00:00
d3df072168
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in ActorsChild.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88831
2020-09-07 15:52:52 +00:00
30a12fc766
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IDBObjectStore.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88830
2020-09-07 15:52:39 +00:00
87245d7d42
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IDBDatabase.cpp; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88829
2020-09-07 15:52:27 +00:00
2620d5fb0d
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IndexedDatabaseManager.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88824
2020-09-07 15:52:19 +00:00
0acd64c691
Bug 1662119 - Replace MOZ_TRY with IDB_TRY; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88832
2020-09-07 12:24:50 +00:00
7e31de8547
Bug 1662004 - Add support for nested QM_TRY/QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88764
2020-09-07 18:00:00 +00:00
16aa57011b
Bug 1661988 - Introduce QM_DEBUG_TRY/QM_DEBUG_TRY_VAR/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88760
2020-09-07 10:05:13 +00:00
bd28698eb3
Bug 1661428 - Use CompactPair instead of Variant for trivially default-constructible V and UnusedZero E. r=froydnj
...
It seems that the clang toolchain has trouble optimizing away the tag access in
a `mozilla::Variant`. Use of a `CompactPair` seems to be better when `E` is
small (all cases where `UnusedZero<E>` is true are small right now anyway).
While this doesn't change `sizeof(Result<V, E>)` in most cases, it makes
the generated code simpler/smaller: As of now, this reduce the overall VM size
of libxul.so by ca. 59K.
Without additional effort, this requires and leads to default-construction of
a `V` even in cases where it is never accessed, so this is restricted to
trivially default-constructible `V` for now.
This could be avoided by replacing `CompactPair<V, E>` by
`CompactPair<AlignedStorage2<V>, E>`.
Differential Revision: https://phabricator.services.mozilla.com/D88393
2020-09-02 17:55:55 +00:00
eae150a880
Backed out 5 changesets (bug 1661457, bug 1661428, bug 1661497, bug 1661502) for build bustages on Result.h. CLOSED TREE
...
Backed out changeset fbf42b3b51f3 (bug 1661428)
Backed out changeset 83f3f36d540f (bug 1661457)
Backed out changeset 8a9dce0d08ce (bug 1661502)
Backed out changeset 733df139089a (bug 1661497)
Backed out changeset fca770fc0956 (bug 1661428)
2020-09-02 19:44:47 +03:00
d5f6d76c5a
Bug 1661428 - Use CompactPair instead of Variant for trivially default-constructible V and UnusedZero E. r=froydnj
...
It seems that the clang toolchain has trouble optimizing away the tag access in
a `mozilla::Variant`. Use of a `CompactPair` seems to be better when `E` is
small (all cases where `UnusedZero<E>` is true are small right now anyway).
While this doesn't change `sizeof(Result<V, E>)` in most cases, it makes
the generated code simpler/smaller: As of now, this reduce the overall VM size
of libxul.so by ca. 59K.
Without additional effort, this requires and leads to default-construction of
a `V` even in cases where it is never accessed, so this is restricted to
trivially default-constructible `V` for now.
This could be avoided by replacing `CompactPair<V, E>` by
`CompactPair<AlignedStorage2<V>, E>`.
Differential Revision: https://phabricator.services.mozilla.com/D88393
2020-09-02 16:22:25 +00:00
c2c6945169
Bug 1650257: Part 2 - Abort SetNewDocument() if ancestors are discarded/cached. r=nika,smaug,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87486
2020-08-31 18:51:56 +00:00
0a69b43f69
Bug 1661085 - Extract DeleteFileManagerDirectory function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88447
2020-08-28 15:53:30 +00:00
bb859f96b7
Bug 1661085 - Use IDB_TRY* in FileManager::GetUsage. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88294
2020-08-28 15:53:28 +00:00
90bfe94b75
Bug 1661085 - Use IDB_TRY* in FileManager::InitDirectory. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88293
2020-08-28 15:53:25 +00:00
f9af7a56bc
Bug 1661085 - Use IDB_TRY* in FileManager::GetFileForId. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88292
2020-08-28 15:53:21 +00:00
51c133be59
Bug 1661085 - Use IDB_TRY* in FileManager::AsyncDeleteFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88291
2020-08-28 15:52:14 +00:00
b682a10d50
Bug 1661085 - Use IDB_TRY* in FileManager::Init. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88173
2020-08-28 15:52:02 +00:00
0cf9a96bdd
Bug 1661085 - Use IDB_TRY_* in RemoveDatabaseFilesAndDirectory. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88172
2020-08-28 15:51:49 +00:00
c3c0a31f4d
Bug 1661085 - Change CreateMarkerFile output parameter to return value. r=janv,dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88171
2020-08-28 15:51:36 +00:00
a8d941f9a6
Bug 1661085 - Use IDB_TRY_* macros in CreateMarkerFile and RemoveMarkerFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88170
2020-08-28 15:51:23 +00:00
ed4841ca72
Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88144
2020-08-28 15:50:38 +00:00
68059713d9
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 15:50:23 +00:00
1bebc65e70
Backed out 2 changesets (bug 1660800, bug 1660816) as per Simon's request. CLOSED TREE
...
Backed out changeset 55d2e05d2e0b (bug 1660800)
Backed out changeset 7b9687fb7d41 (bug 1660816)
2020-08-28 18:45:54 +03:00
c169085c8e
Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88144
2020-08-28 10:02:33 +00:00
881d526f83
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 14:43:51 +00:00
7a010f17ae
Backed out 11 changesets (bug 1661083, bug 1661085, bug 1661084) for build bustages on ResultExtensions.h. CLOSED TREE
...
Backed out changeset 962967831dd4 (bug 1661085)
Backed out changeset 8e61a7d2daf9 (bug 1661085)
Backed out changeset 1edbc081c9f0 (bug 1661085)
Backed out changeset c640f4126079 (bug 1661085)
Backed out changeset b5fc9ebaac12 (bug 1661085)
Backed out changeset 4e3faaadccb6 (bug 1661085)
Backed out changeset 522cdd011e03 (bug 1661085)
Backed out changeset 896e47fc24e3 (bug 1661085)
Backed out changeset bf4043d4ce8e (bug 1661085)
Backed out changeset d0162bb5012e (bug 1661084)
Backed out changeset f0e7db520938 (bug 1661083)
2020-08-28 16:27:58 +03:00
df04c7c099
Bug 1661085 - Extract DeleteFileManagerDirectory function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D88447
2020-08-28 11:21:14 +00:00
39341d0546
Bug 1661085 - Use IDB_TRY* in FileManager::GetUsage. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88294
2020-08-28 10:04:30 +00:00
99af76d797
Bug 1661085 - Use IDB_TRY* in FileManager::InitDirectory. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88293
2020-08-28 10:44:55 +00:00
2757e937b4
Bug 1661085 - Use IDB_TRY* in FileManager::GetFileForId. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88292
2020-08-28 10:04:10 +00:00
f97700db1b
Bug 1661085 - Use IDB_TRY* in FileManager::AsyncDeleteFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88291
2020-08-28 10:03:58 +00:00
19b62b73d6
Bug 1661085 - Use IDB_TRY* in FileManager::Init. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88173
2020-08-28 10:03:45 +00:00
c91f35850d
Bug 1661085 - Use IDB_TRY_* in RemoveDatabaseFilesAndDirectory. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88172
2020-08-28 10:33:06 +00:00
045d96f036
Bug 1661085 - Change CreateMarkerFile output parameter to return value. r=janv,dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88171
2020-08-28 10:03:20 +00:00
557c5bf3ad
Bug 1661085 - Use IDB_TRY_* macros in CreateMarkerFile and RemoveMarkerFile. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D88170
2020-08-28 10:03:07 +00:00
f2f47372af
Bug 1659959 - Introduce QM_FAIL macro and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87633
2020-08-27 11:10:10 +00:00
4cd784c5d8
Bug 1659647 - Correctly propagate error of OpenDatabaseAndHandleBusy in CreateStorageConnection. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D87409
2020-08-18 07:41:55 +00:00
8b5b04028f
Bug 1652244 - P4. Fix test_third_party.html test failure r=timhuang
...
This testcase has:
top-level: mochi.test
1st-level: host (depend on the value in the test data)
2nd-level: mochi.test
This test run tests in the 2nd-level iframe, which is first-party with
respect to the top-level according to the new change.
The test is re-written to run tests in both 1st-level iframe and
2nd-level iframes.
Differential Revision: https://phabricator.services.mozilla.com/D86717
2020-08-12 09:11:01 +00:00
c9061686f8
Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak
...
Includes baddataDB.sqlite which is a copy of goodDB.sqlite but with what appears
to be the row count inflated beyond the end of the file. This causes loading the
database to succeed but queries to fail.
This increments a scalar for every database open and for every database query
where a query is the full execution of a statement from start to completion. If
a statement is re-used then the scalar will be incremented once for each use.
Differential Revision: https://phabricator.services.mozilla.com/D73938
2020-08-11 20:55:33 +00:00
be21687a00
Backed out changeset af815754d58a (bug 1635489) for perma failures on test_statement_executeAsync.js. CLOSED TREE
2020-08-11 00:21:05 +03:00
d49a4517e8
Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak
...
Includes baddataDB.sqlite which is a copy of goodDB.sqlite but with what appears
to be the row count inflated beyond the end of the file. This causes loading the
database to succeed but queries to fail.
This increments a scalar for every database open and for every database query
where a query is the full execution of a statement from start to completion. If
a statement is re-used then the scalar will be incremented once for each use.
Differential Revision: https://phabricator.services.mozilla.com/D73938
2020-08-10 20:09:27 +00:00
1e02318b49
Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
96f3e7e019
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
381fca9783
Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
...
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
032d2ac9d3
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
e8f3f74ef6
Bug 1656411 - Move typed array, ArrayBuffer, and dataview-related functions out of jsfriendapi.h to two new headers. r=mgaudet,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D85524
2020-07-31 16:37:27 +00:00
39831220cc
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to IDB_TRY in dom/indexedDB; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84315
2020-07-24 11:49:27 +00:00
Simon Giesecke
Jan Varga
Razvan Maries
Kris Maglione
Dimi Lee
Dave Townsend
Noemi Erli
Jeff Walden