72a5dedc24
Bug 1644379 - Add IDBResult::PropagateNotOk. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D78877
2020-06-30 10:01:58 +00:00
609f339fc5
Bug 1644379 - Align IDBResult::Unwrap with Result::Unwrap. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D78876
2020-06-30 10:01:50 +00:00
a06ca838f0
Bug 1644379 - Change ToString from an output parameter to returning a value. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D78875
2020-06-30 10:01:43 +00:00
d27dc7b783
Bug 1644379 - Extract extraction of ErrorResult from IDBResult into a function. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D78708
2020-06-30 10:01:20 +00:00
5e5ea484e9
Bug 1644379 - Change IDBResult(Base) to contain the ErrorResult. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D78707
2020-06-30 10:01:03 +00:00
6d12f96928
Bug 1641598 - Added gtest test cases for ToLocaleAwareKey. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D78697
2020-06-29 10:55:07 +00:00
7d203057ee
Bug 1641598 - Fix defect in Key::LengthOfEncodedBinary. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D78696
2020-06-29 14:36:51 +00:00
4c6f89824d
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 8 - mozilla namespace, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80931
2020-06-29 13:40:27 +00:00
34cbc7e2ed
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 7 - RemoteLazyInputStreamUtils, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80930
2020-06-29 11:02:59 +00:00
2c405fb804
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 6 - remoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80929
2020-06-29 11:02:55 +00:00
5fc1253731
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 4 - IPDL actors, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80927
2020-06-29 11:03:02 +00:00
8f12e90e00
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 3 - PRemoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80926
2020-06-29 11:03:04 +00:00
5def6bbc8c
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 11:02:53 +00:00
f7cb24cc7e
Backed out 8 changesets (bug 1648141) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE
...
Backed out changeset e9b4ca0ee700 (bug 16481411648141164814116481411648141164814116481411648141
2020-06-29 13:59:16 +03:00
c71431ab1b
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 8 - mozilla namespace, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80931
2020-06-29 10:30:00 +00:00
16339b8334
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 7 - RemoteLazyInputStreamUtils, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80930
2020-06-29 10:29:05 +00:00
d50c65af76
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 6 - remoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80929
2020-06-29 10:28:21 +00:00
87e1daec9f
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 4 - IPDL actors, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80927
2020-06-29 10:27:20 +00:00
d7cec00cfb
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 3 - PRemoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80926
2020-06-29 10:26:33 +00:00
82d0167e5e
Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 10:25:08 +00:00
02a968dd2a
Bug 1648432 - Stop returning nsresult from CursorOpBaseHelperBase<CursorType>::PopulateExtraResponses. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81301
2020-06-26 15:39:42 +00:00
ee059e6d04
Bug 1648432 - Inline DatabaseOperationBase::GetUniqueIndexTableForObjectStore and simplify it. r=dom-workers-and-storage-reviewers,ttung
...
The function is only called from a single place in CreateIndexOp::Init, and it
is the only action within that function. Inlining it removes the need to bind
parameters to the class' members.
Differential Revision: https://phabricator.services.mozilla.com/D81300
2020-06-26 15:39:30 +00:00
397f9743e5
Bug 1648432 - Stop returning nsresult from DeleteFilesRunnable::DoDatabaseWork and ::Open. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D81299
2020-06-26 15:41:27 +00:00
150e174361
Bug 1648432 - Make use of Result::propagateErr. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81298
2020-06-26 15:15:37 +00:00
d790918c7c
Bug 1648432 - Simplify AllocPBackgroundIDBTransactionParent using TransformIntoNewArrayAbortOnErr. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81297
2020-06-26 15:15:29 +00:00
23aaa23481
Bug 1648432 - Simplify code using std::any_of. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81296
2020-06-26 15:15:27 +00:00
8b9629c1d0
Bug 1648432 - Simplify code using LookupOrAdd(FromFactory). r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81295
2020-06-26 15:15:24 +00:00
3ca22ad465
Bug 1646774 - Use EnsureInserted instead of Contains + PutEntry. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D80849
2020-06-26 08:38:28 +00:00
7463bc52c9
Bug 1646774 - Apply pointer guideline to DatabaseInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D80213
2020-06-25 12:45:57 +00:00
04200bbba9
Bug 1646774 - Apply pointer guideline to TransactionInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D80212
2020-06-25 12:17:27 +00:00
5270b37037
Bug 1645786 - IPCBlobInputStream for socket process, r=smaug,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D80680
2020-06-25 12:21:14 +00:00
8193fe19be
Bug 1641512 - Use distinct types for file and database usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77462
2020-06-25 09:30:06 +00:00
55e3bdd7f8
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77453
2020-06-25 09:31:39 +00:00
c23800e5f2
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77452
2020-06-25 08:34:43 +00:00
15e2980688
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from AtomicSafeRefCounted. r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-23 13:34:52 +00:00
e96a6a2274
Bug 1623278 - Use mozilla::Span instead of pointer/length pair in Read* functions. r=dom-workers-and-storage-reviewers,janv
...
Also replace output parameters by use of mozilla::Result.
Differential Revision: https://phabricator.services.mozilla.com/D72626
2020-06-23 10:18:13 +00:00
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
d7b9a044db
Bug 1647133 - P1. Use nsISerialEventTarget where it's actually that. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80419
2020-06-23 03:21:14 +00:00
6ccabd4784
Bug 1602668 - M(1) manifest and test changes. r=kmag,karlt,necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D70362
2020-06-22 19:09:49 +00:00
ea34205395
Bug 1646054 - P1. Remove EventTargetWrapper class. r=froydnj
...
We also establish the intent of bug 1602167 on the TaskQueue object
Differential Revision: https://phabricator.services.mozilla.com/D80351
2020-06-22 13:55:21 +00:00
a54fa8e5b4
Bug 1623278 - Use mozilla::Span instead of pointer/length pair in Key. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D72632
2020-06-16 14:25:04 +00:00
2e8e66ab3c
Bug 1641512 - Rename AppendTo*Usage methods to Increment*Usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77450
2020-06-11 10:42:16 +00:00
dea8831f5c
Bug 1641512 - Introduce Usage type with operator+/+=. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77449
2020-06-11 10:42:12 +00:00
478765004c
Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D77217
2020-06-11 07:04:38 +00:00
4ab55413a3
Bug 1644640 - Rename RemoveElementsAt(const_iterator, const_iterator) to RemoveElementsRange. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79033
2020-06-11 07:17:25 +00:00
0e09b9191c
Backed out changeset 3f5baab34b1f (bug 1621916) for causing failure at QuotaRequests.cpp. CLOSED TREE
2020-06-11 09:58:59 +03:00
e72a3e7779
Bug 1621916 - Provide a usable stack when requestFinished throws; r=dom-workers-and-storage-reviewers,sg,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D77217
2020-06-11 06:36:55 +00:00
82dc9b2271
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
e3dce68834
Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
...
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
d419f0ff08
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
c644ee9a06
Backed out changeset 99cce83b7e41 (bug 1636050) for assertion failures on ReadStream.cpp. CLOSED TREE
2020-06-09 21:21:34 +03:00
0789e4dfa7
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from SafeRefCounted r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-09 14:32:17 +00:00
5b21d5ce2a
Backed out changeset f1ece7c1dc6e (bug 1636050) for tsan mochitest failure in operator++ CLOSED TREE
2020-06-08 19:14:35 +03:00
0bd79b3130
Bug 1636050 - dom::cache::ReadStream::Controllable now inherits from SafeRefCounted r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D77223
2020-06-08 13:33:49 +00:00
ebbc7ae838
Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78049
2020-06-08 08:50:15 +00:00
42f5cca14e
Bug 1621916 - Fix IndexedDB to ignore unknown files in the client directory during initialization and usage calculation; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D77073
2020-05-28 11:14:52 +00:00
d123d73b2d
Bug 1621916 - Remove unused argument in Client::InitOrigin; r=dom-workers-and-storage-reviewers,sg
...
Depends on D77070
Differential Revision: https://phabricator.services.mozilla.com/D77072
2020-05-27 15:52:49 +00:00
e51ae4f931
Bug 1621916 - Remove unnecessary local variables; r=dom-workers-and-storage-reviewers,sg
...
Depends on D77069
Differential Revision: https://phabricator.services.mozilla.com/D77070
2020-05-27 14:44:17 +00:00
7d0c7ae8e0
Bug 1621916 - Rename GetDatabaseFilename to GetDatabaseFilenameBase; r=dom-workers-and-storage-reviewers,sg
...
The method returns a database filename without any extension, so the method name
needs to express that.
Depends on D77068
Differential Revision: https://phabricator.services.mozilla.com/D77069
2020-05-28 07:56:48 +00:00
0eee7fd0c7
Bug 1621916 - Rename GetBaseFilename to GetFilenameBase to match rest of the code; r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D77068
2020-05-28 10:09:50 +00:00
5183f79beb
Bug 1621916 - Unify reporting of unknown files across quota manager, idb, sdb and ls quota client; r=dom-workers-and-storage-reviewers,ttung
...
Depends on D76703
Differential Revision: https://phabricator.services.mozilla.com/D76717
2020-05-26 07:02:07 +00:00
68a6cbf429
Bug 1621916 - Fix IndexedDB to ignore unknown files in the files and journals directory during initialization and usage calculation; r=dom-workers-and-storage-reviewers,ttung
...
All unknown files in the files and journals directory are now properly filtered
out if the filename can't be converted to an integer.
Differential Revision: https://phabricator.services.mozilla.com/D76703
2020-05-26 07:22:12 +00:00
ffc83ce958
Bug 1637715 - Add missing quotation mark to mac condition. a=fix
...
CLOSED TREE
2020-05-23 01:13:47 +03:00
c592561f15
Bug 1637715 - update disabling condition to include mac and all win r=jmaher DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D76545
2020-05-22 22:01:28 +00:00
09b8072a54
Bug 1637715 - Disable test_upgrade_add_index.html for frequent failures on Linux and Windows. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D75667
2020-05-16 09:51:08 +00:00
d11275bd72
Bug 1632128 - Dissolve FileHandleResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D75053
2020-05-14 09:42:33 +00:00
4fc4c0a9d9
Bug 1632128 - Dissolve ResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74890
2020-05-14 09:42:23 +00:00
9ee13d3ec4
Bug 1632128 - De-virtualize IDBFileRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74875
2020-05-14 09:42:21 +00:00
5f4d07aff0
Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74874
2020-05-14 09:42:18 +00:00
ae0940c00a
Bug 1632128 - Use mozilla::Variant for FileHandleResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74870
2020-05-14 09:42:16 +00:00
7a8f68d96f
Bug 1632128 - Use mozilla::Variant for ResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71936
2020-05-14 09:42:13 +00:00
79f1249dc9
Bug 1623278 - Use MovingNotNull in ActorsParent. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73033
2020-05-14 09:14:17 +00:00
a892bc01f6
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
078debe589
Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
...
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
e0aafb232f
Bug 1623278 - Use MovingNotNull in ActorsParent. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73033
2020-05-13 10:44:52 +00:00
98b9d42815
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
d07bf2b285
Bug 1637159 specify DOMEventTargetHelper owner for IDBFileHandle via constructor r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D75037
2020-05-14 05:28:36 +00:00
e5e444b9cc
Bug 1636316 - Disable defective optimization in DeserializeIndexValueHelper::DispatchAndWait. r=asuth,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75046
2020-05-13 15:49:46 +00:00
cf852bbfb9
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
06937e8b14
Bug 1631970 - Delay converting uint64 results to JSVals. r=sg
...
The rooting hazard analysis is getting upset because of the usage where
a non-GCThing JSVal is declared on the stack and AcquireTransaction() is
called. The analysis doesn't know that it's guaranteed that the value is
NaN-boxed and can't be a GC thing. It also doesn't know that the SafeRefPtr
can't already have a value so a release is impossible.
Arguably the hazard analysis doesn't need to know these things though.
This fix delays the point at which we convert the uint64 into a JS::Value.
The [call to GetResult](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/dom/indexedDB/IDBRequest.cpp#300 )
already has a rooted result and the (Auto)JSAPI initialized, so this is
arguably cleaner and less scary in terms of holding raw pointers in the
ResultHelper that aren't necessary.
This fix doesn't correct the ResultTypeJSValHandle which is a similar
situation, except it's a reference to
[UndefinedHandleValue](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/js/src/vm/Value.cpp#23 )
which is I suppose more fine from a GC perspective. Still somewhat ugly
as used in ResultHelper, but I'm presuming we'll clean ResultHelper up
in the future to use a Variant, at which point we can explicitly indicate
we want `undefined`.
Differential Revision: https://phabricator.services.mozilla.com/D74800
2020-05-12 10:39:00 +00:00
75c988ec13
Bug 1627892 - Use SafeRefPtr for Request. r=dom-workers-and-storage-reviewers,perry
...
Differential Revision: https://phabricator.services.mozilla.com/D70390
2020-05-11 12:13:48 +00:00
e6422e2afd
Bug 1626570 - Remove obsolete copy enabling machinery. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D72176
2020-05-11 08:23:03 +00:00
8ef5cb428c
Bug 1633446 - Fix handling of wrapped ArrayBuffer objects. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D72884
2020-05-07 11:26:19 +00:00
9d5e7505f9
Bug 1623278 - Make Factory derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69398
2020-05-06 12:20:14 +00:00
f5ecb7c004
Bug 1623278 - Use SafeRefCounted in ActorsParent. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69351
2020-05-06 11:35:20 +00:00
6d8be8c785
Bug 1623278 - Make transaction actors refcounted. r=dom-workers-and-storage-reviewers,nika,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71933
2020-05-06 12:20:32 +00:00
ea023a9d8e
Bug 1626570 - Improve handling of copying arrays in dom/indexedDB/. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73650
2020-05-05 14:13:46 +00:00
b3881bb2e1
Bug 1633719 - Support NotNull<SafeRefPtr<T>>. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D72828
2020-05-05 09:09:41 +00:00
34acbb653a
Bug 1619165 - Reformat recent changes to the Google coding style r=andi
...
First reformat with clang-format 10
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D68802
2020-04-25 09:40:08 +00:00
2d8c4390b7
Bug 1628715 - Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=xpcom-reviewers,necko-reviewers,dragana,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D71300
2020-04-24 13:35:27 +00:00
86ba544cc6
Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
...
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-23 08:38:57 +00:00
843c954b43
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
80afdc5ddc
Backed out changeset 7dccafbf3437 (bug 1536540) for failing wpt at idlharness.any.worker.html on a CLOSED TREE
2020-04-22 21:54:11 +03:00
bcf94e6de5
Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
...
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-22 14:53:17 +00:00
2b4a61a0b6
Bug 1628716 - Use range-based for and STL algorithms with hashtables. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D70378
2020-04-22 13:52:52 +00:00
1dd70d203d
Bug 1618542 - Add further uses of new transformation algorithms with nsTHashtable. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D70377
2020-04-22 13:51:43 +00:00
2ff9dc2267
Bug 1565224 - Re-enable Key gtests and fix usage of JSAPI r=sg,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D69709
2020-04-22 08:01:00 +00:00
41c3ea3ee8
acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE
2020-04-22 08:41:47 +03:00
0aeb2db4f6
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
76b2fc7b60
Bug 1618542 - Fixed whitespace on ActorsParent.cpp CLOSED TREE
2020-04-21 20:19:50 +03:00
ecfe1e0e4d
Bug 1618542 - Add use of new transformation algorithms in ActorsChild. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69044
2020-04-21 14:35:03 +00:00
e4e19aad28
Bug 1618542 - Add use of new transformation algorithms in TestFileInfo. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69043
2020-04-21 14:34:51 +00:00
d11730c4fe
Bug 1618542 - Remove redundant assertions on infallible array operations. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69042
2020-04-21 14:34:43 +00:00
410c229065
Bug 1618542 - Add further uses of new transformation algorithms. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69041
2020-04-21 14:56:20 +00:00
48fc4a573b
Bug 1618542 - Make OpenDatabaseOp::MetadataToSpec fallible. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69040
2020-04-21 14:34:26 +00:00
2fd18d4675
Bug 1618542 - Made possibly large memory allocations fallible. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69038
2020-04-21 14:34:19 +00:00
09fa9d86d9
Bug 1618542 - Add further uses of new transformation algorithms. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69037
2020-04-21 14:54:41 +00:00
931e494dba
Bug 1618542 - Remove uses of FallibleTArray in ActorsParent.cpp. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69036
2020-04-21 14:37:51 +00:00
0a8f7dc852
Bug 1618542 - Remove use of FallibleTArray in IDBObjectStore.cpp. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69034
2020-04-21 14:45:55 +00:00
ef41d753b5
Bug 1623278 - Eliminate output and raw pointer input parameters on some ActorsParent functions. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D68338
2020-04-21 14:40:00 +00:00
4968855eb7
Bug 1623278 - Eliminate output parameters on GetOrCreateConnection. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D68337
2020-04-21 14:33:06 +00:00
18c7f261c4
Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
8644241bec
Bug 1628723 - Simplify ConnectionPool::Cleanup and add assertion. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D70379
2020-04-21 13:58:57 +00:00
4c89b71494
Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
...
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.
Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-20 22:31:29 +00:00
a5ac2a8bbc
Backed out 10 changesets (bug 1614462) for causing test_ipc_messagemanager_blob.js failures CLOSED TREE
...
Backed out changeset bf4f8253c708 (bug 1614462)
Backed out changeset c61b797d63e9 (bug 1614462)
Backed out changeset 284002de7137 (bug 1614462)
Backed out changeset 7f604ee5731c (bug 1614462)
Backed out changeset a73ef8167cd4 (bug 1614462)
Backed out changeset ecc3477ed34e (bug 1614462)
Backed out changeset 2106f3ccc4b5 (bug 1614462)
Backed out changeset e68c38a7741d (bug 1614462)
Backed out changeset 93b3bacdbb34 (bug 1614462)
Backed out changeset 0cf4898ae08d (bug 1614462)
2020-04-21 01:11:37 +03:00
91b65009eb
Bug 1549945 - Avoid the need for import-globals-from when (x)html files load scripts via /tests/. r=mossop
...
When loading from /tests/ we can strip off the /tests/ part and find the file with the rest of the path.
Differential Revision: https://phabricator.services.mozilla.com/D71411
2020-04-20 16:15:11 +00:00
d1639bbfcd
Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
...
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.
Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-20 20:11:43 +00:00
dce92be327
Bug 1623278 - Create SafeRefCounted base class that is initialized with a refcount of 1 and can only be instantiated via MakeSafeRefPtr. r=dom-workers-and-storage-reviewers,janv
...
Also, add tests for SafeRefPtr.
Differential Revision: https://phabricator.services.mozilla.com/D61233
2020-04-20 15:13:48 +00:00
9d03b9bd1a
Bug 1629843 - Mark indexedDB classes as able to have pointers into more than one JS zone r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D71289
2020-04-17 14:57:57 +00:00
c15dcac93b
Backed out 10 changesets (bug 1614462) for causing xpcshell failures CLOSED TREE
...
Backed out changeset 34d4a86530b4 (bug 1614462)
Backed out changeset dbc2e2556d08 (bug 1614462)
Backed out changeset 512bbab4730c (bug 1614462)
Backed out changeset cd6b8d630f4c (bug 1614462)
Backed out changeset e4ad5037658f (bug 1614462)
Backed out changeset 0ffed1dc4296 (bug 1614462)
Backed out changeset 90ed81cbfe34 (bug 1614462)
Backed out changeset 6d2137eb1d52 (bug 1614462)
Backed out changeset b4819c99e16e (bug 1614462)
Backed out changeset b7deaed376ed (bug 1614462)
2020-04-17 02:26:14 +03:00
c45d02801c
Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
...
These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.
Differential Revision: https://phabricator.services.mozilla.com/D70745
2020-04-16 16:57:14 +00:00
6209b9c4eb
Bug 1624524 - Remove uses of wasmTextToBinary in non-JS shell tests. r=bbouvier
...
There are not many uses of wasmTextToBinary in the non-JS shell tests, and so
the easiest path to resolving the build size regression from using the 'wat'
crate is to just conditionally compile it in the JS shell. This commit takes
the few cases of wasmTextToBinary in non-JS shell tests and precompiles them
to binary.
Differential Revision: https://phabricator.services.mozilla.com/D68651
--HG--
extra : moz-landing-system : lando
2020-04-10 21:28:19 +00:00
882077ccb1
Bug 1619965 - Simplify clearing of mWaitingFactoryOp; r=sg,dom-workers-and-storage-reviewers
...
mWaitingFactoryOp is now always cleared when the last maybe blocked database is
removed in FactoryOp::NoteDatabaseClosed.
Differential Revision: https://phabricator.services.mozilla.com/D70201
--HG--
extra : moz-landing-system : lando
2020-04-09 08:53:21 +00:00
0f359d3fdb
Bug 1619965 - Remove duplication between NoteDatabaseClosed methods. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65334
--HG--
extra : moz-landing-system : lando
2020-04-09 09:23:39 +00:00
9120151ddb
Backed out 2 changesets (bug 1619965) for bustages complaining about ActorsParent.cpp CLOSED TREE
...
Backed out changeset efa2dcf4f69e (bug 1619965)
Backed out changeset da983a0216c8 (bug 1619965)
2020-04-09 11:36:54 +03:00
61a77769f7
Bug 1619965 - Simplify clearing of mWaitingFactoryOp; r=sg,dom-workers-and-storage-reviewers
...
mWaitingFactoryOp is now always cleared when the last maybe blocked database is
removed in FactoryOp::NoteDatabaseClosed.
Differential Revision: https://phabricator.services.mozilla.com/D70201
--HG--
extra : moz-landing-system : lando
2020-04-09 08:10:10 +00:00
15d16a9d16
Bug 1619965 - Remove duplication between NoteDatabaseClosed methods. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65334
--HG--
extra : moz-landing-system : lando
2020-04-08 17:44:20 +00:00
25ca8d7890
Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
...
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.
Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.
The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.
DocGroups have also been moved to BrowsingContextGroup.
Depends on D67636
Differential Revision: https://phabricator.services.mozilla.com/D65936
--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:47 +00:00
36eaf82163
Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
...
Depends on D67631
Differential Revision: https://phabricator.services.mozilla.com/D67632
--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:33 +00:00
299455107e
Bug 1627282 - Mark all IndexDB cursor subclasses as potentially containing pointers into more than one JS zone r=sg
...
At this point it's probably worth marking all these subclasses in the same way as I expect they can all contain pointers into multiple zones.
Differential Revision: https://phabricator.services.mozilla.com/D69809
--HG--
extra : moz-landing-system : lando
2020-04-06 13:02:52 +00:00
1ca11f861a
Bug 1626973 - Make attempt to increase the file size via IDBFileHandle.truncate an error. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69580
--HG--
extra : moz-landing-system : lando
2020-04-06 13:56:47 +00:00
94e4123950
Bug 1536796 - P3 - Use QM_NewLocalFile in QM and its clients; r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D67875
--HG--
extra : moz-landing-system : lando
2020-04-01 07:26:27 +00:00
a8c2236b19
Bug 1623278 - Replace GetStorageConnection by HasStorageConnection and MutableStorageConnection accessors. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67286
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:56 +00:00
da859a31b2
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:43 +00:00
e614684d09
Bug 1623278 - Use SafeRefPtr for TransactionBase and its subclasses. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65711
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:52 +00:00
02753c9665
Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D65710
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:39 +00:00
64d6929415
Bug 1623278 - Use SafeRefPtr for Database. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65568
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:16 +00:00
88b93c652a
Bug 1623278 - Use SafeRefPtr for FileInfo. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65550
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:01 +00:00
86efbc2cef
Bug 1623278 - Use SafeRefPtr for FileManager. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65549
--HG--
extra : moz-landing-system : lando
2020-04-01 09:52:54 +00:00
3d2232e5e2
Bug 1623278 - Use SafeRefPtr for FullDatabaseMetadata. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65548
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:24 +00:00
bd9cd54c52
Bug 1623278 - Workaround to make gcc 8.3.0 happy. r=jstutte
...
Depends on D65547
Differential Revision: https://phabricator.services.mozilla.com/D69170
--HG--
extra : moz-landing-system : lando
2020-04-01 09:56:58 +00:00
f990e77e90
Bug 1620273 - Add SafeRefPtr. r=asuth,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65547
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:24 +00:00
b62d30f4db
Bug 1625444 - Make IDBObjectStoreCursor a multi-zone JSHolder class. r=jonco,dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D68766
--HG--
extra : moz-landing-system : lando
2020-03-30 18:31:04 +00:00
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
73a498ec0c
Bug 1625138 - Part 38: Replace mozilla::IsSame with std::is_same in dom/. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68557
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
cae4e1fdbc
Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68401
--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
0493bf1a2f
Bug 1601601 - disable test_rename_index.html on linux 18.04 r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D67950
--HG--
extra : moz-landing-system : lando
2020-03-26 09:12:08 +00:00
c1e3671c97
Bug 1624810 - Set the multi-zone JS holder flag on appropriate cycle collected classes r=mccr8
...
Set the flag on the affected classes, which are:
- CallbackTimeoutHandler
- nsJSArgArray
- CallbackObject
- Console
- MessageEvent
- IDBIndexCursor
- ExtendableMessageEvent
- JSPurpleBuffer
Differential Revision: https://phabricator.services.mozilla.com/D68196
--HG--
extra : moz-landing-system : lando
2020-03-26 10:49:06 +00:00
bbcdad1d35
Bug 1607975 - Disabled dom/indexedDB/test/browser_bug839193.js on Windows 7. r=ttung DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D68096
--HG--
extra : moz-landing-system : lando
2020-03-25 12:22:53 +00:00
4b23573552
Bug 1620917 - Ensure a failure of StartTransactionOp is correctly handled on the resulting CommitOp. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67667
--HG--
extra : moz-landing-system : lando
2020-03-23 10:38:47 +00:00
Simon Giesecke
Andrea Marchesini
Razvan Maries
ssengupta
Jean-Yves Avenard
tkhan
Jan Varga
Butkovits Atila
Csoregi Natalia
Bogdan Tara
Mihai Alexandru Michis
Andreea Pavel
Brindusan Cristian
Karl Tomlinson
Andrew Sutherland
Sylvestre Ledru
Chris Peterson
Steve Fink
Dorel Luca
Kris Maglione
Ciure Andrei
Mark Banner
Jon Coppeard
Ryan Hunt
Andreas Farre
Tom Tung
André Bargull
Sebastian Hengst