Граф коммитов

423 Коммитов

Автор SHA1 Сообщение Дата
Tom Ritter 839cfff0f8 Bug 1686975: Add clang-query to the clang-tidy tools r=andi
Differential Revision: https://phabricator.services.mozilla.com/D101939
2021-03-10 20:53:32 +00:00
Andi-Bogdan Postelnicu b3ae95374e Bug 1696491 - when clang errors are present, mark static analysis jobs as failed. r=firefox-build-system-reviewers,mhentges
Our bot was expecting to have tasks that were succeeding, right now we no longer need that
and in a case of a build failure, or in a case of the presence of a checker that asserts itself
as error and not warning we should mark the task red by failing the job.

Differential Revision: https://phabricator.services.mozilla.com/D107656
2021-03-10 05:20:46 +00:00
David Major 219799577d Bug 1694280 - Add clang 12.0.0 rc2 toolchains (not yet used) r=firefox-build-system-reviewers,glandium
Just adding the toolchain tasks for now. They are not yet used by anything, but bug 1693288 might be interested eventually.

As with earlier releases, clang-tidy and mingw builds are not included here, they'll be separate patches.

Differential Revision: https://phabricator.services.mozilla.com/D106554
2021-03-03 16:53:28 +00:00
Mike Hommey 35d498a886 Bug 1692944 - Add a clang toolchain for arm64 mac. r=firefox-build-system-reviewers,andi,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D105267
2021-02-22 21:38:34 +00:00
Mike Hommey d7ab7ac4f9 Bug 1692944 - Reflect the fact that we're building clang with SDK 10.12. r=firefox-build-system-reviewers,andi,dmajor
We've been building clang with SDK 10.12 since bug 1680152, but the
build-clang script is still assuming we're building with an older one.

Differential Revision: https://phabricator.services.mozilla.com/D105266
2021-02-22 21:38:34 +00:00
Calixte Denizet a0b66fc1c7 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco,dmajor
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for linux ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D104990
2021-02-12 20:37:25 +00:00
Csoregi Natalia 63a9b1da37 Backed out changeset 333391f911e5 (bug 1602482) for toolchains bustage. CLOSED TREE 2021-02-12 18:14:44 +02:00
Calixte Denizet 169e0b5a38 Bug 1602482 - Remove use of ___custom_llvm_gcov_flush r=marco,dmajor
Because of conflicts between gcov_flush from gcc and the one from llvm, we renamed llvm one into ___custom_llvm_gcov_flush.
Since we switched to clang for linux ccov builds, this workaround is now useless.

Differential Revision: https://phabricator.services.mozilla.com/D104990
2021-02-12 14:45:24 +00:00
Mike Hommey 7ae7a72a38 Bug 1690937 - Build clang itself using a sysroot. r=firefox-build-system-reviewers,sheehan,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104128
2021-02-09 00:44:01 +00:00
Mike Hommey d1be2e98e1 Bug 1690934 - Adjust clang for use with sysroots. r=firefox-build-system-reviewers,sheehan,mhentges
When using the --sysroot argument to clang, clang changes where it
searches for libraries in its own directory, and excludes the lib and
lib32 subdirectories. So we need to move the gcc files to a place where
it does look (and that it also looks without --sysroot).

We however still keep a copy of libstdc++ in the lib directory for
runtime purposes.

Differential Revision: https://phabricator.services.mozilla.com/D104123
2021-02-08 20:06:40 +00:00
Mike Hommey 4e004f1b25 Bug 1690757 - Build the clang aarch64 cross toolchain as a repack of clang + compiler-rt. r=firefox-build-system-reviewers,andi,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104013
2021-02-04 14:52:00 +00:00
Cosmin Sabou 39960420a1 Bug 1686114 - Lint fix on build-clang.py. a=lint-fix 2021-01-29 15:43:10 +02:00
Tom Ritter 7aba583f22 Bug 1686114: Fix build-clang.py's --skip-checkout argument r=glandium DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D101397
2021-01-13 22:49:52 +00:00
David Major 23d6295ae9 Bug 1686516 - Remove unused files clang-win64.json and clang-win64-2stage.json r=firefox-build-system-reviewers,mhentges DONTBUILD
I missed these in bug 1682405.

Additionally, after this removal, llvmorg-10-init-5191-ga84b200e604-windows-pgo.patch also becomes unused, so it is deleted too.

Differential Revision: https://phabricator.services.mozilla.com/D101633
2021-01-13 19:17:04 +00:00
Mike Hommey 96dd8d7fd7 Bug 1685599 - Remove now unused macosx64-clang-9 and linux64-clang-9-macosx-cross toolchains. r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D101081
2021-01-08 18:51:53 +00:00
Razvan Maries 891da67475 Backed out 6 changesets (bug 1685599) for WR bustages. CLOSED TREE
Backed out changeset 29eab2f84c77 (bug 1685599)
Backed out changeset 2839d8d39881 (bug 1685599)
Backed out changeset 3ba2f1c048c3 (bug 1685599)
Backed out changeset c7d4ecfc689a (bug 1685599)
Backed out changeset 5483ce4f5f4c (bug 1685599)
Backed out changeset 68fa5ecf205c (bug 1685599)
2021-01-08 09:04:37 +02:00
Mike Hommey cf3c69ebe4 Bug 1685034 - Add the task-id to the clang version. r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D100875
2021-01-07 17:07:15 +00:00
Mike Hommey c3d2cb844a Bug 1685599 - Remove now unused macosx64-clang-9 and linux64-clang-9-macosx-cross toolchains. r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D101081
2021-01-08 00:33:35 +00:00
David Major 180d35da9f Bug 1685335 - Update to clang 11.0.1 r=firefox-build-system-reviewers,static-analysis-reviewers,andi,mhentges,sylvestre
In addition to the usual dot-release type of fixes, this also lets us drop a good amount of code that we had patched into our clang 11.

Differential Revision: https://phabricator.services.mozilla.com/D100959
2021-01-07 13:53:53 +00:00
Sebastian Hengst a3e7021190 Backed out 2 changesets (bug 1588710) for frequent crashes on Linux x64 debug affecting Try pushes (bug 1679994). a=backout
Backed out changeset f0b02db01894 (bug 1588710)
Backed out changeset e45001cddaf4 (bug 1588710)
2020-12-16 11:58:47 +01:00
David Major 43a2ab175a Bug 1682405 - Clean up unused clang toolchains (mostly clang-9) r=firefox-build-system-reviewers,mhentges
At this point it's pretty clear that we won't be reverting to clang-9.

This doesn't remove everything with clang-9 in the name. I did a mark-and-sweep GC by hand so this only removes unused entries. Some are still active, e.g. linux64-clang-9 is used to build a number of misc helper tools.

Differential Revision: https://phabricator.services.mozilla.com/D99721
2020-12-15 17:46:10 +00:00
Sylvestre Ledru 5ee117be90 Bug 1588710 - Add missing upstream llvm patch to fix alloc(0) r=firefox-build-system-reviewers,dmajor
From upstream repo:
a1e0363c7402f7aa58e24e0e6dfa447ebabc1910 to bbe6cbbed8c7460a7e8477373b9250543362e771

Differential Revision: https://phabricator.services.mozilla.com/D99681
2020-12-14 16:02:52 +00:00
David Major af9e11f761 Bug 1623520 - Add the asan unpoison patch to clang-cl-2stage r=firefox-build-system-reviewers,glandium
This is needed for cross-compiled win64-asan builds.

Differential Revision: https://phabricator.services.mozilla.com/D99411
2020-12-11 05:06:12 +00:00
David Major 30f8312443 Bug 1680826 - Update MSVC compat version in build-clang.py r=firefox-build-system-reviewers,mhentges
In https://reviews.llvm.org/D92515, clang-12 bumps the build requirement to MSVC version 19.14.

We've already updated well past that (most recently bug 1485224) but build-clang.py never got the memo.

Differential Revision: https://phabricator.services.mozilla.com/D98806
2020-12-04 20:43:30 +00:00
Mike Hommey 5bfd115c9a Bug 1680152 - Fixup: Bump deployment target to 10.12 when building clang.
Differential Revision: https://phabricator.services.mozilla.com/D98544
2020-12-02 22:43:11 +00:00
David Major df33d22907 Bug 1680126 - Remove unused if-constexpr patches to clang-tidy r=firefox-build-system-reviewers,mhentges DONTBUILD
These files were orphaned by bug 1625884.

Differential Revision: https://phabricator.services.mozilla.com/D98389
2020-12-02 07:53:57 +00:00
Sylvestre Ledru 042903ae82 Bug 1588710 - clang stack clash - Cherry-pick an upstream fix r=firefox-build-system-reviewers,mhentges,dmajor
See https://bugs.llvm.org/show_bug.cgi?id=48007#c6

-----
Fix limit behavior of dynamic alloca

When the allocation size is 0, we shouldn't probe. Within [1,  PAGE_SIZE], we
should probe once etc.

This fixes https://bugs.llvm.org/show_bug.cgi?id=47657

(cherry picked from commit 9573c9f2a363da71b2c07a3add4e52721e6028a0)

Also contains the patches:
aac36687f7
bbe6cbbed8

These 3 patches have been merged in the 11 branch
and should be part of the 11.0.1 release
-----

Differential Revision: https://phabricator.services.mozilla.com/D97566
2020-11-30 16:41:20 +00:00
Andi-Bogdan Postelnicu e9fbba867c Bug 1666550 - Update `clang-tools` to `clang-11`. r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D97137
2020-11-17 15:04:14 +00:00
David Major c7dcbe9387 Bug 1675600 - Use the new pass manager during LTO r=firefox-build-system-reviewers,glandium
Currently, in LTO builds, we use the new pass manager during the initial translation to bitcode but not for the final optimization during linking.

On Linux, we can enable the new pass manager during LTO with a plugin option. I've landed a patch upstream to allow it on Windows as well, which is included here.

Switching the pass manager brings speed improvements on its own, but it also reduces code size by ~6%, which we can use a portion of as budget to increase the import limit (via the hot multiplier) for even more speed improvements.

Differential Revision: https://phabricator.services.mozilla.com/D96108
2020-11-17 04:07:54 +00:00
David Major 864a71324c Bug 1677147 - Update build-clang.py for "llvmbuildectomy" r=firefox-build-system-reviewers,mhentges
A recent change upstream [0] removed llvm-build, so we can't test for its files anymore.

[0] 9218ff50f9

Differential Revision: https://phabricator.services.mozilla.com/D97017
2020-11-14 03:15:54 +00:00
David Major 02b04550c6 Bug 1676669 - Trim some context on downgrade-mangling-error.patch for clang-12 r=firefox-build-system-reviewers,rstewart
Some of the surrounding lines recently changed so the patch refuses to apply. We can live with less context so I'd rather trim it than make a new clang-12 version of this patch.

Differential Revision: https://phabricator.services.mozilla.com/D96725
2020-11-11 16:19:25 +00:00
Ricky Stewart 02a7b4ebdf Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
sanketh 14a4c90302 Bug 1668304 - Bump mingw-clang builds to clang 11 r=tjr,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D94676
2020-10-24 05:07:23 +00:00
Bogdan Tara da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart c0cea3b0fa Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 50762dacab Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
David Major 0b9c307bbe Bug 1667841 - Update revert-r362047-and-r362065.patch for clang-12 r=firefox-build-system-reviewers,rstewart
The patch no longer applies cleanly because of nearby changes in 4b8cb665a1.

Instead of forking a clang-12 version of this patch, we can get away with carrying a little less context in our patch file.

Differential Revision: https://phabricator.services.mozilla.com/D91625
2020-09-28 19:03:18 +00:00
june wilde 9178fec3e3 Bug 1664394 - rename linux64-civet-tidy to linux64-external-tidy;r=andi
Differential Revision: https://phabricator.services.mozilla.com/D90158
2020-09-15 15:06:10 +00:00
David Major 84a0b6afc4 Bug 1662608 - Set -fcrash-diagnostics-dir in build-clang.py r=froydnj
This will let us get reproducers for compiler self-host assertion failures.

Differential Revision: https://phabricator.services.mozilla.com/D89079
2020-09-10 20:25:54 +00:00
Bogdan Tara 5bbb6dee2e Backed out changeset 1d92340a0f3c (bug 1662608) for clang5.0 failures CLOSED TREE 2020-09-09 01:43:09 +03:00
David Major 398ec52cef Bug 1662608 - Set -fcrash-diagnostics-dir in build-clang.py r=froydnj CLOSED TREE
This will let us get reproducers for compiler self-host assertion failures.

Differential Revision: https://phabricator.services.mozilla.com/D89079
2020-09-02 00:27:12 +00:00
Tom Ritter cba80ebf36 Bug 1633761 - Bump the mingwclang builds to clang 10 r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D88994
2020-09-02 14:12:22 +00:00
David Major 3e160f998a Bug 1661129 - Add toolchain tasks for clang 11.0.0 rc2 (not yet used) r=nalexander
This adds toolchain definitions for clang 11.0.0 rc2, so that developers can get a sneak peek, but nothing in automation uses these tasks yet. We'll make the switch in a later patch.

NB: most of `clang.yml` is rote copy-paste, except for `macosx64-clang-11` which makes a deliberate departure, described in a comment.

Differential Revision: https://phabricator.services.mozilla.com/D88189
2020-08-25 22:22:12 +00:00
june wilde 103a325162 Bug 1598226 - Create task definitions for external clang-tidy checks; r=andi,tjr,glandium
Depends on D81448

Differential Revision: https://phabricator.services.mozilla.com/D84769
2020-08-10 21:02:04 +00:00
David Major 6883b4d0af Bug 1654674 - Make revert-r362047-and-r362065.patch work with clang-12 r=froydnj
afa1afd410 changed a line at the edge of the context of this patch. I'm really not keen to fork this patch into a separate clang-12 version, so I'd prefer to just shrink the context a little.

Differential Revision: https://phabricator.services.mozilla.com/D84609
2020-07-22 23:34:43 +00:00
Andi-Bogdan Postelnicu 2897e78033 Bug 1654557 - add `clangd` to the `clang-tidy` package. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84528
2020-07-22 18:15:19 +00:00
David Major 63aa7238ca Bug 1616694 - Allow build-clang to work with different Mac SDKs r=froydnj
LLVM 11 introduces a hard requirement for SDK 10.12 in order to build for Mac. We want to keep building older LLVMs with 10.11 though, so this patch adds some flexibility so that build-clang can make use of whatever SDK package a particular task pulls from tooltool (but still requesting a deployment target of 10.11).

Differential Revision: https://phabricator.services.mozilla.com/D82621
2020-07-13 22:44:54 +00:00
Tom Ritter 486f6c9f43 Bug 1652037 - Wire up build_clang_tidy_external in build-clang.py r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D83120
2020-07-10 18:25:29 +00:00
Nathan Froyd 304b57adbc Bug 1651675 - explicitly use some useful linker options when building clang; r=dmajor
clang/LLVM's build scripts can turn these on on their own, but explicitly
setting what we want is better than guessing.  The change is not huge, maybe
~2-3% on the major shared libraries (`libclang`, `libclang-cpp`, `libLLVM`),
about 1% on the overall `.tar.zst` size, but every little bit counts, right?

Differential Revision: https://phabricator.services.mozilla.com/D82896
2020-07-10 12:51:36 +00:00