This patch also renames certain test files to avoid
duplication of test names. Because they are all included in
testing/marionette/client/marionette/tests/webapi-tests.ini through
include statements, the test names must be unique.
--HG--
rename : dom/mobilemessage/tests/marionette/test_dsds_default_service_id.js => dom/mobilemessage/tests/marionette/test_mobilemessage_dsds_default_service_id.js
rename : dom/telephony/test/marionette/test_dsds_default_service_id.js => dom/telephony/test/marionette/test_telephony_dsds_default_service_id.js
rename : dom/voicemail/test/marionette/test_dsds_default_service_id.js => dom/voicemail/test/marionette/test_voicemail_dsds_default_service_id.js
extra : rebase_source : 7fed68c1c8801ce6c981c0314240f0041d9068fa
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
This patch was mostly generated with the following command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e '/WrapObject(JSContext/ {; N; s/\(WrapObject(JSContext *\* *a\{0,1\}[Cc]x\),\n\{0,1\} *JS::Handle<JSObject\*> a\{0,1\}[sS]cope/\1/ ; }' -i ""
and then reverting the changes that made to
dom/bindings/BindingUtils.h, since those WrapObject methods are not
the ones we're trying to change here, plus a bunch of manual fixups
for cases that this command did not catch (including all the callsites
of WrapObject()).
This patch was mostly generated with this command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e 's/Binding::Wrap(aCx, aScope, this/Binding::Wrap(aCx, this/' -e 's/Binding_workers::Wrap(aCx, aScope, this/Binding_workers::Wrap(aCx, this/' -e 's/Binding::Wrap(cx, scope, this/Binding::Wrap(cx, this/' -i ""
plus a few manual fixes to dom/bindings/Codegen.py, js/xpconnect/src/event_impl_gen.py, and a few C++ files that were not caught in the search-and-replace above.
for f in `git show --name-only | grep ^dom/`; do
[ -n "`grep -e '\w\+: function([^)]*\$' $f`" ] && echo $f;
done | xargs sh -c 'rvim "$@" </dev/tty' asdf
RILDIRS="dom/cellbroadcast/ dom/icc/ dom/mobilemessage/ dom/network/ dom/telephony/ dom/voicemail/ dom/system/gonk/";
for f in `find $RILDIRS -type f -name \*.js -o -name \*.jsm`; do
sed -i $f -e 's/function \+(/function(/';
done
Birunthan Mohanathas
Phil Ringnalda
Kyle Huey
Bill McCloskey
Andreas Tolfsen
Tooru Fujisawa
Nathan Froyd
Chris Peterson
Shu-yu Guo
Nicholas Nethercote
Juan Gomez
Ryan VanderMeulen
Andrew McCreight
Hsin-Yi Tsai
Andrea Marchesini
Ehsan Akhgari
Boris Zbarsky
Bevis Tseng
Peter Van der Beken
Bobby Holley
Vicamo Yang
Mike Hommey
Roshan Vidyashankar
Masayuki Nakano
Masatoshi Kimura