We introduce this rule and parse it in this patch. Also, fix some wpt
expectations for ERROR.
We will introduce CSSStartingStyleRule in the following patch, and test
it there.
Differential Revision: https://phabricator.services.mozilla.com/D206428
We may get build bustages for fuzzer/asan build without this change:
`member access into incomplete type 'nsPluginElement'`.
nsMimeTypeArray.h forward-declares the `nsPluginElement` type, so it's not
supposed to have any code that calls methods on instances of that type.
The `do_AddRef` inline function internally calls `AddRef` on the passed-in
thing, so we need to move that to the .cpp file which has the actual type
definition available.
Differential Revision: https://phabricator.services.mozilla.com/D206724
This code is being run as content JS because this is in a plain Mochitest, but
it is calling into the chrome JS function LoginHelper.loginToVanillaObject().
That function returns a chrome JS object, so it ends up in a cross-compartment
wrapper (CCW). The code then attempts to send the CCW over JS actor IPC, via
JSActor::SendQuery. That method attempts to structured clone the CCW by calling
into nsFrameMessageManager::GetParamsForMessage(), but structured cloning
can't deal with a CCW to a plain object, so it falls back to the stringify
JSON method. JS_Stringify apparently can deal with a CCW, so it produces
a JSON string which gets turned into a new JS value, which can be successfully
structured cloned.
The goal of this patch is to avoid relying on that JSON fallback for structured
clone. It does this by reimplementing loginToVanillaObject in content JS, so the
resulting object is content JS, so we avoid the CCW.
Differential Revision: https://phabricator.services.mozilla.com/D206809
We have the "Contributing to Mozilla projects" link in the quick ref
doc, might as well have a link to the
"How to Contribute Code to Firefox" doc.
Differential Revision: https://phabricator.services.mozilla.com/D206803
In following patches, we will make the method be able to get
capabilities from all different key systems. This is a
pre-requirement refactoring.
Differential Revision: https://phabricator.services.mozilla.com/D205889
It seems to occur unexpected crash on Android 6 with Samsung Galaxy J7
only.
I don't know why Editable.replace throws null pointer exception. As long
as AOSP code, there is no reason to throw it. I guess this causes Samsung's
customizations etc.
So I would like to turn off the optimization by bug 1837931 on Galaxy J7
only.
Differential Revision: https://phabricator.services.mozilla.com/D206519
This new command will make it easier to work with the JSON source of
truth for our design tokens. Unfortunately the noisy output when
building the tokens is expected. We can fix this issue by upgrading
to Style Dictionary v4 when it is available and changing the logging
level.[1]
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1889645
Differential Revision: https://phabricator.services.mozilla.com/D206561
Looks like this command didn't get added to the MACH_COMMANDS list which
means 'addstory' will throw an error when you try and use it.
Differential Revision: https://phabricator.services.mozilla.com/D206548
This adds a window/application icon to the linux and windows GUIs.
The icon was already added on macOS, but it is irrelevant right now as
it's run as a background application.
This also changes out the `lazy_static` crate for `once_cell` throughout
the application.
Differential Revision: https://phabricator.services.mozilla.com/D206392
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.
The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.
Differential Revision: https://phabricator.services.mozilla.com/D205481
In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.
This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.
Differential Revision: https://phabricator.services.mozilla.com/D205479
Fixes some call sites where the data-l10n-ids for
some error strings were accidentally renamed to
non-existent strings in the FullPageTranslationsPanel.
Differential Revision: https://phabricator.services.mozilla.com/D206737
They are the same and the latter is more self explanatory.
The patch also addresses a couple of Cleanup methods where I forgot to check the bridge pointer.
Differential Revision: https://phabricator.services.mozilla.com/D206785
It goes like this:
- Configure is called. State is configured.
- Configure fails. It dispatches to the main thread its runnable A to close the
encoder with NOT_SUPPORTED
- Reset is called. State is now Unconfigured.
- Configure is called again
- Configure fails. It dispatches to the main thread its runnable A to close the
encoder with NOT_SUPPORTED
- Runnable from first configure runs, CloseInternal is called, it calls
ResetInternal with NOT_SUPPORTED, State is now Closed
- Runnable from second configure runs, CloseInternal is called, it calls
ResetInternal, this returns an error, and we assert on this at CloseInternal
call site in the lambda.
Differential Revision: https://phabricator.services.mozilla.com/D204273
Boris Chiou
Byron Campen
Joel Maher
Andrew McCreight
Lee Salzman
Nikki Sharpley
Nan Jiang
Jonathan Kew
Emilio Cobos Álvarez
Sandor Molnar
Tomislav Jovanovic
Florian Quèze
Valentin Gosu
Luca Greco
Shane Hughes
Tim Giles
alwu
Harshit Sohaney
Adam Brouwers-Harries
Cosmin Sabou
abhishekmadan30
Makoto Kato
Alex Franchuk
Nika Layzell
Nipun Shukla
Andrew Sutherland
Karandeep
Erik Nordin
Nicolas Silva
Otto Länd
Paul Adenot