The check isn't doing what the comment is saying.
XBL subtrees for video controls all have the
NODE_IS_IN_NATIVE_ANONYMOUS_SUBTREE flag, but not all of them are NAC
themselves, so we may incorrectly miss blockification.
Bug: 1366163
Reviewed-by: heycam
MozReview-Commit-ID: Oq3W258Lz2
Source-Repo: https://github.com/servo/servo
Source-Revision: 5ecedb562c66c1f436850704b6dc467a04f5a283
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4ac2d18a9f0b660d8bc869a436d6e2e210d07302
This showed up in a few profiles, and was an easy improvement.
Source-Repo: https://github.com/servo/servo
Source-Revision: 69f02f4f7f102a3fe3f82d5f000533a9277d233e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d71674e9235874fd965574ec5dd145efba19928f
Interpolated result of FontWeight is wrong because clamping code is incorrect.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1387948](https://bugzilla.mozilla.org/show_bug.cgi?id=1387948).
- [X] These changes do not require tests because Gecko has tests
Source-Repo: https://github.com/servo/servo
Source-Revision: 48b7e6d27c6fbeea9b03acface18d163cb7eedbc
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b634dad43aa799dee556deb2d319ab88f6afe3fc
The current default is 24, which is equal to the maximum number of stack frames
that DMD will record. And that's a terrible value because it splits up too many
related stack traces into separate records. There is no single best value, but
8 is a much better default.
--HG--
extra : rebase_source : c423fc4fe0e490ff6d58fa8f7116bc01c86a366e
Remove '--enable-photon' option and use Photon resources to build Fennec.
This patch prohibits changing skin(Australis/Photon) in mach build because we would drop Australis resources in near future.
Any modification in Nightly after this patch should only affect Photon.
MozReview-Commit-ID: 37HzuN6xmPm
--HG--
extra : rebase_source : 0fe6d2e7f49d3c59ceb13c88109061d5a69fce68
The Browser Console interacts with a ChromeActor instance, which as any TabActor inherited actor,
expects to be "attached" by calling its `attach` request. isTabActor set to true ensures that.
While chrome set to true allows client codebase to enable additional behavior for chrome debugging.
MozReview-Commit-ID: 1MVLBKnluhg
--HG--
extra : rebase_source : 7e5c976c6a9690ae730fd8c32a8909e24a277ace
So we reduce the number of unimplemented methods in the sub-classes of MediaResource.
MozReview-Commit-ID: EAmUEv9WQk8
--HG--
extra : rebase_source : deed5fd089e8c42a5a6ab0546e0781d0061591e5
Those members only make sense for ChannelMediaResource.
MozReview-Commit-ID: 2z6WPQeJnIT
--HG--
extra : rebase_source : 7f43635ee91c8fad1d6ad6f56788e880d54beab2
Because GetStatistics() only makes sense for ChannelMediaResource.
MozReview-Commit-ID: HkEpb4frUx1
--HG--
extra : rebase_source : 7086721f47b381b692a165302ff3bdc13caa8b41
Note we remove the log in BufferingState::Enter() which prevents us from
removing ChannelMediaResource related code from MDSM. We can add it back
in the future after the refactoring.
MozReview-Commit-ID: B94iOI0bTXC
--HG--
extra : rebase_source : 857b7420ab9b52c07dc8a917c1f9344096ed20e6
extra : source : 2c350a4f3cbdf6f446b5e1cc8d6e0892722866d0
So we don't duplicate the code of calculating CanPlayThrough from
download rate and playback rate in MediaDecoder.
MozReview-Commit-ID: 7M5JAuUxFFc
--HG--
extra : rebase_source : cb216a1af59b9d8207e3056a5d3ae05e93d85e74
extra : source : a183c089760e329508fac44239fee42c1f047b80
These members are used only by ChannelMediaDecoder.
MozReview-Commit-ID: 10CHV1sjY9k
--HG--
extra : rebase_source : 2a9817a433cd098d818399e718a5c08d6b88df4c
extra : source : 5d606d67b79543adde8580d96f5aa7055fe0286c
This commit
- adds 2 utility functions to the uitour's head.js
- adds the browser_UITour4.js
- moves the tests in the browser_showMenu_controlCenter.js into the newly added the browser_showMenu.js
- deletes the browser_showMenu_urlbar.js because it's test has been modified and moved into the browser_showMenu.js
- adds one test case for the page action panel in the browser_showMenu.js
- updates the browser_UITour_availableTargets.js test because we have more targets right now.
MozReview-Commit-ID: CydEAkqAl3V
--HG--
rename : browser/components/uitour/test/browser_showMenu_controlCenter.js => browser/components/uitour/test/browser_showMenu.js
extra : rebase_source : 3b4d124ccfc12e577ce509241d19795d87fa3206
This commit
- makes UITour support showMenu, showInfo, showHighlight on the Page Action Panel
- makes UITour support showInfo, showHighlight on the Page Action buttons and on the urlbar's bookmark #star-button button btw
- fixes Bug 1382700 - "UITour lacks the `hideMenu` api support for the single search bar (urlbar) dropdown menu" together
- fixes Bug 1386201 - "UITour wouldn't close the appMenu if running the tracking-protection's ui tour" together
MozReview-Commit-ID: Fou1sD4gAs4
--HG--
extra : rebase_source : 90a08d1b4d58ddd6c3f49730d254a0f3c6c446c1
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.
MozReview-Commit-ID: 6s9j0pbsiUB
--HG--
extra : rebase_source : 0b4029905dc76a0ca49d16a7e71c85f1f07b8e2d
We found that a window will not get focus immediately after exiting full screen
mode on Linux. This seems to be a long-standing issue which surfaces due to the
change of background HTML parsing timing. So, we try to get focus everytime
before requesting full screen mode to ensure the request will not fail because
of the focus issue.
MozReview-Commit-ID: 2pOShFZcq8A
--HG--
extra : rebase_source : 47a9431e02549b483874ddfba804bed0d1c6a534
extra : intermediate-source : 64f74f99771510bc06aaf4e9fc875e61b4c67a75
extra : source : 57f259680880504181191c5fe5fa9688c0692703
This patch is mainly to make IdleTaskRunner reusable by nsHtml5TreeOpExecutor.
The only necessary work to that purpose is to remove the dependency of
sShuttingDown, which was a static variable in nsJSEnvironment.cpp.
The idea is to have a "MayStopProcessing" as a callback for the consumer to
return sShuttingDown.
In addition to sShuttingDown, we use std::function<bool()> as the runner
main callback type.
MozReview-Commit-ID: FT2X1unSvPS
--HG--
extra : rebase_source : 3fe2d4f597f53e9a90f3dc8d5009df04240534ba
extra : intermediate-source : 41f6715c344ce26f7820cecb2544db8c50dca796
extra : source : 042f10937305e34245bdaf75dcb816db7738254e
Nothing is changed in this patch except for renaming and code move around.
The strategy is to have the final file setup in this patch without any
detail change. The actual code change will be in the next patch so that
we can focus on reviewing the diff in the next patch regarding IdleTaskRunner.
MozReview-Commit-ID: 4Bul9mZ7z1n
--HG--
extra : rebase_source : b978da3a3c68da58f9fd93502bcc4295acd699ce
extra : source : 833d4b69accbf7d1d60f9f11d807ee37d608b6fe
gfxContext::PushGroupAndCopyBackground & PushGroupForBlendBack do not change the
content of AzureState, we should remove gfxContext::Save in these two functions.
MozReview-Commit-ID: LUuC7bkqFba
--HG--
extra : rebase_source : bed69fa8544e389f4ac13a63489a215a6c86d632
Since gfxContext::Save keep appear on my screen when I did profile, so I think
we should find a way to prevent unecessary usage of this function.
By this patch, an assertion message will be dump if we save and restore an
unchanged AzureState.
MozReview-Commit-ID: 5lH1Y5T5K7t
--HG--
extra : rebase_source : 3fe0bb72ad78273687008cdf87692090cf3fe931
When a reframe happens on the parent of a pseudo element which has animations,
we need to grab style for the pseudo element that includes the animations'
style and also *replace* old style context (that does not include animations'
style) with it. Otherwise, we will use the old style context that has *no*
animations style, as a result, we will see a flicker right after the reframe.
Two reftests in this patch fail without this fix. One is for CSS transitions,
the other one is for CSS animations.
MozReview-Commit-ID: 6pCdnQ1DGUY
Emilio Cobos Álvarez
Michael Kohler
Carsten "Tomcat" Book
Sebastian Hengst
Paul Adenot
Julian Seward
Boris Chiou
Nicholas Nethercote
Phil Ringnalda
Ethan Lin
Jing-wei Wu
Alexandre Poirot
dagasatvik
Sean Lee
JW Wang
Rex Lee
Fischer Liu
Fischer.json
Evan Tseng
Mark Banner
Henry Chang
Kan-Ru Chen
Blake Kaplan
Jason Orendorff
Julian Descottes
Matthew Noorenberghe
cku
Hiroyuki Ikezoe