Граф коммитов

91 Коммитов

Автор SHA1 Сообщение Дата
Zibi Braniecki a7b00209a5 Bug 1386015 - Do not generate styling for each element with inherited color. r=jaws
This patch does a minor refactor of the code used to style popup menu for
the <select> element.
It improves the custom styling experience on MacOS, preserves the functionality
on Windows and removes the unnecessary per-item CSS rules significantly
improving the performance of opening the <select> list.


MozReview-Commit-ID: 7myXq8aDAWr

--HG--
extra : rebase_source : 3ff52f832ec471cca0942e5d8a39961dbc84cff4
2017-08-11 17:38:14 -07:00
Mike Conley f41361f1d2 Bug 1387583 - Avoid leaking a window in SelectParentHelper. r=jaws
MozReview-Commit-ID: 6YILe7gi2fZ

--HG--
extra : rebase_source : 96ed7c7b960b5a5e4da5c699d1f6fab09fecb9c0
2017-08-10 16:26:37 -04:00
Kris Maglione c593e26ab1 Bug 1381337: Don't contstrain popup select dropdowns to the document viewport. r=aswan
MozReview-Commit-ID: HzISTjddHHK

--HG--
extra : rebase_source : b0877aa4aba0ecd2e64be46ffecc95fc3b8c5cd3
2017-07-16 13:13:03 -07:00
Jared Wein 6e7784693d Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm. r=mconley
MozReview-Commit-ID: HeTSfqFTeVc

--HG--
extra : rebase_source : 10314b78650ff161a21ff1076ae501ea1f7f5b6e
2017-06-21 15:31:31 -04:00
Jared Wein c352d05b9b Bug 1343569 - Delay hiding the popup on blur if the search field gains focus. r=enndeakin+6102
Since the order of events is 'blur' followed by 'focus', we send a message from the content process to the parent process and wait for a reply to give enough time for the parent process to signal that the 'blur' was related to the focusing of the search field. If the parent process hasn't signaled as such, then the content process will proceed with hiding the dropdown.

MozReview-Commit-ID: 6ngoo9uHcsM

--HG--
extra : rebase_source : caf43a975827aec71ba82fe39435b05c954673bc
2017-04-25 20:19:42 -04:00
Jared Wein 29cbea21ed Bug 1355078 - Restore scroll position after updating select popup. r=mossop
MozReview-Commit-ID: 7HfuUCymDz

--HG--
extra : rebase_source : ca73fb30b6f77ddfd7718a6dd3fc747a8533bc8c
2017-04-11 01:36:07 -04:00
Jared Wein 169ec2a84e Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling. r=mossop
MozReview-Commit-ID: 3jzZOIiJyXT

--HG--
extra : rebase_source : 1c223d7c90c72c32386a46dccaa745fd19418fae
2017-04-10 16:03:03 -04:00
Jared Wein ddced6733e Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options. r=mossop
The comparison being removed was only put in place because it seemed like a "good-idea" to prevent <select> from being unreadable, though it's not a fool-proof strategy and it breaks content that uses different styling approaches. This removal does not regress any of the other test cases.

MozReview-Commit-ID: 8HeXZXnjpbl

--HG--
extra : rebase_source : f4eb33de4a8b795fe5dd90c1ede510e8584bf53e
2017-03-28 15:27:57 -04:00
Jared Wein e8d13f3103 Bug 1349701 - Update the styles of <select> popups on focus. r=mossop
This patch also fixes a bug in our UpdateDropDown code where we weren't computing updated styles for <select> element, as well as another bug where we weren't passing the correct number of arguments to this.populate.

MozReview-Commit-ID: 8LAeIliRXhZ

--HG--
extra : rebase_source : 19c573ffebf700de4b4a470ceb1d2706a8088574
2017-03-23 13:34:21 -04:00
Jared Wein 2905dc199f Bug 1348617 - Use the alpha channel of custom styled select backgrounds by applying the requested color on top of the system's background. r=mossop
This matches parity with Google Chrome Canary Version 59.0.3046.0 (Official Build) canary (64-bit).

MozReview-Commit-ID: 3rkhiFv8ezX

--HG--
extra : rebase_source : 3cb05e6c1e048bab4c7573bd050ea7477fc128fb
2017-03-21 10:51:40 -04:00
Saghan ebd9e78f82 Bug 1337025 - Add event listener to command event which will be triggered when x button is clicked and repopulate the list. r=jaws 2017-03-16 15:58:31 -07:00
Jared Wein 3581faf3a2 Bug 1347329 - Make sure that the nth-child index gets updated when recursing so that colors get applied correctly when optgroups are used. r=mossop
This problem only occurs when optgroups are involved since they introduce recursion in to the menu-building code and we weren't correctly passing state through
the recursion.

MozReview-Commit-ID: 514zcjgXbIY

--HG--
extra : rebase_source : fdb9309ec8b08f5ab8ca77d901065d5e7db1617f
2017-03-14 19:06:57 -04:00
Sebastian Hengst 8eb3901b10 Backed out changeset 899f6ba2fe55 (bug 1347329) for failing browser_selectpopup_colors.js. r=backout 2017-03-16 00:25:57 +01:00
Jared Wein 4bccf8475b Bug 1347329 - Make sure that the nth-child index gets updated when recursing so that colors get applied correctly when optgroups are used. r=mossop
This problem only occurs when optgroups are involved since they introduce recursion in to the menu-building code and we weren't correctly passing state through
the recursion.

MozReview-Commit-ID: 514zcjgXbIY

--HG--
extra : rebase_source : fdb9309ec8b08f5ab8ca77d901065d5e7db1617f
2017-03-14 19:06:57 -04:00
Jared Wein 954ab4d3e2 Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. r=mossop
Previously we were respecting the webpages request to show a translucent background on popups, though it now seems that content didn't actually
want a translucent background. After comparing with Chrome, I see that they remove the alpha channel and always show the background color as
fully opaque. This patch also fixes a related bug where the background-color may have been set to a transparent color (not rgba(0, 0, 0, 0)) and
we would show the popup as transparent. This is now fixed with this patch as well.

MozReview-Commit-ID: KqDtvI0zwqP

--HG--
extra : rebase_source : 865bbcd9890997cb0c21f20132a0f033c5c365e4
2017-03-14 14:43:00 -04:00
Jared Wein f0dc3daba8 Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color. r=mconley
MozReview-Commit-ID: A01xHyGP9ec

--HG--
extra : rebase_source : 68fcdfff07723fc4c78d7ed6e70e3f70eb1ee923
2017-03-06 12:10:14 -05:00
Xidorn Quan 3e72a08b95 Bug 1339394 - Don't serialize transparent color to transparent keyword when not necessary. r=heycam,jaws
MozReview-Commit-ID: 59cmaCoFJMR

--HG--
extra : rebase_source : 3b927d3c056b66e98f457de1726cf9d459eb8708
2017-02-16 10:26:13 +11:00
Jared Wein bc8f003598 Bug 1339966 - Add a pref to disable content styling for <select> and <option>. r=mconley
MozReview-Commit-ID: FMSbuHUKLY

--HG--
extra : rebase_source : e3e6927dc3fab6d4f71d40f8852946e9dfcd9925
2017-02-15 18:25:31 -05:00
Jared Wein 3c16c7a188 Bug 1338850 - Only set the background color and foreground color on the select element if it is not transparent or equal to each other. r=mconley
MozReview-Commit-ID: AjzZhoBbcFL

--HG--
extra : rebase_source : e4bcb63a8b914a571cc33f816e747db3f68f3b61
2017-02-15 13:30:50 -05:00
Jared Wein 7d9b3b83c6 Bug 1336301 - Styles that are applied directly to the select element should be forwarded to the popup. r=mconley
MozReview-Commit-ID: 29DjcUUqEkx

--HG--
extra : rebase_source : 97970d2e8f1b6527caa2767b06ddf110a2478195
2017-02-04 00:33:13 -05:00
Jared Wein e159bb1601 Bug 1336125 - Apply option styles using a scoped stylesheet to allow for disabling custom styling on the active item. r=mconley
MozReview-Commit-ID: 1dZ1rbKbNY9

--HG--
extra : rebase_source : 0460988f233dde1bcaed9ec1d76fd1a388b8b1be
2017-02-03 12:46:45 -05:00
Wes Kocher 8d6fa2b529 Backed out changeset 87d2810770f3 (bug 1336125) for OSX failures in browser_selectpopup.js a=backout
MozReview-Commit-ID: 59dxqPvMXmo
2017-02-07 15:15:48 -08:00
Jared Wein c19057b678 Bug 1336125 - Apply option styles using a scoped stylesheet to allow for disabling custom styling on the active item. r=mconley
MozReview-Commit-ID: 1dZ1rbKbNY9

--HG--
extra : rebase_source : c2428b98bd9775535ec4cb138c14206c3009cbe1
2017-02-03 12:46:45 -05:00
Jared Wein 3ea4fdab77 Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley
MozReview-Commit-ID: 8wqclzJr2si

--HG--
extra : rebase_source : 95377b0916cd160302bfdfdbc62c9b795bfbad8f
2017-01-31 15:58:27 -05:00
Wes Kocher 9886fc0a7a Backed out changeset 88872e0b68d2 (bug 1335483) for failures in browser_selectpopup.js a=backout
MozReview-Commit-ID: 39EV3LzTBiI
2017-02-03 11:54:32 -08:00
Jared Wein 3de08e5fac Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley
MozReview-Commit-ID: 8wqclzJr2si

--HG--
extra : rebase_source : 38999f77e1c39ee465f8ddb783bae58138adfce2
2017-01-31 15:58:27 -05:00
Jared Wein fc5fc4eca1 Bug 910022 - Allow websites to provide custom background colors and foreground colors for <select> popups. r=mconley
Portions of the patch were written by Jared Beach (beachjar@msu.edu)

MozReview-Commit-ID: 1SpUTJP8tPq

--HG--
extra : rebase_source : 26c4d857e42bb52a5d728ebeb9bfd8b1b57f98cd
2017-01-30 17:35:14 -05:00
Florian Quèze b11907c7aa Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Neil Deakin 234dd053c4 Bug 1321472, move the drag-scrolling behaviour into the menulist binding so that both remote <select> elements and <menulist> can share this behaviour, r=mconley 2017-01-19 10:04:20 -05:00
Neil Deakin 9f8306f97f Bug 1321472, allow drag-scrolling the select popup when the mouse is pressed on an option in the list, r=mconley 2017-01-19 10:04:11 -05:00
Neil Deakin 839f1bb76c Bug 1311279, when the mouse is released, check if it should be retargetted at the select element in the content process, so that a click event is received, r=mconley 2017-01-19 10:03:56 -05:00
Neil Deakin 03860c9589 Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:56:43 -05:00
Tyler Maklebust db2430b4b9 Bug 1309935 - Add ability to find within select dropdown when over 40 elements. r=jaws
Original patch by Tyler Maklebust <tmaklebust@gmail.com> and Jared Beach <beachjar@msu.edu>

MozReview-Commit-ID: 7FW6PHIrXF4

--HG--
extra : rebase_source : e8132fc8af91657ca80f18a841101bc1070c8b15
2017-01-17 15:40:15 -05:00
Jared Wein 43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Mark Banner 582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
2017-01-09 10:12:26 +00:00
Jared Wein ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher 0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein 7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Joel Maher 9f60f5a226 backout aba885aafee0210b1f063a423b1c0b3ce28d15f7 for intermittent bug 1272834
MozReview-Commit-ID: BTJ13wWojaI
2016-12-14 10:59:43 -05:00
Mark Banner 4f94e4bd68 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
MozReview-Commit-ID: CiIsUjQzp4D

--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
beachjar bdc29beadc Bug 430745 - Select dropdown popups will anchor on a selected element for Mac r=jaws
Select dropdown popups now anchor on the currently selected element in a <select> dropdown for Mac instead of above/below the <select> dropdown.

MozReview-Commit-ID: JlgrZdArehq

--HG--
extra : rebase_source : 4058d306e27abf8176d5a2b663219ebb534bf9fb
2016-11-07 16:19:19 -05:00
Neil Deakin e8520ef209 Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:56:43 -05:00
Neil Deakin 140766f711 Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:56:43 -05:00
Carsten "Tomcat" Book c274b1bb68 Backed out changeset deec8c2ba931 (bug 1314647) for eslint failures 2016-11-17 15:42:59 +01:00
Carsten "Tomcat" Book 27c7333444 Backed out changeset 09093d38540e (bug 1311279) 2016-11-17 15:42:38 +01:00
Neil Deakin 5a0853cab6 Bug 1311279, scroll the select popup when click+drag is used, r=mconley 2016-11-17 09:28:27 -05:00
Neil Deakin 842f358037 Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:28:26 -05:00
Sebastian Hengst 55da257ddf Backed out changeset d67c6dcba478 (bug 430745) on request from jaws. r=backout
MozReview-Commit-ID: DGzLTDimdZZ
2016-11-14 16:25:04 +01:00
beachjar a77bc90a28 Bug 430745 - Select dropdown popups will anchor on a selected element for Mac r=jaws
Select dropdown popups now anchor on the currently selected element in a <select> dropdown for Mac instead of above/below the <select> dropdown.

MozReview-Commit-ID: JlgrZdArehq

--HG--
extra : rebase_source : c1239d97865977256f8fa93d4402d46ac66f2f49
2016-11-07 16:19:19 -05:00
Jared Wein 43af4edf06 Bug 1311450 - Only show the 'touch' padding for the select dropdown when opened via touch. r=mconley,smaug
MozReview-Commit-ID: 521oAj1NzX7

--HG--
extra : rebase_source : c6e72987cfd0c237269ff7f203d47f1e21652e85
2016-10-20 12:45:39 -04:00