This background task checks various eligibility criteria and then
pumps the App Update Service update loop.
For convenience, it uses the existing browser-only `AppUpdater.jsm`.
There's nothing truly browser-specific here, though; in the future, we
could support other applications (namely, Thunderbird).
Differential Revision: https://phabricator.services.mozilla.com/D104638
My immediate use case is making the name for a Windows Scheduled Tasks
agree with the existing task names for the Windows Default Browser
Agent task name. The latter uses `MOZ_APP_DISPLAYNAME` in its static
metadata and from C++.
We want to strongly discourage users from using `MOZ_APP_DISPLAYNAME`
in dynamic contexts, hence the unusual name and long comment; but it's
not worth establishing a lint limiting uses at this time.
Differential Revision: https://phabricator.services.mozilla.com/D104639
The AppUpdater module invokes a callback with updater status codes.
The callback can be invoked multiple times with different codes
throughout the lifecycle of an update (check). This helper captures
the codes that are terminal, meaning that the update (check) has
completed. It also includes a tiny helper to determine a string
representation of a status code for logging.
Differential Revision: https://phabricator.services.mozilla.com/D104637
The `canUsuallyX` variants do not take into account transient factors.
The set of transient factors may evolve over time, so we don't list
them exhaustively, but they may include:
1) Whether this instance has the update mutext (on Windows);
2) Whether other instances are running.
The intended consumer of these variants is the background update task
machinery, which wants to schedule tasks when they are likely to
usually succeed, even if they might not succeed right now.
Differential Revision: https://phabricator.services.mozilla.com/D108702
On Adreno 3xx we have observed that the v_perspective varying in
brush_image being a `flat float` results in the entire UV coordinate
calculation being performed as if flat. This results in images being
rendered as solid color triangles. (The color coming from the texture
sample at the UV coordinate calculated for the provoking vertex.)
Packing the varying in a vector works around this bug. This is seen as
preferrable to making the varying non-flat.
This only appears to affect UV coordinate calculations, rather than
any calculation affecting the fragment output color.
Differential Revision: https://phabricator.services.mozilla.com/D109953
Automatic update from web-platform-tests
[cleanup] Remove myself from various READMEs and META files (#28260)
Where appropriate, stephenmcgruer@ is replaced by foolip@ and/or
jpchase@
--
wpt-commits: ca69247c9fcceaed94f57b6e0958318490f67e95
wpt-pr: 28260
Automatic update from web-platform-tests
[TablesNG] Fix invalidation when COL is removed
Table invalidates the grid when a child is removed.
But, COLs are children of COLGROUP, and did
must explicitly invalidate containing table.
Bug: 1191940
Change-Id: I1227bc01f5212a412db78fa1925be46479534230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787673
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866932}
--
wpt-commits: ea5718b8a1261c357e88dfb90ca6dea16c400cfd
wpt-pr: 28255
Automatic update from web-platform-tests
Disable high bit depth decoding for ImageDecoder.
We don't expose a RGBA_F16 VideoPixelType yet, so disable decoding
to it until we figure out what this should look like.
Bug: 1182435
Change-Id: If494edc688d9997d6e599541a139c99df53b65e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782649
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866919}
--
wpt-commits: 900ea8769247fe4563d79762042eba93d5821943
wpt-pr: 28257
Automatic update from web-platform-tests
DOM: remove branch in range tests that isn't used
--
wpt-commits: e404e7e7e061fbf518e3d21ecc90b02076132b8c
wpt-pr: 28228
Automatic update from web-platform-tests
[composite-bgcolor-animation] Fallback to main for body case
If we put background-color animation in the <body> element, we
cannot composite the animation, because the body won't paint
when the view is responsible for painting the body's background.
In the above case, the BackgroundTransfersToView is true, and
we should let the animation fall back to the main thread.
Bug: 1185646
Change-Id: Id20ac02a90fe58b2f8be93febedc75663e68b7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779551
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866887}
--
wpt-commits: 6bbcc401d336e97a603aa1a1e64012e893387fdc
wpt-pr: 28173
Automatic update from web-platform-tests
[TablesNG] Fix dynamic table layout underinvalidation
This might be possible cause of PaintCollapsedBorders
crash. It was observed by Ian as
https://crash.corp.google.com/browse?stbtiq=e4325a8e6177bb8c#0
Bug: 1192697
Change-Id: Idf447724d2ce6c8c3fca5f48985041f9ab2bdbf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787244
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866812}
--
wpt-commits: 8e9b7817592619fe16b2d853963e35456dc3fd3b
wpt-pr: 28249
Automatic update from web-platform-tests
Switch ImageDecoder over to new ImageTrack semantics.
This moves frameCount and repetitionCount onto the track properties
and removes selectTrack() in favor of "track.selected = true". The
tracks list is modeled after Audio/VideoTrackList, but for now does
not include any events.
This also hardens the 'animated' status on a track so that it won't
change after metadata has been retrieved. repetitionCount is switched
to a 'unrestricted float' so 'Infinity' can be be accurately signaled.
R=chcunningham
Bug: 1182435, 1183456
Test: New and updated unittests and wpt tests.
Change-Id: Ibf8363e6f80d998202d42f745180812953681da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783220
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866786}
--
wpt-commits: 8c208d775e1bcac4b6a9635f9f2484f9f10e8036
wpt-pr: 28196
Automatic update from web-platform-tests
Grid repeat(auto) with max-width shouldn't pay attention only to that (#28247)
--
wpt-commits: 7e8d0819b98b4ec505a2de8d48119af0a34861e6
wpt-pr: 28247
Automatic update from web-platform-tests
CSP: Fix typo in WPT for whitespaces in policy
This Web Platform Test was meant to testing the effect of whitespaces
in Content Security Policies delievered in headers or meta tags.
However, because of a typo, it was only testing meta tags.
Change-Id: If519046741168ed02e85728a761ab55b96007f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782270
Auto-Submit: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866586}
--
wpt-commits: d1986b4f9cdc979deebcba63da2568c7db1adb5c
wpt-pr: 28207
Automatic update from web-platform-tests
Correct clip rectangle when block-fragmented.
We used to apply the whole stitched LayoutBox clip rectangle to every
fragment (we don't store clip rectangles per fragment). To fix this,
post-process the clip rectangle, to clip it against the bounds of the
fragment.
Fixes one test, but test coverage seemed low, so I added 3 more, one for
each writing mode.
This also fixes the following tests when CompositeAfterPaint +
LayoutNGBlockFragmentation are enabled:
external/wpt/css/css-multicol/composited-under-clip-under-multicol.html
fast/multicol/composited-relpos-clipped.html
fast/multicol/composited-relpos-in-clipped.html
.. but note that the expectation files for the latter two are wrong
(pre-CompositeAfterPaint behavior is expected), so they will show up as
failing still.
Long-term we should probably consider storing a clip rectangle per
fragment. There are callers of the original
NGPhysicalBoxFragment::OverflowClipRect() (the one that doesn't take an
incoming break token) in NGBoxFragmentPainter that still don't do the
right thing (no access to the incoming break token there, so no easy way
to fix).
Bug: 1191162, 829028
Change-Id: I7cbaeeb0fb2b8a34665b82da23a7581cde1771b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780489
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866531}
--
wpt-commits: 714ba12a5960db71c14a6092726c214f3d0e8f3d
wpt-pr: 28194
Automatic update from web-platform-tests
WPT: Increase timeout for slow XFO test
The WPT external/wpt/x-frame-options/multiple.html is slow because it
navigates a lot of subframes. Sometimes, it ends up hitting the
timeout.
Change-Id: I55e2f3e839bd3d20e41ebca71300294fe53bdabb
Bug: 626703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2784869
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866527}
--
wpt-commits: 8ed684e5fc9e9732320009121729aa2e510e68ad
wpt-pr: 28237
Automatic update from web-platform-tests
CSP: Add WPT for non-ASCII chars in policy
This CL adds a Web Platform Test for parsing Content Security Policies
containing invalid (non-ASCII) characters. This is a test for
https://github.com/w3c/webappsec-csp/pull/486.
Change-Id: Ib1c51ddf6a5fb3e7753f9faab5f30c1c28bd9258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782323
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866497}
--
wpt-commits: 595c6d4f3c07da67db90c6716e1355fa7773296b
wpt-pr: 28206
Automatic update from web-platform-tests
Merge color-space directory with wide gamut
I just noticed that we already have a directory for color-space related
tests. Merge the test I added with the existing directory.
Bug: 1178707
Change-Id: I509e845219d339d6a7f7f4414eab27425cfe37f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2786303
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866492}
--
wpt-commits: 6adcf0dd95a75ca64f3515d11f3f30f616630067
wpt-pr: 28235
Automatic update from web-platform-tests
[TablesNG] Colspanned cell uses table grid size defined by COL
Colspanned cells cannot extend beyond size of the table grid.
NGTableBorders::ComputeTableBorders did not use COLs
to compute grid size, and cells would up too narrow.
Bug: 1192304
Change-Id: I7e8e54a341c6f8ba99212e5076939c1e27601d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785495
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866448}
--
wpt-commits: 35e3fd4ade7c69f3b56a28d8b1b88723c58755b7
wpt-pr: 28231
Automatic update from web-platform-tests
Don't squash layers across different 3-D transform rendering/sorting contexts.
Layers that are part of different 3-D rendering contexts (preserve-3d
hierarchies) cannot be squashed; doing so will lead to part of the
resulting layer being rendered incorrectly.
Bug: 1133666
Change-Id: I857f1b60cd49483bbf1991d464f72143f115e9aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743522
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: L. David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866395}
--
wpt-commits: 5a23624905effc83d3832362a80dc826fff916c4
wpt-pr: 27973
Automatic update from web-platform-tests
[cc] Add test for dynamic scale3d transforms
My current patch for raster scales with different X and Y components
would make this test fail, but bots were green. So let's add the test.
Bug: 1119996
Change-Id: I3a3a2c684ee0ee45bcfe4e00f037d27290806a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782901
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#866357}
--
wpt-commits: 63749d9081df5b774306bc07cba5d1b3c1e55d3c
wpt-pr: 28200
Automatic update from web-platform-tests
[TablesNG] Fix dynamic writing mode invalidation
Our fancy new DCHECK uncovered a bug in TablesNG code.
Changing only the writing mode did not invalidate
logical borders properly.
The is because we were using BorderVisuallyEqual to
compare old and new borders. This function operates
in physical, not logical space.
A unittest was trying to test if borders are good
after writing mode change:
LayoutTableCellTest::BorderWidthsWithCollapsedBorders
The test was testing the wrong thing. I've tested
results in the browser, and Chrome was not definitely
getting the right borders. With the fix, expectations
for TablesNG and Legacy are very different, one is
buggy, the other one is not.
Change-Id: Ice7e20fb3b2ab9b449e2ee9bb15f316c4acd8161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783627
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866306}
--
wpt-commits: 417056750f1a544cbcff368b96e546845e7b6cc8
wpt-pr: 28208
Automatic update from web-platform-tests
[size-adjust] Implement @font-face descriptor 'size-adjust'
'size-adjust' is specified as a scaling factor to 'font-size' before
font selection, similar to 'font-size-adjust' property. Therefore, this
patch implements it in a way similar to 'font-size-adjust' that, both
affect the result of FontDescription::EffectiveFontSize().
Spec: https://drafts.csswg.org/css-fonts-5/#descdef-font-face-size-adjust
Bug: 1137633
Change-Id: I157705bd1a9c1e58ec3c4f41bbff7a37d1f7e3dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2773716
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866291}
--
wpt-commits: 1bf5bd2167212b5c73d0fd7c469ac713a4cd9799
wpt-pr: 28158
Automatic update from web-platform-tests
Deflakes a background-color transition layout test
The fix here follows the same strategy as:
https://chromium-review.googlesource.com/c/chromium/src/+/2785141
Bug: 1187461
Change-Id: I335d5994bb4837ef81bd4ba0e12f7f0f0e155d20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785560
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866282}
--
wpt-commits: 8c761a54dce032864c3b9b068d0950cd5f5a6463
wpt-pr: 28220
Automatic update from web-platform-tests
Disable NavigatorPluginsEmpty feature
This feature was enabled by default [1] to check web compat, and after
M90 went to Beta, a number of issues were raised ([2],[3]). As a
result, this feature is being disabled. This will likely need to
be merged back to M90 Beta.
This CL removes the WPT that tests for empty arrays, and reinstates
the prior layout test which enforces non-empty arrays.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2629990
[2] b/183094994
[3] crbug.com/1191639
Bug: 1164635, 1191639
Change-Id: Ieed5de8ece2332b5b830e9e295c9163e21e9c4a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783393
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866271}
--
wpt-commits: 5ca713723d4b7b4c552df6359f359f692efc610e
wpt-pr: 28223
Automatic update from web-platform-tests
Reland "Create canvasFilter class and interface"
Using the NewCanvas2DAPI flag on an idl file caused MSAN failures because
that flag was not explicitly initialized on the WebPreferences
constructor. This CL solves that problem
https://chromium-review.googlesource.com/c/chromium/src/+/2783641
I'll also run this CL through the MSan bots to confirm.
This is a reland of 5d00b2d8b1b3a3431ce093a990524a8b25a2bcac
It was reverted here https://chromium-review.googlesource.com/c/chromium/src/+/2775779
Original change's description:
> Create canvasFilter class and interface
>
> Create a "mongo-db" like interface for filters. Implement blur, but only
> blur.
>
> Bug: 1169216
> Change-Id: I0dc045fa70f0d1e443cf4f8ff53632056cca6924
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2741994
> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
> Reviewed-by: Yi Xu <yiyix@chromium.org>
> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#864863}
Bug: 1169216
Change-Id: I6e5badf27d41f6dbdc1759ac518d502d1983ebd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780336
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866266}
--
wpt-commits: 6b72c0a3b73ca8d18dc88ff6c70999388e747b03
wpt-pr: 28213
Automatic update from web-platform-tests
Deflake a background-color animation layout test
It seems that adding a document.getAnimations()[0].ready fixes
the problem. Locally I have run the test 1000 times with -f
and no flakes at all.
Bug: 1190211
Change-Id: Idc4f3fc429b775c2553a37d9a98c88322204939a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785141
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866212}
--
wpt-commits: b6c4ab4753cc9af7caa8f36c1ced6c07cecccc71
wpt-pr: 28215
Automatic update from web-platform-tests
URLPattern: Allow a second argument to test()/exec() for baseURL.
This CL adds support for code to pass a secondary argument to test()
and exec() to act as a baseURL. For example:
pattern.test('./index.html', self.location);
To support this the webidl was restructured to have separate method
overloads for USVString and URLPatternInit inputs. In addition, the
internal implementation was refactored to account for the fact that
a union type is no longer used for the input.
Finally, there was one open question about what to reflect in the
`input` property on the URLPatternResult returned from exec(). This
property contains the input passed to exec(). In the past this was
always a single value, but now there are two values. This CL deals
with the situation by populating `result.input` with the fully resolved
URL when a baseURL is present. This is a bit inconsistent with the
value when populated in other cases, but seems less weird than trying
to use an array or secondary property.
Bug: 1141510
Change-Id: Ia247f59b1541ca254ba7d1d871f64d65a7b0b7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779364
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#865794}
--
wpt-commits: 0d7dd845ec0c0482cbd8c11bddafe9878dc32522
wpt-pr: 28192
Automatic update from web-platform-tests
Remove Access-Control-Allow-Headers
Access-Control-Allow-Headers is added for CORS preflight and should be
removed according to the spec
(https://w3c.github.io/ServiceWorker/#update-algorithm).
Bug: 1191514
Change-Id: Ide3c8556bf3a53d51f26d5f9be34af3b873922be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782391
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866130}
--
wpt-commits: b1fc334f29f80f3160e98a1fc479b0d44b54ffd8
wpt-pr: 28197
Automatic update from web-platform-tests
testdriver: Explicitly set a default for the one_realm parameter.
The parameter was already optional, but since it is supposed to be a boolean
it is more clear to default it to false. Doing so in the documentation also
makes it easier for API users to know that it is not always necessary to set
it.
--
wpt-commits: 7dafde1ff840c1e60b6f129203a7ee5d7cf1e197
wpt-pr: 28189
Nick Alexander
Timothy Nikkel
Jamie Nicol
moz-wptsync-bot
Eric Willigers
Aleks Totic
Stephen McGruer
Dale Curtis
Trevor Rowbotham
Xida Chen
Tab Atkins Jr
Antonio Sartori
Morten Stenshorne
Seokho Song
Yi Xu
L. David Baron
Oriol Brufau
Xiaocheng Hu
Mason Freed
Aaron Krajeski
Ben Kelly
Philip Jägenstedt
Ghazale Hosseinabadi
Raphael Kubo da Costa